All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: David Decotigny <ddecotig@google.com>, David Ahern <dsahern@kernel.org>
Cc: "Mahesh Bandewar (महेश बंडेवार)" <maheshb@google.com>,
	"David Decotigny" <decot+git@google.com>,
	"David S. Miller" <davem@davemloft.net>,
	"Eric Dumazet" <edumazet@google.com>,
	"Paolo Abeni" <pabeni@redhat.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Nikolay Aleksandrov" <razor@blackwall.org>,
	"Denis V. Lunev" <den@openvz.org>,
	"Daniel Borkmann" <daniel@iogearbox.net>,
	"Chen Zhongjin" <chenzhongjin@huawei.com>,
	"Yuwei Wang" <wangyuweihx@gmail.com>,
	"Alexander Mikhalitsyn" <alexander.mikhalitsyn@virtuozzo.com>,
	"Thomas Zeitlhofer" <thomas.zeitlhofer+lkml@ze-it.at>
Subject: Re: [PATCH v1 1/1] net: neigh: persist proxy config across link flaps
Date: Thu, 15 Dec 2022 11:05:44 -0800	[thread overview]
Message-ID: <20221215110544.7e832e41@kernel.org> (raw)
In-Reply-To: <CAG88wWbZ3eXCFJBZ8mrfvddKiVihF-GfEOYAOmT_7VX_AeOoqQ@mail.gmail.com>

On Wed, 14 Dec 2022 22:18:04 -0800 David Decotigny wrote:
> I don't think this patch is changing that part of the behavior: we still
> flush the cached nd entries when the link flaps. What we don't remove are
> the pneigh_entry-es (ip neigh add proxy ...) attached to the device where
> the link flaps: those are configured once and this patch ensures that they
> survive the link flaps as long as the netdev stays admin-up. When
> the netdev is brought admin-down, we keep the behavior we had before the
> patch.

Makes sense. This is not urgent, tho, right?

David A, do you agree and should we treat this as a fix with

Fixes: 859bd2ef1fc1 ("net: Evict neighbor entries on carrier down")

added?

Reminder: please bottom post on the list

  parent reply	other threads:[~2022-12-15 19:06 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-13  7:38 [PATCH v1 1/1] net: neigh: persist proxy config across link flaps David Decotigny
2022-12-15  4:48 ` Jakub Kicinski
2022-12-15  5:34   ` Mahesh Bandewar (महेश बंडेवार)
     [not found]     ` <CAG88wWbZ3eXCFJBZ8mrfvddKiVihF-GfEOYAOmT_7VX_AeOoqQ@mail.gmail.com>
2022-12-15 19:05       ` Jakub Kicinski [this message]
2022-12-15 20:36         ` David Decotigny
2022-12-15 21:16           ` Jakub Kicinski
2022-12-15 23:14             ` David Ahern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221215110544.7e832e41@kernel.org \
    --to=kuba@kernel.org \
    --cc=alexander.mikhalitsyn@virtuozzo.com \
    --cc=chenzhongjin@huawei.com \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=ddecotig@google.com \
    --cc=decot+git@google.com \
    --cc=den@openvz.org \
    --cc=dsahern@kernel.org \
    --cc=edumazet@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maheshb@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=razor@blackwall.org \
    --cc=thomas.zeitlhofer+lkml@ze-it.at \
    --cc=wangyuweihx@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.