From: "Mahesh Bandewar (महेश बंडेवार)" <maheshb@google.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: David Decotigny <decot+git@google.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Nikolay Aleksandrov <razor@blackwall.org>,
David Ahern <dsahern@kernel.org>,
"Denis V. Lunev" <den@openvz.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Chen Zhongjin <chenzhongjin@huawei.com>,
David Decotigny <ddecotig@google.com>,
Yuwei Wang <wangyuweihx@gmail.com>,
Alexander Mikhalitsyn <alexander.mikhalitsyn@virtuozzo.com>,
Thomas Zeitlhofer <thomas.zeitlhofer+lkml@ze-it.at>
Subject: Re: [PATCH v1 1/1] net: neigh: persist proxy config across link flaps
Date: Wed, 14 Dec 2022 21:34:00 -0800 [thread overview]
Message-ID: <CAF2d9jh_O0-uceNq=AP5rqPm9xcn=9y8bVxMD-2EiJ3bD_mZsQ@mail.gmail.com> (raw)
In-Reply-To: <20221214204851.2102ba31@kernel.org>
On Wed, Dec 14, 2022 at 8:49 PM Jakub Kicinski <kuba@kernel.org> wrote:
>
> On Mon, 12 Dec 2022 23:38:01 -0800 David Decotigny wrote:
> > From: David Decotigny <ddecotig@google.com>
> >
> > Without this patch, the 'ip neigh add proxy' config is lost when the
> > cable or peer disappear, ie. when the link goes down while staying
> > admin up. When the link comes back, the config is never recovered.
> >
> > This patch makes sure that such an nd proxy config survives a switch
> > or cable issue.
>
> Hm, how does this square with the spirit of 859bd2ef1fc11 ?
>
Devid's (Decotigny) patch is adding the distinction between admin-down
from carrier-off which could be transient. So in my belief, it's
correcting / enhancing the behavior that David (Ahern) introduced but
we can hear from David himself :)
> Would be great to hear from David, IDK if he's around or off until
> next year.
next prev parent reply other threads:[~2022-12-15 5:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-13 7:38 [PATCH v1 1/1] net: neigh: persist proxy config across link flaps David Decotigny
2022-12-15 4:48 ` Jakub Kicinski
2022-12-15 5:34 ` Mahesh Bandewar (महेश बंडेवार) [this message]
[not found] ` <CAG88wWbZ3eXCFJBZ8mrfvddKiVihF-GfEOYAOmT_7VX_AeOoqQ@mail.gmail.com>
2022-12-15 19:05 ` Jakub Kicinski
2022-12-15 20:36 ` David Decotigny
2022-12-15 21:16 ` Jakub Kicinski
2022-12-15 23:14 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAF2d9jh_O0-uceNq=AP5rqPm9xcn=9y8bVxMD-2EiJ3bD_mZsQ@mail.gmail.com' \
--to=maheshb@google.com \
--cc=alexander.mikhalitsyn@virtuozzo.com \
--cc=chenzhongjin@huawei.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=ddecotig@google.com \
--cc=decot+git@google.com \
--cc=den@openvz.org \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=razor@blackwall.org \
--cc=thomas.zeitlhofer+lkml@ze-it.at \
--cc=wangyuweihx@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.