* [folded-merged] mm-use-stack_depot-for-recording-kmemleaks-backtrace-checkpatch-fixes.patch removed from -mm tree
@ 2022-12-15 20:26 Andrew Morton
0 siblings, 0 replies; only message in thread
From: Andrew Morton @ 2022-12-15 20:26 UTC (permalink / raw)
To: mm-commits, zhaoyang.huang, willy, vbabka, ke.wang,
huangzhaoyang, catalin.marinas, akpm, akpm
The quilt patch titled
Subject: mm-use-stack_depot-for-recording-kmemleaks-backtrace-checkpatch-fixes
has been removed from the -mm tree. Its filename was
mm-use-stack_depot-for-recording-kmemleaks-backtrace-checkpatch-fixes.patch
This patch was dropped because it was folded into mm-use-stack_depot-for-recording-kmemleaks-backtrace.patch
------------------------------------------------------
From: Andrew Morton <akpm@linux-foundation.org>
Subject: mm-use-stack_depot-for-recording-kmemleaks-backtrace-checkpatch-fixes
Date: Thu Oct 27 12:12:56 PM PDT 2022
WARNING: please, no spaces at the start of a line
#59: FILE: mm/kmemleak.c:362:
+ for (i = 0; i < nr_entries; i++) {$
WARNING: suspect code indent for conditional statements (7, 15)
#59: FILE: mm/kmemleak.c:362:
+ for (i = 0; i < nr_entries; i++) {
+ void *ptr = (void *)entries[i];
ERROR: code indent should use tabs where possible
#60: FILE: mm/kmemleak.c:363:
+ void *ptr = (void *)entries[i];$
WARNING: please, no spaces at the start of a line
#60: FILE: mm/kmemleak.c:363:
+ void *ptr = (void *)entries[i];$
ERROR: code indent should use tabs where possible
#61: FILE: mm/kmemleak.c:364:
+ warn_or_seq_printf(seq, " [<%p>] %pS\n", ptr, ptr);$
WARNING: Missing a blank line after declarations
#61: FILE: mm/kmemleak.c:364:
+ void *ptr = (void *)entries[i];
+ warn_or_seq_printf(seq, " [<%p>] %pS\n", ptr, ptr);
WARNING: please, no spaces at the start of a line
#61: FILE: mm/kmemleak.c:364:
+ warn_or_seq_printf(seq, " [<%p>] %pS\n", ptr, ptr);$
WARNING: please, no spaces at the start of a line
#62: FILE: mm/kmemleak.c:365:
+ }$
ERROR: space required before the open parenthesis '('
#71: FILE: mm/kmemleak.c:384:
+ if(object->trace_handle)
total: 3 errors, 6 warnings, 107 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
NOTE: Whitespace errors detected.
You may wish to use scripts/cleanpatch or scripts/cleanfile
./patches/mm-use-stack_depot-for-recording-kmemleaks-backtrace.patch has style problems, please review.
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
Please run checkpatch prior to sending patches
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: ke.wang <ke.wang@unisoc.com>
Cc: Matthew Wilcox (Oracle) <willy@infradead.org>
Cc: Vlastimil Babka <vbabka@suse.cz>
Cc: Zhaoyang Huang <huangzhaoyang@gmail.com>
Cc: Zhaoyang Huang <zhaoyang.huang@unisoc.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
mm/kmemleak.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
--- a/mm/kmemleak.c~mm-use-stack_depot-for-recording-kmemleaks-backtrace-checkpatch-fixes
+++ a/mm/kmemleak.c
@@ -359,10 +359,10 @@ static void print_unreferenced(struct se
hex_dump_object(seq, object);
warn_or_seq_printf(seq, " backtrace:\n");
- for (i = 0; i < nr_entries; i++) {
- void *ptr = (void *)entries[i];
- warn_or_seq_printf(seq, " [<%p>] %pS\n", ptr, ptr);
- }
+ for (i = 0; i < nr_entries; i++) {
+ void *ptr = (void *)entries[i];
+ warn_or_seq_printf(seq, " [<%p>] %pS\n", ptr, ptr);
+ }
}
/*
@@ -381,7 +381,7 @@ static void dump_object_info(struct kmem
pr_notice(" flags = 0x%x\n", object->flags);
pr_notice(" checksum = %u\n", object->checksum);
pr_notice(" backtrace:\n");
- if(object->trace_handle)
+ if (object->trace_handle)
stack_depot_print(object->trace_handle);
}
_
Patches currently in -mm which might be from akpm@linux-foundation.org are
mm-use-stack_depot-for-recording-kmemleaks-backtrace.patch
mm-use-stack_depot-for-recording-kmemleaks-backtrace-fix.patch
mm-use-stack_depot-for-recording-kmemleaks-backtrace-v3-fix.patch
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2022-12-15 20:27 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-15 20:26 [folded-merged] mm-use-stack_depot-for-recording-kmemleaks-backtrace-checkpatch-fixes.patch removed from -mm tree Andrew Morton
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.