From: Christoph Hellwig <hch@lst.de> To: Mikhail Gavrilov <mikhail.v.gavrilov@gmail.com> Cc: Takashi Iwai <tiwai@suse.de>, alsa-devel@alsa-project.org, hch@lst.de, m.szyprowski@samsung.com, Linux List Kernel Mailing <linux-kernel@vger.kernel.org>, Robin Murphy <robin.murphy@arm.com>, iommu@lists.linux.dev Subject: Re: [6.2][regression] after commit ffcb754584603adf7039d7972564fbf6febdc542 all sound devices disappeared (due BUG at mm/page_alloc.c:3592!) Date: Fri, 16 Dec 2022 07:46:45 +0100 [thread overview] Message-ID: <20221216064645.GA24446@lst.de> (raw) In-Reply-To: <CABXGCsPnpu0TGHnvXM1we7q1t3tJAOYW2rA=AMvf7ZahcYvpRQ@mail.gmail.com> Ok, it seems like the sound noncontig alloc code that I already commented on as potentially bogus GFP_GOMP mapping trips this. I think for now the right thing would be to revert the hunk in dma-iommu.c (see patch below). The other thing to try would be to remove both uses GFP_COMP in sound/core/memalloc.c, which should have the same effect. diff --git a/drivers/iommu/dma-iommu.c b/drivers/iommu/dma-iommu.c index 9297b741f5e80e..f798c44e090337 100644 --- a/drivers/iommu/dma-iommu.c +++ b/drivers/iommu/dma-iommu.c @@ -744,9 +744,6 @@ static struct page **__iommu_dma_alloc_pages(struct device *dev, /* IOMMU can map any pages, so himem can also be used here */ gfp |= __GFP_NOWARN | __GFP_HIGHMEM; - /* It makes no sense to muck about with huge pages */ - gfp &= ~__GFP_COMP; - while (count) { struct page *page = NULL; unsigned int order_size;
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de> To: Mikhail Gavrilov <mikhail.v.gavrilov@gmail.com> Cc: alsa-devel@alsa-project.org, Takashi Iwai <tiwai@suse.de>, Linux List Kernel Mailing <linux-kernel@vger.kernel.org>, iommu@lists.linux.dev, Robin Murphy <robin.murphy@arm.com>, hch@lst.de, m.szyprowski@samsung.com Subject: Re: [6.2][regression] after commit ffcb754584603adf7039d7972564fbf6febdc542 all sound devices disappeared (due BUG at mm/page_alloc.c:3592!) Date: Fri, 16 Dec 2022 07:46:45 +0100 [thread overview] Message-ID: <20221216064645.GA24446@lst.de> (raw) In-Reply-To: <CABXGCsPnpu0TGHnvXM1we7q1t3tJAOYW2rA=AMvf7ZahcYvpRQ@mail.gmail.com> Ok, it seems like the sound noncontig alloc code that I already commented on as potentially bogus GFP_GOMP mapping trips this. I think for now the right thing would be to revert the hunk in dma-iommu.c (see patch below). The other thing to try would be to remove both uses GFP_COMP in sound/core/memalloc.c, which should have the same effect. diff --git a/drivers/iommu/dma-iommu.c b/drivers/iommu/dma-iommu.c index 9297b741f5e80e..f798c44e090337 100644 --- a/drivers/iommu/dma-iommu.c +++ b/drivers/iommu/dma-iommu.c @@ -744,9 +744,6 @@ static struct page **__iommu_dma_alloc_pages(struct device *dev, /* IOMMU can map any pages, so himem can also be used here */ gfp |= __GFP_NOWARN | __GFP_HIGHMEM; - /* It makes no sense to muck about with huge pages */ - gfp &= ~__GFP_COMP; - while (count) { struct page *page = NULL; unsigned int order_size;
next prev parent reply other threads:[~2022-12-16 6:47 UTC|newest] Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-12-15 14:17 [6.2][regression] after commit ffcb754584603adf7039d7972564fbf6febdc542 all sound devices disappeared (due BUG at mm/page_alloc.c:3592!) Mikhail Gavrilov 2022-12-15 18:23 ` Kai Vehmanen 2022-12-15 18:23 ` Kai Vehmanen 2022-12-16 0:06 ` Joan Bruguera 2022-12-16 6:46 ` Christoph Hellwig [this message] 2022-12-16 6:46 ` Christoph Hellwig 2022-12-16 11:40 ` Robin Murphy 2022-12-16 11:40 ` Robin Murphy 2022-12-16 12:15 ` Christoph Hellwig 2022-12-16 12:15 ` Christoph Hellwig 2022-12-16 12:52 ` Robin Murphy 2022-12-16 12:52 ` Robin Murphy 2022-12-22 12:17 ` [6.2][regression] after commit ffcb754584603adf7039d7972564fbf6febdc542 all sound devices disappeared (due BUG at mm/page_alloc.c:3592!) #forregzbot Thorsten Leemhuis 2022-12-24 7:20 ` Thorsten Leemhuis [not found] <CABXGCsPnpu0TGHnvXM1we7q1t3tJAOYW2rA=> 2022-12-15 23:52 ` [6.2][regression] after commit ffcb754584603adf7039d7972564fbf6febdc542 all sound devices disappeared (due BUG at mm/page_alloc.c:3592!) Joan Bruguera
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20221216064645.GA24446@lst.de \ --to=hch@lst.de \ --cc=alsa-devel@alsa-project.org \ --cc=iommu@lists.linux.dev \ --cc=linux-kernel@vger.kernel.org \ --cc=m.szyprowski@samsung.com \ --cc=mikhail.v.gavrilov@gmail.com \ --cc=robin.murphy@arm.com \ --cc=tiwai@suse.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.