* Re: [Intel-gfx] [PATCH 2/2] drm/i915: Consolidate TLB invalidation flow
@ 2023-01-03 19:57 ` Matt Roper
0 siblings, 0 replies; 19+ messages in thread
From: Matt Roper @ 2023-01-03 19:57 UTC (permalink / raw)
To: Andrzej Hajda; +Cc: Intel-gfx, dri-devel
On Mon, Dec 19, 2022 at 05:10:02PM +0100, Andrzej Hajda wrote:
> On 19.12.2022 11:13, Tvrtko Ursulin wrote:
> > From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> >
> > As the logic for selecting the register and corresponsing values grew, the
>
> corresponding
>
> > code become a bit unsightly. Consolidate by storing the required values at
> > engine init time in the engine itself, and by doing so minimise the amount
> > of invariant platform and engine checks during each and every TLB
> > invalidation.
> >
> > v2:
> > * Fail engine probe if TLB invlidations registers are unknown.
> >
> > Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> > Cc: Andrzej Hajda <andrzej.hajda@intel.com>
> > Cc: Matt Roper <matthew.d.roper@intel.com>
> > Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com> # v1
> > ---
> > drivers/gpu/drm/i915/gt/intel_engine_cs.c | 93 +++++++++++++
> > drivers/gpu/drm/i915/gt/intel_engine_types.h | 15 +++
> > drivers/gpu/drm/i915/gt/intel_gt.c | 135 +++----------------
> > 3 files changed, 128 insertions(+), 115 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/gt/intel_engine_cs.c b/drivers/gpu/drm/i915/gt/intel_engine_cs.c
> > index 99c4b866addd..d47dadfc25c8 100644
> > --- a/drivers/gpu/drm/i915/gt/intel_engine_cs.c
> > +++ b/drivers/gpu/drm/i915/gt/intel_engine_cs.c
> > @@ -1143,12 +1143,105 @@ static int init_status_page(struct intel_engine_cs *engine)
> > return ret;
> > }
> > +static int intel_engine_init_tlb_invalidation(struct intel_engine_cs *engine)
> > +{
> > + static const union intel_engine_tlb_inv_reg gen8_regs[] = {
> > + [RENDER_CLASS].reg = GEN8_RTCR,
> > + [VIDEO_DECODE_CLASS].reg = GEN8_M1TCR, /* , GEN8_M2TCR */
> > + [VIDEO_ENHANCEMENT_CLASS].reg = GEN8_VTCR,
> > + [COPY_ENGINE_CLASS].reg = GEN8_BTCR,
> > + };
> > + static const union intel_engine_tlb_inv_reg gen12_regs[] = {
> > + [RENDER_CLASS].reg = GEN12_GFX_TLB_INV_CR,
> > + [VIDEO_DECODE_CLASS].reg = GEN12_VD_TLB_INV_CR,
> > + [VIDEO_ENHANCEMENT_CLASS].reg = GEN12_VE_TLB_INV_CR,
> > + [COPY_ENGINE_CLASS].reg = GEN12_BLT_TLB_INV_CR,
> > + [COMPUTE_CLASS].reg = GEN12_COMPCTX_TLB_INV_CR,
> > + };
> > + static const union intel_engine_tlb_inv_reg xehp_regs[] = {
> > + [RENDER_CLASS].mcr_reg = XEHP_GFX_TLB_INV_CR,
> > + [VIDEO_DECODE_CLASS].mcr_reg = XEHP_VD_TLB_INV_CR,
> > + [VIDEO_ENHANCEMENT_CLASS].mcr_reg = XEHP_VE_TLB_INV_CR,
> > + [COPY_ENGINE_CLASS].mcr_reg = XEHP_BLT_TLB_INV_CR,
> > + [COMPUTE_CLASS].mcr_reg = XEHP_COMPCTX_TLB_INV_CR,
> > + };
> > + struct drm_i915_private *i915 = engine->i915;
> > + const union intel_engine_tlb_inv_reg *regs;
> > + union intel_engine_tlb_inv_reg reg;
> > + unsigned int class = engine->class;
> > + unsigned int num = 0;
> > + u32 val;
> > +
> > + /*
> > + * New platforms should not be added with catch-all-newer (>=)
> > + * condition so that any later platform added triggers the below warning
> > + * and in turn mandates a human cross-check of whether the invalidation
> > + * flows have compatible semantics.
> > + *
> > + * For instance with the 11.00 -> 12.00 transition three out of five
> > + * respective engine registers were moved to masked type. Then after the
> > + * 12.00 -> 12.50 transition multi cast handling is required too.
> > + */
> > +
> > + if (GRAPHICS_VER_FULL(i915) == IP_VER(12, 50)) {
This is bad...it only captures XEHPSDV and breaks the handling of DG2
(12.55), PVC (12.60), and MTL (12.70, 12.71, and 12.72). You're not
hitting the warning as expected since those are all now being captured
by the next case of the if/else ladder. With the way GMD_ID works, we
may also get new version numbers that silently show up in hardware too
at some point (e.g., 12.73, 12.74, etc.)
> > + regs = xehp_regs;
> > + num = ARRAY_SIZE(xehp_regs);
> > + } else if (GRAPHICS_VER(i915) == 12) {
You'd want to change this to
GRAPHICS_VER_FULL(i915) == IP_VER(12, 0)
to get the behavior you expected.
Matt
> > + regs = gen12_regs;
> > + num = ARRAY_SIZE(gen12_regs);
> > + } else if (GRAPHICS_VER(i915) >= 8 && GRAPHICS_VER(i915) <= 11) {
> > + regs = gen8_regs;
> > + num = ARRAY_SIZE(gen8_regs);
> > + } else if (GRAPHICS_VER(i915) < 8) {
> > + return 0;
> > + } > +
> > + if (drm_WARN_ONCE(&i915->drm, !num,
> > + "Platform does not implement TLB invalidation!"))
> > + return -ENODEV;
> > +
> > + if (drm_WARN_ON_ONCE(&i915->drm,
> > + class >= num ||
> > + (!regs[class].reg.reg &&
> > + !regs[class].mcr_reg.reg)))
> > + return -ERANGE;
>
> I hope the propagation of -ERANGE to device probe is OK.
>
> Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com>
>
> Regards
> Andrzej
>
> > +
> > + reg = regs[class];
> > +
> > + if (GRAPHICS_VER(i915) == 8 && class == VIDEO_DECODE_CLASS) {
> > + reg.reg.reg += 4 * engine->instance; /* GEN8_M2TCR */
> > + val = 0;
> > + } else {
> > + val = engine->instance;
> > + }
> > +
> > + val = BIT(val);
> > +
> > + engine->tlb_inv.mcr = regs == xehp_regs;
> > + engine->tlb_inv.reg = reg;
> > + engine->tlb_inv.done = val;
> > +
> > + if (GRAPHICS_VER(i915) >= 12 &&
> > + (engine->class == VIDEO_DECODE_CLASS ||
> > + engine->class == VIDEO_ENHANCEMENT_CLASS ||
> > + engine->class == COMPUTE_CLASS))
> > + engine->tlb_inv.request = _MASKED_BIT_ENABLE(val);
> > + else
> > + engine->tlb_inv.request = val;
> > +
> > + return 0;
> > +}
> > +
> > static int engine_setup_common(struct intel_engine_cs *engine)
> > {
> > int err;
> > init_llist_head(&engine->barrier_tasks);
> > + err = intel_engine_init_tlb_invalidation(engine);
> > + if (err)
> > + return err;
> > +
> > err = init_status_page(engine);
> > if (err)
> > return err;
> > diff --git a/drivers/gpu/drm/i915/gt/intel_engine_types.h b/drivers/gpu/drm/i915/gt/intel_engine_types.h
> > index 4fd54fb8810f..8c661fe89314 100644
> > --- a/drivers/gpu/drm/i915/gt/intel_engine_types.h
> > +++ b/drivers/gpu/drm/i915/gt/intel_engine_types.h
> > @@ -341,6 +341,19 @@ struct intel_engine_guc_stats {
> > u64 start_gt_clk;
> > };
> > +union intel_engine_tlb_inv_reg {
> > + i915_reg_t reg;
> > + i915_mcr_reg_t mcr_reg;
> > +};
> > +
> > +struct intel_engine_tlb_inv
> > +{
> > + bool mcr;
> > + union intel_engine_tlb_inv_reg reg;
> > + u32 request;
> > + u32 done;
> > +};
> > +
> > struct intel_engine_cs {
> > struct drm_i915_private *i915;
> > struct intel_gt *gt;
> > @@ -372,6 +385,8 @@ struct intel_engine_cs {
> > u32 context_size;
> > u32 mmio_base;
> > + struct intel_engine_tlb_inv tlb_inv;
> > +
> > /*
> > * Some w/a require forcewake to be held (which prevents RC6) while
> > * a particular engine is active. If so, we set fw_domain to which
> > diff --git a/drivers/gpu/drm/i915/gt/intel_gt.c b/drivers/gpu/drm/i915/gt/intel_gt.c
> > index 854841a731cb..9fb0ac03f51a 100644
> > --- a/drivers/gpu/drm/i915/gt/intel_gt.c
> > +++ b/drivers/gpu/drm/i915/gt/intel_gt.c
> > @@ -983,36 +983,6 @@ void intel_gt_info_print(const struct intel_gt_info *info,
> > intel_sseu_dump(&info->sseu, p);
> > }
> > -struct reg_and_bit {
> > - union {
> > - i915_reg_t reg;
> > - i915_mcr_reg_t mcr_reg;
> > - };
> > - u32 bit;
> > -};
> > -
> > -static struct reg_and_bit
> > -get_reg_and_bit(const struct intel_engine_cs *engine, const bool gen8,
> > - const i915_reg_t *regs, const unsigned int num)
> > -{
> > - const unsigned int class = engine->class;
> > - struct reg_and_bit rb = { };
> > -
> > - if (drm_WARN_ON_ONCE(&engine->i915->drm,
> > - class >= num || !regs[class].reg))
> > - return rb;
> > -
> > - rb.reg = regs[class];
> > - if (gen8 && class == VIDEO_DECODE_CLASS)
> > - rb.reg.reg += 4 * engine->instance; /* GEN8_M2TCR */
> > - else
> > - rb.bit = engine->instance;
> > -
> > - rb.bit = BIT(rb.bit);
> > -
> > - return rb;
> > -}
> > -
> > /*
> > * HW architecture suggest typical invalidation time at 40us,
> > * with pessimistic cases up to 100us and a recommendation to
> > @@ -1026,14 +996,20 @@ get_reg_and_bit(const struct intel_engine_cs *engine, const bool gen8,
> > * but are now considered MCR registers. Since they exist within a GAM range,
> > * the primary instance of the register rolls up the status from each unit.
> > */
> > -static int wait_for_invalidate(struct intel_gt *gt, struct reg_and_bit rb)
> > +static int wait_for_invalidate(struct intel_engine_cs *engine)
> > {
> > - if (GRAPHICS_VER_FULL(gt->i915) >= IP_VER(12, 50))
> > - return intel_gt_mcr_wait_for_reg(gt, rb.mcr_reg, rb.bit, 0,
> > + if (engine->tlb_inv.mcr)
> > + return intel_gt_mcr_wait_for_reg(engine->gt,
> > + engine->tlb_inv.reg.mcr_reg,
> > + engine->tlb_inv.done,
> > + 0,
> > TLB_INVAL_TIMEOUT_US,
> > TLB_INVAL_TIMEOUT_MS);
> > else
> > - return __intel_wait_for_register_fw(gt->uncore, rb.reg, rb.bit, 0,
> > + return __intel_wait_for_register_fw(engine->gt->uncore,
> > + engine->tlb_inv.reg.reg,
> > + engine->tlb_inv.done,
> > + 0,
> > TLB_INVAL_TIMEOUT_US,
> > TLB_INVAL_TIMEOUT_MS,
> > NULL);
> > @@ -1041,61 +1017,14 @@ static int wait_for_invalidate(struct intel_gt *gt, struct reg_and_bit rb)
> > static void mmio_invalidate_full(struct intel_gt *gt)
> > {
> > - static const i915_reg_t gen8_regs[] = {
> > - [RENDER_CLASS] = GEN8_RTCR,
> > - [VIDEO_DECODE_CLASS] = GEN8_M1TCR, /* , GEN8_M2TCR */
> > - [VIDEO_ENHANCEMENT_CLASS] = GEN8_VTCR,
> > - [COPY_ENGINE_CLASS] = GEN8_BTCR,
> > - };
> > - static const i915_reg_t gen12_regs[] = {
> > - [RENDER_CLASS] = GEN12_GFX_TLB_INV_CR,
> > - [VIDEO_DECODE_CLASS] = GEN12_VD_TLB_INV_CR,
> > - [VIDEO_ENHANCEMENT_CLASS] = GEN12_VE_TLB_INV_CR,
> > - [COPY_ENGINE_CLASS] = GEN12_BLT_TLB_INV_CR,
> > - [COMPUTE_CLASS] = GEN12_COMPCTX_TLB_INV_CR,
> > - };
> > - static const i915_mcr_reg_t xehp_regs[] = {
> > - [RENDER_CLASS] = XEHP_GFX_TLB_INV_CR,
> > - [VIDEO_DECODE_CLASS] = XEHP_VD_TLB_INV_CR,
> > - [VIDEO_ENHANCEMENT_CLASS] = XEHP_VE_TLB_INV_CR,
> > - [COPY_ENGINE_CLASS] = XEHP_BLT_TLB_INV_CR,
> > - [COMPUTE_CLASS] = XEHP_COMPCTX_TLB_INV_CR,
> > - };
> > struct drm_i915_private *i915 = gt->i915;
> > struct intel_uncore *uncore = gt->uncore;
> > struct intel_engine_cs *engine;
> > intel_engine_mask_t awake, tmp;
> > enum intel_engine_id id;
> > - const i915_reg_t *regs;
> > - unsigned int num = 0;
> > unsigned long flags;
> > - /*
> > - * New platforms should not be added with catch-all-newer (>=)
> > - * condition so that any later platform added triggers the below warning
> > - * and in turn mandates a human cross-check of whether the invalidation
> > - * flows have compatible semantics.
> > - *
> > - * For instance with the 11.00 -> 12.00 transition three out of five
> > - * respective engine registers were moved to masked type. Then after the
> > - * 12.00 -> 12.50 transition multi cast handling is required too.
> > - */
> > -
> > - if (GRAPHICS_VER_FULL(i915) == IP_VER(12, 50)) {
> > - regs = NULL;
> > - num = ARRAY_SIZE(xehp_regs);
> > - } else if (GRAPHICS_VER(i915) == 12) {
> > - regs = gen12_regs;
> > - num = ARRAY_SIZE(gen12_regs);
> > - } else if (GRAPHICS_VER(i915) >= 8 && GRAPHICS_VER(i915) <= 11) {
> > - regs = gen8_regs;
> > - num = ARRAY_SIZE(gen8_regs);
> > - } else if (GRAPHICS_VER(i915) < 8) {
> > - return;
> > - }
> > -
> > - if (drm_WARN_ONCE(&i915->drm, !num,
> > - "Platform does not implement TLB invalidation!"))
> > + if (GRAPHICS_VER(i915) < 8)
> > return;
> > intel_uncore_forcewake_get(uncore, FORCEWAKE_ALL);
> > @@ -1105,33 +1034,18 @@ static void mmio_invalidate_full(struct intel_gt *gt)
> > awake = 0;
> > for_each_engine(engine, gt, id) {
> > - struct reg_and_bit rb;
> > -
> > if (!intel_engine_pm_is_awake(engine))
> > continue;
> > - if (GRAPHICS_VER_FULL(i915) >= IP_VER(12, 50)) {
> > - u32 val = BIT(engine->instance);
> > -
> > - if (engine->class == VIDEO_DECODE_CLASS ||
> > - engine->class == VIDEO_ENHANCEMENT_CLASS ||
> > - engine->class == COMPUTE_CLASS)
> > - val = _MASKED_BIT_ENABLE(val);
> > + if (engine->tlb_inv.mcr)
> > intel_gt_mcr_multicast_write_fw(gt,
> > - xehp_regs[engine->class],
> > - val);
> > - } else {
> > - rb = get_reg_and_bit(engine, regs == gen8_regs, regs, num);
> > - if (!i915_mmio_reg_offset(rb.reg))
> > - continue;
> > -
> > - if (GRAPHICS_VER(i915) == 12 && (engine->class == VIDEO_DECODE_CLASS ||
> > - engine->class == VIDEO_ENHANCEMENT_CLASS ||
> > - engine->class == COMPUTE_CLASS))
> > - rb.bit = _MASKED_BIT_ENABLE(rb.bit);
> > -
> > - intel_uncore_write_fw(uncore, rb.reg, rb.bit);
> > - }
> > + engine->tlb_inv.reg.mcr_reg,
> > + engine->tlb_inv.request);
> > + else
> > + intel_uncore_write_fw(uncore,
> > + engine->tlb_inv.reg.reg,
> > + engine->tlb_inv.request);
> > +
> > awake |= engine->mask;
> > }
> > @@ -1150,16 +1064,7 @@ static void mmio_invalidate_full(struct intel_gt *gt)
> > intel_gt_mcr_unlock(gt, flags);
> > for_each_engine_masked(engine, gt, awake, tmp) {
> > - struct reg_and_bit rb;
> > -
> > - if (GRAPHICS_VER_FULL(i915) >= IP_VER(12, 50)) {
> > - rb.mcr_reg = xehp_regs[engine->class];
> > - rb.bit = BIT(engine->instance);
> > - } else {
> > - rb = get_reg_and_bit(engine, regs == gen8_regs, regs, num);
> > - }
> > -
> > - if (wait_for_invalidate(gt, rb))
> > + if (wait_for_invalidate(engine))
> > drm_err_ratelimited(>->i915->drm,
> > "%s TLB invalidation did not complete in %ums!\n",
> > engine->name, TLB_INVAL_TIMEOUT_MS);
>
--
Matt Roper
Graphics Software Engineer
VTT-OSGC Platform Enablement
Intel Corporation
^ permalink raw reply [flat|nested] 19+ messages in thread* Re: [Intel-gfx] [PATCH 2/2] drm/i915: Consolidate TLB invalidation flow
2023-01-03 19:57 ` Matt Roper
(?)
@ 2023-01-04 8:46 ` Andrzej Hajda
-1 siblings, 0 replies; 19+ messages in thread
From: Andrzej Hajda @ 2023-01-04 8:46 UTC (permalink / raw)
To: Matt Roper; +Cc: Intel-gfx, dri-devel
On 03.01.2023 20:57, Matt Roper wrote:
> On Mon, Dec 19, 2022 at 05:10:02PM +0100, Andrzej Hajda wrote:
>> On 19.12.2022 11:13, Tvrtko Ursulin wrote:
>>> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>>
>>> As the logic for selecting the register and corresponsing values grew, the
>>
>> corresponding
>>
>>> code become a bit unsightly. Consolidate by storing the required values at
>>> engine init time in the engine itself, and by doing so minimise the amount
>>> of invariant platform and engine checks during each and every TLB
>>> invalidation.
>>>
>>> v2:
>>> * Fail engine probe if TLB invlidations registers are unknown.
>>>
>>> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>> Cc: Andrzej Hajda <andrzej.hajda@intel.com>
>>> Cc: Matt Roper <matthew.d.roper@intel.com>
>>> Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com> # v1
>>> ---
>>> drivers/gpu/drm/i915/gt/intel_engine_cs.c | 93 +++++++++++++
>>> drivers/gpu/drm/i915/gt/intel_engine_types.h | 15 +++
>>> drivers/gpu/drm/i915/gt/intel_gt.c | 135 +++----------------
>>> 3 files changed, 128 insertions(+), 115 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/i915/gt/intel_engine_cs.c b/drivers/gpu/drm/i915/gt/intel_engine_cs.c
>>> index 99c4b866addd..d47dadfc25c8 100644
>>> --- a/drivers/gpu/drm/i915/gt/intel_engine_cs.c
>>> +++ b/drivers/gpu/drm/i915/gt/intel_engine_cs.c
>>> @@ -1143,12 +1143,105 @@ static int init_status_page(struct intel_engine_cs *engine)
>>> return ret;
>>> }
>>> +static int intel_engine_init_tlb_invalidation(struct intel_engine_cs *engine)
>>> +{
>>> + static const union intel_engine_tlb_inv_reg gen8_regs[] = {
>>> + [RENDER_CLASS].reg = GEN8_RTCR,
>>> + [VIDEO_DECODE_CLASS].reg = GEN8_M1TCR, /* , GEN8_M2TCR */
>>> + [VIDEO_ENHANCEMENT_CLASS].reg = GEN8_VTCR,
>>> + [COPY_ENGINE_CLASS].reg = GEN8_BTCR,
>>> + };
>>> + static const union intel_engine_tlb_inv_reg gen12_regs[] = {
>>> + [RENDER_CLASS].reg = GEN12_GFX_TLB_INV_CR,
>>> + [VIDEO_DECODE_CLASS].reg = GEN12_VD_TLB_INV_CR,
>>> + [VIDEO_ENHANCEMENT_CLASS].reg = GEN12_VE_TLB_INV_CR,
>>> + [COPY_ENGINE_CLASS].reg = GEN12_BLT_TLB_INV_CR,
>>> + [COMPUTE_CLASS].reg = GEN12_COMPCTX_TLB_INV_CR,
>>> + };
>>> + static const union intel_engine_tlb_inv_reg xehp_regs[] = {
>>> + [RENDER_CLASS].mcr_reg = XEHP_GFX_TLB_INV_CR,
>>> + [VIDEO_DECODE_CLASS].mcr_reg = XEHP_VD_TLB_INV_CR,
>>> + [VIDEO_ENHANCEMENT_CLASS].mcr_reg = XEHP_VE_TLB_INV_CR,
>>> + [COPY_ENGINE_CLASS].mcr_reg = XEHP_BLT_TLB_INV_CR,
>>> + [COMPUTE_CLASS].mcr_reg = XEHP_COMPCTX_TLB_INV_CR,
>>> + };
>>> + struct drm_i915_private *i915 = engine->i915;
>>> + const union intel_engine_tlb_inv_reg *regs;
>>> + union intel_engine_tlb_inv_reg reg;
>>> + unsigned int class = engine->class;
>>> + unsigned int num = 0;
>>> + u32 val;
>>> +
>>> + /*
>>> + * New platforms should not be added with catch-all-newer (>=)
>>> + * condition so that any later platform added triggers the below warning
>>> + * and in turn mandates a human cross-check of whether the invalidation
>>> + * flows have compatible semantics.
>>> + *
>>> + * For instance with the 11.00 -> 12.00 transition three out of five
>>> + * respective engine registers were moved to masked type. Then after the
>>> + * 12.00 -> 12.50 transition multi cast handling is required too.
>>> + */
>>> +
>>> + if (GRAPHICS_VER_FULL(i915) == IP_VER(12, 50)) {
>
> This is bad...it only captures XEHPSDV and breaks the handling of DG2
> (12.55), PVC (12.60), and MTL (12.70, 12.71, and 12.72). You're not
> hitting the warning as expected since those are all now being captured
> by the next case of the if/else ladder. With the way GMD_ID works, we
> may also get new version numbers that silently show up in hardware too
> at some point (e.g., 12.73, 12.74, etc.)
>
>>> + regs = xehp_regs;
>>> + num = ARRAY_SIZE(xehp_regs);
>>> + } else if (GRAPHICS_VER(i915) == 12) {
>
> You'd want to change this to
>
> GRAPHICS_VER_FULL(i915) == IP_VER(12, 0)
>
> to get the behavior you expected.
According to dg1_info dg1 has IP_VER(12, 10), it will not fit into this
bucket.
Regards
Andrzej
>
>
> Matt
>
>>> + regs = gen12_regs;
>>> + num = ARRAY_SIZE(gen12_regs);
>>> + } else if (GRAPHICS_VER(i915) >= 8 && GRAPHICS_VER(i915) <= 11) {
>>> + regs = gen8_regs;
>>> + num = ARRAY_SIZE(gen8_regs);
>>> + } else if (GRAPHICS_VER(i915) < 8) {
>>> + return 0;
>>> + } > +
>>> + if (drm_WARN_ONCE(&i915->drm, !num,
>>> + "Platform does not implement TLB invalidation!"))
>>> + return -ENODEV;
>>> +
>>> + if (drm_WARN_ON_ONCE(&i915->drm,
>>> + class >= num ||
>>> + (!regs[class].reg.reg &&
>>> + !regs[class].mcr_reg.reg)))
>>> + return -ERANGE;
>>
>> I hope the propagation of -ERANGE to device probe is OK.
>>
>> Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com>
>>
>> Regards
>> Andrzej
>>
>>> +
>>> + reg = regs[class];
>>> +
>>> + if (GRAPHICS_VER(i915) == 8 && class == VIDEO_DECODE_CLASS) {
>>> + reg.reg.reg += 4 * engine->instance; /* GEN8_M2TCR */
>>> + val = 0;
>>> + } else {
>>> + val = engine->instance;
>>> + }
>>> +
>>> + val = BIT(val);
>>> +
>>> + engine->tlb_inv.mcr = regs == xehp_regs;
>>> + engine->tlb_inv.reg = reg;
>>> + engine->tlb_inv.done = val;
>>> +
>>> + if (GRAPHICS_VER(i915) >= 12 &&
>>> + (engine->class == VIDEO_DECODE_CLASS ||
>>> + engine->class == VIDEO_ENHANCEMENT_CLASS ||
>>> + engine->class == COMPUTE_CLASS))
>>> + engine->tlb_inv.request = _MASKED_BIT_ENABLE(val);
>>> + else
>>> + engine->tlb_inv.request = val;
>>> +
>>> + return 0;
>>> +}
>>> +
>>> static int engine_setup_common(struct intel_engine_cs *engine)
>>> {
>>> int err;
>>> init_llist_head(&engine->barrier_tasks);
>>> + err = intel_engine_init_tlb_invalidation(engine);
>>> + if (err)
>>> + return err;
>>> +
>>> err = init_status_page(engine);
>>> if (err)
>>> return err;
>>> diff --git a/drivers/gpu/drm/i915/gt/intel_engine_types.h b/drivers/gpu/drm/i915/gt/intel_engine_types.h
>>> index 4fd54fb8810f..8c661fe89314 100644
>>> --- a/drivers/gpu/drm/i915/gt/intel_engine_types.h
>>> +++ b/drivers/gpu/drm/i915/gt/intel_engine_types.h
>>> @@ -341,6 +341,19 @@ struct intel_engine_guc_stats {
>>> u64 start_gt_clk;
>>> };
>>> +union intel_engine_tlb_inv_reg {
>>> + i915_reg_t reg;
>>> + i915_mcr_reg_t mcr_reg;
>>> +};
>>> +
>>> +struct intel_engine_tlb_inv
>>> +{
>>> + bool mcr;
>>> + union intel_engine_tlb_inv_reg reg;
>>> + u32 request;
>>> + u32 done;
>>> +};
>>> +
>>> struct intel_engine_cs {
>>> struct drm_i915_private *i915;
>>> struct intel_gt *gt;
>>> @@ -372,6 +385,8 @@ struct intel_engine_cs {
>>> u32 context_size;
>>> u32 mmio_base;
>>> + struct intel_engine_tlb_inv tlb_inv;
>>> +
>>> /*
>>> * Some w/a require forcewake to be held (which prevents RC6) while
>>> * a particular engine is active. If so, we set fw_domain to which
>>> diff --git a/drivers/gpu/drm/i915/gt/intel_gt.c b/drivers/gpu/drm/i915/gt/intel_gt.c
>>> index 854841a731cb..9fb0ac03f51a 100644
>>> --- a/drivers/gpu/drm/i915/gt/intel_gt.c
>>> +++ b/drivers/gpu/drm/i915/gt/intel_gt.c
>>> @@ -983,36 +983,6 @@ void intel_gt_info_print(const struct intel_gt_info *info,
>>> intel_sseu_dump(&info->sseu, p);
>>> }
>>> -struct reg_and_bit {
>>> - union {
>>> - i915_reg_t reg;
>>> - i915_mcr_reg_t mcr_reg;
>>> - };
>>> - u32 bit;
>>> -};
>>> -
>>> -static struct reg_and_bit
>>> -get_reg_and_bit(const struct intel_engine_cs *engine, const bool gen8,
>>> - const i915_reg_t *regs, const unsigned int num)
>>> -{
>>> - const unsigned int class = engine->class;
>>> - struct reg_and_bit rb = { };
>>> -
>>> - if (drm_WARN_ON_ONCE(&engine->i915->drm,
>>> - class >= num || !regs[class].reg))
>>> - return rb;
>>> -
>>> - rb.reg = regs[class];
>>> - if (gen8 && class == VIDEO_DECODE_CLASS)
>>> - rb.reg.reg += 4 * engine->instance; /* GEN8_M2TCR */
>>> - else
>>> - rb.bit = engine->instance;
>>> -
>>> - rb.bit = BIT(rb.bit);
>>> -
>>> - return rb;
>>> -}
>>> -
>>> /*
>>> * HW architecture suggest typical invalidation time at 40us,
>>> * with pessimistic cases up to 100us and a recommendation to
>>> @@ -1026,14 +996,20 @@ get_reg_and_bit(const struct intel_engine_cs *engine, const bool gen8,
>>> * but are now considered MCR registers. Since they exist within a GAM range,
>>> * the primary instance of the register rolls up the status from each unit.
>>> */
>>> -static int wait_for_invalidate(struct intel_gt *gt, struct reg_and_bit rb)
>>> +static int wait_for_invalidate(struct intel_engine_cs *engine)
>>> {
>>> - if (GRAPHICS_VER_FULL(gt->i915) >= IP_VER(12, 50))
>>> - return intel_gt_mcr_wait_for_reg(gt, rb.mcr_reg, rb.bit, 0,
>>> + if (engine->tlb_inv.mcr)
>>> + return intel_gt_mcr_wait_for_reg(engine->gt,
>>> + engine->tlb_inv.reg.mcr_reg,
>>> + engine->tlb_inv.done,
>>> + 0,
>>> TLB_INVAL_TIMEOUT_US,
>>> TLB_INVAL_TIMEOUT_MS);
>>> else
>>> - return __intel_wait_for_register_fw(gt->uncore, rb.reg, rb.bit, 0,
>>> + return __intel_wait_for_register_fw(engine->gt->uncore,
>>> + engine->tlb_inv.reg.reg,
>>> + engine->tlb_inv.done,
>>> + 0,
>>> TLB_INVAL_TIMEOUT_US,
>>> TLB_INVAL_TIMEOUT_MS,
>>> NULL);
>>> @@ -1041,61 +1017,14 @@ static int wait_for_invalidate(struct intel_gt *gt, struct reg_and_bit rb)
>>> static void mmio_invalidate_full(struct intel_gt *gt)
>>> {
>>> - static const i915_reg_t gen8_regs[] = {
>>> - [RENDER_CLASS] = GEN8_RTCR,
>>> - [VIDEO_DECODE_CLASS] = GEN8_M1TCR, /* , GEN8_M2TCR */
>>> - [VIDEO_ENHANCEMENT_CLASS] = GEN8_VTCR,
>>> - [COPY_ENGINE_CLASS] = GEN8_BTCR,
>>> - };
>>> - static const i915_reg_t gen12_regs[] = {
>>> - [RENDER_CLASS] = GEN12_GFX_TLB_INV_CR,
>>> - [VIDEO_DECODE_CLASS] = GEN12_VD_TLB_INV_CR,
>>> - [VIDEO_ENHANCEMENT_CLASS] = GEN12_VE_TLB_INV_CR,
>>> - [COPY_ENGINE_CLASS] = GEN12_BLT_TLB_INV_CR,
>>> - [COMPUTE_CLASS] = GEN12_COMPCTX_TLB_INV_CR,
>>> - };
>>> - static const i915_mcr_reg_t xehp_regs[] = {
>>> - [RENDER_CLASS] = XEHP_GFX_TLB_INV_CR,
>>> - [VIDEO_DECODE_CLASS] = XEHP_VD_TLB_INV_CR,
>>> - [VIDEO_ENHANCEMENT_CLASS] = XEHP_VE_TLB_INV_CR,
>>> - [COPY_ENGINE_CLASS] = XEHP_BLT_TLB_INV_CR,
>>> - [COMPUTE_CLASS] = XEHP_COMPCTX_TLB_INV_CR,
>>> - };
>>> struct drm_i915_private *i915 = gt->i915;
>>> struct intel_uncore *uncore = gt->uncore;
>>> struct intel_engine_cs *engine;
>>> intel_engine_mask_t awake, tmp;
>>> enum intel_engine_id id;
>>> - const i915_reg_t *regs;
>>> - unsigned int num = 0;
>>> unsigned long flags;
>>> - /*
>>> - * New platforms should not be added with catch-all-newer (>=)
>>> - * condition so that any later platform added triggers the below warning
>>> - * and in turn mandates a human cross-check of whether the invalidation
>>> - * flows have compatible semantics.
>>> - *
>>> - * For instance with the 11.00 -> 12.00 transition three out of five
>>> - * respective engine registers were moved to masked type. Then after the
>>> - * 12.00 -> 12.50 transition multi cast handling is required too.
>>> - */
>>> -
>>> - if (GRAPHICS_VER_FULL(i915) == IP_VER(12, 50)) {
>>> - regs = NULL;
>>> - num = ARRAY_SIZE(xehp_regs);
>>> - } else if (GRAPHICS_VER(i915) == 12) {
>>> - regs = gen12_regs;
>>> - num = ARRAY_SIZE(gen12_regs);
>>> - } else if (GRAPHICS_VER(i915) >= 8 && GRAPHICS_VER(i915) <= 11) {
>>> - regs = gen8_regs;
>>> - num = ARRAY_SIZE(gen8_regs);
>>> - } else if (GRAPHICS_VER(i915) < 8) {
>>> - return;
>>> - }
>>> -
>>> - if (drm_WARN_ONCE(&i915->drm, !num,
>>> - "Platform does not implement TLB invalidation!"))
>>> + if (GRAPHICS_VER(i915) < 8)
>>> return;
>>> intel_uncore_forcewake_get(uncore, FORCEWAKE_ALL);
>>> @@ -1105,33 +1034,18 @@ static void mmio_invalidate_full(struct intel_gt *gt)
>>> awake = 0;
>>> for_each_engine(engine, gt, id) {
>>> - struct reg_and_bit rb;
>>> -
>>> if (!intel_engine_pm_is_awake(engine))
>>> continue;
>>> - if (GRAPHICS_VER_FULL(i915) >= IP_VER(12, 50)) {
>>> - u32 val = BIT(engine->instance);
>>> -
>>> - if (engine->class == VIDEO_DECODE_CLASS ||
>>> - engine->class == VIDEO_ENHANCEMENT_CLASS ||
>>> - engine->class == COMPUTE_CLASS)
>>> - val = _MASKED_BIT_ENABLE(val);
>>> + if (engine->tlb_inv.mcr)
>>> intel_gt_mcr_multicast_write_fw(gt,
>>> - xehp_regs[engine->class],
>>> - val);
>>> - } else {
>>> - rb = get_reg_and_bit(engine, regs == gen8_regs, regs, num);
>>> - if (!i915_mmio_reg_offset(rb.reg))
>>> - continue;
>>> -
>>> - if (GRAPHICS_VER(i915) == 12 && (engine->class == VIDEO_DECODE_CLASS ||
>>> - engine->class == VIDEO_ENHANCEMENT_CLASS ||
>>> - engine->class == COMPUTE_CLASS))
>>> - rb.bit = _MASKED_BIT_ENABLE(rb.bit);
>>> -
>>> - intel_uncore_write_fw(uncore, rb.reg, rb.bit);
>>> - }
>>> + engine->tlb_inv.reg.mcr_reg,
>>> + engine->tlb_inv.request);
>>> + else
>>> + intel_uncore_write_fw(uncore,
>>> + engine->tlb_inv.reg.reg,
>>> + engine->tlb_inv.request);
>>> +
>>> awake |= engine->mask;
>>> }
>>> @@ -1150,16 +1064,7 @@ static void mmio_invalidate_full(struct intel_gt *gt)
>>> intel_gt_mcr_unlock(gt, flags);
>>> for_each_engine_masked(engine, gt, awake, tmp) {
>>> - struct reg_and_bit rb;
>>> -
>>> - if (GRAPHICS_VER_FULL(i915) >= IP_VER(12, 50)) {
>>> - rb.mcr_reg = xehp_regs[engine->class];
>>> - rb.bit = BIT(engine->instance);
>>> - } else {
>>> - rb = get_reg_and_bit(engine, regs == gen8_regs, regs, num);
>>> - }
>>> -
>>> - if (wait_for_invalidate(gt, rb))
>>> + if (wait_for_invalidate(engine))
>>> drm_err_ratelimited(>->i915->drm,
>>> "%s TLB invalidation did not complete in %ums!\n",
>>> engine->name, TLB_INVAL_TIMEOUT_MS);
>>
>
^ permalink raw reply [flat|nested] 19+ messages in thread* Re: [Intel-gfx] [PATCH 2/2] drm/i915: Consolidate TLB invalidation flow
2023-01-03 19:57 ` Matt Roper
(?)
(?)
@ 2023-01-04 10:08 ` Tvrtko Ursulin
2023-01-04 17:41 ` Matt Roper
-1 siblings, 1 reply; 19+ messages in thread
From: Tvrtko Ursulin @ 2023-01-04 10:08 UTC (permalink / raw)
To: Matt Roper, Andrzej Hajda; +Cc: Intel-gfx, dri-devel
On 03/01/2023 19:57, Matt Roper wrote:
> On Mon, Dec 19, 2022 at 05:10:02PM +0100, Andrzej Hajda wrote:
>> On 19.12.2022 11:13, Tvrtko Ursulin wrote:
>>> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>>
>>> As the logic for selecting the register and corresponsing values grew, the
>>
>> corresponding
>>
>>> code become a bit unsightly. Consolidate by storing the required values at
>>> engine init time in the engine itself, and by doing so minimise the amount
>>> of invariant platform and engine checks during each and every TLB
>>> invalidation.
>>>
>>> v2:
>>> * Fail engine probe if TLB invlidations registers are unknown.
>>>
>>> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>> Cc: Andrzej Hajda <andrzej.hajda@intel.com>
>>> Cc: Matt Roper <matthew.d.roper@intel.com>
>>> Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com> # v1
>>> ---
>>> drivers/gpu/drm/i915/gt/intel_engine_cs.c | 93 +++++++++++++
>>> drivers/gpu/drm/i915/gt/intel_engine_types.h | 15 +++
>>> drivers/gpu/drm/i915/gt/intel_gt.c | 135 +++----------------
>>> 3 files changed, 128 insertions(+), 115 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/i915/gt/intel_engine_cs.c b/drivers/gpu/drm/i915/gt/intel_engine_cs.c
>>> index 99c4b866addd..d47dadfc25c8 100644
>>> --- a/drivers/gpu/drm/i915/gt/intel_engine_cs.c
>>> +++ b/drivers/gpu/drm/i915/gt/intel_engine_cs.c
>>> @@ -1143,12 +1143,105 @@ static int init_status_page(struct intel_engine_cs *engine)
>>> return ret;
>>> }
>>> +static int intel_engine_init_tlb_invalidation(struct intel_engine_cs *engine)
>>> +{
>>> + static const union intel_engine_tlb_inv_reg gen8_regs[] = {
>>> + [RENDER_CLASS].reg = GEN8_RTCR,
>>> + [VIDEO_DECODE_CLASS].reg = GEN8_M1TCR, /* , GEN8_M2TCR */
>>> + [VIDEO_ENHANCEMENT_CLASS].reg = GEN8_VTCR,
>>> + [COPY_ENGINE_CLASS].reg = GEN8_BTCR,
>>> + };
>>> + static const union intel_engine_tlb_inv_reg gen12_regs[] = {
>>> + [RENDER_CLASS].reg = GEN12_GFX_TLB_INV_CR,
>>> + [VIDEO_DECODE_CLASS].reg = GEN12_VD_TLB_INV_CR,
>>> + [VIDEO_ENHANCEMENT_CLASS].reg = GEN12_VE_TLB_INV_CR,
>>> + [COPY_ENGINE_CLASS].reg = GEN12_BLT_TLB_INV_CR,
>>> + [COMPUTE_CLASS].reg = GEN12_COMPCTX_TLB_INV_CR,
>>> + };
>>> + static const union intel_engine_tlb_inv_reg xehp_regs[] = {
>>> + [RENDER_CLASS].mcr_reg = XEHP_GFX_TLB_INV_CR,
>>> + [VIDEO_DECODE_CLASS].mcr_reg = XEHP_VD_TLB_INV_CR,
>>> + [VIDEO_ENHANCEMENT_CLASS].mcr_reg = XEHP_VE_TLB_INV_CR,
>>> + [COPY_ENGINE_CLASS].mcr_reg = XEHP_BLT_TLB_INV_CR,
>>> + [COMPUTE_CLASS].mcr_reg = XEHP_COMPCTX_TLB_INV_CR,
>>> + };
>>> + struct drm_i915_private *i915 = engine->i915;
>>> + const union intel_engine_tlb_inv_reg *regs;
>>> + union intel_engine_tlb_inv_reg reg;
>>> + unsigned int class = engine->class;
>>> + unsigned int num = 0;
>>> + u32 val;
>>> +
>>> + /*
>>> + * New platforms should not be added with catch-all-newer (>=)
>>> + * condition so that any later platform added triggers the below warning
>>> + * and in turn mandates a human cross-check of whether the invalidation
>>> + * flows have compatible semantics.
>>> + *
>>> + * For instance with the 11.00 -> 12.00 transition three out of five
>>> + * respective engine registers were moved to masked type. Then after the
>>> + * 12.00 -> 12.50 transition multi cast handling is required too.
>>> + */
>>> +
>>> + if (GRAPHICS_VER_FULL(i915) == IP_VER(12, 50)) {
>
> This is bad...it only captures XEHPSDV and breaks the handling of DG2
> (12.55), PVC (12.60), and MTL (12.70, 12.71, and 12.72). You're not
> hitting the warning as expected since those are all now being captured
> by the next case of the if/else ladder. With the way GMD_ID works, we
> may also get new version numbers that silently show up in hardware too
> at some point (e.g., 12.73, 12.74, etc.)
Great (on multiple counts) ...
>
>>> + regs = xehp_regs;
>>> + num = ARRAY_SIZE(xehp_regs);
>>> + } else if (GRAPHICS_VER(i915) == 12) {
>
> You'd want to change this to
>
> GRAPHICS_VER_FULL(i915) == IP_VER(12, 0)
>
> to get the behavior you expected.
Okay, that, and then to be as safe as I intended, ie. warn on every new
platforms so developers *must* check registers are still compatible
during platform enablement, we would need a full ver range check
something like:
if (GRAPHICS_VER_FULL(i915) >= IP_VER(12, 50) &&
GRAPHICS_VER_FULL(i915) <= IP_VER(12, 55)) {
regs = xehp_regs;
num = ARRAY_SIZE(xehp_regs);
} else if (GRAPHICS_VER_FULL(i915) == IP_VER(12, 0)) {
regs = gen12_regs;
num = ARRAY_SIZE(gen12_regs);
What do you think about that?
Or you are saying new GMD IDs may appear in the field without first
having passed the new platform enablemend process? That would be
horrible so I hope not.
Regards,
Tvrtko
>>> + regs = gen12_regs;
>>> + num = ARRAY_SIZE(gen12_regs);
>>> + } else if (GRAPHICS_VER(i915) >= 8 && GRAPHICS_VER(i915) <= 11) {
>>> + regs = gen8_regs;
>>> + num = ARRAY_SIZE(gen8_regs);
>>> + } else if (GRAPHICS_VER(i915) < 8) {
>>> + return 0;
>>> + } > +
>>> + if (drm_WARN_ONCE(&i915->drm, !num,
>>> + "Platform does not implement TLB invalidation!"))
>>> + return -ENODEV;
>>> +
>>> + if (drm_WARN_ON_ONCE(&i915->drm,
>>> + class >= num ||
>>> + (!regs[class].reg.reg &&
>>> + !regs[class].mcr_reg.reg)))
>>> + return -ERANGE;
>>
>> I hope the propagation of -ERANGE to device probe is OK.
>>
>> Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com>
>>
>> Regards
>> Andrzej
>>
>>> +
>>> + reg = regs[class];
>>> +
>>> + if (GRAPHICS_VER(i915) == 8 && class == VIDEO_DECODE_CLASS) {
>>> + reg.reg.reg += 4 * engine->instance; /* GEN8_M2TCR */
>>> + val = 0;
>>> + } else {
>>> + val = engine->instance;
>>> + }
>>> +
>>> + val = BIT(val);
>>> +
>>> + engine->tlb_inv.mcr = regs == xehp_regs;
>>> + engine->tlb_inv.reg = reg;
>>> + engine->tlb_inv.done = val;
>>> +
>>> + if (GRAPHICS_VER(i915) >= 12 &&
>>> + (engine->class == VIDEO_DECODE_CLASS ||
>>> + engine->class == VIDEO_ENHANCEMENT_CLASS ||
>>> + engine->class == COMPUTE_CLASS))
>>> + engine->tlb_inv.request = _MASKED_BIT_ENABLE(val);
>>> + else
>>> + engine->tlb_inv.request = val;
>>> +
>>> + return 0;
>>> +}
>>> +
>>> static int engine_setup_common(struct intel_engine_cs *engine)
>>> {
>>> int err;
>>> init_llist_head(&engine->barrier_tasks);
>>> + err = intel_engine_init_tlb_invalidation(engine);
>>> + if (err)
>>> + return err;
>>> +
>>> err = init_status_page(engine);
>>> if (err)
>>> return err;
>>> diff --git a/drivers/gpu/drm/i915/gt/intel_engine_types.h b/drivers/gpu/drm/i915/gt/intel_engine_types.h
>>> index 4fd54fb8810f..8c661fe89314 100644
>>> --- a/drivers/gpu/drm/i915/gt/intel_engine_types.h
>>> +++ b/drivers/gpu/drm/i915/gt/intel_engine_types.h
>>> @@ -341,6 +341,19 @@ struct intel_engine_guc_stats {
>>> u64 start_gt_clk;
>>> };
>>> +union intel_engine_tlb_inv_reg {
>>> + i915_reg_t reg;
>>> + i915_mcr_reg_t mcr_reg;
>>> +};
>>> +
>>> +struct intel_engine_tlb_inv
>>> +{
>>> + bool mcr;
>>> + union intel_engine_tlb_inv_reg reg;
>>> + u32 request;
>>> + u32 done;
>>> +};
>>> +
>>> struct intel_engine_cs {
>>> struct drm_i915_private *i915;
>>> struct intel_gt *gt;
>>> @@ -372,6 +385,8 @@ struct intel_engine_cs {
>>> u32 context_size;
>>> u32 mmio_base;
>>> + struct intel_engine_tlb_inv tlb_inv;
>>> +
>>> /*
>>> * Some w/a require forcewake to be held (which prevents RC6) while
>>> * a particular engine is active. If so, we set fw_domain to which
>>> diff --git a/drivers/gpu/drm/i915/gt/intel_gt.c b/drivers/gpu/drm/i915/gt/intel_gt.c
>>> index 854841a731cb..9fb0ac03f51a 100644
>>> --- a/drivers/gpu/drm/i915/gt/intel_gt.c
>>> +++ b/drivers/gpu/drm/i915/gt/intel_gt.c
>>> @@ -983,36 +983,6 @@ void intel_gt_info_print(const struct intel_gt_info *info,
>>> intel_sseu_dump(&info->sseu, p);
>>> }
>>> -struct reg_and_bit {
>>> - union {
>>> - i915_reg_t reg;
>>> - i915_mcr_reg_t mcr_reg;
>>> - };
>>> - u32 bit;
>>> -};
>>> -
>>> -static struct reg_and_bit
>>> -get_reg_and_bit(const struct intel_engine_cs *engine, const bool gen8,
>>> - const i915_reg_t *regs, const unsigned int num)
>>> -{
>>> - const unsigned int class = engine->class;
>>> - struct reg_and_bit rb = { };
>>> -
>>> - if (drm_WARN_ON_ONCE(&engine->i915->drm,
>>> - class >= num || !regs[class].reg))
>>> - return rb;
>>> -
>>> - rb.reg = regs[class];
>>> - if (gen8 && class == VIDEO_DECODE_CLASS)
>>> - rb.reg.reg += 4 * engine->instance; /* GEN8_M2TCR */
>>> - else
>>> - rb.bit = engine->instance;
>>> -
>>> - rb.bit = BIT(rb.bit);
>>> -
>>> - return rb;
>>> -}
>>> -
>>> /*
>>> * HW architecture suggest typical invalidation time at 40us,
>>> * with pessimistic cases up to 100us and a recommendation to
>>> @@ -1026,14 +996,20 @@ get_reg_and_bit(const struct intel_engine_cs *engine, const bool gen8,
>>> * but are now considered MCR registers. Since they exist within a GAM range,
>>> * the primary instance of the register rolls up the status from each unit.
>>> */
>>> -static int wait_for_invalidate(struct intel_gt *gt, struct reg_and_bit rb)
>>> +static int wait_for_invalidate(struct intel_engine_cs *engine)
>>> {
>>> - if (GRAPHICS_VER_FULL(gt->i915) >= IP_VER(12, 50))
>>> - return intel_gt_mcr_wait_for_reg(gt, rb.mcr_reg, rb.bit, 0,
>>> + if (engine->tlb_inv.mcr)
>>> + return intel_gt_mcr_wait_for_reg(engine->gt,
>>> + engine->tlb_inv.reg.mcr_reg,
>>> + engine->tlb_inv.done,
>>> + 0,
>>> TLB_INVAL_TIMEOUT_US,
>>> TLB_INVAL_TIMEOUT_MS);
>>> else
>>> - return __intel_wait_for_register_fw(gt->uncore, rb.reg, rb.bit, 0,
>>> + return __intel_wait_for_register_fw(engine->gt->uncore,
>>> + engine->tlb_inv.reg.reg,
>>> + engine->tlb_inv.done,
>>> + 0,
>>> TLB_INVAL_TIMEOUT_US,
>>> TLB_INVAL_TIMEOUT_MS,
>>> NULL);
>>> @@ -1041,61 +1017,14 @@ static int wait_for_invalidate(struct intel_gt *gt, struct reg_and_bit rb)
>>> static void mmio_invalidate_full(struct intel_gt *gt)
>>> {
>>> - static const i915_reg_t gen8_regs[] = {
>>> - [RENDER_CLASS] = GEN8_RTCR,
>>> - [VIDEO_DECODE_CLASS] = GEN8_M1TCR, /* , GEN8_M2TCR */
>>> - [VIDEO_ENHANCEMENT_CLASS] = GEN8_VTCR,
>>> - [COPY_ENGINE_CLASS] = GEN8_BTCR,
>>> - };
>>> - static const i915_reg_t gen12_regs[] = {
>>> - [RENDER_CLASS] = GEN12_GFX_TLB_INV_CR,
>>> - [VIDEO_DECODE_CLASS] = GEN12_VD_TLB_INV_CR,
>>> - [VIDEO_ENHANCEMENT_CLASS] = GEN12_VE_TLB_INV_CR,
>>> - [COPY_ENGINE_CLASS] = GEN12_BLT_TLB_INV_CR,
>>> - [COMPUTE_CLASS] = GEN12_COMPCTX_TLB_INV_CR,
>>> - };
>>> - static const i915_mcr_reg_t xehp_regs[] = {
>>> - [RENDER_CLASS] = XEHP_GFX_TLB_INV_CR,
>>> - [VIDEO_DECODE_CLASS] = XEHP_VD_TLB_INV_CR,
>>> - [VIDEO_ENHANCEMENT_CLASS] = XEHP_VE_TLB_INV_CR,
>>> - [COPY_ENGINE_CLASS] = XEHP_BLT_TLB_INV_CR,
>>> - [COMPUTE_CLASS] = XEHP_COMPCTX_TLB_INV_CR,
>>> - };
>>> struct drm_i915_private *i915 = gt->i915;
>>> struct intel_uncore *uncore = gt->uncore;
>>> struct intel_engine_cs *engine;
>>> intel_engine_mask_t awake, tmp;
>>> enum intel_engine_id id;
>>> - const i915_reg_t *regs;
>>> - unsigned int num = 0;
>>> unsigned long flags;
>>> - /*
>>> - * New platforms should not be added with catch-all-newer (>=)
>>> - * condition so that any later platform added triggers the below warning
>>> - * and in turn mandates a human cross-check of whether the invalidation
>>> - * flows have compatible semantics.
>>> - *
>>> - * For instance with the 11.00 -> 12.00 transition three out of five
>>> - * respective engine registers were moved to masked type. Then after the
>>> - * 12.00 -> 12.50 transition multi cast handling is required too.
>>> - */
>>> -
>>> - if (GRAPHICS_VER_FULL(i915) == IP_VER(12, 50)) {
>>> - regs = NULL;
>>> - num = ARRAY_SIZE(xehp_regs);
>>> - } else if (GRAPHICS_VER(i915) == 12) {
>>> - regs = gen12_regs;
>>> - num = ARRAY_SIZE(gen12_regs);
>>> - } else if (GRAPHICS_VER(i915) >= 8 && GRAPHICS_VER(i915) <= 11) {
>>> - regs = gen8_regs;
>>> - num = ARRAY_SIZE(gen8_regs);
>>> - } else if (GRAPHICS_VER(i915) < 8) {
>>> - return;
>>> - }
>>> -
>>> - if (drm_WARN_ONCE(&i915->drm, !num,
>>> - "Platform does not implement TLB invalidation!"))
>>> + if (GRAPHICS_VER(i915) < 8)
>>> return;
>>> intel_uncore_forcewake_get(uncore, FORCEWAKE_ALL);
>>> @@ -1105,33 +1034,18 @@ static void mmio_invalidate_full(struct intel_gt *gt)
>>> awake = 0;
>>> for_each_engine(engine, gt, id) {
>>> - struct reg_and_bit rb;
>>> -
>>> if (!intel_engine_pm_is_awake(engine))
>>> continue;
>>> - if (GRAPHICS_VER_FULL(i915) >= IP_VER(12, 50)) {
>>> - u32 val = BIT(engine->instance);
>>> -
>>> - if (engine->class == VIDEO_DECODE_CLASS ||
>>> - engine->class == VIDEO_ENHANCEMENT_CLASS ||
>>> - engine->class == COMPUTE_CLASS)
>>> - val = _MASKED_BIT_ENABLE(val);
>>> + if (engine->tlb_inv.mcr)
>>> intel_gt_mcr_multicast_write_fw(gt,
>>> - xehp_regs[engine->class],
>>> - val);
>>> - } else {
>>> - rb = get_reg_and_bit(engine, regs == gen8_regs, regs, num);
>>> - if (!i915_mmio_reg_offset(rb.reg))
>>> - continue;
>>> -
>>> - if (GRAPHICS_VER(i915) == 12 && (engine->class == VIDEO_DECODE_CLASS ||
>>> - engine->class == VIDEO_ENHANCEMENT_CLASS ||
>>> - engine->class == COMPUTE_CLASS))
>>> - rb.bit = _MASKED_BIT_ENABLE(rb.bit);
>>> -
>>> - intel_uncore_write_fw(uncore, rb.reg, rb.bit);
>>> - }
>>> + engine->tlb_inv.reg.mcr_reg,
>>> + engine->tlb_inv.request);
>>> + else
>>> + intel_uncore_write_fw(uncore,
>>> + engine->tlb_inv.reg.reg,
>>> + engine->tlb_inv.request);
>>> +
>>> awake |= engine->mask;
>>> }
>>> @@ -1150,16 +1064,7 @@ static void mmio_invalidate_full(struct intel_gt *gt)
>>> intel_gt_mcr_unlock(gt, flags);
>>> for_each_engine_masked(engine, gt, awake, tmp) {
>>> - struct reg_and_bit rb;
>>> -
>>> - if (GRAPHICS_VER_FULL(i915) >= IP_VER(12, 50)) {
>>> - rb.mcr_reg = xehp_regs[engine->class];
>>> - rb.bit = BIT(engine->instance);
>>> - } else {
>>> - rb = get_reg_and_bit(engine, regs == gen8_regs, regs, num);
>>> - }
>>> -
>>> - if (wait_for_invalidate(gt, rb))
>>> + if (wait_for_invalidate(engine))
>>> drm_err_ratelimited(>->i915->drm,
>>> "%s TLB invalidation did not complete in %ums!\n",
>>> engine->name, TLB_INVAL_TIMEOUT_MS);
>>
>
^ permalink raw reply [flat|nested] 19+ messages in thread* Re: [Intel-gfx] [PATCH 2/2] drm/i915: Consolidate TLB invalidation flow
2023-01-04 10:08 ` Tvrtko Ursulin
@ 2023-01-04 17:41 ` Matt Roper
2023-01-04 21:58 ` Andrzej Hajda
2023-01-05 13:06 ` Tvrtko Ursulin
0 siblings, 2 replies; 19+ messages in thread
From: Matt Roper @ 2023-01-04 17:41 UTC (permalink / raw)
To: Tvrtko Ursulin; +Cc: Intel-gfx, dri-devel, Andrzej Hajda
On Wed, Jan 04, 2023 at 10:08:29AM +0000, Tvrtko Ursulin wrote:
>
> On 03/01/2023 19:57, Matt Roper wrote:
> > On Mon, Dec 19, 2022 at 05:10:02PM +0100, Andrzej Hajda wrote:
> > > On 19.12.2022 11:13, Tvrtko Ursulin wrote:
> > > > From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> > > >
> > > > As the logic for selecting the register and corresponsing values grew, the
> > >
> > > corresponding
> > >
> > > > code become a bit unsightly. Consolidate by storing the required values at
> > > > engine init time in the engine itself, and by doing so minimise the amount
> > > > of invariant platform and engine checks during each and every TLB
> > > > invalidation.
> > > >
> > > > v2:
> > > > * Fail engine probe if TLB invlidations registers are unknown.
> > > >
> > > > Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> > > > Cc: Andrzej Hajda <andrzej.hajda@intel.com>
> > > > Cc: Matt Roper <matthew.d.roper@intel.com>
> > > > Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com> # v1
> > > > ---
> > > > drivers/gpu/drm/i915/gt/intel_engine_cs.c | 93 +++++++++++++
> > > > drivers/gpu/drm/i915/gt/intel_engine_types.h | 15 +++
> > > > drivers/gpu/drm/i915/gt/intel_gt.c | 135 +++----------------
> > > > 3 files changed, 128 insertions(+), 115 deletions(-)
> > > >
> > > > diff --git a/drivers/gpu/drm/i915/gt/intel_engine_cs.c b/drivers/gpu/drm/i915/gt/intel_engine_cs.c
> > > > index 99c4b866addd..d47dadfc25c8 100644
> > > > --- a/drivers/gpu/drm/i915/gt/intel_engine_cs.c
> > > > +++ b/drivers/gpu/drm/i915/gt/intel_engine_cs.c
> > > > @@ -1143,12 +1143,105 @@ static int init_status_page(struct intel_engine_cs *engine)
> > > > return ret;
> > > > }
> > > > +static int intel_engine_init_tlb_invalidation(struct intel_engine_cs *engine)
> > > > +{
> > > > + static const union intel_engine_tlb_inv_reg gen8_regs[] = {
> > > > + [RENDER_CLASS].reg = GEN8_RTCR,
> > > > + [VIDEO_DECODE_CLASS].reg = GEN8_M1TCR, /* , GEN8_M2TCR */
> > > > + [VIDEO_ENHANCEMENT_CLASS].reg = GEN8_VTCR,
> > > > + [COPY_ENGINE_CLASS].reg = GEN8_BTCR,
> > > > + };
> > > > + static const union intel_engine_tlb_inv_reg gen12_regs[] = {
> > > > + [RENDER_CLASS].reg = GEN12_GFX_TLB_INV_CR,
> > > > + [VIDEO_DECODE_CLASS].reg = GEN12_VD_TLB_INV_CR,
> > > > + [VIDEO_ENHANCEMENT_CLASS].reg = GEN12_VE_TLB_INV_CR,
> > > > + [COPY_ENGINE_CLASS].reg = GEN12_BLT_TLB_INV_CR,
> > > > + [COMPUTE_CLASS].reg = GEN12_COMPCTX_TLB_INV_CR,
> > > > + };
> > > > + static const union intel_engine_tlb_inv_reg xehp_regs[] = {
> > > > + [RENDER_CLASS].mcr_reg = XEHP_GFX_TLB_INV_CR,
> > > > + [VIDEO_DECODE_CLASS].mcr_reg = XEHP_VD_TLB_INV_CR,
> > > > + [VIDEO_ENHANCEMENT_CLASS].mcr_reg = XEHP_VE_TLB_INV_CR,
> > > > + [COPY_ENGINE_CLASS].mcr_reg = XEHP_BLT_TLB_INV_CR,
> > > > + [COMPUTE_CLASS].mcr_reg = XEHP_COMPCTX_TLB_INV_CR,
> > > > + };
> > > > + struct drm_i915_private *i915 = engine->i915;
> > > > + const union intel_engine_tlb_inv_reg *regs;
> > > > + union intel_engine_tlb_inv_reg reg;
> > > > + unsigned int class = engine->class;
> > > > + unsigned int num = 0;
> > > > + u32 val;
> > > > +
> > > > + /*
> > > > + * New platforms should not be added with catch-all-newer (>=)
> > > > + * condition so that any later platform added triggers the below warning
> > > > + * and in turn mandates a human cross-check of whether the invalidation
> > > > + * flows have compatible semantics.
> > > > + *
> > > > + * For instance with the 11.00 -> 12.00 transition three out of five
> > > > + * respective engine registers were moved to masked type. Then after the
> > > > + * 12.00 -> 12.50 transition multi cast handling is required too.
> > > > + */
> > > > +
> > > > + if (GRAPHICS_VER_FULL(i915) == IP_VER(12, 50)) {
> >
> > This is bad...it only captures XEHPSDV and breaks the handling of DG2
> > (12.55), PVC (12.60), and MTL (12.70, 12.71, and 12.72). You're not
> > hitting the warning as expected since those are all now being captured
> > by the next case of the if/else ladder. With the way GMD_ID works, we
> > may also get new version numbers that silently show up in hardware too
> > at some point (e.g., 12.73, 12.74, etc.)
>
> Great (on multiple counts) ...
>
> >
> > > > + regs = xehp_regs;
> > > > + num = ARRAY_SIZE(xehp_regs);
> > > > + } else if (GRAPHICS_VER(i915) == 12) {
> >
> > You'd want to change this to
> >
> > GRAPHICS_VER_FULL(i915) == IP_VER(12, 0)
> >
> > to get the behavior you expected.
>
> Okay, that, and then to be as safe as I intended, ie. warn on every new
> platforms so developers *must* check registers are still compatible during
> platform enablement, we would need a full ver range check something like:
>
> if (GRAPHICS_VER_FULL(i915) >= IP_VER(12, 50) &&
> GRAPHICS_VER_FULL(i915) <= IP_VER(12, 55)) {
> regs = xehp_regs;
> num = ARRAY_SIZE(xehp_regs);
> } else if (GRAPHICS_VER_FULL(i915) == IP_VER(12, 0)) {
> regs = gen12_regs;
> num = ARRAY_SIZE(gen12_regs);
>
> What do you think about that?
What about just keeping the code the way it is now, but adding a new
error condition at the *top* of the ladder?
if (GRAPHICS_VER_FULL(i915) > IP_VER(12, 72)) {
/* Error, something new we haven't considered */
} else if (GRAPHICS_VER_FULL(i915) >= IP_VER(12, 50)) {
...
I guess that won't catch cases where they go back and insert a new
version or IP refresh that's older than the latest version number, but
usually refresh platforms aren't going to be adding the kind of
architectural changes that require a new if/else arm anyway.
Also, as Andrzej pointed out on a different reply, we classified DG1 as
12.10 (because of the interrupt handling changes), so I guess we'd need
a further adjustment to the "gen12" branch to cover that one too.
Honestly, I'm not super wild about the general plan of intentionally
breaking inheritance here; that runs counter to how we usually try to do
things in i915. In most places we always try to assume that future
platforms will behave the same way as the latest one, and then we update
those assumptions as part of the initial bringup when a future platform
comes along that breaks them. Most of the places where we do specific
checks and a MISSING_CASE warning are where we have a strong reason to
believe that each platform will always need a new implementation (e.g.,
stuff like workaround lists). I don't see a reason to expect major
changes in MMIO-based invalidation for a platform n+1, n+2, etc. The
change that I _do_ expect to show up (even for some of these current
platforms) is that a GuC-based TLB invalidation path will be added since
that's mandatory for a lot of modern features, but that will be a
parallel codepath, not part of the if/else ladder we're editing here.
>
> Or you are saying new GMD IDs may appear in the field without first having
> passed the new platform enablemend process? That would be horrible so I hope
> not.
They won't just show up in the wild, we'll know they're coming. But
they'll be used for stuff like how DG2-G12 showed up after we'd already
enabled DG2-G10 and DG2-G11. Or how we picked up a couple more ADL
variants that our driver treats as "ADL-P," even though there are
technically other SKU letters associated with them. So they're things
that we wouldn't consider to be a whole new platform, just a new
subplatform at best.
Matt
>
> Regards,
>
> Tvrtko
>
> > > > + regs = gen12_regs;
> > > > + num = ARRAY_SIZE(gen12_regs);
> > > > + } else if (GRAPHICS_VER(i915) >= 8 && GRAPHICS_VER(i915) <= 11) {
> > > > + regs = gen8_regs;
> > > > + num = ARRAY_SIZE(gen8_regs);
> > > > + } else if (GRAPHICS_VER(i915) < 8) {
> > > > + return 0;
> > > > + } > +
> > > > + if (drm_WARN_ONCE(&i915->drm, !num,
> > > > + "Platform does not implement TLB invalidation!"))
> > > > + return -ENODEV;
> > > > +
> > > > + if (drm_WARN_ON_ONCE(&i915->drm,
> > > > + class >= num ||
> > > > + (!regs[class].reg.reg &&
> > > > + !regs[class].mcr_reg.reg)))
> > > > + return -ERANGE;
> > >
> > > I hope the propagation of -ERANGE to device probe is OK.
> > >
> > > Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com>
> > >
> > > Regards
> > > Andrzej
> > >
> > > > +
> > > > + reg = regs[class];
> > > > +
> > > > + if (GRAPHICS_VER(i915) == 8 && class == VIDEO_DECODE_CLASS) {
> > > > + reg.reg.reg += 4 * engine->instance; /* GEN8_M2TCR */
> > > > + val = 0;
> > > > + } else {
> > > > + val = engine->instance;
> > > > + }
> > > > +
> > > > + val = BIT(val);
> > > > +
> > > > + engine->tlb_inv.mcr = regs == xehp_regs;
> > > > + engine->tlb_inv.reg = reg;
> > > > + engine->tlb_inv.done = val;
> > > > +
> > > > + if (GRAPHICS_VER(i915) >= 12 &&
> > > > + (engine->class == VIDEO_DECODE_CLASS ||
> > > > + engine->class == VIDEO_ENHANCEMENT_CLASS ||
> > > > + engine->class == COMPUTE_CLASS))
> > > > + engine->tlb_inv.request = _MASKED_BIT_ENABLE(val);
> > > > + else
> > > > + engine->tlb_inv.request = val;
> > > > +
> > > > + return 0;
> > > > +}
> > > > +
> > > > static int engine_setup_common(struct intel_engine_cs *engine)
> > > > {
> > > > int err;
> > > > init_llist_head(&engine->barrier_tasks);
> > > > + err = intel_engine_init_tlb_invalidation(engine);
> > > > + if (err)
> > > > + return err;
> > > > +
> > > > err = init_status_page(engine);
> > > > if (err)
> > > > return err;
> > > > diff --git a/drivers/gpu/drm/i915/gt/intel_engine_types.h b/drivers/gpu/drm/i915/gt/intel_engine_types.h
> > > > index 4fd54fb8810f..8c661fe89314 100644
> > > > --- a/drivers/gpu/drm/i915/gt/intel_engine_types.h
> > > > +++ b/drivers/gpu/drm/i915/gt/intel_engine_types.h
> > > > @@ -341,6 +341,19 @@ struct intel_engine_guc_stats {
> > > > u64 start_gt_clk;
> > > > };
> > > > +union intel_engine_tlb_inv_reg {
> > > > + i915_reg_t reg;
> > > > + i915_mcr_reg_t mcr_reg;
> > > > +};
> > > > +
> > > > +struct intel_engine_tlb_inv
> > > > +{
> > > > + bool mcr;
> > > > + union intel_engine_tlb_inv_reg reg;
> > > > + u32 request;
> > > > + u32 done;
> > > > +};
> > > > +
> > > > struct intel_engine_cs {
> > > > struct drm_i915_private *i915;
> > > > struct intel_gt *gt;
> > > > @@ -372,6 +385,8 @@ struct intel_engine_cs {
> > > > u32 context_size;
> > > > u32 mmio_base;
> > > > + struct intel_engine_tlb_inv tlb_inv;
> > > > +
> > > > /*
> > > > * Some w/a require forcewake to be held (which prevents RC6) while
> > > > * a particular engine is active. If so, we set fw_domain to which
> > > > diff --git a/drivers/gpu/drm/i915/gt/intel_gt.c b/drivers/gpu/drm/i915/gt/intel_gt.c
> > > > index 854841a731cb..9fb0ac03f51a 100644
> > > > --- a/drivers/gpu/drm/i915/gt/intel_gt.c
> > > > +++ b/drivers/gpu/drm/i915/gt/intel_gt.c
> > > > @@ -983,36 +983,6 @@ void intel_gt_info_print(const struct intel_gt_info *info,
> > > > intel_sseu_dump(&info->sseu, p);
> > > > }
> > > > -struct reg_and_bit {
> > > > - union {
> > > > - i915_reg_t reg;
> > > > - i915_mcr_reg_t mcr_reg;
> > > > - };
> > > > - u32 bit;
> > > > -};
> > > > -
> > > > -static struct reg_and_bit
> > > > -get_reg_and_bit(const struct intel_engine_cs *engine, const bool gen8,
> > > > - const i915_reg_t *regs, const unsigned int num)
> > > > -{
> > > > - const unsigned int class = engine->class;
> > > > - struct reg_and_bit rb = { };
> > > > -
> > > > - if (drm_WARN_ON_ONCE(&engine->i915->drm,
> > > > - class >= num || !regs[class].reg))
> > > > - return rb;
> > > > -
> > > > - rb.reg = regs[class];
> > > > - if (gen8 && class == VIDEO_DECODE_CLASS)
> > > > - rb.reg.reg += 4 * engine->instance; /* GEN8_M2TCR */
> > > > - else
> > > > - rb.bit = engine->instance;
> > > > -
> > > > - rb.bit = BIT(rb.bit);
> > > > -
> > > > - return rb;
> > > > -}
> > > > -
> > > > /*
> > > > * HW architecture suggest typical invalidation time at 40us,
> > > > * with pessimistic cases up to 100us and a recommendation to
> > > > @@ -1026,14 +996,20 @@ get_reg_and_bit(const struct intel_engine_cs *engine, const bool gen8,
> > > > * but are now considered MCR registers. Since they exist within a GAM range,
> > > > * the primary instance of the register rolls up the status from each unit.
> > > > */
> > > > -static int wait_for_invalidate(struct intel_gt *gt, struct reg_and_bit rb)
> > > > +static int wait_for_invalidate(struct intel_engine_cs *engine)
> > > > {
> > > > - if (GRAPHICS_VER_FULL(gt->i915) >= IP_VER(12, 50))
> > > > - return intel_gt_mcr_wait_for_reg(gt, rb.mcr_reg, rb.bit, 0,
> > > > + if (engine->tlb_inv.mcr)
> > > > + return intel_gt_mcr_wait_for_reg(engine->gt,
> > > > + engine->tlb_inv.reg.mcr_reg,
> > > > + engine->tlb_inv.done,
> > > > + 0,
> > > > TLB_INVAL_TIMEOUT_US,
> > > > TLB_INVAL_TIMEOUT_MS);
> > > > else
> > > > - return __intel_wait_for_register_fw(gt->uncore, rb.reg, rb.bit, 0,
> > > > + return __intel_wait_for_register_fw(engine->gt->uncore,
> > > > + engine->tlb_inv.reg.reg,
> > > > + engine->tlb_inv.done,
> > > > + 0,
> > > > TLB_INVAL_TIMEOUT_US,
> > > > TLB_INVAL_TIMEOUT_MS,
> > > > NULL);
> > > > @@ -1041,61 +1017,14 @@ static int wait_for_invalidate(struct intel_gt *gt, struct reg_and_bit rb)
> > > > static void mmio_invalidate_full(struct intel_gt *gt)
> > > > {
> > > > - static const i915_reg_t gen8_regs[] = {
> > > > - [RENDER_CLASS] = GEN8_RTCR,
> > > > - [VIDEO_DECODE_CLASS] = GEN8_M1TCR, /* , GEN8_M2TCR */
> > > > - [VIDEO_ENHANCEMENT_CLASS] = GEN8_VTCR,
> > > > - [COPY_ENGINE_CLASS] = GEN8_BTCR,
> > > > - };
> > > > - static const i915_reg_t gen12_regs[] = {
> > > > - [RENDER_CLASS] = GEN12_GFX_TLB_INV_CR,
> > > > - [VIDEO_DECODE_CLASS] = GEN12_VD_TLB_INV_CR,
> > > > - [VIDEO_ENHANCEMENT_CLASS] = GEN12_VE_TLB_INV_CR,
> > > > - [COPY_ENGINE_CLASS] = GEN12_BLT_TLB_INV_CR,
> > > > - [COMPUTE_CLASS] = GEN12_COMPCTX_TLB_INV_CR,
> > > > - };
> > > > - static const i915_mcr_reg_t xehp_regs[] = {
> > > > - [RENDER_CLASS] = XEHP_GFX_TLB_INV_CR,
> > > > - [VIDEO_DECODE_CLASS] = XEHP_VD_TLB_INV_CR,
> > > > - [VIDEO_ENHANCEMENT_CLASS] = XEHP_VE_TLB_INV_CR,
> > > > - [COPY_ENGINE_CLASS] = XEHP_BLT_TLB_INV_CR,
> > > > - [COMPUTE_CLASS] = XEHP_COMPCTX_TLB_INV_CR,
> > > > - };
> > > > struct drm_i915_private *i915 = gt->i915;
> > > > struct intel_uncore *uncore = gt->uncore;
> > > > struct intel_engine_cs *engine;
> > > > intel_engine_mask_t awake, tmp;
> > > > enum intel_engine_id id;
> > > > - const i915_reg_t *regs;
> > > > - unsigned int num = 0;
> > > > unsigned long flags;
> > > > - /*
> > > > - * New platforms should not be added with catch-all-newer (>=)
> > > > - * condition so that any later platform added triggers the below warning
> > > > - * and in turn mandates a human cross-check of whether the invalidation
> > > > - * flows have compatible semantics.
> > > > - *
> > > > - * For instance with the 11.00 -> 12.00 transition three out of five
> > > > - * respective engine registers were moved to masked type. Then after the
> > > > - * 12.00 -> 12.50 transition multi cast handling is required too.
> > > > - */
> > > > -
> > > > - if (GRAPHICS_VER_FULL(i915) == IP_VER(12, 50)) {
> > > > - regs = NULL;
> > > > - num = ARRAY_SIZE(xehp_regs);
> > > > - } else if (GRAPHICS_VER(i915) == 12) {
> > > > - regs = gen12_regs;
> > > > - num = ARRAY_SIZE(gen12_regs);
> > > > - } else if (GRAPHICS_VER(i915) >= 8 && GRAPHICS_VER(i915) <= 11) {
> > > > - regs = gen8_regs;
> > > > - num = ARRAY_SIZE(gen8_regs);
> > > > - } else if (GRAPHICS_VER(i915) < 8) {
> > > > - return;
> > > > - }
> > > > -
> > > > - if (drm_WARN_ONCE(&i915->drm, !num,
> > > > - "Platform does not implement TLB invalidation!"))
> > > > + if (GRAPHICS_VER(i915) < 8)
> > > > return;
> > > > intel_uncore_forcewake_get(uncore, FORCEWAKE_ALL);
> > > > @@ -1105,33 +1034,18 @@ static void mmio_invalidate_full(struct intel_gt *gt)
> > > > awake = 0;
> > > > for_each_engine(engine, gt, id) {
> > > > - struct reg_and_bit rb;
> > > > -
> > > > if (!intel_engine_pm_is_awake(engine))
> > > > continue;
> > > > - if (GRAPHICS_VER_FULL(i915) >= IP_VER(12, 50)) {
> > > > - u32 val = BIT(engine->instance);
> > > > -
> > > > - if (engine->class == VIDEO_DECODE_CLASS ||
> > > > - engine->class == VIDEO_ENHANCEMENT_CLASS ||
> > > > - engine->class == COMPUTE_CLASS)
> > > > - val = _MASKED_BIT_ENABLE(val);
> > > > + if (engine->tlb_inv.mcr)
> > > > intel_gt_mcr_multicast_write_fw(gt,
> > > > - xehp_regs[engine->class],
> > > > - val);
> > > > - } else {
> > > > - rb = get_reg_and_bit(engine, regs == gen8_regs, regs, num);
> > > > - if (!i915_mmio_reg_offset(rb.reg))
> > > > - continue;
> > > > -
> > > > - if (GRAPHICS_VER(i915) == 12 && (engine->class == VIDEO_DECODE_CLASS ||
> > > > - engine->class == VIDEO_ENHANCEMENT_CLASS ||
> > > > - engine->class == COMPUTE_CLASS))
> > > > - rb.bit = _MASKED_BIT_ENABLE(rb.bit);
> > > > -
> > > > - intel_uncore_write_fw(uncore, rb.reg, rb.bit);
> > > > - }
> > > > + engine->tlb_inv.reg.mcr_reg,
> > > > + engine->tlb_inv.request);
> > > > + else
> > > > + intel_uncore_write_fw(uncore,
> > > > + engine->tlb_inv.reg.reg,
> > > > + engine->tlb_inv.request);
> > > > +
> > > > awake |= engine->mask;
> > > > }
> > > > @@ -1150,16 +1064,7 @@ static void mmio_invalidate_full(struct intel_gt *gt)
> > > > intel_gt_mcr_unlock(gt, flags);
> > > > for_each_engine_masked(engine, gt, awake, tmp) {
> > > > - struct reg_and_bit rb;
> > > > -
> > > > - if (GRAPHICS_VER_FULL(i915) >= IP_VER(12, 50)) {
> > > > - rb.mcr_reg = xehp_regs[engine->class];
> > > > - rb.bit = BIT(engine->instance);
> > > > - } else {
> > > > - rb = get_reg_and_bit(engine, regs == gen8_regs, regs, num);
> > > > - }
> > > > -
> > > > - if (wait_for_invalidate(gt, rb))
> > > > + if (wait_for_invalidate(engine))
> > > > drm_err_ratelimited(>->i915->drm,
> > > > "%s TLB invalidation did not complete in %ums!\n",
> > > > engine->name, TLB_INVAL_TIMEOUT_MS);
> > >
> >
--
Matt Roper
Graphics Software Engineer
VTT-OSGC Platform Enablement
Intel Corporation
^ permalink raw reply [flat|nested] 19+ messages in thread* Re: [Intel-gfx] [PATCH 2/2] drm/i915: Consolidate TLB invalidation flow
2023-01-04 17:41 ` Matt Roper
@ 2023-01-04 21:58 ` Andrzej Hajda
2023-01-05 13:06 ` Tvrtko Ursulin
1 sibling, 0 replies; 19+ messages in thread
From: Andrzej Hajda @ 2023-01-04 21:58 UTC (permalink / raw)
To: Matt Roper, Tvrtko Ursulin; +Cc: Intel-gfx, dri-devel
On 04.01.2023 18:41, Matt Roper wrote:
> On Wed, Jan 04, 2023 at 10:08:29AM +0000, Tvrtko Ursulin wrote:
>>
>> On 03/01/2023 19:57, Matt Roper wrote:
>>> On Mon, Dec 19, 2022 at 05:10:02PM +0100, Andrzej Hajda wrote:
>>>> On 19.12.2022 11:13, Tvrtko Ursulin wrote:
>>>>> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>>>>
>>>>> As the logic for selecting the register and corresponsing values grew, the
>>>>
>>>> corresponding
>>>>
>>>>> code become a bit unsightly. Consolidate by storing the required values at
>>>>> engine init time in the engine itself, and by doing so minimise the amount
>>>>> of invariant platform and engine checks during each and every TLB
>>>>> invalidation.
>>>>>
>>>>> v2:
>>>>> * Fail engine probe if TLB invlidations registers are unknown.
>>>>>
>>>>> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>>>> Cc: Andrzej Hajda <andrzej.hajda@intel.com>
>>>>> Cc: Matt Roper <matthew.d.roper@intel.com>
>>>>> Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com> # v1
>>>>> ---
>>>>> drivers/gpu/drm/i915/gt/intel_engine_cs.c | 93 +++++++++++++
>>>>> drivers/gpu/drm/i915/gt/intel_engine_types.h | 15 +++
>>>>> drivers/gpu/drm/i915/gt/intel_gt.c | 135 +++----------------
>>>>> 3 files changed, 128 insertions(+), 115 deletions(-)
>>>>>
>>>>> diff --git a/drivers/gpu/drm/i915/gt/intel_engine_cs.c b/drivers/gpu/drm/i915/gt/intel_engine_cs.c
>>>>> index 99c4b866addd..d47dadfc25c8 100644
>>>>> --- a/drivers/gpu/drm/i915/gt/intel_engine_cs.c
>>>>> +++ b/drivers/gpu/drm/i915/gt/intel_engine_cs.c
>>>>> @@ -1143,12 +1143,105 @@ static int init_status_page(struct intel_engine_cs *engine)
>>>>> return ret;
>>>>> }
>>>>> +static int intel_engine_init_tlb_invalidation(struct intel_engine_cs *engine)
>>>>> +{
>>>>> + static const union intel_engine_tlb_inv_reg gen8_regs[] = {
>>>>> + [RENDER_CLASS].reg = GEN8_RTCR,
>>>>> + [VIDEO_DECODE_CLASS].reg = GEN8_M1TCR, /* , GEN8_M2TCR */
>>>>> + [VIDEO_ENHANCEMENT_CLASS].reg = GEN8_VTCR,
>>>>> + [COPY_ENGINE_CLASS].reg = GEN8_BTCR,
>>>>> + };
>>>>> + static const union intel_engine_tlb_inv_reg gen12_regs[] = {
>>>>> + [RENDER_CLASS].reg = GEN12_GFX_TLB_INV_CR,
>>>>> + [VIDEO_DECODE_CLASS].reg = GEN12_VD_TLB_INV_CR,
>>>>> + [VIDEO_ENHANCEMENT_CLASS].reg = GEN12_VE_TLB_INV_CR,
>>>>> + [COPY_ENGINE_CLASS].reg = GEN12_BLT_TLB_INV_CR,
>>>>> + [COMPUTE_CLASS].reg = GEN12_COMPCTX_TLB_INV_CR,
>>>>> + };
>>>>> + static const union intel_engine_tlb_inv_reg xehp_regs[] = {
>>>>> + [RENDER_CLASS].mcr_reg = XEHP_GFX_TLB_INV_CR,
>>>>> + [VIDEO_DECODE_CLASS].mcr_reg = XEHP_VD_TLB_INV_CR,
>>>>> + [VIDEO_ENHANCEMENT_CLASS].mcr_reg = XEHP_VE_TLB_INV_CR,
>>>>> + [COPY_ENGINE_CLASS].mcr_reg = XEHP_BLT_TLB_INV_CR,
>>>>> + [COMPUTE_CLASS].mcr_reg = XEHP_COMPCTX_TLB_INV_CR,
>>>>> + };
>>>>> + struct drm_i915_private *i915 = engine->i915;
>>>>> + const union intel_engine_tlb_inv_reg *regs;
>>>>> + union intel_engine_tlb_inv_reg reg;
>>>>> + unsigned int class = engine->class;
>>>>> + unsigned int num = 0;
>>>>> + u32 val;
>>>>> +
>>>>> + /*
>>>>> + * New platforms should not be added with catch-all-newer (>=)
>>>>> + * condition so that any later platform added triggers the below warning
>>>>> + * and in turn mandates a human cross-check of whether the invalidation
>>>>> + * flows have compatible semantics.
>>>>> + *
>>>>> + * For instance with the 11.00 -> 12.00 transition three out of five
>>>>> + * respective engine registers were moved to masked type. Then after the
>>>>> + * 12.00 -> 12.50 transition multi cast handling is required too.
>>>>> + */
>>>>> +
>>>>> + if (GRAPHICS_VER_FULL(i915) == IP_VER(12, 50)) {
>>>
>>> This is bad...it only captures XEHPSDV and breaks the handling of DG2
>>> (12.55), PVC (12.60), and MTL (12.70, 12.71, and 12.72). You're not
>>> hitting the warning as expected since those are all now being captured
>>> by the next case of the if/else ladder. With the way GMD_ID works, we
>>> may also get new version numbers that silently show up in hardware too
>>> at some point (e.g., 12.73, 12.74, etc.)
>>
>> Great (on multiple counts) ...
>>
>>>
>>>>> + regs = xehp_regs;
>>>>> + num = ARRAY_SIZE(xehp_regs);
>>>>> + } else if (GRAPHICS_VER(i915) == 12) {
>>>
>>> You'd want to change this to
>>>
>>> GRAPHICS_VER_FULL(i915) == IP_VER(12, 0)
>>>
>>> to get the behavior you expected.
>>
>> Okay, that, and then to be as safe as I intended, ie. warn on every new
>> platforms so developers *must* check registers are still compatible during
>> platform enablement, we would need a full ver range check something like:
>>
>> if (GRAPHICS_VER_FULL(i915) >= IP_VER(12, 50) &&
>> GRAPHICS_VER_FULL(i915) <= IP_VER(12, 55)) {
>> regs = xehp_regs;
>> num = ARRAY_SIZE(xehp_regs);
>> } else if (GRAPHICS_VER_FULL(i915) == IP_VER(12, 0)) {
>> regs = gen12_regs;
>> num = ARRAY_SIZE(gen12_regs);
>>
>> What do you think about that?
>
> What about just keeping the code the way it is now, but adding a new
> error condition at the *top* of the ladder?
>
> if (GRAPHICS_VER_FULL(i915) > IP_VER(12, 72)) {
> /* Error, something new we haven't considered */
> } else if (GRAPHICS_VER_FULL(i915) >= IP_VER(12, 50)) {
> ...
>
> I guess that won't catch cases where they go back and insert a new
> version or IP refresh that's older than the latest version number, but
> usually refresh platforms aren't going to be adding the kind of
> architectural changes that require a new if/else arm anyway.
>
> Also, as Andrzej pointed out on a different reply, we classified DG1 as
> 12.10 (because of the interrupt handling changes), so I guess we'd need
> a further adjustment to the "gen12" branch to cover that one too.
My 2 cents.
There seems to be two more or less elegant ways IMO:
1. The ladder for choosing range, covering all values in top-down order,
in such case it could be simplified (only one check per if):
if (ver > IP_VER(12, 72)) {
error
} else if (ver >= IP_VER(12, 50)) {
} else if (ver >= ...) {
} else {
return;
}
This clearly covers whole range, no possible holes/overlaps, but can be
little bit problematic if there will be 'exceptional' platforms, but
this is not the case for now.
2. Explicit checking for supported versions:
- either switch, either ifs specifiying all supported versions (no
ranges) - ok this is not elegant but at least very strict.
- adding tlb_inv_type field to struct intel_device_info, this in theory
will be quite restrictive, but copy/paste technique can ruin it :).
Current approach is also OK (after fixing bugs) but for me seems not
consistent - dubious double checks, upper not-supported range tested at
the end differently.
Regards
Andrzej
>
> Honestly, I'm not super wild about the general plan of intentionally
> breaking inheritance here; that runs counter to how we usually try to do
> things in i915. In most places we always try to assume that future
> platforms will behave the same way as the latest one, and then we update
> those assumptions as part of the initial bringup when a future platform
> comes along that breaks them. Most of the places where we do specific
> checks and a MISSING_CASE warning are where we have a strong reason to
> believe that each platform will always need a new implementation (e.g.,
> stuff like workaround lists). I don't see a reason to expect major
> changes in MMIO-based invalidation for a platform n+1, n+2, etc. The
> change that I _do_ expect to show up (even for some of these current
> platforms) is that a GuC-based TLB invalidation path will be added since
> that's mandatory for a lot of modern features, but that will be a
> parallel codepath, not part of the if/else ladder we're editing here.
>
>>
>> Or you are saying new GMD IDs may appear in the field without first having
>> passed the new platform enablemend process? That would be horrible so I hope
>> not.
>
> They won't just show up in the wild, we'll know they're coming. But
> they'll be used for stuff like how DG2-G12 showed up after we'd already
> enabled DG2-G10 and DG2-G11. Or how we picked up a couple more ADL
> variants that our driver treats as "ADL-P," even though there are
> technically other SKU letters associated with them. So they're things
> that we wouldn't consider to be a whole new platform, just a new
> subplatform at best.
>
>
> Matt
>
>>
>> Regards,
>>
>> Tvrtko
>>
>>>>> + regs = gen12_regs;
>>>>> + num = ARRAY_SIZE(gen12_regs);
>>>>> + } else if (GRAPHICS_VER(i915) >= 8 && GRAPHICS_VER(i915) <= 11) {
>>>>> + regs = gen8_regs;
>>>>> + num = ARRAY_SIZE(gen8_regs);
>>>>> + } else if (GRAPHICS_VER(i915) < 8) {
>>>>> + return 0;
>>>>> + } > +
>>>>> + if (drm_WARN_ONCE(&i915->drm, !num,
>>>>> + "Platform does not implement TLB invalidation!"))
>>>>> + return -ENODEV;
>>>>> +
>>>>> + if (drm_WARN_ON_ONCE(&i915->drm,
>>>>> + class >= num ||
>>>>> + (!regs[class].reg.reg &&
>>>>> + !regs[class].mcr_reg.reg)))
>>>>> + return -ERANGE;
>>>>
>>>> I hope the propagation of -ERANGE to device probe is OK.
>>>>
>>>> Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com>
>>>>
>>>> Regards
>>>> Andrzej
>>>>
>>>>> +
>>>>> + reg = regs[class];
>>>>> +
>>>>> + if (GRAPHICS_VER(i915) == 8 && class == VIDEO_DECODE_CLASS) {
>>>>> + reg.reg.reg += 4 * engine->instance; /* GEN8_M2TCR */
>>>>> + val = 0;
>>>>> + } else {
>>>>> + val = engine->instance;
>>>>> + }
>>>>> +
>>>>> + val = BIT(val);
>>>>> +
>>>>> + engine->tlb_inv.mcr = regs == xehp_regs;
>>>>> + engine->tlb_inv.reg = reg;
>>>>> + engine->tlb_inv.done = val;
>>>>> +
>>>>> + if (GRAPHICS_VER(i915) >= 12 &&
>>>>> + (engine->class == VIDEO_DECODE_CLASS ||
>>>>> + engine->class == VIDEO_ENHANCEMENT_CLASS ||
>>>>> + engine->class == COMPUTE_CLASS))
>>>>> + engine->tlb_inv.request = _MASKED_BIT_ENABLE(val);
>>>>> + else
>>>>> + engine->tlb_inv.request = val;
>>>>> +
>>>>> + return 0;
>>>>> +}
>>>>> +
>>>>> static int engine_setup_common(struct intel_engine_cs *engine)
>>>>> {
>>>>> int err;
>>>>> init_llist_head(&engine->barrier_tasks);
>>>>> + err = intel_engine_init_tlb_invalidation(engine);
>>>>> + if (err)
>>>>> + return err;
>>>>> +
>>>>> err = init_status_page(engine);
>>>>> if (err)
>>>>> return err;
>>>>> diff --git a/drivers/gpu/drm/i915/gt/intel_engine_types.h b/drivers/gpu/drm/i915/gt/intel_engine_types.h
>>>>> index 4fd54fb8810f..8c661fe89314 100644
>>>>> --- a/drivers/gpu/drm/i915/gt/intel_engine_types.h
>>>>> +++ b/drivers/gpu/drm/i915/gt/intel_engine_types.h
>>>>> @@ -341,6 +341,19 @@ struct intel_engine_guc_stats {
>>>>> u64 start_gt_clk;
>>>>> };
>>>>> +union intel_engine_tlb_inv_reg {
>>>>> + i915_reg_t reg;
>>>>> + i915_mcr_reg_t mcr_reg;
>>>>> +};
>>>>> +
>>>>> +struct intel_engine_tlb_inv
>>>>> +{
>>>>> + bool mcr;
>>>>> + union intel_engine_tlb_inv_reg reg;
>>>>> + u32 request;
>>>>> + u32 done;
>>>>> +};
>>>>> +
>>>>> struct intel_engine_cs {
>>>>> struct drm_i915_private *i915;
>>>>> struct intel_gt *gt;
>>>>> @@ -372,6 +385,8 @@ struct intel_engine_cs {
>>>>> u32 context_size;
>>>>> u32 mmio_base;
>>>>> + struct intel_engine_tlb_inv tlb_inv;
>>>>> +
>>>>> /*
>>>>> * Some w/a require forcewake to be held (which prevents RC6) while
>>>>> * a particular engine is active. If so, we set fw_domain to which
>>>>> diff --git a/drivers/gpu/drm/i915/gt/intel_gt.c b/drivers/gpu/drm/i915/gt/intel_gt.c
>>>>> index 854841a731cb..9fb0ac03f51a 100644
>>>>> --- a/drivers/gpu/drm/i915/gt/intel_gt.c
>>>>> +++ b/drivers/gpu/drm/i915/gt/intel_gt.c
>>>>> @@ -983,36 +983,6 @@ void intel_gt_info_print(const struct intel_gt_info *info,
>>>>> intel_sseu_dump(&info->sseu, p);
>>>>> }
>>>>> -struct reg_and_bit {
>>>>> - union {
>>>>> - i915_reg_t reg;
>>>>> - i915_mcr_reg_t mcr_reg;
>>>>> - };
>>>>> - u32 bit;
>>>>> -};
>>>>> -
>>>>> -static struct reg_and_bit
>>>>> -get_reg_and_bit(const struct intel_engine_cs *engine, const bool gen8,
>>>>> - const i915_reg_t *regs, const unsigned int num)
>>>>> -{
>>>>> - const unsigned int class = engine->class;
>>>>> - struct reg_and_bit rb = { };
>>>>> -
>>>>> - if (drm_WARN_ON_ONCE(&engine->i915->drm,
>>>>> - class >= num || !regs[class].reg))
>>>>> - return rb;
>>>>> -
>>>>> - rb.reg = regs[class];
>>>>> - if (gen8 && class == VIDEO_DECODE_CLASS)
>>>>> - rb.reg.reg += 4 * engine->instance; /* GEN8_M2TCR */
>>>>> - else
>>>>> - rb.bit = engine->instance;
>>>>> -
>>>>> - rb.bit = BIT(rb.bit);
>>>>> -
>>>>> - return rb;
>>>>> -}
>>>>> -
>>>>> /*
>>>>> * HW architecture suggest typical invalidation time at 40us,
>>>>> * with pessimistic cases up to 100us and a recommendation to
>>>>> @@ -1026,14 +996,20 @@ get_reg_and_bit(const struct intel_engine_cs *engine, const bool gen8,
>>>>> * but are now considered MCR registers. Since they exist within a GAM range,
>>>>> * the primary instance of the register rolls up the status from each unit.
>>>>> */
>>>>> -static int wait_for_invalidate(struct intel_gt *gt, struct reg_and_bit rb)
>>>>> +static int wait_for_invalidate(struct intel_engine_cs *engine)
>>>>> {
>>>>> - if (GRAPHICS_VER_FULL(gt->i915) >= IP_VER(12, 50))
>>>>> - return intel_gt_mcr_wait_for_reg(gt, rb.mcr_reg, rb.bit, 0,
>>>>> + if (engine->tlb_inv.mcr)
>>>>> + return intel_gt_mcr_wait_for_reg(engine->gt,
>>>>> + engine->tlb_inv.reg.mcr_reg,
>>>>> + engine->tlb_inv.done,
>>>>> + 0,
>>>>> TLB_INVAL_TIMEOUT_US,
>>>>> TLB_INVAL_TIMEOUT_MS);
>>>>> else
>>>>> - return __intel_wait_for_register_fw(gt->uncore, rb.reg, rb.bit, 0,
>>>>> + return __intel_wait_for_register_fw(engine->gt->uncore,
>>>>> + engine->tlb_inv.reg.reg,
>>>>> + engine->tlb_inv.done,
>>>>> + 0,
>>>>> TLB_INVAL_TIMEOUT_US,
>>>>> TLB_INVAL_TIMEOUT_MS,
>>>>> NULL);
>>>>> @@ -1041,61 +1017,14 @@ static int wait_for_invalidate(struct intel_gt *gt, struct reg_and_bit rb)
>>>>> static void mmio_invalidate_full(struct intel_gt *gt)
>>>>> {
>>>>> - static const i915_reg_t gen8_regs[] = {
>>>>> - [RENDER_CLASS] = GEN8_RTCR,
>>>>> - [VIDEO_DECODE_CLASS] = GEN8_M1TCR, /* , GEN8_M2TCR */
>>>>> - [VIDEO_ENHANCEMENT_CLASS] = GEN8_VTCR,
>>>>> - [COPY_ENGINE_CLASS] = GEN8_BTCR,
>>>>> - };
>>>>> - static const i915_reg_t gen12_regs[] = {
>>>>> - [RENDER_CLASS] = GEN12_GFX_TLB_INV_CR,
>>>>> - [VIDEO_DECODE_CLASS] = GEN12_VD_TLB_INV_CR,
>>>>> - [VIDEO_ENHANCEMENT_CLASS] = GEN12_VE_TLB_INV_CR,
>>>>> - [COPY_ENGINE_CLASS] = GEN12_BLT_TLB_INV_CR,
>>>>> - [COMPUTE_CLASS] = GEN12_COMPCTX_TLB_INV_CR,
>>>>> - };
>>>>> - static const i915_mcr_reg_t xehp_regs[] = {
>>>>> - [RENDER_CLASS] = XEHP_GFX_TLB_INV_CR,
>>>>> - [VIDEO_DECODE_CLASS] = XEHP_VD_TLB_INV_CR,
>>>>> - [VIDEO_ENHANCEMENT_CLASS] = XEHP_VE_TLB_INV_CR,
>>>>> - [COPY_ENGINE_CLASS] = XEHP_BLT_TLB_INV_CR,
>>>>> - [COMPUTE_CLASS] = XEHP_COMPCTX_TLB_INV_CR,
>>>>> - };
>>>>> struct drm_i915_private *i915 = gt->i915;
>>>>> struct intel_uncore *uncore = gt->uncore;
>>>>> struct intel_engine_cs *engine;
>>>>> intel_engine_mask_t awake, tmp;
>>>>> enum intel_engine_id id;
>>>>> - const i915_reg_t *regs;
>>>>> - unsigned int num = 0;
>>>>> unsigned long flags;
>>>>> - /*
>>>>> - * New platforms should not be added with catch-all-newer (>=)
>>>>> - * condition so that any later platform added triggers the below warning
>>>>> - * and in turn mandates a human cross-check of whether the invalidation
>>>>> - * flows have compatible semantics.
>>>>> - *
>>>>> - * For instance with the 11.00 -> 12.00 transition three out of five
>>>>> - * respective engine registers were moved to masked type. Then after the
>>>>> - * 12.00 -> 12.50 transition multi cast handling is required too.
>>>>> - */
>>>>> -
>>>>> - if (GRAPHICS_VER_FULL(i915) == IP_VER(12, 50)) {
>>>>> - regs = NULL;
>>>>> - num = ARRAY_SIZE(xehp_regs);
>>>>> - } else if (GRAPHICS_VER(i915) == 12) {
>>>>> - regs = gen12_regs;
>>>>> - num = ARRAY_SIZE(gen12_regs);
>>>>> - } else if (GRAPHICS_VER(i915) >= 8 && GRAPHICS_VER(i915) <= 11) {
>>>>> - regs = gen8_regs;
>>>>> - num = ARRAY_SIZE(gen8_regs);
>>>>> - } else if (GRAPHICS_VER(i915) < 8) {
>>>>> - return;
>>>>> - }
>>>>> -
>>>>> - if (drm_WARN_ONCE(&i915->drm, !num,
>>>>> - "Platform does not implement TLB invalidation!"))
>>>>> + if (GRAPHICS_VER(i915) < 8)
>>>>> return;
>>>>> intel_uncore_forcewake_get(uncore, FORCEWAKE_ALL);
>>>>> @@ -1105,33 +1034,18 @@ static void mmio_invalidate_full(struct intel_gt *gt)
>>>>> awake = 0;
>>>>> for_each_engine(engine, gt, id) {
>>>>> - struct reg_and_bit rb;
>>>>> -
>>>>> if (!intel_engine_pm_is_awake(engine))
>>>>> continue;
>>>>> - if (GRAPHICS_VER_FULL(i915) >= IP_VER(12, 50)) {
>>>>> - u32 val = BIT(engine->instance);
>>>>> -
>>>>> - if (engine->class == VIDEO_DECODE_CLASS ||
>>>>> - engine->class == VIDEO_ENHANCEMENT_CLASS ||
>>>>> - engine->class == COMPUTE_CLASS)
>>>>> - val = _MASKED_BIT_ENABLE(val);
>>>>> + if (engine->tlb_inv.mcr)
>>>>> intel_gt_mcr_multicast_write_fw(gt,
>>>>> - xehp_regs[engine->class],
>>>>> - val);
>>>>> - } else {
>>>>> - rb = get_reg_and_bit(engine, regs == gen8_regs, regs, num);
>>>>> - if (!i915_mmio_reg_offset(rb.reg))
>>>>> - continue;
>>>>> -
>>>>> - if (GRAPHICS_VER(i915) == 12 && (engine->class == VIDEO_DECODE_CLASS ||
>>>>> - engine->class == VIDEO_ENHANCEMENT_CLASS ||
>>>>> - engine->class == COMPUTE_CLASS))
>>>>> - rb.bit = _MASKED_BIT_ENABLE(rb.bit);
>>>>> -
>>>>> - intel_uncore_write_fw(uncore, rb.reg, rb.bit);
>>>>> - }
>>>>> + engine->tlb_inv.reg.mcr_reg,
>>>>> + engine->tlb_inv.request);
>>>>> + else
>>>>> + intel_uncore_write_fw(uncore,
>>>>> + engine->tlb_inv.reg.reg,
>>>>> + engine->tlb_inv.request);
>>>>> +
>>>>> awake |= engine->mask;
>>>>> }
>>>>> @@ -1150,16 +1064,7 @@ static void mmio_invalidate_full(struct intel_gt *gt)
>>>>> intel_gt_mcr_unlock(gt, flags);
>>>>> for_each_engine_masked(engine, gt, awake, tmp) {
>>>>> - struct reg_and_bit rb;
>>>>> -
>>>>> - if (GRAPHICS_VER_FULL(i915) >= IP_VER(12, 50)) {
>>>>> - rb.mcr_reg = xehp_regs[engine->class];
>>>>> - rb.bit = BIT(engine->instance);
>>>>> - } else {
>>>>> - rb = get_reg_and_bit(engine, regs == gen8_regs, regs, num);
>>>>> - }
>>>>> -
>>>>> - if (wait_for_invalidate(gt, rb))
>>>>> + if (wait_for_invalidate(engine))
>>>>> drm_err_ratelimited(>->i915->drm,
>>>>> "%s TLB invalidation did not complete in %ums!\n",
>>>>> engine->name, TLB_INVAL_TIMEOUT_MS);
>>>>
>>>
>
^ permalink raw reply [flat|nested] 19+ messages in thread* Re: [Intel-gfx] [PATCH 2/2] drm/i915: Consolidate TLB invalidation flow
2023-01-04 17:41 ` Matt Roper
2023-01-04 21:58 ` Andrzej Hajda
@ 2023-01-05 13:06 ` Tvrtko Ursulin
2023-01-06 0:19 ` Matt Roper
1 sibling, 1 reply; 19+ messages in thread
From: Tvrtko Ursulin @ 2023-01-05 13:06 UTC (permalink / raw)
To: Matt Roper; +Cc: Intel-gfx, dri-devel, Andrzej Hajda
On 04/01/2023 17:41, Matt Roper wrote:
> On Wed, Jan 04, 2023 at 10:08:29AM +0000, Tvrtko Ursulin wrote:
>>
>> On 03/01/2023 19:57, Matt Roper wrote:
>>> On Mon, Dec 19, 2022 at 05:10:02PM +0100, Andrzej Hajda wrote:
>>>> On 19.12.2022 11:13, Tvrtko Ursulin wrote:
>>>>> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>>>>
>>>>> As the logic for selecting the register and corresponsing values grew, the
>>>>
>>>> corresponding
>>>>
>>>>> code become a bit unsightly. Consolidate by storing the required values at
>>>>> engine init time in the engine itself, and by doing so minimise the amount
>>>>> of invariant platform and engine checks during each and every TLB
>>>>> invalidation.
>>>>>
>>>>> v2:
>>>>> * Fail engine probe if TLB invlidations registers are unknown.
>>>>>
>>>>> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>>>> Cc: Andrzej Hajda <andrzej.hajda@intel.com>
>>>>> Cc: Matt Roper <matthew.d.roper@intel.com>
>>>>> Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com> # v1
>>>>> ---
>>>>> drivers/gpu/drm/i915/gt/intel_engine_cs.c | 93 +++++++++++++
>>>>> drivers/gpu/drm/i915/gt/intel_engine_types.h | 15 +++
>>>>> drivers/gpu/drm/i915/gt/intel_gt.c | 135 +++----------------
>>>>> 3 files changed, 128 insertions(+), 115 deletions(-)
>>>>>
>>>>> diff --git a/drivers/gpu/drm/i915/gt/intel_engine_cs.c b/drivers/gpu/drm/i915/gt/intel_engine_cs.c
>>>>> index 99c4b866addd..d47dadfc25c8 100644
>>>>> --- a/drivers/gpu/drm/i915/gt/intel_engine_cs.c
>>>>> +++ b/drivers/gpu/drm/i915/gt/intel_engine_cs.c
>>>>> @@ -1143,12 +1143,105 @@ static int init_status_page(struct intel_engine_cs *engine)
>>>>> return ret;
>>>>> }
>>>>> +static int intel_engine_init_tlb_invalidation(struct intel_engine_cs *engine)
>>>>> +{
>>>>> + static const union intel_engine_tlb_inv_reg gen8_regs[] = {
>>>>> + [RENDER_CLASS].reg = GEN8_RTCR,
>>>>> + [VIDEO_DECODE_CLASS].reg = GEN8_M1TCR, /* , GEN8_M2TCR */
>>>>> + [VIDEO_ENHANCEMENT_CLASS].reg = GEN8_VTCR,
>>>>> + [COPY_ENGINE_CLASS].reg = GEN8_BTCR,
>>>>> + };
>>>>> + static const union intel_engine_tlb_inv_reg gen12_regs[] = {
>>>>> + [RENDER_CLASS].reg = GEN12_GFX_TLB_INV_CR,
>>>>> + [VIDEO_DECODE_CLASS].reg = GEN12_VD_TLB_INV_CR,
>>>>> + [VIDEO_ENHANCEMENT_CLASS].reg = GEN12_VE_TLB_INV_CR,
>>>>> + [COPY_ENGINE_CLASS].reg = GEN12_BLT_TLB_INV_CR,
>>>>> + [COMPUTE_CLASS].reg = GEN12_COMPCTX_TLB_INV_CR,
>>>>> + };
>>>>> + static const union intel_engine_tlb_inv_reg xehp_regs[] = {
>>>>> + [RENDER_CLASS].mcr_reg = XEHP_GFX_TLB_INV_CR,
>>>>> + [VIDEO_DECODE_CLASS].mcr_reg = XEHP_VD_TLB_INV_CR,
>>>>> + [VIDEO_ENHANCEMENT_CLASS].mcr_reg = XEHP_VE_TLB_INV_CR,
>>>>> + [COPY_ENGINE_CLASS].mcr_reg = XEHP_BLT_TLB_INV_CR,
>>>>> + [COMPUTE_CLASS].mcr_reg = XEHP_COMPCTX_TLB_INV_CR,
>>>>> + };
>>>>> + struct drm_i915_private *i915 = engine->i915;
>>>>> + const union intel_engine_tlb_inv_reg *regs;
>>>>> + union intel_engine_tlb_inv_reg reg;
>>>>> + unsigned int class = engine->class;
>>>>> + unsigned int num = 0;
>>>>> + u32 val;
>>>>> +
>>>>> + /*
>>>>> + * New platforms should not be added with catch-all-newer (>=)
>>>>> + * condition so that any later platform added triggers the below warning
>>>>> + * and in turn mandates a human cross-check of whether the invalidation
>>>>> + * flows have compatible semantics.
>>>>> + *
>>>>> + * For instance with the 11.00 -> 12.00 transition three out of five
>>>>> + * respective engine registers were moved to masked type. Then after the
>>>>> + * 12.00 -> 12.50 transition multi cast handling is required too.
>>>>> + */
>>>>> +
>>>>> + if (GRAPHICS_VER_FULL(i915) == IP_VER(12, 50)) {
>>>
>>> This is bad...it only captures XEHPSDV and breaks the handling of DG2
>>> (12.55), PVC (12.60), and MTL (12.70, 12.71, and 12.72). You're not
>>> hitting the warning as expected since those are all now being captured
>>> by the next case of the if/else ladder. With the way GMD_ID works, we
>>> may also get new version numbers that silently show up in hardware too
>>> at some point (e.g., 12.73, 12.74, etc.)
>>
>> Great (on multiple counts) ...
>>
>>>
>>>>> + regs = xehp_regs;
>>>>> + num = ARRAY_SIZE(xehp_regs);
>>>>> + } else if (GRAPHICS_VER(i915) == 12) {
>>>
>>> You'd want to change this to
>>>
>>> GRAPHICS_VER_FULL(i915) == IP_VER(12, 0)
>>>
>>> to get the behavior you expected.
>>
>> Okay, that, and then to be as safe as I intended, ie. warn on every new
>> platforms so developers *must* check registers are still compatible during
>> platform enablement, we would need a full ver range check something like:
>>
>> if (GRAPHICS_VER_FULL(i915) >= IP_VER(12, 50) &&
>> GRAPHICS_VER_FULL(i915) <= IP_VER(12, 55)) {
>> regs = xehp_regs;
>> num = ARRAY_SIZE(xehp_regs);
>> } else if (GRAPHICS_VER_FULL(i915) == IP_VER(12, 0)) {
>> regs = gen12_regs;
>> num = ARRAY_SIZE(gen12_regs);
>>
>> What do you think about that?
>
> What about just keeping the code the way it is now, but adding a new
> error condition at the *top* of the ladder?
>
> if (GRAPHICS_VER_FULL(i915) > IP_VER(12, 72)) {
> /* Error, something new we haven't considered */
> } else if (GRAPHICS_VER_FULL(i915) >= IP_VER(12, 50)) {
> ...
>
> I guess that won't catch cases where they go back and insert a new
> version or IP refresh that's older than the latest version number, but
> usually refresh platforms aren't going to be adding the kind of
> architectural changes that require a new if/else arm anyway.
>
> Also, as Andrzej pointed out on a different reply, we classified DG1 as
> 12.10 (because of the interrupt handling changes), so I guess we'd need
> a further adjustment to the "gen12" branch to cover that one too.
>
> Honestly, I'm not super wild about the general plan of intentionally
> breaking inheritance here; that runs counter to how we usually try to do
> things in i915. In most places we always try to assume that future
> platforms will behave the same way as the latest one, and then we update
> those assumptions as part of the initial bringup when a future platform
> comes along that breaks them. Most of the places where we do specific
> checks and a MISSING_CASE warning are where we have a strong reason to
> believe that each platform will always need a new implementation (e.g.,
> stuff like workaround lists). I don't see a reason to expect major
> changes in MMIO-based invalidation for a platform n+1, n+2, etc. The
> change that I _do_ expect to show up (even for some of these current
> platforms) is that a GuC-based TLB invalidation path will be added since
> that's mandatory for a lot of modern features, but that will be a
> parallel codepath, not part of the if/else ladder we're editing here.
The strong reason you mention is currently the lack of _any_ test
coverage for this. In other words you'd never know a new platform does
not work properly (imaging one more register becomes masked, like three
have become from Gen11 to Gen12). Or if refactoring this area of the
code broke an existing platform. And both cases lead to CVEs so IMO
safety trumps our usual patterns.
As I said earlier, I am not going to merge anything in this area, apart
that I want "drm/i915: Do not cover all future platforms in TLB
invalidation" in, until test coverage materialises.
Once we have test coverage I am okay with catch all future platforms.
So regarding "drm/i915: Do not cover all future platforms in TLB
invalidation".. minimal change is then to have it like:
if (GRAPHICS_VER_FULL(i915) >= IP_VER(12, 50) &&) {
GRAPHICS_VER_FULL(i915) <= IP_VER(12, 55)
...
} else if (GRAPHICS_VER(i915) == 12) {
...
...
Is this agreeable? That covers XEHPSDV and DG2. PVC and MTL, if they are
intended to be supported, someone (not exclusing myself here) needs to
check bspec before extending the condition with an explicit patch.
Otherwise 77fa9efc16a9 ("drm/i915/xehp: Create separate reg definitions
for new MCR registers") was about Xe_HP, already wrong and Andrzej fixed
it in 4d5cf7b1680a ("drm/i915: fix TLB invalidation for Gen12.50 video
and compute engines").
Further work can happen once test coverage appears.
Regards,
Tvrtko
>>
>> Or you are saying new GMD IDs may appear in the field without first having
>> passed the new platform enablemend process? That would be horrible so I hope
>> not.
>
> They won't just show up in the wild, we'll know they're coming. But
> they'll be used for stuff like how DG2-G12 showed up after we'd already
> enabled DG2-G10 and DG2-G11. Or how we picked up a couple more ADL
> variants that our driver treats as "ADL-P," even though there are
> technically other SKU letters associated with them. So they're things
> that we wouldn't consider to be a whole new platform, just a new
> subplatform at best.
>
>
> Matt
>
>>
>> Regards,
>>
>> Tvrtko
>>
>>>>> + regs = gen12_regs;
>>>>> + num = ARRAY_SIZE(gen12_regs);
>>>>> + } else if (GRAPHICS_VER(i915) >= 8 && GRAPHICS_VER(i915) <= 11) {
>>>>> + regs = gen8_regs;
>>>>> + num = ARRAY_SIZE(gen8_regs);
>>>>> + } else if (GRAPHICS_VER(i915) < 8) {
>>>>> + return 0;
>>>>> + } > +
>>>>> + if (drm_WARN_ONCE(&i915->drm, !num,
>>>>> + "Platform does not implement TLB invalidation!"))
>>>>> + return -ENODEV;
>>>>> +
>>>>> + if (drm_WARN_ON_ONCE(&i915->drm,
>>>>> + class >= num ||
>>>>> + (!regs[class].reg.reg &&
>>>>> + !regs[class].mcr_reg.reg)))
>>>>> + return -ERANGE;
>>>>
>>>> I hope the propagation of -ERANGE to device probe is OK.
>>>>
>>>> Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com>
>>>>
>>>> Regards
>>>> Andrzej
>>>>
>>>>> +
>>>>> + reg = regs[class];
>>>>> +
>>>>> + if (GRAPHICS_VER(i915) == 8 && class == VIDEO_DECODE_CLASS) {
>>>>> + reg.reg.reg += 4 * engine->instance; /* GEN8_M2TCR */
>>>>> + val = 0;
>>>>> + } else {
>>>>> + val = engine->instance;
>>>>> + }
>>>>> +
>>>>> + val = BIT(val);
>>>>> +
>>>>> + engine->tlb_inv.mcr = regs == xehp_regs;
>>>>> + engine->tlb_inv.reg = reg;
>>>>> + engine->tlb_inv.done = val;
>>>>> +
>>>>> + if (GRAPHICS_VER(i915) >= 12 &&
>>>>> + (engine->class == VIDEO_DECODE_CLASS ||
>>>>> + engine->class == VIDEO_ENHANCEMENT_CLASS ||
>>>>> + engine->class == COMPUTE_CLASS))
>>>>> + engine->tlb_inv.request = _MASKED_BIT_ENABLE(val);
>>>>> + else
>>>>> + engine->tlb_inv.request = val;
>>>>> +
>>>>> + return 0;
>>>>> +}
>>>>> +
>>>>> static int engine_setup_common(struct intel_engine_cs *engine)
>>>>> {
>>>>> int err;
>>>>> init_llist_head(&engine->barrier_tasks);
>>>>> + err = intel_engine_init_tlb_invalidation(engine);
>>>>> + if (err)
>>>>> + return err;
>>>>> +
>>>>> err = init_status_page(engine);
>>>>> if (err)
>>>>> return err;
>>>>> diff --git a/drivers/gpu/drm/i915/gt/intel_engine_types.h b/drivers/gpu/drm/i915/gt/intel_engine_types.h
>>>>> index 4fd54fb8810f..8c661fe89314 100644
>>>>> --- a/drivers/gpu/drm/i915/gt/intel_engine_types.h
>>>>> +++ b/drivers/gpu/drm/i915/gt/intel_engine_types.h
>>>>> @@ -341,6 +341,19 @@ struct intel_engine_guc_stats {
>>>>> u64 start_gt_clk;
>>>>> };
>>>>> +union intel_engine_tlb_inv_reg {
>>>>> + i915_reg_t reg;
>>>>> + i915_mcr_reg_t mcr_reg;
>>>>> +};
>>>>> +
>>>>> +struct intel_engine_tlb_inv
>>>>> +{
>>>>> + bool mcr;
>>>>> + union intel_engine_tlb_inv_reg reg;
>>>>> + u32 request;
>>>>> + u32 done;
>>>>> +};
>>>>> +
>>>>> struct intel_engine_cs {
>>>>> struct drm_i915_private *i915;
>>>>> struct intel_gt *gt;
>>>>> @@ -372,6 +385,8 @@ struct intel_engine_cs {
>>>>> u32 context_size;
>>>>> u32 mmio_base;
>>>>> + struct intel_engine_tlb_inv tlb_inv;
>>>>> +
>>>>> /*
>>>>> * Some w/a require forcewake to be held (which prevents RC6) while
>>>>> * a particular engine is active. If so, we set fw_domain to which
>>>>> diff --git a/drivers/gpu/drm/i915/gt/intel_gt.c b/drivers/gpu/drm/i915/gt/intel_gt.c
>>>>> index 854841a731cb..9fb0ac03f51a 100644
>>>>> --- a/drivers/gpu/drm/i915/gt/intel_gt.c
>>>>> +++ b/drivers/gpu/drm/i915/gt/intel_gt.c
>>>>> @@ -983,36 +983,6 @@ void intel_gt_info_print(const struct intel_gt_info *info,
>>>>> intel_sseu_dump(&info->sseu, p);
>>>>> }
>>>>> -struct reg_and_bit {
>>>>> - union {
>>>>> - i915_reg_t reg;
>>>>> - i915_mcr_reg_t mcr_reg;
>>>>> - };
>>>>> - u32 bit;
>>>>> -};
>>>>> -
>>>>> -static struct reg_and_bit
>>>>> -get_reg_and_bit(const struct intel_engine_cs *engine, const bool gen8,
>>>>> - const i915_reg_t *regs, const unsigned int num)
>>>>> -{
>>>>> - const unsigned int class = engine->class;
>>>>> - struct reg_and_bit rb = { };
>>>>> -
>>>>> - if (drm_WARN_ON_ONCE(&engine->i915->drm,
>>>>> - class >= num || !regs[class].reg))
>>>>> - return rb;
>>>>> -
>>>>> - rb.reg = regs[class];
>>>>> - if (gen8 && class == VIDEO_DECODE_CLASS)
>>>>> - rb.reg.reg += 4 * engine->instance; /* GEN8_M2TCR */
>>>>> - else
>>>>> - rb.bit = engine->instance;
>>>>> -
>>>>> - rb.bit = BIT(rb.bit);
>>>>> -
>>>>> - return rb;
>>>>> -}
>>>>> -
>>>>> /*
>>>>> * HW architecture suggest typical invalidation time at 40us,
>>>>> * with pessimistic cases up to 100us and a recommendation to
>>>>> @@ -1026,14 +996,20 @@ get_reg_and_bit(const struct intel_engine_cs *engine, const bool gen8,
>>>>> * but are now considered MCR registers. Since they exist within a GAM range,
>>>>> * the primary instance of the register rolls up the status from each unit.
>>>>> */
>>>>> -static int wait_for_invalidate(struct intel_gt *gt, struct reg_and_bit rb)
>>>>> +static int wait_for_invalidate(struct intel_engine_cs *engine)
>>>>> {
>>>>> - if (GRAPHICS_VER_FULL(gt->i915) >= IP_VER(12, 50))
>>>>> - return intel_gt_mcr_wait_for_reg(gt, rb.mcr_reg, rb.bit, 0,
>>>>> + if (engine->tlb_inv.mcr)
>>>>> + return intel_gt_mcr_wait_for_reg(engine->gt,
>>>>> + engine->tlb_inv.reg.mcr_reg,
>>>>> + engine->tlb_inv.done,
>>>>> + 0,
>>>>> TLB_INVAL_TIMEOUT_US,
>>>>> TLB_INVAL_TIMEOUT_MS);
>>>>> else
>>>>> - return __intel_wait_for_register_fw(gt->uncore, rb.reg, rb.bit, 0,
>>>>> + return __intel_wait_for_register_fw(engine->gt->uncore,
>>>>> + engine->tlb_inv.reg.reg,
>>>>> + engine->tlb_inv.done,
>>>>> + 0,
>>>>> TLB_INVAL_TIMEOUT_US,
>>>>> TLB_INVAL_TIMEOUT_MS,
>>>>> NULL);
>>>>> @@ -1041,61 +1017,14 @@ static int wait_for_invalidate(struct intel_gt *gt, struct reg_and_bit rb)
>>>>> static void mmio_invalidate_full(struct intel_gt *gt)
>>>>> {
>>>>> - static const i915_reg_t gen8_regs[] = {
>>>>> - [RENDER_CLASS] = GEN8_RTCR,
>>>>> - [VIDEO_DECODE_CLASS] = GEN8_M1TCR, /* , GEN8_M2TCR */
>>>>> - [VIDEO_ENHANCEMENT_CLASS] = GEN8_VTCR,
>>>>> - [COPY_ENGINE_CLASS] = GEN8_BTCR,
>>>>> - };
>>>>> - static const i915_reg_t gen12_regs[] = {
>>>>> - [RENDER_CLASS] = GEN12_GFX_TLB_INV_CR,
>>>>> - [VIDEO_DECODE_CLASS] = GEN12_VD_TLB_INV_CR,
>>>>> - [VIDEO_ENHANCEMENT_CLASS] = GEN12_VE_TLB_INV_CR,
>>>>> - [COPY_ENGINE_CLASS] = GEN12_BLT_TLB_INV_CR,
>>>>> - [COMPUTE_CLASS] = GEN12_COMPCTX_TLB_INV_CR,
>>>>> - };
>>>>> - static const i915_mcr_reg_t xehp_regs[] = {
>>>>> - [RENDER_CLASS] = XEHP_GFX_TLB_INV_CR,
>>>>> - [VIDEO_DECODE_CLASS] = XEHP_VD_TLB_INV_CR,
>>>>> - [VIDEO_ENHANCEMENT_CLASS] = XEHP_VE_TLB_INV_CR,
>>>>> - [COPY_ENGINE_CLASS] = XEHP_BLT_TLB_INV_CR,
>>>>> - [COMPUTE_CLASS] = XEHP_COMPCTX_TLB_INV_CR,
>>>>> - };
>>>>> struct drm_i915_private *i915 = gt->i915;
>>>>> struct intel_uncore *uncore = gt->uncore;
>>>>> struct intel_engine_cs *engine;
>>>>> intel_engine_mask_t awake, tmp;
>>>>> enum intel_engine_id id;
>>>>> - const i915_reg_t *regs;
>>>>> - unsigned int num = 0;
>>>>> unsigned long flags;
>>>>> - /*
>>>>> - * New platforms should not be added with catch-all-newer (>=)
>>>>> - * condition so that any later platform added triggers the below warning
>>>>> - * and in turn mandates a human cross-check of whether the invalidation
>>>>> - * flows have compatible semantics.
>>>>> - *
>>>>> - * For instance with the 11.00 -> 12.00 transition three out of five
>>>>> - * respective engine registers were moved to masked type. Then after the
>>>>> - * 12.00 -> 12.50 transition multi cast handling is required too.
>>>>> - */
>>>>> -
>>>>> - if (GRAPHICS_VER_FULL(i915) == IP_VER(12, 50)) {
>>>>> - regs = NULL;
>>>>> - num = ARRAY_SIZE(xehp_regs);
>>>>> - } else if (GRAPHICS_VER(i915) == 12) {
>>>>> - regs = gen12_regs;
>>>>> - num = ARRAY_SIZE(gen12_regs);
>>>>> - } else if (GRAPHICS_VER(i915) >= 8 && GRAPHICS_VER(i915) <= 11) {
>>>>> - regs = gen8_regs;
>>>>> - num = ARRAY_SIZE(gen8_regs);
>>>>> - } else if (GRAPHICS_VER(i915) < 8) {
>>>>> - return;
>>>>> - }
>>>>> -
>>>>> - if (drm_WARN_ONCE(&i915->drm, !num,
>>>>> - "Platform does not implement TLB invalidation!"))
>>>>> + if (GRAPHICS_VER(i915) < 8)
>>>>> return;
>>>>> intel_uncore_forcewake_get(uncore, FORCEWAKE_ALL);
>>>>> @@ -1105,33 +1034,18 @@ static void mmio_invalidate_full(struct intel_gt *gt)
>>>>> awake = 0;
>>>>> for_each_engine(engine, gt, id) {
>>>>> - struct reg_and_bit rb;
>>>>> -
>>>>> if (!intel_engine_pm_is_awake(engine))
>>>>> continue;
>>>>> - if (GRAPHICS_VER_FULL(i915) >= IP_VER(12, 50)) {
>>>>> - u32 val = BIT(engine->instance);
>>>>> -
>>>>> - if (engine->class == VIDEO_DECODE_CLASS ||
>>>>> - engine->class == VIDEO_ENHANCEMENT_CLASS ||
>>>>> - engine->class == COMPUTE_CLASS)
>>>>> - val = _MASKED_BIT_ENABLE(val);
>>>>> + if (engine->tlb_inv.mcr)
>>>>> intel_gt_mcr_multicast_write_fw(gt,
>>>>> - xehp_regs[engine->class],
>>>>> - val);
>>>>> - } else {
>>>>> - rb = get_reg_and_bit(engine, regs == gen8_regs, regs, num);
>>>>> - if (!i915_mmio_reg_offset(rb.reg))
>>>>> - continue;
>>>>> -
>>>>> - if (GRAPHICS_VER(i915) == 12 && (engine->class == VIDEO_DECODE_CLASS ||
>>>>> - engine->class == VIDEO_ENHANCEMENT_CLASS ||
>>>>> - engine->class == COMPUTE_CLASS))
>>>>> - rb.bit = _MASKED_BIT_ENABLE(rb.bit);
>>>>> -
>>>>> - intel_uncore_write_fw(uncore, rb.reg, rb.bit);
>>>>> - }
>>>>> + engine->tlb_inv.reg.mcr_reg,
>>>>> + engine->tlb_inv.request);
>>>>> + else
>>>>> + intel_uncore_write_fw(uncore,
>>>>> + engine->tlb_inv.reg.reg,
>>>>> + engine->tlb_inv.request);
>>>>> +
>>>>> awake |= engine->mask;
>>>>> }
>>>>> @@ -1150,16 +1064,7 @@ static void mmio_invalidate_full(struct intel_gt *gt)
>>>>> intel_gt_mcr_unlock(gt, flags);
>>>>> for_each_engine_masked(engine, gt, awake, tmp) {
>>>>> - struct reg_and_bit rb;
>>>>> -
>>>>> - if (GRAPHICS_VER_FULL(i915) >= IP_VER(12, 50)) {
>>>>> - rb.mcr_reg = xehp_regs[engine->class];
>>>>> - rb.bit = BIT(engine->instance);
>>>>> - } else {
>>>>> - rb = get_reg_and_bit(engine, regs == gen8_regs, regs, num);
>>>>> - }
>>>>> -
>>>>> - if (wait_for_invalidate(gt, rb))
>>>>> + if (wait_for_invalidate(engine))
>>>>> drm_err_ratelimited(>->i915->drm,
>>>>> "%s TLB invalidation did not complete in %ums!\n",
>>>>> engine->name, TLB_INVAL_TIMEOUT_MS);
>>>>
>>>
>
^ permalink raw reply [flat|nested] 19+ messages in thread* Re: [Intel-gfx] [PATCH 2/2] drm/i915: Consolidate TLB invalidation flow
2023-01-05 13:06 ` Tvrtko Ursulin
@ 2023-01-06 0:19 ` Matt Roper
0 siblings, 0 replies; 19+ messages in thread
From: Matt Roper @ 2023-01-06 0:19 UTC (permalink / raw)
To: Tvrtko Ursulin; +Cc: Intel-gfx, dri-devel, Andrzej Hajda
On Thu, Jan 05, 2023 at 01:06:37PM +0000, Tvrtko Ursulin wrote:
>
> On 04/01/2023 17:41, Matt Roper wrote:
> > On Wed, Jan 04, 2023 at 10:08:29AM +0000, Tvrtko Ursulin wrote:
> > >
> > > On 03/01/2023 19:57, Matt Roper wrote:
> > > > On Mon, Dec 19, 2022 at 05:10:02PM +0100, Andrzej Hajda wrote:
> > > > > On 19.12.2022 11:13, Tvrtko Ursulin wrote:
> > > > > > From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> > > > > >
> > > > > > As the logic for selecting the register and corresponsing values grew, the
> > > > >
> > > > > corresponding
> > > > >
> > > > > > code become a bit unsightly. Consolidate by storing the required values at
> > > > > > engine init time in the engine itself, and by doing so minimise the amount
> > > > > > of invariant platform and engine checks during each and every TLB
> > > > > > invalidation.
> > > > > >
> > > > > > v2:
> > > > > > * Fail engine probe if TLB invlidations registers are unknown.
> > > > > >
> > > > > > Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> > > > > > Cc: Andrzej Hajda <andrzej.hajda@intel.com>
> > > > > > Cc: Matt Roper <matthew.d.roper@intel.com>
> > > > > > Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com> # v1
> > > > > > ---
> > > > > > drivers/gpu/drm/i915/gt/intel_engine_cs.c | 93 +++++++++++++
> > > > > > drivers/gpu/drm/i915/gt/intel_engine_types.h | 15 +++
> > > > > > drivers/gpu/drm/i915/gt/intel_gt.c | 135 +++----------------
> > > > > > 3 files changed, 128 insertions(+), 115 deletions(-)
> > > > > >
> > > > > > diff --git a/drivers/gpu/drm/i915/gt/intel_engine_cs.c b/drivers/gpu/drm/i915/gt/intel_engine_cs.c
> > > > > > index 99c4b866addd..d47dadfc25c8 100644
> > > > > > --- a/drivers/gpu/drm/i915/gt/intel_engine_cs.c
> > > > > > +++ b/drivers/gpu/drm/i915/gt/intel_engine_cs.c
> > > > > > @@ -1143,12 +1143,105 @@ static int init_status_page(struct intel_engine_cs *engine)
> > > > > > return ret;
> > > > > > }
> > > > > > +static int intel_engine_init_tlb_invalidation(struct intel_engine_cs *engine)
> > > > > > +{
> > > > > > + static const union intel_engine_tlb_inv_reg gen8_regs[] = {
> > > > > > + [RENDER_CLASS].reg = GEN8_RTCR,
> > > > > > + [VIDEO_DECODE_CLASS].reg = GEN8_M1TCR, /* , GEN8_M2TCR */
> > > > > > + [VIDEO_ENHANCEMENT_CLASS].reg = GEN8_VTCR,
> > > > > > + [COPY_ENGINE_CLASS].reg = GEN8_BTCR,
> > > > > > + };
> > > > > > + static const union intel_engine_tlb_inv_reg gen12_regs[] = {
> > > > > > + [RENDER_CLASS].reg = GEN12_GFX_TLB_INV_CR,
> > > > > > + [VIDEO_DECODE_CLASS].reg = GEN12_VD_TLB_INV_CR,
> > > > > > + [VIDEO_ENHANCEMENT_CLASS].reg = GEN12_VE_TLB_INV_CR,
> > > > > > + [COPY_ENGINE_CLASS].reg = GEN12_BLT_TLB_INV_CR,
> > > > > > + [COMPUTE_CLASS].reg = GEN12_COMPCTX_TLB_INV_CR,
> > > > > > + };
> > > > > > + static const union intel_engine_tlb_inv_reg xehp_regs[] = {
> > > > > > + [RENDER_CLASS].mcr_reg = XEHP_GFX_TLB_INV_CR,
> > > > > > + [VIDEO_DECODE_CLASS].mcr_reg = XEHP_VD_TLB_INV_CR,
> > > > > > + [VIDEO_ENHANCEMENT_CLASS].mcr_reg = XEHP_VE_TLB_INV_CR,
> > > > > > + [COPY_ENGINE_CLASS].mcr_reg = XEHP_BLT_TLB_INV_CR,
> > > > > > + [COMPUTE_CLASS].mcr_reg = XEHP_COMPCTX_TLB_INV_CR,
> > > > > > + };
> > > > > > + struct drm_i915_private *i915 = engine->i915;
> > > > > > + const union intel_engine_tlb_inv_reg *regs;
> > > > > > + union intel_engine_tlb_inv_reg reg;
> > > > > > + unsigned int class = engine->class;
> > > > > > + unsigned int num = 0;
> > > > > > + u32 val;
> > > > > > +
> > > > > > + /*
> > > > > > + * New platforms should not be added with catch-all-newer (>=)
> > > > > > + * condition so that any later platform added triggers the below warning
> > > > > > + * and in turn mandates a human cross-check of whether the invalidation
> > > > > > + * flows have compatible semantics.
> > > > > > + *
> > > > > > + * For instance with the 11.00 -> 12.00 transition three out of five
> > > > > > + * respective engine registers were moved to masked type. Then after the
> > > > > > + * 12.00 -> 12.50 transition multi cast handling is required too.
> > > > > > + */
> > > > > > +
> > > > > > + if (GRAPHICS_VER_FULL(i915) == IP_VER(12, 50)) {
> > > >
> > > > This is bad...it only captures XEHPSDV and breaks the handling of DG2
> > > > (12.55), PVC (12.60), and MTL (12.70, 12.71, and 12.72). You're not
> > > > hitting the warning as expected since those are all now being captured
> > > > by the next case of the if/else ladder. With the way GMD_ID works, we
> > > > may also get new version numbers that silently show up in hardware too
> > > > at some point (e.g., 12.73, 12.74, etc.)
> > >
> > > Great (on multiple counts) ...
> > >
> > > >
> > > > > > + regs = xehp_regs;
> > > > > > + num = ARRAY_SIZE(xehp_regs);
> > > > > > + } else if (GRAPHICS_VER(i915) == 12) {
> > > >
> > > > You'd want to change this to
> > > >
> > > > GRAPHICS_VER_FULL(i915) == IP_VER(12, 0)
> > > >
> > > > to get the behavior you expected.
> > >
> > > Okay, that, and then to be as safe as I intended, ie. warn on every new
> > > platforms so developers *must* check registers are still compatible during
> > > platform enablement, we would need a full ver range check something like:
> > >
> > > if (GRAPHICS_VER_FULL(i915) >= IP_VER(12, 50) &&
> > > GRAPHICS_VER_FULL(i915) <= IP_VER(12, 55)) {
> > > regs = xehp_regs;
> > > num = ARRAY_SIZE(xehp_regs);
> > > } else if (GRAPHICS_VER_FULL(i915) == IP_VER(12, 0)) {
> > > regs = gen12_regs;
> > > num = ARRAY_SIZE(gen12_regs);
> > >
> > > What do you think about that?
> >
> > What about just keeping the code the way it is now, but adding a new
> > error condition at the *top* of the ladder?
> >
> > if (GRAPHICS_VER_FULL(i915) > IP_VER(12, 72)) {
> > /* Error, something new we haven't considered */
> > } else if (GRAPHICS_VER_FULL(i915) >= IP_VER(12, 50)) {
> > ...
> >
> > I guess that won't catch cases where they go back and insert a new
> > version or IP refresh that's older than the latest version number, but
> > usually refresh platforms aren't going to be adding the kind of
> > architectural changes that require a new if/else arm anyway.
> >
> > Also, as Andrzej pointed out on a different reply, we classified DG1 as
> > 12.10 (because of the interrupt handling changes), so I guess we'd need
> > a further adjustment to the "gen12" branch to cover that one too.
> >
> > Honestly, I'm not super wild about the general plan of intentionally
> > breaking inheritance here; that runs counter to how we usually try to do
> > things in i915. In most places we always try to assume that future
> > platforms will behave the same way as the latest one, and then we update
> > those assumptions as part of the initial bringup when a future platform
> > comes along that breaks them. Most of the places where we do specific
> > checks and a MISSING_CASE warning are where we have a strong reason to
> > believe that each platform will always need a new implementation (e.g.,
> > stuff like workaround lists). I don't see a reason to expect major
> > changes in MMIO-based invalidation for a platform n+1, n+2, etc. The
> > change that I _do_ expect to show up (even for some of these current
> > platforms) is that a GuC-based TLB invalidation path will be added since
> > that's mandatory for a lot of modern features, but that will be a
> > parallel codepath, not part of the if/else ladder we're editing here.
>
> The strong reason you mention is currently the lack of _any_ test coverage
> for this. In other words you'd never know a new platform does not work
> properly (imaging one more register becomes masked, like three have become
> from Gen11 to Gen12). Or if refactoring this area of the code broke an
> existing platform. And both cases lead to CVEs so IMO safety trumps our
> usual patterns.
>
> As I said earlier, I am not going to merge anything in this area, apart that
> I want "drm/i915: Do not cover all future platforms in TLB invalidation" in,
> until test coverage materialises.
>
> Once we have test coverage I am okay with catch all future platforms.
>
> So regarding "drm/i915: Do not cover all future platforms in TLB
> invalidation".. minimal change is then to have it like:
>
> if (GRAPHICS_VER_FULL(i915) >= IP_VER(12, 50) &&) {
> GRAPHICS_VER_FULL(i915) <= IP_VER(12, 55)
> ...
> } else if (GRAPHICS_VER(i915) == 12) {
> ...
> ...
>
> Is this agreeable? That covers XEHPSDV and DG2. PVC and MTL, if they are
> intended to be supported, someone (not exclusing myself here) needs to check
> bspec before extending the condition with an explicit patch.
Yeah, that's probably fine (although it does put a hard stop to any hope
of getting preliminary/partial CI coverage of some platforms that are
still in the process of being enabled).
PVC needs the GuC-based invalidation handling (which hasn't been posted
yet); I don't think it even has MMIO invalidation registers like these
so it will never enter this function once the platform is fully enabled.
For MTL I already noted during review of Daniele's GSC series that we'd
need some kind of an update here to include the invalidation register
for the GSC engine (which is of class 'other'), but the change for that
is still coming as well. So in general I think we do already know when
updates like this are needed for a platform and we should be able to
make sure we have those updates in place before force_probe is removed,
but your concern about being extra paranoid on areas of the code that
can lead to CVEs makes sense as well, so your proposal sounds okay to
me.
>
> Otherwise 77fa9efc16a9 ("drm/i915/xehp: Create separate reg definitions for
> new MCR registers") was about Xe_HP, already wrong and Andrzej fixed it in
> 4d5cf7b1680a ("drm/i915: fix TLB invalidation for Gen12.50 video and compute
> engines").
I think the problem there was more an artifact of the original fix
04aa64375f48a ("drm/i915: fix TLB invalidation for Gen12 video and
compute engines") silently landing through a non-gfx tree. That fix was
good on a mainline kernel release at that point in time, but was no
longer a complete solution once the pending DRM tree pull request
landed. A follow-up after the merge was necessary to bring the second
half of the fix.
Matt
>
> Further work can happen once test coverage appears.
>
> Regards,
>
> Tvrtko
>
> > >
> > > Or you are saying new GMD IDs may appear in the field without first having
> > > passed the new platform enablemend process? That would be horrible so I hope
> > > not.
> >
> > They won't just show up in the wild, we'll know they're coming. But
> > they'll be used for stuff like how DG2-G12 showed up after we'd already
> > enabled DG2-G10 and DG2-G11. Or how we picked up a couple more ADL
> > variants that our driver treats as "ADL-P," even though there are
> > technically other SKU letters associated with them. So they're things
> > that we wouldn't consider to be a whole new platform, just a new
> > subplatform at best.
> >
> >
> > Matt
> >
> > >
> > > Regards,
> > >
> > > Tvrtko
> > >
> > > > > > + regs = gen12_regs;
> > > > > > + num = ARRAY_SIZE(gen12_regs);
> > > > > > + } else if (GRAPHICS_VER(i915) >= 8 && GRAPHICS_VER(i915) <= 11) {
> > > > > > + regs = gen8_regs;
> > > > > > + num = ARRAY_SIZE(gen8_regs);
> > > > > > + } else if (GRAPHICS_VER(i915) < 8) {
> > > > > > + return 0;
> > > > > > + } > +
> > > > > > + if (drm_WARN_ONCE(&i915->drm, !num,
> > > > > > + "Platform does not implement TLB invalidation!"))
> > > > > > + return -ENODEV;
> > > > > > +
> > > > > > + if (drm_WARN_ON_ONCE(&i915->drm,
> > > > > > + class >= num ||
> > > > > > + (!regs[class].reg.reg &&
> > > > > > + !regs[class].mcr_reg.reg)))
> > > > > > + return -ERANGE;
> > > > >
> > > > > I hope the propagation of -ERANGE to device probe is OK.
> > > > >
> > > > > Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com>
> > > > >
> > > > > Regards
> > > > > Andrzej
> > > > >
> > > > > > +
> > > > > > + reg = regs[class];
> > > > > > +
> > > > > > + if (GRAPHICS_VER(i915) == 8 && class == VIDEO_DECODE_CLASS) {
> > > > > > + reg.reg.reg += 4 * engine->instance; /* GEN8_M2TCR */
> > > > > > + val = 0;
> > > > > > + } else {
> > > > > > + val = engine->instance;
> > > > > > + }
> > > > > > +
> > > > > > + val = BIT(val);
> > > > > > +
> > > > > > + engine->tlb_inv.mcr = regs == xehp_regs;
> > > > > > + engine->tlb_inv.reg = reg;
> > > > > > + engine->tlb_inv.done = val;
> > > > > > +
> > > > > > + if (GRAPHICS_VER(i915) >= 12 &&
> > > > > > + (engine->class == VIDEO_DECODE_CLASS ||
> > > > > > + engine->class == VIDEO_ENHANCEMENT_CLASS ||
> > > > > > + engine->class == COMPUTE_CLASS))
> > > > > > + engine->tlb_inv.request = _MASKED_BIT_ENABLE(val);
> > > > > > + else
> > > > > > + engine->tlb_inv.request = val;
> > > > > > +
> > > > > > + return 0;
> > > > > > +}
> > > > > > +
> > > > > > static int engine_setup_common(struct intel_engine_cs *engine)
> > > > > > {
> > > > > > int err;
> > > > > > init_llist_head(&engine->barrier_tasks);
> > > > > > + err = intel_engine_init_tlb_invalidation(engine);
> > > > > > + if (err)
> > > > > > + return err;
> > > > > > +
> > > > > > err = init_status_page(engine);
> > > > > > if (err)
> > > > > > return err;
> > > > > > diff --git a/drivers/gpu/drm/i915/gt/intel_engine_types.h b/drivers/gpu/drm/i915/gt/intel_engine_types.h
> > > > > > index 4fd54fb8810f..8c661fe89314 100644
> > > > > > --- a/drivers/gpu/drm/i915/gt/intel_engine_types.h
> > > > > > +++ b/drivers/gpu/drm/i915/gt/intel_engine_types.h
> > > > > > @@ -341,6 +341,19 @@ struct intel_engine_guc_stats {
> > > > > > u64 start_gt_clk;
> > > > > > };
> > > > > > +union intel_engine_tlb_inv_reg {
> > > > > > + i915_reg_t reg;
> > > > > > + i915_mcr_reg_t mcr_reg;
> > > > > > +};
> > > > > > +
> > > > > > +struct intel_engine_tlb_inv
> > > > > > +{
> > > > > > + bool mcr;
> > > > > > + union intel_engine_tlb_inv_reg reg;
> > > > > > + u32 request;
> > > > > > + u32 done;
> > > > > > +};
> > > > > > +
> > > > > > struct intel_engine_cs {
> > > > > > struct drm_i915_private *i915;
> > > > > > struct intel_gt *gt;
> > > > > > @@ -372,6 +385,8 @@ struct intel_engine_cs {
> > > > > > u32 context_size;
> > > > > > u32 mmio_base;
> > > > > > + struct intel_engine_tlb_inv tlb_inv;
> > > > > > +
> > > > > > /*
> > > > > > * Some w/a require forcewake to be held (which prevents RC6) while
> > > > > > * a particular engine is active. If so, we set fw_domain to which
> > > > > > diff --git a/drivers/gpu/drm/i915/gt/intel_gt.c b/drivers/gpu/drm/i915/gt/intel_gt.c
> > > > > > index 854841a731cb..9fb0ac03f51a 100644
> > > > > > --- a/drivers/gpu/drm/i915/gt/intel_gt.c
> > > > > > +++ b/drivers/gpu/drm/i915/gt/intel_gt.c
> > > > > > @@ -983,36 +983,6 @@ void intel_gt_info_print(const struct intel_gt_info *info,
> > > > > > intel_sseu_dump(&info->sseu, p);
> > > > > > }
> > > > > > -struct reg_and_bit {
> > > > > > - union {
> > > > > > - i915_reg_t reg;
> > > > > > - i915_mcr_reg_t mcr_reg;
> > > > > > - };
> > > > > > - u32 bit;
> > > > > > -};
> > > > > > -
> > > > > > -static struct reg_and_bit
> > > > > > -get_reg_and_bit(const struct intel_engine_cs *engine, const bool gen8,
> > > > > > - const i915_reg_t *regs, const unsigned int num)
> > > > > > -{
> > > > > > - const unsigned int class = engine->class;
> > > > > > - struct reg_and_bit rb = { };
> > > > > > -
> > > > > > - if (drm_WARN_ON_ONCE(&engine->i915->drm,
> > > > > > - class >= num || !regs[class].reg))
> > > > > > - return rb;
> > > > > > -
> > > > > > - rb.reg = regs[class];
> > > > > > - if (gen8 && class == VIDEO_DECODE_CLASS)
> > > > > > - rb.reg.reg += 4 * engine->instance; /* GEN8_M2TCR */
> > > > > > - else
> > > > > > - rb.bit = engine->instance;
> > > > > > -
> > > > > > - rb.bit = BIT(rb.bit);
> > > > > > -
> > > > > > - return rb;
> > > > > > -}
> > > > > > -
> > > > > > /*
> > > > > > * HW architecture suggest typical invalidation time at 40us,
> > > > > > * with pessimistic cases up to 100us and a recommendation to
> > > > > > @@ -1026,14 +996,20 @@ get_reg_and_bit(const struct intel_engine_cs *engine, const bool gen8,
> > > > > > * but are now considered MCR registers. Since they exist within a GAM range,
> > > > > > * the primary instance of the register rolls up the status from each unit.
> > > > > > */
> > > > > > -static int wait_for_invalidate(struct intel_gt *gt, struct reg_and_bit rb)
> > > > > > +static int wait_for_invalidate(struct intel_engine_cs *engine)
> > > > > > {
> > > > > > - if (GRAPHICS_VER_FULL(gt->i915) >= IP_VER(12, 50))
> > > > > > - return intel_gt_mcr_wait_for_reg(gt, rb.mcr_reg, rb.bit, 0,
> > > > > > + if (engine->tlb_inv.mcr)
> > > > > > + return intel_gt_mcr_wait_for_reg(engine->gt,
> > > > > > + engine->tlb_inv.reg.mcr_reg,
> > > > > > + engine->tlb_inv.done,
> > > > > > + 0,
> > > > > > TLB_INVAL_TIMEOUT_US,
> > > > > > TLB_INVAL_TIMEOUT_MS);
> > > > > > else
> > > > > > - return __intel_wait_for_register_fw(gt->uncore, rb.reg, rb.bit, 0,
> > > > > > + return __intel_wait_for_register_fw(engine->gt->uncore,
> > > > > > + engine->tlb_inv.reg.reg,
> > > > > > + engine->tlb_inv.done,
> > > > > > + 0,
> > > > > > TLB_INVAL_TIMEOUT_US,
> > > > > > TLB_INVAL_TIMEOUT_MS,
> > > > > > NULL);
> > > > > > @@ -1041,61 +1017,14 @@ static int wait_for_invalidate(struct intel_gt *gt, struct reg_and_bit rb)
> > > > > > static void mmio_invalidate_full(struct intel_gt *gt)
> > > > > > {
> > > > > > - static const i915_reg_t gen8_regs[] = {
> > > > > > - [RENDER_CLASS] = GEN8_RTCR,
> > > > > > - [VIDEO_DECODE_CLASS] = GEN8_M1TCR, /* , GEN8_M2TCR */
> > > > > > - [VIDEO_ENHANCEMENT_CLASS] = GEN8_VTCR,
> > > > > > - [COPY_ENGINE_CLASS] = GEN8_BTCR,
> > > > > > - };
> > > > > > - static const i915_reg_t gen12_regs[] = {
> > > > > > - [RENDER_CLASS] = GEN12_GFX_TLB_INV_CR,
> > > > > > - [VIDEO_DECODE_CLASS] = GEN12_VD_TLB_INV_CR,
> > > > > > - [VIDEO_ENHANCEMENT_CLASS] = GEN12_VE_TLB_INV_CR,
> > > > > > - [COPY_ENGINE_CLASS] = GEN12_BLT_TLB_INV_CR,
> > > > > > - [COMPUTE_CLASS] = GEN12_COMPCTX_TLB_INV_CR,
> > > > > > - };
> > > > > > - static const i915_mcr_reg_t xehp_regs[] = {
> > > > > > - [RENDER_CLASS] = XEHP_GFX_TLB_INV_CR,
> > > > > > - [VIDEO_DECODE_CLASS] = XEHP_VD_TLB_INV_CR,
> > > > > > - [VIDEO_ENHANCEMENT_CLASS] = XEHP_VE_TLB_INV_CR,
> > > > > > - [COPY_ENGINE_CLASS] = XEHP_BLT_TLB_INV_CR,
> > > > > > - [COMPUTE_CLASS] = XEHP_COMPCTX_TLB_INV_CR,
> > > > > > - };
> > > > > > struct drm_i915_private *i915 = gt->i915;
> > > > > > struct intel_uncore *uncore = gt->uncore;
> > > > > > struct intel_engine_cs *engine;
> > > > > > intel_engine_mask_t awake, tmp;
> > > > > > enum intel_engine_id id;
> > > > > > - const i915_reg_t *regs;
> > > > > > - unsigned int num = 0;
> > > > > > unsigned long flags;
> > > > > > - /*
> > > > > > - * New platforms should not be added with catch-all-newer (>=)
> > > > > > - * condition so that any later platform added triggers the below warning
> > > > > > - * and in turn mandates a human cross-check of whether the invalidation
> > > > > > - * flows have compatible semantics.
> > > > > > - *
> > > > > > - * For instance with the 11.00 -> 12.00 transition three out of five
> > > > > > - * respective engine registers were moved to masked type. Then after the
> > > > > > - * 12.00 -> 12.50 transition multi cast handling is required too.
> > > > > > - */
> > > > > > -
> > > > > > - if (GRAPHICS_VER_FULL(i915) == IP_VER(12, 50)) {
> > > > > > - regs = NULL;
> > > > > > - num = ARRAY_SIZE(xehp_regs);
> > > > > > - } else if (GRAPHICS_VER(i915) == 12) {
> > > > > > - regs = gen12_regs;
> > > > > > - num = ARRAY_SIZE(gen12_regs);
> > > > > > - } else if (GRAPHICS_VER(i915) >= 8 && GRAPHICS_VER(i915) <= 11) {
> > > > > > - regs = gen8_regs;
> > > > > > - num = ARRAY_SIZE(gen8_regs);
> > > > > > - } else if (GRAPHICS_VER(i915) < 8) {
> > > > > > - return;
> > > > > > - }
> > > > > > -
> > > > > > - if (drm_WARN_ONCE(&i915->drm, !num,
> > > > > > - "Platform does not implement TLB invalidation!"))
> > > > > > + if (GRAPHICS_VER(i915) < 8)
> > > > > > return;
> > > > > > intel_uncore_forcewake_get(uncore, FORCEWAKE_ALL);
> > > > > > @@ -1105,33 +1034,18 @@ static void mmio_invalidate_full(struct intel_gt *gt)
> > > > > > awake = 0;
> > > > > > for_each_engine(engine, gt, id) {
> > > > > > - struct reg_and_bit rb;
> > > > > > -
> > > > > > if (!intel_engine_pm_is_awake(engine))
> > > > > > continue;
> > > > > > - if (GRAPHICS_VER_FULL(i915) >= IP_VER(12, 50)) {
> > > > > > - u32 val = BIT(engine->instance);
> > > > > > -
> > > > > > - if (engine->class == VIDEO_DECODE_CLASS ||
> > > > > > - engine->class == VIDEO_ENHANCEMENT_CLASS ||
> > > > > > - engine->class == COMPUTE_CLASS)
> > > > > > - val = _MASKED_BIT_ENABLE(val);
> > > > > > + if (engine->tlb_inv.mcr)
> > > > > > intel_gt_mcr_multicast_write_fw(gt,
> > > > > > - xehp_regs[engine->class],
> > > > > > - val);
> > > > > > - } else {
> > > > > > - rb = get_reg_and_bit(engine, regs == gen8_regs, regs, num);
> > > > > > - if (!i915_mmio_reg_offset(rb.reg))
> > > > > > - continue;
> > > > > > -
> > > > > > - if (GRAPHICS_VER(i915) == 12 && (engine->class == VIDEO_DECODE_CLASS ||
> > > > > > - engine->class == VIDEO_ENHANCEMENT_CLASS ||
> > > > > > - engine->class == COMPUTE_CLASS))
> > > > > > - rb.bit = _MASKED_BIT_ENABLE(rb.bit);
> > > > > > -
> > > > > > - intel_uncore_write_fw(uncore, rb.reg, rb.bit);
> > > > > > - }
> > > > > > + engine->tlb_inv.reg.mcr_reg,
> > > > > > + engine->tlb_inv.request);
> > > > > > + else
> > > > > > + intel_uncore_write_fw(uncore,
> > > > > > + engine->tlb_inv.reg.reg,
> > > > > > + engine->tlb_inv.request);
> > > > > > +
> > > > > > awake |= engine->mask;
> > > > > > }
> > > > > > @@ -1150,16 +1064,7 @@ static void mmio_invalidate_full(struct intel_gt *gt)
> > > > > > intel_gt_mcr_unlock(gt, flags);
> > > > > > for_each_engine_masked(engine, gt, awake, tmp) {
> > > > > > - struct reg_and_bit rb;
> > > > > > -
> > > > > > - if (GRAPHICS_VER_FULL(i915) >= IP_VER(12, 50)) {
> > > > > > - rb.mcr_reg = xehp_regs[engine->class];
> > > > > > - rb.bit = BIT(engine->instance);
> > > > > > - } else {
> > > > > > - rb = get_reg_and_bit(engine, regs == gen8_regs, regs, num);
> > > > > > - }
> > > > > > -
> > > > > > - if (wait_for_invalidate(gt, rb))
> > > > > > + if (wait_for_invalidate(engine))
> > > > > > drm_err_ratelimited(>->i915->drm,
> > > > > > "%s TLB invalidation did not complete in %ums!\n",
> > > > > > engine->name, TLB_INVAL_TIMEOUT_MS);
> > > > >
> > > >
> >
--
Matt Roper
Graphics Software Engineer
Linux GPU Platform Enablement
Intel Corporation
^ permalink raw reply [flat|nested] 19+ messages in thread