* [PATCH v1 1/1] makefile: add multi_dtb_fit dep
@ 2022-12-21 7:54 Neal Frager
2022-12-21 23:37 ` Simon Glass
2023-01-11 14:16 ` Michal Simek
0 siblings, 2 replies; 4+ messages in thread
From: Neal Frager @ 2022-12-21 7:54 UTC (permalink / raw)
To: u-boot; +Cc: michal.simek, luca.ceresoli, Neal Frager
With certain gcc compilers, the u-boot.itb is built immediately after dtb
generation. If CONFIG_MULTI_DTB_FIT is used, it is possible that the
fit-dtb.blob is not finished in time.
This patch adds a necessary dependency to guarantee that the fit-dtb.blob
is built before attempting to build the u-boot.itb.
Signed-off-by: Neal Frager <neal.frager@amd.com>
---
Makefile | 1 +
1 file changed, 1 insertion(+)
diff --git a/Makefile b/Makefile
index b96e2ffa15..682a5d94fd 100644
--- a/Makefile
+++ b/Makefile
@@ -1425,6 +1425,7 @@ MKIMAGEFLAGS_u-boot.itb += -B 0x8
ifdef U_BOOT_ITS
u-boot.itb: u-boot-nodtb.bin \
$(if $(CONFIG_OF_SEPARATE)$(CONFIG_OF_EMBED)$(CONFIG_SANDBOX),dts/dt.dtb) \
+ $(if $(CONFIG_MULTI_DTB_FIT),$(FINAL_DTB_CONTAINER)) \
$(U_BOOT_ITS) FORCE
$(call if_changed,mkfitimage)
$(BOARD_SIZE_CHECK)
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v1 1/1] makefile: add multi_dtb_fit dep
2022-12-21 7:54 [PATCH v1 1/1] makefile: add multi_dtb_fit dep Neal Frager
@ 2022-12-21 23:37 ` Simon Glass
2022-12-22 6:16 ` Frager, Neal
2023-01-11 14:16 ` Michal Simek
1 sibling, 1 reply; 4+ messages in thread
From: Simon Glass @ 2022-12-21 23:37 UTC (permalink / raw)
To: Neal Frager; +Cc: u-boot, michal.simek, luca.ceresoli
Hi Neil,
On Wed, 21 Dec 2022 at 07:07, Neal Frager <neal.frager@amd.com> wrote:
>
> With certain gcc compilers, the u-boot.itb is built immediately after dtb
> generation. If CONFIG_MULTI_DTB_FIT is used, it is possible that the
> fit-dtb.blob is not finished in time.
>
> This patch adds a necessary dependency to guarantee that the fit-dtb.blob
> is built before attempting to build the u-boot.itb.
>
> Signed-off-by: Neal Frager <neal.frager@amd.com>
> ---
> Makefile | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Makefile b/Makefile
> index b96e2ffa15..682a5d94fd 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1425,6 +1425,7 @@ MKIMAGEFLAGS_u-boot.itb += -B 0x8
> ifdef U_BOOT_ITS
> u-boot.itb: u-boot-nodtb.bin \
> $(if $(CONFIG_OF_SEPARATE)$(CONFIG_OF_EMBED)$(CONFIG_SANDBOX),dts/dt.dtb) \
> + $(if $(CONFIG_MULTI_DTB_FIT),$(FINAL_DTB_CONTAINER)) \
> $(U_BOOT_ITS) FORCE
> $(call if_changed,mkfitimage)
> $(BOARD_SIZE_CHECK)
> --
> 2.17.1
>
Reviewed-by: Simon Glass <sjg@chromium.org>
I wonder if we should try to get this moved to binman?
Regards,
SImon
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH v1 1/1] makefile: add multi_dtb_fit dep
2022-12-21 23:37 ` Simon Glass
@ 2022-12-22 6:16 ` Frager, Neal
0 siblings, 0 replies; 4+ messages in thread
From: Frager, Neal @ 2022-12-22 6:16 UTC (permalink / raw)
To: Simon Glass; +Cc: u-boot, Simek, Michal, luca.ceresoli
Hi Simon,
>
> With certain gcc compilers, the u-boot.itb is built immediately after
> dtb generation. If CONFIG_MULTI_DTB_FIT is used, it is possible that
> the fit-dtb.blob is not finished in time.
>
> This patch adds a necessary dependency to guarantee that the
> fit-dtb.blob is built before attempting to build the u-boot.itb.
>
> Signed-off-by: Neal Frager <neal.frager@amd.com>
> ---
> Makefile | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Makefile b/Makefile
> index b96e2ffa15..682a5d94fd 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1425,6 +1425,7 @@ MKIMAGEFLAGS_u-boot.itb += -B 0x8 ifdef
> U_BOOT_ITS
> u-boot.itb: u-boot-nodtb.bin \
> $(if
> $(CONFIG_OF_SEPARATE)$(CONFIG_OF_EMBED)$(CONFIG_SANDBOX),dts/dt.dtb) \
> + $(if $(CONFIG_MULTI_DTB_FIT),$(FINAL_DTB_CONTAINER)) \
> $(U_BOOT_ITS) FORCE
> $(call if_changed,mkfitimage)
> $(BOARD_SIZE_CHECK)
> --
> 2.17.1
>
> Reviewed-by: Simon Glass <sjg@chromium.org>
> I wonder if we should try to get this moved to binman?
Thank you for the review! Yes, the next step will be to move to binman.
Best regards,
Neal Frager
AMD
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1 1/1] makefile: add multi_dtb_fit dep
2022-12-21 7:54 [PATCH v1 1/1] makefile: add multi_dtb_fit dep Neal Frager
2022-12-21 23:37 ` Simon Glass
@ 2023-01-11 14:16 ` Michal Simek
1 sibling, 0 replies; 4+ messages in thread
From: Michal Simek @ 2023-01-11 14:16 UTC (permalink / raw)
To: Neal Frager, u-boot; +Cc: luca.ceresoli
On 12/21/22 08:54, Neal Frager wrote:
> With certain gcc compilers, the u-boot.itb is built immediately after dtb
> generation. If CONFIG_MULTI_DTB_FIT is used, it is possible that the
> fit-dtb.blob is not finished in time.
>
> This patch adds a necessary dependency to guarantee that the fit-dtb.blob
> is built before attempting to build the u-boot.itb.
>
> Signed-off-by: Neal Frager <neal.frager@amd.com>
> ---
> Makefile | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Makefile b/Makefile
> index b96e2ffa15..682a5d94fd 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1425,6 +1425,7 @@ MKIMAGEFLAGS_u-boot.itb += -B 0x8
> ifdef U_BOOT_ITS
> u-boot.itb: u-boot-nodtb.bin \
> $(if $(CONFIG_OF_SEPARATE)$(CONFIG_OF_EMBED)$(CONFIG_SANDBOX),dts/dt.dtb) \
> + $(if $(CONFIG_MULTI_DTB_FIT),$(FINAL_DTB_CONTAINER)) \
> $(U_BOOT_ITS) FORCE
> $(call if_changed,mkfitimage)
> $(BOARD_SIZE_CHECK)
Applied.
M
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-01-11 14:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-21 7:54 [PATCH v1 1/1] makefile: add multi_dtb_fit dep Neal Frager
2022-12-21 23:37 ` Simon Glass
2022-12-22 6:16 ` Frager, Neal
2023-01-11 14:16 ` Michal Simek
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.