[Buildroot] [git commit] package/qemu: fix indentation for host-qemu sub-options in menuconfig

[Buildroot] [git commit] package/qemu: fix indentation for host-qemu sub-options in menuconfig

[Yann E. MORIN]

commit: https://git.buildroot.net/buildroot/commit/?id=037226b33b42fb22234694fe1fcb0b6db624161f
branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master

Commit 255acdc14365 (package/qemu: needs gcc >= 8) added a comment that
explains that host-qemu would not be available for gcc < 4.8.

However, it interspersed that comment between the main symbol and the
conditional block with the sub-options. This breaks the indentation of
the sub-options in menuconfig, where they appear at the same level as
the main symbol, rather than indented below it.

Fix that by moving the comment before the main symbol.

Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
---
 package/qemu/Config.in.host | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/package/qemu/Config.in.host b/package/qemu/Config.in.host
index f9cdb9b703..8dd0c7d11b 100644
--- a/package/qemu/Config.in.host
+++ b/package/qemu/Config.in.host
@@ -34,6 +34,11 @@ config BR2_PACKAGE_HOST_QEMU_USER_ARCH_SUPPORTS
 	bool
 	default y if BR2_PACKAGE_HOST_QEMU_ARCH_SUPPORTS
 
+comment "host-qemu needs a host gcc >= 8"
+	depends on BR2_PACKAGE_HOST_QEMU_SYSTEM_ARCH_SUPPORTS || \
+		BR2_PACKAGE_HOST_QEMU_USER_ARCH_SUPPORT
+	depends on !BR2_HOST_GCC_AT_LEAST_8
+
 config BR2_PACKAGE_HOST_QEMU
 	bool "host qemu"
 	depends on BR2_PACKAGE_HOST_QEMU_SYSTEM_ARCH_SUPPORTS || BR2_PACKAGE_HOST_QEMU_USER_ARCH_SUPPORTS
@@ -50,11 +55,6 @@ config BR2_PACKAGE_HOST_QEMU
 
 	  http://www.qemu.org
 
-comment "host-qemu needs a host gcc >= 8"
-	depends on BR2_PACKAGE_HOST_QEMU_SYSTEM_ARCH_SUPPORTS || \
-		BR2_PACKAGE_HOST_QEMU_USER_ARCH_SUPPORT
-	depends on !BR2_HOST_GCC_AT_LEAST_8
-
 if BR2_PACKAGE_HOST_QEMU
 
 comment "Emulators selection"
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [git commit] package/qemu: fix indentation for host-qemu sub-options in menuconfig

[Peter Korsgaard]

>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:

 > commit: https://git.buildroot.net/buildroot/commit/?id=037226b33b42fb22234694fe1fcb0b6db624161f
 > branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master

 > Commit 255acdc14365 (package/qemu: needs gcc >= 8) added a comment that
 > explains that host-qemu would not be available for gcc < 4.8.

 > However, it interspersed that comment between the main symbol and the
 > conditional block with the sub-options. This breaks the indentation of
 > the sub-options in menuconfig, where they appear at the same level as
 > the main symbol, rather than indented below it.

 > Fix that by moving the comment before the main symbol.

 > Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>

Committed to 2022.11.x and 2022.02.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot