From: Diogo Ivo <diogo.ivo@tecnico.ulisboa.pt>
To: Rayyan Ansari <rayyan@ansari.sh>
Cc: devicetree@vger.kernel.org, arnd@arndb.de, airlied@linux.ie,
dri-devel@lists.freedesktop.org, jonathanh@nvidia.com,
robh+dt@kernel.org, thierry.reding@gmail.com,
krzysztof.kozlowski+dt@linaro.org, linux-tegra@vger.kernel.org,
sam@ravnborg.org
Subject: Re: [v2,3/4] drm/panel: Add driver for JDI LPM102A188A
Date: Tue, 27 Dec 2022 11:58:51 +0000 [thread overview]
Message-ID: <20221227115851.mpvlbero4nsdq4r5@wslaptop> (raw)
In-Reply-To: <7aa53ccc-2942-e2d4-9c84-32f1bdf462ad@ansari.sh>
Hello,
On Fri, Dec 23, 2022 at 03:33:40PM +0000, Rayyan Ansari wrote:
> On 25/10/2022 16:37, Diogo Ivo wrote:
> > +config DRM_PANEL_JDI_LPM102A188A
> > + tristate "JDI LPM102A188A DSI panel"
> > + depends on OF && GPIOLIB
> > + depends on DRM_MIPI_DSI
> > + depends on BACKLIGHT_CLASS_DEVICE
> > + help
> > + Say Y here if you want to enable support for JDI LPM102A188A DSI
> > + control mode panel as found in Google Pixel C devices.
> Shouldn't this be "command mode panel" instead of "control mode panel"?
Yes, it should.
> > +static struct mipi_dsi_driver jdi_panel_dsi_driver = {
> > + .driver = {
> > + .name = "panel-jdi-lpm102a188a-dsi",
> Is the "-dsi" suffix needed here? Other panel drivers don't have this.
I had not noticed this, and I will drop it.
Thank you for your review and attention to detail. I will address these
points in the next version.
Diogo Ivo
WARNING: multiple messages have this Message-ID (diff)
From: Diogo Ivo <diogo.ivo@tecnico.ulisboa.pt>
To: Rayyan Ansari <rayyan@ansari.sh>
Cc: devicetree@vger.kernel.org, krzysztof.kozlowski+dt@linaro.org,
arnd@arndb.de, airlied@linux.ie, dri-devel@lists.freedesktop.org,
jonathanh@nvidia.com, robh+dt@kernel.org,
thierry.reding@gmail.com, linux-tegra@vger.kernel.org,
sam@ravnborg.org
Subject: Re: [v2,3/4] drm/panel: Add driver for JDI LPM102A188A
Date: Tue, 27 Dec 2022 11:58:51 +0000 [thread overview]
Message-ID: <20221227115851.mpvlbero4nsdq4r5@wslaptop> (raw)
In-Reply-To: <7aa53ccc-2942-e2d4-9c84-32f1bdf462ad@ansari.sh>
Hello,
On Fri, Dec 23, 2022 at 03:33:40PM +0000, Rayyan Ansari wrote:
> On 25/10/2022 16:37, Diogo Ivo wrote:
> > +config DRM_PANEL_JDI_LPM102A188A
> > + tristate "JDI LPM102A188A DSI panel"
> > + depends on OF && GPIOLIB
> > + depends on DRM_MIPI_DSI
> > + depends on BACKLIGHT_CLASS_DEVICE
> > + help
> > + Say Y here if you want to enable support for JDI LPM102A188A DSI
> > + control mode panel as found in Google Pixel C devices.
> Shouldn't this be "command mode panel" instead of "control mode panel"?
Yes, it should.
> > +static struct mipi_dsi_driver jdi_panel_dsi_driver = {
> > + .driver = {
> > + .name = "panel-jdi-lpm102a188a-dsi",
> Is the "-dsi" suffix needed here? Other panel drivers don't have this.
I had not noticed this, and I will drop it.
Thank you for your review and attention to detail. I will address these
points in the next version.
Diogo Ivo
next prev parent reply other threads:[~2022-12-27 12:01 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-25 15:37 [PATCH v2 0/4] Add JDI LPM102A188A display panel support Diogo Ivo
2022-10-25 15:37 ` Diogo Ivo
2022-10-25 15:37 ` [PATCH v2 1/4] dt-bindings: display: Add bindings for JDI LPM102A188A Diogo Ivo
2022-10-25 15:37 ` Diogo Ivo
2022-10-26 14:57 ` Krzysztof Kozlowski
2022-10-26 14:57 ` Krzysztof Kozlowski
2022-10-25 15:37 ` [PATCH v2 2/4] drm/tegra: dsi: Clear enable register if powered by bootloader Diogo Ivo
2022-10-25 15:37 ` Diogo Ivo
2022-10-25 15:37 ` [PATCH v2 3/4] drm/panel: Add driver for JDI LPM102A188A Diogo Ivo
2022-10-25 15:37 ` Diogo Ivo
2022-12-23 15:33 ` [v2,3/4] " Rayyan Ansari
2022-12-23 15:33 ` Rayyan Ansari
2022-12-27 11:58 ` Diogo Ivo [this message]
2022-12-27 11:58 ` Diogo Ivo
2022-10-25 15:37 ` [PATCH v2 4/4] arm64: dts: smaug: Add display panel node Diogo Ivo
2022-10-25 15:37 ` Diogo Ivo
2023-01-09 15:09 ` [PATCH v2 0/4] Add JDI LPM102A188A display panel support Diogo Ivo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221227115851.mpvlbero4nsdq4r5@wslaptop \
--to=diogo.ivo@tecnico.ulisboa.pt \
--cc=airlied@linux.ie \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jonathanh@nvidia.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-tegra@vger.kernel.org \
--cc=rayyan@ansari.sh \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.