* [PATCH 0/2] net: ethernet: Drop empty platform remove function
@ 2022-12-27 21:45 Uwe Kleine-König
2022-12-27 21:45 ` [PATCH 1/2] net: ethernet: broadcom: bcm63xx_enet: " Uwe Kleine-König
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Uwe Kleine-König @ 2022-12-27 21:45 UTC (permalink / raw)
To: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Claudiu Manoil
Cc: netdev, kernel
Hello,
this series drops all empty remove callbacks from platform drivers. A
callback that only returns zero is equivalent to no callback at all, so
use this simpler approach.
Best regards
Uwe
Uwe Kleine-König (2):
net: ethernet: broadcom: bcm63xx_enet: Drop empty platform remove
function
net: ethernet: freescale: enetc: Drop empty platform remove function
drivers/net/ethernet/broadcom/bcm63xx_enet.c | 6 ------
drivers/net/ethernet/freescale/enetc/enetc_ierb.c | 6 ------
2 files changed, 12 deletions(-)
base-commit: 1b929c02afd37871d5afb9d498426f83432e71c2
--
2.38.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/2] net: ethernet: broadcom: bcm63xx_enet: Drop empty platform remove function
2022-12-27 21:45 [PATCH 0/2] net: ethernet: Drop empty platform remove function Uwe Kleine-König
@ 2022-12-27 21:45 ` Uwe Kleine-König
2022-12-28 0:05 ` Florian Fainelli
2022-12-27 21:45 ` [PATCH 2/2] net: ethernet: freescale: enetc: " Uwe Kleine-König
2022-12-30 7:40 ` [PATCH 0/2] net: ethernet: " patchwork-bot+netdevbpf
2 siblings, 1 reply; 5+ messages in thread
From: Uwe Kleine-König @ 2022-12-27 21:45 UTC (permalink / raw)
To: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni; +Cc: netdev, kernel
A remove callback just returning 0 is equivalent to no remove callback
at all. So drop the useless function.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
drivers/net/ethernet/broadcom/bcm63xx_enet.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/net/ethernet/broadcom/bcm63xx_enet.c b/drivers/net/ethernet/broadcom/bcm63xx_enet.c
index d91fdb0c2649..2cf96892e565 100644
--- a/drivers/net/ethernet/broadcom/bcm63xx_enet.c
+++ b/drivers/net/ethernet/broadcom/bcm63xx_enet.c
@@ -2784,17 +2784,11 @@ static int bcm_enet_shared_probe(struct platform_device *pdev)
return 0;
}
-static int bcm_enet_shared_remove(struct platform_device *pdev)
-{
- return 0;
-}
-
/* this "shared" driver is needed because both macs share a single
* address space
*/
struct platform_driver bcm63xx_enet_shared_driver = {
.probe = bcm_enet_shared_probe,
- .remove = bcm_enet_shared_remove,
.driver = {
.name = "bcm63xx_enet_shared",
.owner = THIS_MODULE,
--
2.38.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/2] net: ethernet: freescale: enetc: Drop empty platform remove function
2022-12-27 21:45 [PATCH 0/2] net: ethernet: Drop empty platform remove function Uwe Kleine-König
2022-12-27 21:45 ` [PATCH 1/2] net: ethernet: broadcom: bcm63xx_enet: " Uwe Kleine-König
@ 2022-12-27 21:45 ` Uwe Kleine-König
2022-12-30 7:40 ` [PATCH 0/2] net: ethernet: " patchwork-bot+netdevbpf
2 siblings, 0 replies; 5+ messages in thread
From: Uwe Kleine-König @ 2022-12-27 21:45 UTC (permalink / raw)
To: Claudiu Manoil, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni
Cc: netdev, kernel
A remove callback just returning 0 is equivalent to no remove callback
at all. So drop the useless function.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
drivers/net/ethernet/freescale/enetc/enetc_ierb.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/net/ethernet/freescale/enetc/enetc_ierb.c b/drivers/net/ethernet/freescale/enetc/enetc_ierb.c
index 91f02c505028..b307bef4dc29 100644
--- a/drivers/net/ethernet/freescale/enetc/enetc_ierb.c
+++ b/drivers/net/ethernet/freescale/enetc/enetc_ierb.c
@@ -127,11 +127,6 @@ static int enetc_ierb_probe(struct platform_device *pdev)
return 0;
}
-static int enetc_ierb_remove(struct platform_device *pdev)
-{
- return 0;
-}
-
static const struct of_device_id enetc_ierb_match[] = {
{ .compatible = "fsl,ls1028a-enetc-ierb", },
{},
@@ -144,7 +139,6 @@ static struct platform_driver enetc_ierb_driver = {
.of_match_table = enetc_ierb_match,
},
.probe = enetc_ierb_probe,
- .remove = enetc_ierb_remove,
};
module_platform_driver(enetc_ierb_driver);
--
2.38.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] net: ethernet: broadcom: bcm63xx_enet: Drop empty platform remove function
2022-12-27 21:45 ` [PATCH 1/2] net: ethernet: broadcom: bcm63xx_enet: " Uwe Kleine-König
@ 2022-12-28 0:05 ` Florian Fainelli
0 siblings, 0 replies; 5+ messages in thread
From: Florian Fainelli @ 2022-12-28 0:05 UTC (permalink / raw)
To: Uwe Kleine-König, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni
Cc: netdev, kernel
On 12/27/2022 1:45 PM, Uwe Kleine-König wrote:
> A remove callback just returning 0 is equivalent to no remove callback
> at all. So drop the useless function.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 0/2] net: ethernet: Drop empty platform remove function
2022-12-27 21:45 [PATCH 0/2] net: ethernet: Drop empty platform remove function Uwe Kleine-König
2022-12-27 21:45 ` [PATCH 1/2] net: ethernet: broadcom: bcm63xx_enet: " Uwe Kleine-König
2022-12-27 21:45 ` [PATCH 2/2] net: ethernet: freescale: enetc: " Uwe Kleine-König
@ 2022-12-30 7:40 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 5+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-12-30 7:40 UTC (permalink / raw)
To: =?utf-8?q?Uwe_Kleine-K=C3=B6nig_=3Cu=2Ekleine-koenig=40pengutronix=2Ede=3E?=
Cc: davem, edumazet, kuba, pabeni, claudiu.manoil, netdev, kernel
Hello:
This series was applied to netdev/net.git (master)
by David S. Miller <davem@davemloft.net>:
On Tue, 27 Dec 2022 22:45:06 +0100 you wrote:
> Hello,
>
> this series drops all empty remove callbacks from platform drivers. A
> callback that only returns zero is equivalent to no callback at all, so
> use this simpler approach.
>
> Best regards
> Uwe
>
> [...]
Here is the summary with links:
- [1/2] net: ethernet: broadcom: bcm63xx_enet: Drop empty platform remove function
https://git.kernel.org/netdev/net/c/6b57bffa5f67
- [2/2] net: ethernet: freescale: enetc: Drop empty platform remove function
https://git.kernel.org/netdev/net/c/af691c94d022
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-12-30 7:40 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-27 21:45 [PATCH 0/2] net: ethernet: Drop empty platform remove function Uwe Kleine-König
2022-12-27 21:45 ` [PATCH 1/2] net: ethernet: broadcom: bcm63xx_enet: " Uwe Kleine-König
2022-12-28 0:05 ` Florian Fainelli
2022-12-27 21:45 ` [PATCH 2/2] net: ethernet: freescale: enetc: " Uwe Kleine-König
2022-12-30 7:40 ` [PATCH 0/2] net: ethernet: " patchwork-bot+netdevbpf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.