* [PATCH] mfd: rk808: re-add rk808-clkout to RK818
@ 2022-12-28 14:07 ` Tom Fitzhenry
0 siblings, 0 replies; 10+ messages in thread
From: Tom Fitzhenry @ 2022-12-28 14:07 UTC (permalink / raw)
To: Lee Jones, Neil Armstrong
Cc: Ondrej Jirman, Javier Martinez Canillas, Martijn Braam,
linux-rockchip, linux-kernel, Tom Fitzhenry
Fixes RK818 (e.g. on Pinephone Pro) to register its clock, without which
dependent devices (e.g. wifi/BT, via sdio-wifi-pwrseq) fail to probe.
This line was removed in commit 3633daacea2e
("mfd: rk808: Permit having multiple PMIC instances"), but only from RK818.
Signed-off-by: Tom Fitzhenry <tom@tom-fitzhenry.me.uk>
---
drivers/mfd/rk808.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mfd/rk808.c b/drivers/mfd/rk808.c
index f44fc3f080a8..0f22ef61e817 100644
--- a/drivers/mfd/rk808.c
+++ b/drivers/mfd/rk808.c
@@ -189,6 +189,7 @@ static const struct mfd_cell rk817s[] = {
};
static const struct mfd_cell rk818s[] = {
+ { .name = "rk808-clkout", .id = PLATFORM_DEVID_NONE, },
{ .name = "rk808-regulator", .id = PLATFORM_DEVID_NONE, },
{
.name = "rk808-rtc",
base-commit: c76083fac3bae1a87ae3d005b5cb1cbc761e31d5
--
2.38.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH] mfd: rk808: re-add rk808-clkout to RK818
@ 2022-12-28 14:07 ` Tom Fitzhenry
0 siblings, 0 replies; 10+ messages in thread
From: Tom Fitzhenry @ 2022-12-28 14:07 UTC (permalink / raw)
To: Lee Jones, Neil Armstrong
Cc: Ondrej Jirman, Javier Martinez Canillas, Martijn Braam,
linux-rockchip, linux-kernel, Tom Fitzhenry
Fixes RK818 (e.g. on Pinephone Pro) to register its clock, without which
dependent devices (e.g. wifi/BT, via sdio-wifi-pwrseq) fail to probe.
This line was removed in commit 3633daacea2e
("mfd: rk808: Permit having multiple PMIC instances"), but only from RK818.
Signed-off-by: Tom Fitzhenry <tom@tom-fitzhenry.me.uk>
---
drivers/mfd/rk808.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mfd/rk808.c b/drivers/mfd/rk808.c
index f44fc3f080a8..0f22ef61e817 100644
--- a/drivers/mfd/rk808.c
+++ b/drivers/mfd/rk808.c
@@ -189,6 +189,7 @@ static const struct mfd_cell rk817s[] = {
};
static const struct mfd_cell rk818s[] = {
+ { .name = "rk808-clkout", .id = PLATFORM_DEVID_NONE, },
{ .name = "rk808-regulator", .id = PLATFORM_DEVID_NONE, },
{
.name = "rk808-rtc",
base-commit: c76083fac3bae1a87ae3d005b5cb1cbc761e31d5
--
2.38.1
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH] mfd: rk808: re-add rk808-clkout to RK818
2022-12-28 14:07 ` Tom Fitzhenry
@ 2022-12-29 18:27 ` Javier Martinez Canillas
-1 siblings, 0 replies; 10+ messages in thread
From: Javier Martinez Canillas @ 2022-12-29 18:27 UTC (permalink / raw)
To: Tom Fitzhenry, Lee Jones, Neil Armstrong
Cc: Ondrej Jirman, Martijn Braam, linux-rockchip, linux-kernel
Hello Tom,
On 12/28/22 15:07, Tom Fitzhenry wrote:
> Fixes RK818 (e.g. on Pinephone Pro) to register its clock, without which
> dependent devices (e.g. wifi/BT, via sdio-wifi-pwrseq) fail to probe.
>
> This line was removed in commit 3633daacea2e
> ("mfd: rk808: Permit having multiple PMIC instances"), but only from RK818.
>
Maybe add a Fixes: 3633daacea2e ("mfd: rk808: Permit having multiple PMIC instances") ?
> Signed-off-by: Tom Fitzhenry <tom@tom-fitzhenry.me.uk>
> ---
The patch looks good to me.
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] mfd: rk808: re-add rk808-clkout to RK818
@ 2022-12-29 18:27 ` Javier Martinez Canillas
0 siblings, 0 replies; 10+ messages in thread
From: Javier Martinez Canillas @ 2022-12-29 18:27 UTC (permalink / raw)
To: Tom Fitzhenry, Lee Jones, Neil Armstrong
Cc: Ondrej Jirman, Martijn Braam, linux-rockchip, linux-kernel
Hello Tom,
On 12/28/22 15:07, Tom Fitzhenry wrote:
> Fixes RK818 (e.g. on Pinephone Pro) to register its clock, without which
> dependent devices (e.g. wifi/BT, via sdio-wifi-pwrseq) fail to probe.
>
> This line was removed in commit 3633daacea2e
> ("mfd: rk808: Permit having multiple PMIC instances"), but only from RK818.
>
Maybe add a Fixes: 3633daacea2e ("mfd: rk808: Permit having multiple PMIC instances") ?
> Signed-off-by: Tom Fitzhenry <tom@tom-fitzhenry.me.uk>
> ---
The patch looks good to me.
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] mfd: rk808: re-add rk808-clkout to RK818
2022-12-28 14:07 ` Tom Fitzhenry
@ 2023-01-02 10:06 ` Neil Armstrong
-1 siblings, 0 replies; 10+ messages in thread
From: Neil Armstrong @ 2023-01-02 10:06 UTC (permalink / raw)
To: Tom Fitzhenry, Lee Jones
Cc: Ondrej Jirman, Javier Martinez Canillas, Martijn Braam,
linux-rockchip, linux-kernel
On 28/12/2022 15:07, Tom Fitzhenry wrote:
> Fixes RK818 (e.g. on Pinephone Pro) to register its clock, without which
> dependent devices (e.g. wifi/BT, via sdio-wifi-pwrseq) fail to probe.
>
> This line was removed in commit 3633daacea2e
> ("mfd: rk808: Permit having multiple PMIC instances"), but only from RK818.
>
> Signed-off-by: Tom Fitzhenry <tom@tom-fitzhenry.me.uk>
> ---
> drivers/mfd/rk808.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mfd/rk808.c b/drivers/mfd/rk808.c
> index f44fc3f080a8..0f22ef61e817 100644
> --- a/drivers/mfd/rk808.c
> +++ b/drivers/mfd/rk808.c
> @@ -189,6 +189,7 @@ static const struct mfd_cell rk817s[] = {
> };
>
> static const struct mfd_cell rk818s[] = {
> + { .name = "rk808-clkout", .id = PLATFORM_DEVID_NONE, },
> { .name = "rk808-regulator", .id = PLATFORM_DEVID_NONE, },
> {
> .name = "rk808-rtc",
>
> base-commit: c76083fac3bae1a87ae3d005b5cb1cbc761e31d5
Sorry, my bad...
Acked-by: Neil Armstrong <neil.armstrong@linaro.org>
Thanks,
Neil
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] mfd: rk808: re-add rk808-clkout to RK818
@ 2023-01-02 10:06 ` Neil Armstrong
0 siblings, 0 replies; 10+ messages in thread
From: Neil Armstrong @ 2023-01-02 10:06 UTC (permalink / raw)
To: Tom Fitzhenry, Lee Jones
Cc: Ondrej Jirman, Javier Martinez Canillas, Martijn Braam,
linux-rockchip, linux-kernel
On 28/12/2022 15:07, Tom Fitzhenry wrote:
> Fixes RK818 (e.g. on Pinephone Pro) to register its clock, without which
> dependent devices (e.g. wifi/BT, via sdio-wifi-pwrseq) fail to probe.
>
> This line was removed in commit 3633daacea2e
> ("mfd: rk808: Permit having multiple PMIC instances"), but only from RK818.
>
> Signed-off-by: Tom Fitzhenry <tom@tom-fitzhenry.me.uk>
> ---
> drivers/mfd/rk808.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mfd/rk808.c b/drivers/mfd/rk808.c
> index f44fc3f080a8..0f22ef61e817 100644
> --- a/drivers/mfd/rk808.c
> +++ b/drivers/mfd/rk808.c
> @@ -189,6 +189,7 @@ static const struct mfd_cell rk817s[] = {
> };
>
> static const struct mfd_cell rk818s[] = {
> + { .name = "rk808-clkout", .id = PLATFORM_DEVID_NONE, },
> { .name = "rk808-regulator", .id = PLATFORM_DEVID_NONE, },
> {
> .name = "rk808-rtc",
>
> base-commit: c76083fac3bae1a87ae3d005b5cb1cbc761e31d5
Sorry, my bad...
Acked-by: Neil Armstrong <neil.armstrong@linaro.org>
Thanks,
Neil
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] mfd: rk808: re-add rk808-clkout to RK818
2023-01-02 10:06 ` Neil Armstrong
@ 2023-01-02 11:13 ` Tom Fitzhenry
-1 siblings, 0 replies; 10+ messages in thread
From: Tom Fitzhenry @ 2023-01-02 11:13 UTC (permalink / raw)
To: neil.armstrong, Lee Jones
Cc: Ondrej Jirman, Javier Martinez Canillas, Martijn Braam,
linux-rockchip, linux-kernel
On 2/1/23 21:06, Neil Armstrong wrote:
> On 28/12/2022 15:07, Tom Fitzhenry wrote:
>> Fixes RK818 (e.g. on Pinephone Pro) to register its clock, without which
>> dependent devices (e.g. wifi/BT, via sdio-wifi-pwrseq) fail to probe.
>>
>> This line was removed in commit 3633daacea2e
>> ("mfd: rk808: Permit having multiple PMIC instances"), but only from
>> RK818.
>>
>> Signed-off-by: Tom Fitzhenry <tom@tom-fitzhenry.me.uk>
>> ---
>> drivers/mfd/rk808.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/mfd/rk808.c b/drivers/mfd/rk808.c
>> index f44fc3f080a8..0f22ef61e817 100644
>> --- a/drivers/mfd/rk808.c
>> +++ b/drivers/mfd/rk808.c
>> @@ -189,6 +189,7 @@ static const struct mfd_cell rk817s[] = {
>> };
>> static const struct mfd_cell rk818s[] = {
>> + { .name = "rk808-clkout", .id = PLATFORM_DEVID_NONE, },
>> { .name = "rk808-regulator", .id = PLATFORM_DEVID_NONE, },
>> {
>> .name = "rk808-rtc",
>>
>> base-commit: c76083fac3bae1a87ae3d005b5cb1cbc761e31d5
>
> Sorry, my bad...
No worries!
> Acked-by: Neil Armstrong <neil.armstrong@linaro.org>
Thanks, I have added this to the v2 patch.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] mfd: rk808: re-add rk808-clkout to RK818
@ 2023-01-02 11:13 ` Tom Fitzhenry
0 siblings, 0 replies; 10+ messages in thread
From: Tom Fitzhenry @ 2023-01-02 11:13 UTC (permalink / raw)
To: neil.armstrong, Lee Jones
Cc: Ondrej Jirman, Javier Martinez Canillas, Martijn Braam,
linux-rockchip, linux-kernel
On 2/1/23 21:06, Neil Armstrong wrote:
> On 28/12/2022 15:07, Tom Fitzhenry wrote:
>> Fixes RK818 (e.g. on Pinephone Pro) to register its clock, without which
>> dependent devices (e.g. wifi/BT, via sdio-wifi-pwrseq) fail to probe.
>>
>> This line was removed in commit 3633daacea2e
>> ("mfd: rk808: Permit having multiple PMIC instances"), but only from
>> RK818.
>>
>> Signed-off-by: Tom Fitzhenry <tom@tom-fitzhenry.me.uk>
>> ---
>> drivers/mfd/rk808.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/mfd/rk808.c b/drivers/mfd/rk808.c
>> index f44fc3f080a8..0f22ef61e817 100644
>> --- a/drivers/mfd/rk808.c
>> +++ b/drivers/mfd/rk808.c
>> @@ -189,6 +189,7 @@ static const struct mfd_cell rk817s[] = {
>> };
>> static const struct mfd_cell rk818s[] = {
>> + { .name = "rk808-clkout", .id = PLATFORM_DEVID_NONE, },
>> { .name = "rk808-regulator", .id = PLATFORM_DEVID_NONE, },
>> {
>> .name = "rk808-rtc",
>>
>> base-commit: c76083fac3bae1a87ae3d005b5cb1cbc761e31d5
>
> Sorry, my bad...
No worries!
> Acked-by: Neil Armstrong <neil.armstrong@linaro.org>
Thanks, I have added this to the v2 patch.
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] mfd: rk808: re-add rk808-clkout to RK818
2022-12-29 18:27 ` Javier Martinez Canillas
@ 2023-01-02 11:15 ` Tom Fitzhenry
-1 siblings, 0 replies; 10+ messages in thread
From: Tom Fitzhenry @ 2023-01-02 11:15 UTC (permalink / raw)
To: Javier Martinez Canillas, Lee Jones, Neil Armstrong
Cc: Ondrej Jirman, Martijn Braam, linux-rockchip, linux-kernel
On 30/12/22 05:27, Javier Martinez Canillas wrote:
> On 12/28/22 15:07, Tom Fitzhenry wrote:
>> Fixes RK818 (e.g. on Pinephone Pro) to register its clock, without which
>> dependent devices (e.g. wifi/BT, via sdio-wifi-pwrseq) fail to probe.
>>
>> This line was removed in commit 3633daacea2e
>> ("mfd: rk808: Permit having multiple PMIC instances"), but only from RK818.
>>
>
> Maybe add a Fixes: 3633daacea2e ("mfd: rk808: Permit having multiple PMIC instances") ?
SGTM. I have added this to the v2 patch.
> The patch looks good to me.
>
> Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
Thanks, I have added this to the v2 patch.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] mfd: rk808: re-add rk808-clkout to RK818
@ 2023-01-02 11:15 ` Tom Fitzhenry
0 siblings, 0 replies; 10+ messages in thread
From: Tom Fitzhenry @ 2023-01-02 11:15 UTC (permalink / raw)
To: Javier Martinez Canillas, Lee Jones, Neil Armstrong
Cc: Ondrej Jirman, Martijn Braam, linux-rockchip, linux-kernel
On 30/12/22 05:27, Javier Martinez Canillas wrote:
> On 12/28/22 15:07, Tom Fitzhenry wrote:
>> Fixes RK818 (e.g. on Pinephone Pro) to register its clock, without which
>> dependent devices (e.g. wifi/BT, via sdio-wifi-pwrseq) fail to probe.
>>
>> This line was removed in commit 3633daacea2e
>> ("mfd: rk808: Permit having multiple PMIC instances"), but only from RK818.
>>
>
> Maybe add a Fixes: 3633daacea2e ("mfd: rk808: Permit having multiple PMIC instances") ?
SGTM. I have added this to the v2 patch.
> The patch looks good to me.
>
> Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
Thanks, I have added this to the v2 patch.
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2023-01-02 11:19 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-28 14:07 [PATCH] mfd: rk808: re-add rk808-clkout to RK818 Tom Fitzhenry
2022-12-28 14:07 ` Tom Fitzhenry
2022-12-29 18:27 ` Javier Martinez Canillas
2022-12-29 18:27 ` Javier Martinez Canillas
2023-01-02 11:15 ` Tom Fitzhenry
2023-01-02 11:15 ` Tom Fitzhenry
2023-01-02 10:06 ` Neil Armstrong
2023-01-02 10:06 ` Neil Armstrong
2023-01-02 11:13 ` Tom Fitzhenry
2023-01-02 11:13 ` Tom Fitzhenry
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.