All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/v3d: replace open-coded implementation of drm_gem_object_lookup
@ 2022-12-27 20:00 Maíra Canal
  2022-12-28 14:35 ` Melissa Wen
  0 siblings, 1 reply; 3+ messages in thread
From: Maíra Canal @ 2022-12-27 20:00 UTC (permalink / raw)
  To: Melissa Wen, Emma Anholt, David Airlie, Daniel Vetter
  Cc: Maíra Canal, André Almeida, dri-devel

As v3d_submit_tfu_ioctl() performs the same steps as drm_gem_object_lookup(),
replace the open-code implementation in v3d with its DRM core equivalent.

Signed-off-by: Maíra Canal <mcanal@igalia.com>
---
 drivers/gpu/drm/v3d/v3d_gem.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/v3d/v3d_gem.c b/drivers/gpu/drm/v3d/v3d_gem.c
index 6e152ef26358..5da1806f3969 100644
--- a/drivers/gpu/drm/v3d/v3d_gem.c
+++ b/drivers/gpu/drm/v3d/v3d_gem.c
@@ -861,7 +861,6 @@ v3d_submit_tfu_ioctl(struct drm_device *dev, void *data,
 
 	job->args = *args;
 
-	spin_lock(&file_priv->table_lock);
 	for (job->base.bo_count = 0;
 	     job->base.bo_count < ARRAY_SIZE(args->bo_handles);
 	     job->base.bo_count++) {
@@ -870,20 +869,16 @@ v3d_submit_tfu_ioctl(struct drm_device *dev, void *data,
 		if (!args->bo_handles[job->base.bo_count])
 			break;
 
-		bo = idr_find(&file_priv->object_idr,
-			      args->bo_handles[job->base.bo_count]);
+		bo = drm_gem_object_lookup(file_priv, args->bo_handles[job->base.bo_count]);
 		if (!bo) {
 			DRM_DEBUG("Failed to look up GEM BO %d: %d\n",
 				  job->base.bo_count,
 				  args->bo_handles[job->base.bo_count]);
 			ret = -ENOENT;
-			spin_unlock(&file_priv->table_lock);
 			goto fail;
 		}
-		drm_gem_object_get(bo);
 		job->base.bo[job->base.bo_count] = bo;
 	}
-	spin_unlock(&file_priv->table_lock);
 
 	ret = v3d_lock_bo_reservations(&job->base, &acquire_ctx);
 	if (ret)
-- 
2.38.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: [PATCH] drm/v3d: replace open-coded implementation of drm_gem_object_lookup
  2022-12-27 20:00 [PATCH] drm/v3d: replace open-coded implementation of drm_gem_object_lookup Maíra Canal
@ 2022-12-28 14:35 ` Melissa Wen
  2023-01-03 19:20   ` Melissa Wen
  0 siblings, 1 reply; 3+ messages in thread
From: Melissa Wen @ 2022-12-28 14:35 UTC (permalink / raw)
  To: Maíra Canal; +Cc: André Almeida, dri-devel, Emma Anholt

[-- Attachment #1: Type: text/plain, Size: 1724 bytes --]

On 12/27, Maíra Canal wrote:
> As v3d_submit_tfu_ioctl() performs the same steps as drm_gem_object_lookup(),
> replace the open-code implementation in v3d with its DRM core equivalent.
> 
> Signed-off-by: Maíra Canal <mcanal@igalia.com>
> ---
>  drivers/gpu/drm/v3d/v3d_gem.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/drivers/gpu/drm/v3d/v3d_gem.c b/drivers/gpu/drm/v3d/v3d_gem.c
> index 6e152ef26358..5da1806f3969 100644
> --- a/drivers/gpu/drm/v3d/v3d_gem.c
> +++ b/drivers/gpu/drm/v3d/v3d_gem.c
> @@ -861,7 +861,6 @@ v3d_submit_tfu_ioctl(struct drm_device *dev, void *data,
>  
>  	job->args = *args;
>  
> -	spin_lock(&file_priv->table_lock);
>  	for (job->base.bo_count = 0;
>  	     job->base.bo_count < ARRAY_SIZE(args->bo_handles);
>  	     job->base.bo_count++) {
> @@ -870,20 +869,16 @@ v3d_submit_tfu_ioctl(struct drm_device *dev, void *data,
>  		if (!args->bo_handles[job->base.bo_count])
>  			break;
>  
> -		bo = idr_find(&file_priv->object_idr,
> -			      args->bo_handles[job->base.bo_count]);
> +		bo = drm_gem_object_lookup(file_priv, args->bo_handles[job->base.bo_count]);
>  		if (!bo) {
>  			DRM_DEBUG("Failed to look up GEM BO %d: %d\n",
>  				  job->base.bo_count,
>  				  args->bo_handles[job->base.bo_count]);
>  			ret = -ENOENT;
> -			spin_unlock(&file_priv->table_lock);
>  			goto fail;
>  		}
> -		drm_gem_object_get(bo);
>  		job->base.bo[job->base.bo_count] = bo;
>  	}
> -	spin_unlock(&file_priv->table_lock);

Hi Maíra,

Thanks for you patch.

LGTM

Reviewed-by: Melissa Wen <mwen@igalia.com>

>  
>  	ret = v3d_lock_bo_reservations(&job->base, &acquire_ctx);
>  	if (ret)
> -- 
> 2.38.1
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [PATCH] drm/v3d: replace open-coded implementation of drm_gem_object_lookup
  2022-12-28 14:35 ` Melissa Wen
@ 2023-01-03 19:20   ` Melissa Wen
  0 siblings, 0 replies; 3+ messages in thread
From: Melissa Wen @ 2023-01-03 19:20 UTC (permalink / raw)
  To: Maíra Canal; +Cc: André Almeida, Emma Anholt, dri-devel


[-- Attachment #1.1: Type: text/plain, Size: 1919 bytes --]

On 12/28, Melissa Wen wrote:
> On 12/27, Maíra Canal wrote:
> > As v3d_submit_tfu_ioctl() performs the same steps as drm_gem_object_lookup(),
> > replace the open-code implementation in v3d with its DRM core equivalent.
> > 
> > Signed-off-by: Maíra Canal <mcanal@igalia.com>
> > ---
> >  drivers/gpu/drm/v3d/v3d_gem.c | 7 +------
> >  1 file changed, 1 insertion(+), 6 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/v3d/v3d_gem.c b/drivers/gpu/drm/v3d/v3d_gem.c
> > index 6e152ef26358..5da1806f3969 100644
> > --- a/drivers/gpu/drm/v3d/v3d_gem.c
> > +++ b/drivers/gpu/drm/v3d/v3d_gem.c
> > @@ -861,7 +861,6 @@ v3d_submit_tfu_ioctl(struct drm_device *dev, void *data,
> >  
> >  	job->args = *args;
> >  
> > -	spin_lock(&file_priv->table_lock);
> >  	for (job->base.bo_count = 0;
> >  	     job->base.bo_count < ARRAY_SIZE(args->bo_handles);
> >  	     job->base.bo_count++) {
> > @@ -870,20 +869,16 @@ v3d_submit_tfu_ioctl(struct drm_device *dev, void *data,
> >  		if (!args->bo_handles[job->base.bo_count])
> >  			break;
> >  
> > -		bo = idr_find(&file_priv->object_idr,
> > -			      args->bo_handles[job->base.bo_count]);
> > +		bo = drm_gem_object_lookup(file_priv, args->bo_handles[job->base.bo_count]);
> >  		if (!bo) {
> >  			DRM_DEBUG("Failed to look up GEM BO %d: %d\n",
> >  				  job->base.bo_count,
> >  				  args->bo_handles[job->base.bo_count]);
> >  			ret = -ENOENT;
> > -			spin_unlock(&file_priv->table_lock);
> >  			goto fail;
> >  		}
> > -		drm_gem_object_get(bo);
> >  		job->base.bo[job->base.bo_count] = bo;
> >  	}
> > -	spin_unlock(&file_priv->table_lock);
> 
> Hi Maíra,
> 
> Thanks for you patch.
> 
> LGTM
> 
> Reviewed-by: Melissa Wen <mwen@igalia.com>

Applied to drm-misc-next.

Thanks,

Melissa
> 
> >  
> >  	ret = v3d_lock_bo_reservations(&job->base, &acquire_ctx);
> >  	if (ret)
> > -- 
> > 2.38.1
> > 



[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-01-03 19:21 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-27 20:00 [PATCH] drm/v3d: replace open-coded implementation of drm_gem_object_lookup Maíra Canal
2022-12-28 14:35 ` Melissa Wen
2023-01-03 19:20   ` Melissa Wen

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.