From: Tom Rini <trini@konsulko.com>
To: "Pali Rohár" <pali@kernel.org>
Cc: Heiko Schocher <hs@denx.de>, u-boot@lists.denx.de
Subject: Re: [PATCH u-boot] powerpc/mpc85xx: socrates: Re-enable building u-boot-socrates.bin
Date: Wed, 28 Dec 2022 19:11:34 -0500 [thread overview]
Message-ID: <20221229001134.GQ3787616@bill-the-cat> (raw)
In-Reply-To: <20221228181839.22003-1-pali@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 1845 bytes --]
On Wed, Dec 28, 2022 at 07:18:39PM +0100, Pali Rohár wrote:
> U-Boot build system builds final U-Boot binary for socrates board in custom
> file u-boot-socrates.bin (instead of standard u-boot.bin). Output target
> file u-boot-socrates.bin is generated by binman as defined in board binman
> config file arch/powerpc/dts/socrates-u-boot.dtsi.
>
> But binman was disabled in commit 5af42eafd7e1 ("Makefile: Reduce usage of
> custom mpc85xx u-boot.bin target") for all mpc85xx boards which do not use
> standard powerpc binman config file arch/powerpc/dts/u-boot.dtsi and boards
> which do not require binman at all.
>
> The only such mpc85xx board is socrates. So since that commit, U-Boot does
> not final binary for socrates board anymore.
>
> Fix this issue by re-enabling binman for socrates board. And build process
> starts again producing u-boot-socrates.bin binary.
>
> Note that build process for this socrates board always produce u-boot.bin
> binary which is broken and not usable for socrates board. Long term
> solution should be to disable building broken binary u-boot.bin and then
> renaming u-boot-socrates.bin to u-boot.bin, or switching to use common
> powerpc binman config file arch/powerpc/dts/socrates-u-boot.dtsi (if it is
> possible).
>
> Fixes: 5af42eafd7e1 ("Makefile: Reduce usage of custom mpc85xx u-boot.bin target")
> Signed-off-by: Pali Rohár <pali@kernel.org>
> ---
> Heiko Schocher: Could you test if u-boot is still working on this board?
>
> Tom Rini: Cannot be this issue handled by CI? For example that CI check
> build process produce required output binaries?
So, in so far as CI can check for something like this, it does when we
enable it (akin to the build time size checks). I think in this case,
some settings for CONFIG_BUILD_TARGET would help.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2022-12-29 0:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-28 18:18 [PATCH u-boot] powerpc/mpc85xx: socrates: Re-enable building u-boot-socrates.bin Pali Rohár
2022-12-29 0:11 ` Tom Rini [this message]
2022-12-29 1:34 ` Pali Rohár
2022-12-29 7:01 ` Heiko Schocher
2022-12-30 12:44 ` Pali Rohár
2022-12-30 15:20 ` Tom Rini
2022-12-31 9:36 ` Heiko Schocher
2022-12-31 12:58 ` Pali Rohár
2022-12-31 13:36 ` Heiko Schocher
2022-12-31 15:31 ` Heiko Schocher
2022-12-31 15:37 ` Pali Rohár
2023-01-01 6:57 ` Heiko Schocher
2023-01-02 8:29 ` Heiko Schocher
2023-01-11 0:09 ` Pali Rohár
2023-01-06 16:52 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221229001134.GQ3787616@bill-the-cat \
--to=trini@konsulko.com \
--cc=hs@denx.de \
--cc=pali@kernel.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.