* [PATCH] iio: imu: st_lsm6dsx: fix build when CONFIG_IIO_TRIGGERED_BUFFER=m
@ 2023-01-03 13:03 Vladimir Oltean
2023-01-08 12:15 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Vladimir Oltean @ 2023-01-03 13:03 UTC (permalink / raw)
To: Jonathan Cameron, linux-iio
Cc: Lorenzo Bianconi, Lars-Peter Clausen, linux-kernel
The following kernel linkage error:
st_lsm6dsx_core.o: in function `st_lsm6dsx_sw_buffers_setup':
st_lsm6dsx_core.c:2578: undefined reference to `devm_iio_triggered_buffer_setup_ext'
is caused by the fact that the object owning devm_iio_triggered_buffer_setup_ext()
(drivers/iio/buffer/industrialio-triggered-buffer.o) is allowed to be
built as module when its user (drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c)
is built-in.
The st_lsm6dsx driver already has a "select IIO_BUFFER", so add another
select for IIO_TRIGGERED_BUFFER, to make that option follow what is set
for the st_lsm6dsx driver. This is similar to what other iio drivers do.
Fixes: 2cfb2180c3e8 ("iio: imu: st_lsm6dsx: introduce sw trigger support")
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
---
drivers/iio/imu/st_lsm6dsx/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/iio/imu/st_lsm6dsx/Kconfig b/drivers/iio/imu/st_lsm6dsx/Kconfig
index f6660847fb58..8c16cdacf2f2 100644
--- a/drivers/iio/imu/st_lsm6dsx/Kconfig
+++ b/drivers/iio/imu/st_lsm6dsx/Kconfig
@@ -4,6 +4,7 @@ config IIO_ST_LSM6DSX
tristate "ST_LSM6DSx driver for STM 6-axis IMU MEMS sensors"
depends on (I2C || SPI || I3C)
select IIO_BUFFER
+ select IIO_TRIGGERED_BUFFER
select IIO_KFIFO_BUF
select IIO_ST_LSM6DSX_I2C if (I2C)
select IIO_ST_LSM6DSX_SPI if (SPI_MASTER)
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] iio: imu: st_lsm6dsx: fix build when CONFIG_IIO_TRIGGERED_BUFFER=m
2023-01-03 13:03 [PATCH] iio: imu: st_lsm6dsx: fix build when CONFIG_IIO_TRIGGERED_BUFFER=m Vladimir Oltean
@ 2023-01-08 12:15 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2023-01-08 12:15 UTC (permalink / raw)
To: Vladimir Oltean
Cc: linux-iio, Lorenzo Bianconi, Lars-Peter Clausen, linux-kernel
On Tue, 3 Jan 2023 15:03:48 +0200
Vladimir Oltean <vladimir.oltean@nxp.com> wrote:
> The following kernel linkage error:
>
> st_lsm6dsx_core.o: in function `st_lsm6dsx_sw_buffers_setup':
> st_lsm6dsx_core.c:2578: undefined reference to `devm_iio_triggered_buffer_setup_ext'
>
> is caused by the fact that the object owning devm_iio_triggered_buffer_setup_ext()
> (drivers/iio/buffer/industrialio-triggered-buffer.o) is allowed to be
> built as module when its user (drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c)
> is built-in.
>
> The st_lsm6dsx driver already has a "select IIO_BUFFER", so add another
> select for IIO_TRIGGERED_BUFFER, to make that option follow what is set
> for the st_lsm6dsx driver. This is similar to what other iio drivers do.
>
> Fixes: 2cfb2180c3e8 ("iio: imu: st_lsm6dsx: introduce sw trigger support")
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Applied to the fixes-togreg branch of iio.git and marked for stable.
Thanks,
Jonathan
> ---
> drivers/iio/imu/st_lsm6dsx/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iio/imu/st_lsm6dsx/Kconfig b/drivers/iio/imu/st_lsm6dsx/Kconfig
> index f6660847fb58..8c16cdacf2f2 100644
> --- a/drivers/iio/imu/st_lsm6dsx/Kconfig
> +++ b/drivers/iio/imu/st_lsm6dsx/Kconfig
> @@ -4,6 +4,7 @@ config IIO_ST_LSM6DSX
> tristate "ST_LSM6DSx driver for STM 6-axis IMU MEMS sensors"
> depends on (I2C || SPI || I3C)
> select IIO_BUFFER
> + select IIO_TRIGGERED_BUFFER
> select IIO_KFIFO_BUF
> select IIO_ST_LSM6DSX_I2C if (I2C)
> select IIO_ST_LSM6DSX_SPI if (SPI_MASTER)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-01-08 12:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-03 13:03 [PATCH] iio: imu: st_lsm6dsx: fix build when CONFIG_IIO_TRIGGERED_BUFFER=m Vladimir Oltean
2023-01-08 12:15 ` Jonathan Cameron
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.