From: Guenter Roeck <linux@roeck-us.net> To: Hal Feng <hal.feng@starfivetech.com> Cc: linux-hwmon@vger.kernel.org, linux-doc@vger.kernel.org, linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, Jean Delvare <jdelvare@suse.com>, Jonathan Corbet <corbet@lwn.net>, Conor Dooley <conor@kernel.org>, Paul Walmsley <paul.walmsley@sifive.com>, Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Emil Renner Berthing <emil.renner.berthing@canonical.com>, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 1/4] dt-bindings: hwmon: Add starfive,jh71x0-temp Date: Tue, 3 Jan 2023 14:14:05 -0800 [thread overview] Message-ID: <20230103221405.GA217696@roeck-us.net> (raw) In-Reply-To: <20230103013145.9570-2-hal.feng@starfivetech.com> On Tue, Jan 03, 2023 at 09:31:42AM +0800, Hal Feng wrote: > From: Emil Renner Berthing <kernel@esmil.dk> > > Add bindings for the temperature sensor on the StarFive JH7100 and > JH7110 SoCs. > > Signed-off-by: Emil Renner Berthing <kernel@esmil.dk> > Signed-off-by: Hal Feng <hal.feng@starfivetech.com> The previous version of this bindings document (v3, https://patchwork.kernel.org/project/linux-hwmon/patch/20210726171802.1052716-2-kernel@esmil.dk/ had been reviewed by Rob Herring. Even though this version is named differently (starfive,jh71x0-temp.yaml instead of starfive,jh7100-temp.yaml), the old version should be referenced, and there should be a change log. Guenter > --- > .../bindings/hwmon/starfive,jh71x0-temp.yaml | 75 +++++++++++++++++++ > 1 file changed, 75 insertions(+) > create mode 100644 Documentation/devicetree/bindings/hwmon/starfive,jh71x0-temp.yaml > > diff --git a/Documentation/devicetree/bindings/hwmon/starfive,jh71x0-temp.yaml b/Documentation/devicetree/bindings/hwmon/starfive,jh71x0-temp.yaml > new file mode 100644 > index 000000000000..2600881e2cdc > --- /dev/null > +++ b/Documentation/devicetree/bindings/hwmon/starfive,jh71x0-temp.yaml > @@ -0,0 +1,75 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/hwmon/starfive,jh71x0-temp.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: StarFive JH71x0 Temperature Sensor > + > +maintainers: > + - Emil Renner Berthing <kernel@esmil.dk> > + > +description: | > + StarFive Technology Co. JH71x0 embedded temperature sensor > + > +properties: > + compatible: > + enum: > + - starfive,jh7100-temp > + - starfive,jh7110-temp > + > + reg: > + maxItems: 1 > + > + clocks: > + minItems: 2 > + maxItems: 2 > + > + clock-names: > + items: > + - const: "sense" > + - const: "bus" > + > + '#thermal-sensor-cells': > + const: 0 > + > + interrupts: > + maxItems: 1 > + > + resets: > + minItems: 2 > + maxItems: 2 > + > + reset-names: > + items: > + - const: "sense" > + - const: "bus" > + > +required: > + - compatible > + - reg > + - clocks > + - clock-names > + - interrupts > + - resets > + - reset-names > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/clock/starfive-jh7100.h> > + #include <dt-bindings/reset/starfive-jh7100.h> > + > + tmon@124a0000 { > + compatible = "starfive,jh7100-temp"; > + reg = <0x124a0000 0x10000>; > + clocks = <&clkgen JH7100_CLK_TEMP_SENSE>, > + <&clkgen JH7100_CLK_TEMP_APB>; > + clock-names = "sense", "bus"; > + #thermal-sensor-cells = <0>; > + interrupts = <122>; > + resets = <&rstgen JH7100_RSTN_TEMP_SENSE>, > + <&rstgen JH7100_RSTN_TEMP_APB>; > + reset-names = "sense", "bus"; > + };
WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <linux@roeck-us.net> To: Hal Feng <hal.feng@starfivetech.com> Cc: linux-hwmon@vger.kernel.org, linux-doc@vger.kernel.org, linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, Jean Delvare <jdelvare@suse.com>, Jonathan Corbet <corbet@lwn.net>, Conor Dooley <conor@kernel.org>, Paul Walmsley <paul.walmsley@sifive.com>, Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Emil Renner Berthing <emil.renner.berthing@canonical.com>, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 1/4] dt-bindings: hwmon: Add starfive,jh71x0-temp Date: Tue, 3 Jan 2023 14:14:05 -0800 [thread overview] Message-ID: <20230103221405.GA217696@roeck-us.net> (raw) In-Reply-To: <20230103013145.9570-2-hal.feng@starfivetech.com> On Tue, Jan 03, 2023 at 09:31:42AM +0800, Hal Feng wrote: > From: Emil Renner Berthing <kernel@esmil.dk> > > Add bindings for the temperature sensor on the StarFive JH7100 and > JH7110 SoCs. > > Signed-off-by: Emil Renner Berthing <kernel@esmil.dk> > Signed-off-by: Hal Feng <hal.feng@starfivetech.com> The previous version of this bindings document (v3, https://patchwork.kernel.org/project/linux-hwmon/patch/20210726171802.1052716-2-kernel@esmil.dk/ had been reviewed by Rob Herring. Even though this version is named differently (starfive,jh71x0-temp.yaml instead of starfive,jh7100-temp.yaml), the old version should be referenced, and there should be a change log. Guenter > --- > .../bindings/hwmon/starfive,jh71x0-temp.yaml | 75 +++++++++++++++++++ > 1 file changed, 75 insertions(+) > create mode 100644 Documentation/devicetree/bindings/hwmon/starfive,jh71x0-temp.yaml > > diff --git a/Documentation/devicetree/bindings/hwmon/starfive,jh71x0-temp.yaml b/Documentation/devicetree/bindings/hwmon/starfive,jh71x0-temp.yaml > new file mode 100644 > index 000000000000..2600881e2cdc > --- /dev/null > +++ b/Documentation/devicetree/bindings/hwmon/starfive,jh71x0-temp.yaml > @@ -0,0 +1,75 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/hwmon/starfive,jh71x0-temp.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: StarFive JH71x0 Temperature Sensor > + > +maintainers: > + - Emil Renner Berthing <kernel@esmil.dk> > + > +description: | > + StarFive Technology Co. JH71x0 embedded temperature sensor > + > +properties: > + compatible: > + enum: > + - starfive,jh7100-temp > + - starfive,jh7110-temp > + > + reg: > + maxItems: 1 > + > + clocks: > + minItems: 2 > + maxItems: 2 > + > + clock-names: > + items: > + - const: "sense" > + - const: "bus" > + > + '#thermal-sensor-cells': > + const: 0 > + > + interrupts: > + maxItems: 1 > + > + resets: > + minItems: 2 > + maxItems: 2 > + > + reset-names: > + items: > + - const: "sense" > + - const: "bus" > + > +required: > + - compatible > + - reg > + - clocks > + - clock-names > + - interrupts > + - resets > + - reset-names > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/clock/starfive-jh7100.h> > + #include <dt-bindings/reset/starfive-jh7100.h> > + > + tmon@124a0000 { > + compatible = "starfive,jh7100-temp"; > + reg = <0x124a0000 0x10000>; > + clocks = <&clkgen JH7100_CLK_TEMP_SENSE>, > + <&clkgen JH7100_CLK_TEMP_APB>; > + clock-names = "sense", "bus"; > + #thermal-sensor-cells = <0>; > + interrupts = <122>; > + resets = <&rstgen JH7100_RSTN_TEMP_SENSE>, > + <&rstgen JH7100_RSTN_TEMP_APB>; > + reset-names = "sense", "bus"; > + }; _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2023-01-03 22:14 UTC|newest] Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-01-03 1:31 [PATCH v1 0/4] Temperature sensor support for StarFive JH7110 RISC-V SoC Hal Feng 2023-01-03 1:31 ` Hal Feng 2023-01-03 1:31 ` [PATCH v1 1/4] dt-bindings: hwmon: Add starfive,jh71x0-temp Hal Feng 2023-01-03 1:31 ` Hal Feng 2023-01-03 22:14 ` Guenter Roeck [this message] 2023-01-03 22:14 ` Guenter Roeck 2023-02-06 17:16 ` Hal Feng 2023-02-06 17:16 ` Hal Feng 2023-01-03 1:31 ` [PATCH v1 2/4] hwmon: (sfctemp) Add StarFive JH71x0 temperature sensor Hal Feng 2023-01-03 1:31 ` Hal Feng 2023-01-03 22:10 ` Guenter Roeck 2023-01-03 22:10 ` Guenter Roeck 2023-02-06 17:12 ` Hal Feng 2023-02-06 17:12 ` Hal Feng 2023-02-06 19:21 ` Guenter Roeck 2023-02-06 19:21 ` Guenter Roeck 2023-02-08 12:40 ` Hal Feng 2023-02-08 12:40 ` Hal Feng 2023-02-08 15:16 ` Guenter Roeck 2023-02-08 15:16 ` Guenter Roeck 2023-02-09 6:20 ` Hal Feng 2023-02-09 6:20 ` Hal Feng 2023-01-03 1:31 ` [PATCH v1 3/4] riscv: dts: starfive: jh7110: Add temperature sensor node Hal Feng 2023-01-03 1:31 ` Hal Feng 2023-01-03 1:31 ` [PATCH v1 4/4] riscv: dts: starfive: visionfive-2: Add thermal-zones Hal Feng 2023-01-03 1:31 ` Hal Feng 2023-01-03 1:56 ` [PATCH v1 0/4] Temperature sensor support for StarFive JH7110 RISC-V SoC Guenter Roeck 2023-01-03 1:56 ` Guenter Roeck 2023-01-06 1:11 ` Hal Feng 2023-01-06 1:11 ` Hal Feng 2023-02-07 7:51 ` Hal Feng 2023-02-07 7:51 ` Hal Feng
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230103221405.GA217696@roeck-us.net \ --to=linux@roeck-us.net \ --cc=aou@eecs.berkeley.edu \ --cc=conor@kernel.org \ --cc=corbet@lwn.net \ --cc=devicetree@vger.kernel.org \ --cc=emil.renner.berthing@canonical.com \ --cc=hal.feng@starfivetech.com \ --cc=jdelvare@suse.com \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=linux-doc@vger.kernel.org \ --cc=linux-hwmon@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-riscv@lists.infradead.org \ --cc=palmer@dabbelt.com \ --cc=paul.walmsley@sifive.com \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.