* [PATCH] hw/display/xlnx_dp: fix underflow in xlnx_dp_aux_pop_tx_fifo()
@ 2023-01-05 11:53 Qiang Liu
0 siblings, 0 replies; only message in thread
From: Qiang Liu @ 2023-01-05 11:53 UTC (permalink / raw)
To: qemu-devel
Cc: Qiang Liu, Alistair Francis, Edgar E. Iglesias, Peter Maydell,
open list:Xilinx ZynqMP and...
Fixes: 58ac482a66de ("introduce xlnx-dp")
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1418
Reported-by: Qiang Liu <cyruscyliu@gmail.com>
Signed-off-by: Qiang Liu <cyruscyliu@gmail.com>
---
hw/display/xlnx_dp.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/hw/display/xlnx_dp.c b/hw/display/xlnx_dp.c
index 407518c870..322e2faadd 100644
--- a/hw/display/xlnx_dp.c
+++ b/hw/display/xlnx_dp.c
@@ -520,6 +520,10 @@ static void xlnx_dp_aux_set_command(XlnxDPState *s, uint32_t value)
case WRITE_AUX:
case WRITE_I2C:
case WRITE_I2C_MOT:
+ if (nbytes > fifo8_num_used(&s->tx_fifo)) {
+ qemu_log_mask(LOG_GUEST_ERROR, "xlnx_dp: TX length > fifo data length");
+ nbytes = fifo8_num_used(&s->tx_fifo);
+ }
for (i = 0; i < nbytes; i++) {
buf[i] = xlnx_dp_aux_pop_tx_fifo(s);
}
--
2.25.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2023-01-05 12:01 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-05 11:53 [PATCH] hw/display/xlnx_dp: fix underflow in xlnx_dp_aux_pop_tx_fifo() Qiang Liu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.