* [PATCH] ethtool: Replace 0-length array with flexible array
@ 2023-01-05 21:41 Kees Cook
2023-01-05 23:27 ` Jakub Kicinski
0 siblings, 1 reply; 3+ messages in thread
From: Kees Cook @ 2023-01-05 21:41 UTC (permalink / raw)
To: David S. Miller
Cc: Kees Cook, Jakub Kicinski, Andrew Lunn, kernel test robot,
Oleksij Rempel, Sean Anderson, Alexandru Tachici, Amit Cohen,
Gustavo A. R. Silva, Vincent Mailhol, linux-kernel,
linux-hardening
Zero-length arrays are deprecated[1]. Replace struct ethtool_rxnfc's
"rule_locs" 0-length array with a flexible array. Detected with GCC 13,
using -fstrict-flex-arrays=3:
net/ethtool/common.c: In function 'ethtool_get_max_rxnfc_channel':
net/ethtool/common.c:558:55: warning: array subscript i is outside array bounds of '__u32[0]' {aka 'unsigned int[]'} [-Warray-bounds=]
558 | .fs.location = info->rule_locs[i],
| ~~~~~~~~~~~~~~~^~~
In file included from include/linux/ethtool.h:19,
from include/uapi/linux/ethtool_netlink.h:12,
from include/linux/ethtool_netlink.h:6,
from net/ethtool/common.c:3:
include/uapi/linux/ethtool.h:1186:41: note: while referencing
'rule_locs'
1186 | __u32 rule_locs[0];
| ^~~~~~~~~
[1] https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Andrew Lunn <andrew@lunn.ch>
Cc: kernel test robot <lkp@intel.com>
Cc: Oleksij Rempel <linux@rempel-privat.de>
Cc: Sean Anderson <sean.anderson@seco.com>
Cc: Alexandru Tachici <alexandru.tachici@analog.com>
Cc: Amit Cohen <amcohen@nvidia.com>
Cc: "Gustavo A. R. Silva" <gustavoars@kernel.org>
Cc: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
Signed-off-by: Kees Cook <keescook@chromium.org>
---
include/uapi/linux/ethtool.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/uapi/linux/ethtool.h b/include/uapi/linux/ethtool.h
index 58e587ba0450..9b97b3e0ec1f 100644
--- a/include/uapi/linux/ethtool.h
+++ b/include/uapi/linux/ethtool.h
@@ -1183,7 +1183,7 @@ struct ethtool_rxnfc {
__u32 rule_cnt;
__u32 rss_context;
};
- __u32 rule_locs[0];
+ __DECLARE_FLEX_ARRAY(__u32, rule_locs);
};
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ethtool: Replace 0-length array with flexible array
2023-01-05 21:41 [PATCH] ethtool: Replace 0-length array with flexible array Kees Cook
@ 2023-01-05 23:27 ` Jakub Kicinski
2023-01-05 23:34 ` Kees Cook
0 siblings, 1 reply; 3+ messages in thread
From: Jakub Kicinski @ 2023-01-05 23:27 UTC (permalink / raw)
To: Kees Cook
Cc: David S. Miller, Andrew Lunn, kernel test robot, Oleksij Rempel,
Sean Anderson, Alexandru Tachici, Amit Cohen,
Gustavo A. R. Silva, Vincent Mailhol, linux-kernel,
linux-hardening
On Thu, 5 Jan 2023 13:41:34 -0800 Kees Cook wrote:
> Zero-length arrays are deprecated[1]. Replace struct ethtool_rxnfc's
> "rule_locs" 0-length array with a flexible array. Detected with GCC 13,
> using -fstrict-flex-arrays=3:
You gotta CC netdev to get it into patchwork etc.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ethtool: Replace 0-length array with flexible array
2023-01-05 23:27 ` Jakub Kicinski
@ 2023-01-05 23:34 ` Kees Cook
0 siblings, 0 replies; 3+ messages in thread
From: Kees Cook @ 2023-01-05 23:34 UTC (permalink / raw)
To: Jakub Kicinski
Cc: David S. Miller, Andrew Lunn, kernel test robot, Oleksij Rempel,
Sean Anderson, Alexandru Tachici, Amit Cohen,
Gustavo A. R. Silva, Vincent Mailhol, linux-kernel,
linux-hardening
On Thu, Jan 05, 2023 at 03:27:31PM -0800, Jakub Kicinski wrote:
> On Thu, 5 Jan 2023 13:41:34 -0800 Kees Cook wrote:
> > Zero-length arrays are deprecated[1]. Replace struct ethtool_rxnfc's
> > "rule_locs" 0-length array with a flexible array. Detected with GCC 13,
> > using -fstrict-flex-arrays=3:
>
> You gotta CC netdev to get it into patchwork etc.
Oops, thanks. I'm not sure how that went missing. v2 sent.
--
Kees Cook
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-01-05 23:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-05 21:41 [PATCH] ethtool: Replace 0-length array with flexible array Kees Cook
2023-01-05 23:27 ` Jakub Kicinski
2023-01-05 23:34 ` Kees Cook
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.