All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] fs/coredump: fix a compilation issue
@ 2023-01-06  7:13 oushixiong
  0 siblings, 0 replies; only message in thread
From: oushixiong @ 2023-01-06  7:13 UTC (permalink / raw)
  To: Alexander Viro; +Cc: linux-fsdevel, linux-kernel, oushixiong, k2ci

if CONFIG_ELF_CORE is not set,  it will cause a compilation issue:
   error: ‘dump_emit_page’ defined but not used.

Fixes: 06bbaa6dc53c "[coredump] don't use __kernel_write()"

Reported-by: k2ci <kernel-bot@kylinos.cn>
Signed-off-by: oushixiong <oushixiong@kylinos.cn>
---
 fs/coredump.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/fs/coredump.c b/fs/coredump.c
index de78bde2991b..95390a73b912 100644
--- a/fs/coredump.c
+++ b/fs/coredump.c
@@ -838,6 +838,7 @@ static int __dump_skip(struct coredump_params *cprm, size_t nr)
 	}
 }
 
+#ifdef CONFIG_ELF_CORE
 static int dump_emit_page(struct coredump_params *cprm, struct page *page)
 {
 	struct bio_vec bvec = {
@@ -870,6 +871,7 @@ static int dump_emit_page(struct coredump_params *cprm, struct page *page)
 
 	return 1;
 }
+#endif
 
 int dump_emit(struct coredump_params *cprm, const void *addr, int nr)
 {
-- 
2.25.1


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2023-01-06  7:13 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-06  7:13 [PATCH] fs/coredump: fix a compilation issue oushixiong

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.