All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: "Pali Rohár" <pali@kernel.org>
Cc: u-boot@lists.denx.de, Marek Vasut <marex@denx.de>,
	Patrick Delaunay <patrick.delaunay@foss.st.com>
Subject: Re: [PATCH] Revert "common/memsize.c: Fix get_effective_memsize() to check for overflow"
Date: Fri, 6 Jan 2023 12:25:24 -0500	[thread overview]
Message-ID: <20230106172524.GE3787616@bill-the-cat> (raw)
In-Reply-To: <20230106164543.3gtq73flpoocg7mc@pali>

[-- Attachment #1: Type: text/plain, Size: 1182 bytes --]

On Fri, Jan 06, 2023 at 05:45:43PM +0100, Pali Rohár wrote:
> On Friday 06 January 2023 10:51:43 Tom Rini wrote:
> > This reverts commit 777aaaa706bcfe08c284aed06886db7d482af3f8.
> > 
> > The changes to this generic function, which is intended to help with
> > 32bit platforms with large amounts of memory has unintended side effects
> > (which in turn lead to boot failures) on other platforms which were
> > previously functional.
> 
> As mentioned previously, unfortunately this revert breaks 32-bit u-boot
> on 36-bit mpc85xx boards with 32-bit e500v2 cores and 4GB DDR module.
> 
> Which platforms currently have broken u-boot without this revert? The
> only one which was reported is stm32mp but for it there different
> workaround patch waiting in the queue.

Are you able to test on one of these PowerPC platforms currently?  As
the stm32 problem shows, not everything is getting tested frequently
enough, so how many other cases are lurking out there.  And, I think
overall issue is that the overflow check-and-change you introduce here
should just be in the CONFIG_MAX_MEM_MAPPED==true case.  As that's the
case you're dealing with, yes?

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

  reply	other threads:[~2023-01-06 17:25 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-06 15:51 [PATCH] Revert "common/memsize.c: Fix get_effective_memsize() to check for overflow" Tom Rini
2023-01-06 16:45 ` Pali Rohár
2023-01-06 17:25   ` Tom Rini [this message]
2023-01-06 20:22     ` Pali Rohár
2023-01-06 21:14       ` Tom Rini
2023-01-06 21:45         ` Tom Rini
2023-01-06 22:09           ` Pali Rohár
2023-01-06 22:51             ` Tom Rini
2023-01-07 16:26               ` Pali Rohár
2023-01-07 17:32                 ` Tom Rini
2023-01-07 17:38                   ` Pali Rohár
2023-01-07 17:40                     ` Tom Rini
2023-01-07 17:44                       ` Pali Rohár
2023-01-07 17:46                         ` Tom Rini
2023-01-07 21:58                           ` Pali Rohár
2023-01-06 20:29 ` Fabio Estevam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230106172524.GE3787616@bill-the-cat \
    --to=trini@konsulko.com \
    --cc=marex@denx.de \
    --cc=pali@kernel.org \
    --cc=patrick.delaunay@foss.st.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.