All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@meta.com>
Cc: linux-nvme@lists.infradead.org, hch@lst.de, sagi@grimberg.me,
	Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCH 4/4] nvme: always initialize known command effects
Date: Sun, 8 Jan 2023 19:21:00 +0100	[thread overview]
Message-ID: <20230108182100.GA25544@lst.de> (raw)
In-Reply-To: <20230105202833.3225645-5-kbusch@meta.com>


> +static int nvme_init_effects(struct nvme_ctrl *ctrl, bool read_log)

.. this read_log argument really confused me ...

> +	ret = nvme_init_effects(ctrl, id->lpa & NVME_CTRL_LPA_CMD_EFFECTS_LOG);

.. until I saw this.

Any reason to not pass the nvme_id_ctrl to nvme_init_effects and
check the actual flag there?  That avoids losing the context through
that bool parameter.

The rest of this looks good to me.


  reply	other threads:[~2023-01-08 18:21 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-05 20:28 [PATCH 0/4] nvme patches for 6.3 Keith Busch
2023-01-05 20:28 ` [PATCH 1/4] nvme-pci: remove SGL segment descriptors Keith Busch
2023-01-09  7:07   ` Chaitanya Kulkarni
2023-02-13 10:15   ` Sagi Grimberg
2023-01-05 20:28 ` [PATCH 2/4] nvme-pci: use mapped entries for sgl decision Keith Busch
2023-01-09  7:09   ` Chaitanya Kulkarni
2023-01-05 20:28 ` [PATCH 3/4] nvme-pci: place descriptor addresses in iod Keith Busch
2023-02-13 10:19   ` Sagi Grimberg
2023-01-05 20:28 ` [PATCH 4/4] nvme: always initialize known command effects Keith Busch
2023-01-08 18:21   ` Christoph Hellwig [this message]
2023-01-08 18:22 ` [PATCH 0/4] nvme patches for 6.3 Christoph Hellwig
2023-02-10 14:34   ` Niklas Schnelle
2023-02-10 15:24     ` Keith Busch
2023-02-10 15:37       ` Keith Busch
2023-02-10 16:29         ` Niklas Schnelle
2023-02-10 17:14           ` Keith Busch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230108182100.GA25544@lst.de \
    --to=hch@lst.de \
    --cc=kbusch@kernel.org \
    --cc=kbusch@meta.com \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.