From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Keith Busch <kbusch@meta.com>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"hch@lst.de" <hch@lst.de>, "sagi@grimberg.me" <sagi@grimberg.me>
Cc: Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCH 2/4] nvme-pci: use mapped entries for sgl decision
Date: Mon, 9 Jan 2023 07:09:09 +0000 [thread overview]
Message-ID: <f892925a-8394-681f-bc05-8bb698916c8a@nvidia.com> (raw)
In-Reply-To: <20230105202833.3225645-3-kbusch@meta.com>
On 1/5/23 12:28, Keith Busch wrote:
> From: Keith Busch <kbusch@kernel.org>
>
> The driver uses the dma entries for setting up its command's SGL/PRP
> lists. The dma mapping might have fewer entries than the physical
> segments, so check the dma mapped count to determine which nvme data
> layout method is more optimal.
>
> Signed-off-by: Keith Busch <kbusch@kernel.org>
> Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
> ---
I vaguely remember a similar bug in this area where this actually happened
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
-ck
next prev parent reply other threads:[~2023-01-09 7:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-05 20:28 [PATCH 0/4] nvme patches for 6.3 Keith Busch
2023-01-05 20:28 ` [PATCH 1/4] nvme-pci: remove SGL segment descriptors Keith Busch
2023-01-09 7:07 ` Chaitanya Kulkarni
2023-02-13 10:15 ` Sagi Grimberg
2023-01-05 20:28 ` [PATCH 2/4] nvme-pci: use mapped entries for sgl decision Keith Busch
2023-01-09 7:09 ` Chaitanya Kulkarni [this message]
2023-01-05 20:28 ` [PATCH 3/4] nvme-pci: place descriptor addresses in iod Keith Busch
2023-02-13 10:19 ` Sagi Grimberg
2023-01-05 20:28 ` [PATCH 4/4] nvme: always initialize known command effects Keith Busch
2023-01-08 18:21 ` Christoph Hellwig
2023-01-08 18:22 ` [PATCH 0/4] nvme patches for 6.3 Christoph Hellwig
2023-02-10 14:34 ` Niklas Schnelle
2023-02-10 15:24 ` Keith Busch
2023-02-10 15:37 ` Keith Busch
2023-02-10 16:29 ` Niklas Schnelle
2023-02-10 17:14 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f892925a-8394-681f-bc05-8bb698916c8a@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=kbusch@meta.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.