All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Zimmermann <tzimmermann@suse.de>
To: alexander.deucher@amd.com, christian.koenig@amd.com,
	airlied@gmail.com, daniel@ffwll.ch,
	maarten.lankhorst@linux.intel.com, mripard@kernel.org,
	patrik.r.jakobsson@gmail.com, thierry.reding@gmail.com,
	sam@ravnborg.org, f.fainelli@gmail.com
Cc: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
	bcm-kernel-feedback-list@broadcom.com,
	linux-rpi-kernel@lists.infradead.org,
	Thomas Zimmermann <tzimmermann@suse.de>,
	linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/5] drm: Include <linux/of.h> in drm_modes.c
Date: Mon,  9 Jan 2023 11:12:43 +0100	[thread overview]
Message-ID: <20230109101243.26995-6-tzimmermann@suse.de> (raw)
In-Reply-To: <20230109101243.26995-1-tzimmermann@suse.de>

Include <linux/of.h> in drm_modes.c for of_property_read_u32(). Until
now, the OF header got included via <linux/fb.h>.

Also comment on the reason for still including <linux/fb.h>. The header
file is still required to get KHZ2PICOS(). The macro is part of the UAPI
headers, so it cannot be moved to a less prominent location.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
 drivers/gpu/drm/drm_modes.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c
index be030f4a5311..40d482a01178 100644
--- a/drivers/gpu/drm/drm_modes.c
+++ b/drivers/gpu/drm/drm_modes.c
@@ -31,10 +31,11 @@
  */
 
 #include <linux/ctype.h>
+#include <linux/export.h>
+#include <linux/fb.h> /* for KHZ2PICOS() */
 #include <linux/list.h>
 #include <linux/list_sort.h>
-#include <linux/export.h>
-#include <linux/fb.h>
+#include <linux/of.h>
 
 #include <video/of_display_timing.h>
 #include <video/of_videomode.h>
-- 
2.39.0


WARNING: multiple messages have this Message-ID (diff)
From: Thomas Zimmermann <tzimmermann@suse.de>
To: alexander.deucher@amd.com, christian.koenig@amd.com,
	airlied@gmail.com, daniel@ffwll.ch,
	maarten.lankhorst@linux.intel.com, mripard@kernel.org,
	patrik.r.jakobsson@gmail.com, thierry.reding@gmail.com,
	sam@ravnborg.org, f.fainelli@gmail.com
Cc: dri-devel@lists.freedesktop.org,
	bcm-kernel-feedback-list@broadcom.com,
	linux-rpi-kernel@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	amd-gfx@lists.freedesktop.org,
	Thomas Zimmermann <tzimmermann@suse.de>
Subject: [PATCH 5/5] drm: Include <linux/of.h> in drm_modes.c
Date: Mon,  9 Jan 2023 11:12:43 +0100	[thread overview]
Message-ID: <20230109101243.26995-6-tzimmermann@suse.de> (raw)
In-Reply-To: <20230109101243.26995-1-tzimmermann@suse.de>

Include <linux/of.h> in drm_modes.c for of_property_read_u32(). Until
now, the OF header got included via <linux/fb.h>.

Also comment on the reason for still including <linux/fb.h>. The header
file is still required to get KHZ2PICOS(). The macro is part of the UAPI
headers, so it cannot be moved to a less prominent location.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
 drivers/gpu/drm/drm_modes.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c
index be030f4a5311..40d482a01178 100644
--- a/drivers/gpu/drm/drm_modes.c
+++ b/drivers/gpu/drm/drm_modes.c
@@ -31,10 +31,11 @@
  */
 
 #include <linux/ctype.h>
+#include <linux/export.h>
+#include <linux/fb.h> /* for KHZ2PICOS() */
 #include <linux/list.h>
 #include <linux/list_sort.h>
-#include <linux/export.h>
-#include <linux/fb.h>
+#include <linux/of.h>
 
 #include <video/of_display_timing.h>
 #include <video/of_videomode.h>
-- 
2.39.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2023-01-09 10:13 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-09 10:12 [PATCH 0/5] drm: Do not include <linux/fb.h> unnecessarily Thomas Zimmermann
2023-01-09 10:12 ` Thomas Zimmermann
2023-01-09 10:12 ` [PATCH 1/5] drm: Include <linux/backlight.h> where needed Thomas Zimmermann
2023-01-09 10:12   ` Thomas Zimmermann
2023-01-09 10:29   ` Christian König
2023-01-09 10:29     ` Christian König
2023-01-09 10:12 ` [PATCH 2/5] drm: Don't include linux/fb.h in drm_crtc_helper.h Thomas Zimmermann
2023-01-09 10:12   ` Thomas Zimmermann
2023-01-09 12:16   ` kernel test robot
2023-01-09 12:16     ` kernel test robot
2023-01-09 13:17   ` kernel test robot
2023-01-09 13:17     ` kernel test robot
2023-01-09 10:12 ` [PATCH 3/5] drm/amdgpu: Do not include <linux/fb.h> Thomas Zimmermann
2023-01-09 10:12   ` Thomas Zimmermann
2023-01-09 10:30   ` Christian König
2023-01-09 10:30     ` Christian König
2023-01-09 10:12 ` [PATCH 4/5] drm/panel: " Thomas Zimmermann
2023-01-09 10:12   ` Thomas Zimmermann
2023-01-09 10:12 ` Thomas Zimmermann [this message]
2023-01-09 10:12   ` [PATCH 5/5] drm: Include <linux/of.h> in drm_modes.c Thomas Zimmermann
2023-01-13 10:36 ` [PATCH 0/5] drm: Do not include <linux/fb.h> unnecessarily Maxime Ripard
2023-01-13 10:36   ` Maxime Ripard
2023-01-13 10:36   ` Maxime Ripard
2023-01-13 12:10   ` Thomas Zimmermann
2023-01-13 12:10     ` Thomas Zimmermann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230109101243.26995-6-tzimmermann@suse.de \
    --to=tzimmermann@suse.de \
    --cc=airlied@gmail.com \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=christian.koenig@amd.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=f.fainelli@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-rpi-kernel@lists.infradead.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=patrik.r.jakobsson@gmail.com \
    --cc=sam@ravnborg.org \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.