* [PATCH net 1/1] net: stmmac: add aux timestamps fifo clearance wait
@ 2023-01-09 14:39 Noor Azura Ahmad Tarmizi
0 siblings, 0 replies; 8+ messages in thread
From: Noor Azura Ahmad Tarmizi @ 2023-01-09 14:39 UTC (permalink / raw)
To: Noor Azura Ahmad Tarmizi; +Cc: Noor Azura Ahmad Tarmizi, stable
Add timeout polling wait for auxiliary timestamps snapshot FIFO clear bit
(ATSFC) to clear. This is to ensure no residue fifo value is being read
erroneously.
Cc: <stable@vger.kernel.org> # 5.10.x
Signed-off-by: Noor Azura Ahmad Tarmizi <noor.azura.ahmad.tarmizi@intel.com>
---
drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c
index fc06ddeac0d5..b4388ca8d211 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c
@@ -210,7 +210,10 @@ static int stmmac_enable(struct ptp_clock_info *ptp,
}
writel(acr_value, ptpaddr + PTP_ACR);
mutex_unlock(&priv->aux_ts_lock);
- ret = 0;
+ /* wait for auxts fifo clear to finish */
+ ret = readl_poll_timeout(ptpaddr + PTP_ACR, acr_value,
+ !(acr_value & PTP_ACR_ATSFC),
+ 10, 10000);
break;
default:
--
2.17.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH net 1/1] net: stmmac: add aux timestamps fifo clearance wait
2023-01-10 10:27 ` Paolo Abeni
@ 2023-01-11 3:32 ` Noor Azura Ahmad Tarmizi
-1 siblings, 0 replies; 8+ messages in thread
From: Noor Azura Ahmad Tarmizi @ 2023-01-11 3:32 UTC (permalink / raw)
To: Paolo Abeni
Cc: Noor Azura Ahmad Tarmizi, David S . Miller, Giuseppe Cavallaro,
Alexandre Torgue, Jose Abreu, Eric Dumazet, Jakub Kicinski,
Maxime Coquelin, Richard Cochran, netdev, linux-stm32,
linux-arm-kernel, linux-kernel, Tan Tee Min, Looi Hong Aun,
Muhammad Husaini Zulkifli, stable
On Tue, Jan 10, 2023 at 11:27:47AM +0100, Paolo Abeni wrote:
> On Mon, 2023-01-09 at 23:15 +0800, Noor Azura Ahmad Tarmizi wrote:
> > Add timeout polling wait for auxiliary timestamps snapshot FIFO clear bit
> > (ATSFC) to clear. This is to ensure no residue fifo value is being read
> > erroneously.
> >
> > Cc: <stable@vger.kernel.org> # 5.10.x
> > Signed-off-by: Noor Azura Ahmad Tarmizi <noor.azura.ahmad.tarmizi@intel.com>
>
> Please post a new revision of this patch including a suitable 'Fixes'
> tag, thanks!
>
> Paolo
>
Ok Paolo, sorry i missed that out. Will send out v2 ASAP.
Thanks!
Azura
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH net 1/1] net: stmmac: add aux timestamps fifo clearance wait
@ 2023-01-11 3:32 ` Noor Azura Ahmad Tarmizi
0 siblings, 0 replies; 8+ messages in thread
From: Noor Azura Ahmad Tarmizi @ 2023-01-11 3:32 UTC (permalink / raw)
To: Paolo Abeni
Cc: Noor Azura Ahmad Tarmizi, David S . Miller, Giuseppe Cavallaro,
Alexandre Torgue, Jose Abreu, Eric Dumazet, Jakub Kicinski,
Maxime Coquelin, Richard Cochran, netdev, linux-stm32,
linux-arm-kernel, linux-kernel, Tan Tee Min, Looi Hong Aun,
Muhammad Husaini Zulkifli, stable
On Tue, Jan 10, 2023 at 11:27:47AM +0100, Paolo Abeni wrote:
> On Mon, 2023-01-09 at 23:15 +0800, Noor Azura Ahmad Tarmizi wrote:
> > Add timeout polling wait for auxiliary timestamps snapshot FIFO clear bit
> > (ATSFC) to clear. This is to ensure no residue fifo value is being read
> > erroneously.
> >
> > Cc: <stable@vger.kernel.org> # 5.10.x
> > Signed-off-by: Noor Azura Ahmad Tarmizi <noor.azura.ahmad.tarmizi@intel.com>
>
> Please post a new revision of this patch including a suitable 'Fixes'
> tag, thanks!
>
> Paolo
>
Ok Paolo, sorry i missed that out. Will send out v2 ASAP.
Thanks!
Azura
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH net 1/1] net: stmmac: add aux timestamps fifo clearance wait
2023-01-09 15:15 ` Noor Azura Ahmad Tarmizi
@ 2023-01-10 10:27 ` Paolo Abeni
-1 siblings, 0 replies; 8+ messages in thread
From: Paolo Abeni @ 2023-01-10 10:27 UTC (permalink / raw)
To: Noor Azura Ahmad Tarmizi, David S . Miller, Giuseppe Cavallaro,
Alexandre Torgue, Jose Abreu, Eric Dumazet, Jakub Kicinski,
Maxime Coquelin, Richard Cochran
Cc: netdev, linux-stm32, linux-arm-kernel, linux-kernel,
Noor Azura Ahmad Tarmizi, Tan Tee Min, Looi Hong Aun,
Muhammad Husaini Zulkifli, stable
On Mon, 2023-01-09 at 23:15 +0800, Noor Azura Ahmad Tarmizi wrote:
> Add timeout polling wait for auxiliary timestamps snapshot FIFO clear bit
> (ATSFC) to clear. This is to ensure no residue fifo value is being read
> erroneously.
>
> Cc: <stable@vger.kernel.org> # 5.10.x
> Signed-off-by: Noor Azura Ahmad Tarmizi <noor.azura.ahmad.tarmizi@intel.com>
Please post a new revision of this patch including a suitable 'Fixes'
tag, thanks!
Paolo
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH net 1/1] net: stmmac: add aux timestamps fifo clearance wait
@ 2023-01-10 10:27 ` Paolo Abeni
0 siblings, 0 replies; 8+ messages in thread
From: Paolo Abeni @ 2023-01-10 10:27 UTC (permalink / raw)
To: Noor Azura Ahmad Tarmizi, David S . Miller, Giuseppe Cavallaro,
Alexandre Torgue, Jose Abreu, Eric Dumazet, Jakub Kicinski,
Maxime Coquelin, Richard Cochran
Cc: netdev, linux-stm32, linux-arm-kernel, linux-kernel,
Noor Azura Ahmad Tarmizi, Tan Tee Min, Looi Hong Aun,
Muhammad Husaini Zulkifli, stable
On Mon, 2023-01-09 at 23:15 +0800, Noor Azura Ahmad Tarmizi wrote:
> Add timeout polling wait for auxiliary timestamps snapshot FIFO clear bit
> (ATSFC) to clear. This is to ensure no residue fifo value is being read
> erroneously.
>
> Cc: <stable@vger.kernel.org> # 5.10.x
> Signed-off-by: Noor Azura Ahmad Tarmizi <noor.azura.ahmad.tarmizi@intel.com>
Please post a new revision of this patch including a suitable 'Fixes'
tag, thanks!
Paolo
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH net 1/1] net: stmmac: add aux timestamps fifo clearance wait
@ 2023-01-09 15:15 ` Noor Azura Ahmad Tarmizi
0 siblings, 0 replies; 8+ messages in thread
From: Noor Azura Ahmad Tarmizi @ 2023-01-09 15:15 UTC (permalink / raw)
To: David S . Miller, Giuseppe Cavallaro, Alexandre Torgue,
Jose Abreu, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Maxime Coquelin, Richard Cochran
Cc: netdev, linux-stm32, linux-arm-kernel, linux-kernel,
Noor Azura Ahmad Tarmizi, Tan Tee Min, Looi Hong Aun,
Muhammad Husaini Zulkifli, Noor Azura Ahmad Tarmizi, stable
Add timeout polling wait for auxiliary timestamps snapshot FIFO clear bit
(ATSFC) to clear. This is to ensure no residue fifo value is being read
erroneously.
Cc: <stable@vger.kernel.org> # 5.10.x
Signed-off-by: Noor Azura Ahmad Tarmizi <noor.azura.ahmad.tarmizi@intel.com>
---
drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c
index fc06ddeac0d5..b4388ca8d211 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c
@@ -210,7 +210,10 @@ static int stmmac_enable(struct ptp_clock_info *ptp,
}
writel(acr_value, ptpaddr + PTP_ACR);
mutex_unlock(&priv->aux_ts_lock);
- ret = 0;
+ /* wait for auxts fifo clear to finish */
+ ret = readl_poll_timeout(ptpaddr + PTP_ACR, acr_value,
+ !(acr_value & PTP_ACR_ATSFC),
+ 10, 10000);
break;
default:
--
2.17.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH net 1/1] net: stmmac: add aux timestamps fifo clearance wait
@ 2023-01-09 15:15 ` Noor Azura Ahmad Tarmizi
0 siblings, 0 replies; 8+ messages in thread
From: Noor Azura Ahmad Tarmizi @ 2023-01-09 15:15 UTC (permalink / raw)
To: David S . Miller, Giuseppe Cavallaro, Alexandre Torgue,
Jose Abreu, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Maxime Coquelin, Richard Cochran
Cc: netdev, linux-stm32, linux-arm-kernel, linux-kernel,
Noor Azura Ahmad Tarmizi, Tan Tee Min, Looi Hong Aun,
Muhammad Husaini Zulkifli, Noor Azura Ahmad Tarmizi, stable
Add timeout polling wait for auxiliary timestamps snapshot FIFO clear bit
(ATSFC) to clear. This is to ensure no residue fifo value is being read
erroneously.
Cc: <stable@vger.kernel.org> # 5.10.x
Signed-off-by: Noor Azura Ahmad Tarmizi <noor.azura.ahmad.tarmizi@intel.com>
---
drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c
index fc06ddeac0d5..b4388ca8d211 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c
@@ -210,7 +210,10 @@ static int stmmac_enable(struct ptp_clock_info *ptp,
}
writel(acr_value, ptpaddr + PTP_ACR);
mutex_unlock(&priv->aux_ts_lock);
- ret = 0;
+ /* wait for auxts fifo clear to finish */
+ ret = readl_poll_timeout(ptpaddr + PTP_ACR, acr_value,
+ !(acr_value & PTP_ACR_ATSFC),
+ 10, 10000);
break;
default:
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH net 1/1] net: stmmac: add aux timestamps fifo clearance wait
@ 2023-01-09 15:14 Noor Azura Ahmad Tarmizi
0 siblings, 0 replies; 8+ messages in thread
From: Noor Azura Ahmad Tarmizi @ 2023-01-09 15:14 UTC (permalink / raw)
To: Noor Azura Ahmad Tarmizi; +Cc: Noor Azura Ahmad Tarmizi, stable
Add timeout polling wait for auxiliary timestamps snapshot FIFO clear bit
(ATSFC) to clear. This is to ensure no residue fifo value is being read
erroneously.
Cc: <stable@vger.kernel.org> # 5.10.x
Signed-off-by: Noor Azura Ahmad Tarmizi <noor.azura.ahmad.tarmizi@intel.com>
---
drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c
index fc06ddeac0d5..b4388ca8d211 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c
@@ -210,7 +210,10 @@ static int stmmac_enable(struct ptp_clock_info *ptp,
}
writel(acr_value, ptpaddr + PTP_ACR);
mutex_unlock(&priv->aux_ts_lock);
- ret = 0;
+ /* wait for auxts fifo clear to finish */
+ ret = readl_poll_timeout(ptpaddr + PTP_ACR, acr_value,
+ !(acr_value & PTP_ACR_ATSFC),
+ 10, 10000);
break;
default:
--
2.17.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
end of thread, other threads:[~2023-01-11 3:46 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-09 14:39 [PATCH net 1/1] net: stmmac: add aux timestamps fifo clearance wait Noor Azura Ahmad Tarmizi
2023-01-09 15:14 Noor Azura Ahmad Tarmizi
2023-01-09 15:15 Noor Azura Ahmad Tarmizi
2023-01-09 15:15 ` Noor Azura Ahmad Tarmizi
2023-01-10 10:27 ` Paolo Abeni
2023-01-10 10:27 ` Paolo Abeni
2023-01-11 3:32 ` Noor Azura Ahmad Tarmizi
2023-01-11 3:32 ` Noor Azura Ahmad Tarmizi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.