* [PATCH v3 0/5] dt-bindings: usb: Convert some more simple OHCI/EHCI bindings
@ 2023-01-24 3:05 ` Rob Herring
0 siblings, 0 replies; 20+ messages in thread
From: Rob Herring @ 2023-01-24 3:05 UTC (permalink / raw)
To: Greg Kroah-Hartman, Krzysztof Kozlowski, Michael Ellerman,
Nicholas Piggin, Christophe Leroy, Avi Fishman, Tomer Maimon,
Tali Perry, Patrick Venture, Nancy Yuen, Benjamin Fair,
Lee Jones
Cc: devicetree, openbmc, linux-usb, linuxppc-dev, linux-kernel
The 'ohci-usb' compatible is another 'generic' compatible for OHCI, but
isn't documented with a schema. Let's add it to generic-ohci.yaml
schema. While looking at this, I found a few other USB host bindings
which are simple enough to use the 'generic' schemas.
Signed-off-by: Rob Herring <robh@kernel.org>
---
Changes in v3:
- Fix document references to generic-ehci.yaml and generic-ohci.yaml
- Link to v2: https://lore.kernel.org/r/20230110-dt-usb-v2-0-926bc1260e51@kernel.org
Changes in v2:
- Fix schema error for 'transceiver'
- Split OMAP changes to separate patch and convert omap-ehci
- Link to v1: https://lore.kernel.org/r/20230110-dt-usb-v1-0-8e366e326513@kernel.org
---
Rob Herring (5):
dt-bindings: usb: Remove obsolete brcm,bcm3384-usb.txt
dt-bindings: usb: Convert multiple "usb-ohci" bindings to DT schema
dt-bindings: usb: Convert OMAP OHCI/EHCI bindings to schema
dt-bindings: usb: Convert Marvell Orion EHCI to DT schema
dt-bindings: usb: Convert Nuvoton EHCI to DT schema
.../devicetree/bindings/mfd/omap-usb-host.txt | 8 ++---
.../devicetree/bindings/powerpc/nintendo/wii.txt | 10 -------
.../devicetree/bindings/usb/brcm,bcm3384-usb.txt | 11 -------
.../devicetree/bindings/usb/ehci-omap.txt | 31 -------------------
.../devicetree/bindings/usb/ehci-orion.txt | 22 --------------
.../devicetree/bindings/usb/generic-ehci.yaml | 5 ++++
.../devicetree/bindings/usb/generic-ohci.yaml | 32 +++++++++++++++++---
.../devicetree/bindings/usb/npcm7xx-usb.txt | 20 -------------
Documentation/devicetree/bindings/usb/ohci-nxp.txt | 24 ---------------
.../devicetree/bindings/usb/ohci-omap3.txt | 15 ----------
Documentation/devicetree/bindings/usb/pxa-usb.txt | 2 +-
.../devicetree/bindings/usb/spear-usb.txt | 35 ----------------------
12 files changed, 38 insertions(+), 177 deletions(-)
---
base-commit: 1b929c02afd37871d5afb9d498426f83432e71c2
change-id: 20230110-dt-usb-1c637752a83b
Best regards,
--
Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 20+ messages in thread* [PATCH v3 1/5] dt-bindings: usb: Remove obsolete brcm,bcm3384-usb.txt
2023-01-24 3:05 ` Rob Herring
@ 2023-01-24 3:05 ` Rob Herring
-1 siblings, 0 replies; 20+ messages in thread
From: Rob Herring @ 2023-01-24 3:05 UTC (permalink / raw)
To: Greg Kroah-Hartman, Krzysztof Kozlowski, Michael Ellerman,
Nicholas Piggin, Christophe Leroy, Avi Fishman, Tomer Maimon,
Tali Perry, Patrick Venture, Nancy Yuen, Benjamin Fair,
Lee Jones
Cc: linux-usb, devicetree, linux-kernel, linuxppc-dev, openbmc
The "brcm,bcm3384-ohci" and "brcm,bcm3384-ehci" compatibles are already
documented in generic-ohci.yaml and generic-ehci.yaml, respectively, so
remove the old txt binding.
Signed-off-by: Rob Herring <robh@kernel.org>
---
Documentation/devicetree/bindings/usb/brcm,bcm3384-usb.txt | 11 -----------
1 file changed, 11 deletions(-)
diff --git a/Documentation/devicetree/bindings/usb/brcm,bcm3384-usb.txt b/Documentation/devicetree/bindings/usb/brcm,bcm3384-usb.txt
deleted file mode 100644
index 452c45c7bf29..000000000000
--- a/Documentation/devicetree/bindings/usb/brcm,bcm3384-usb.txt
+++ /dev/null
@@ -1,11 +0,0 @@
-* Broadcom USB controllers
-
-Required properties:
-- compatible: "brcm,bcm3384-ohci", "brcm,bcm3384-ehci"
-
- These currently use the generic-ohci and generic-ehci drivers. On some
- systems, special handling may be needed in the following cases:
-
- - Restoring state after systemwide power save modes
- - Sharing PHYs with the USBD (UDC) hardware
- - Figuring out which controllers are disabled on ASIC bondout variants
--
2.39.0
^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCH v3 1/5] dt-bindings: usb: Remove obsolete brcm,bcm3384-usb.txt
@ 2023-01-24 3:05 ` Rob Herring
0 siblings, 0 replies; 20+ messages in thread
From: Rob Herring @ 2023-01-24 3:05 UTC (permalink / raw)
To: Greg Kroah-Hartman, Krzysztof Kozlowski, Michael Ellerman,
Nicholas Piggin, Christophe Leroy, Avi Fishman, Tomer Maimon,
Tali Perry, Patrick Venture, Nancy Yuen, Benjamin Fair,
Lee Jones
Cc: devicetree, openbmc, linux-usb, linuxppc-dev, linux-kernel
The "brcm,bcm3384-ohci" and "brcm,bcm3384-ehci" compatibles are already
documented in generic-ohci.yaml and generic-ehci.yaml, respectively, so
remove the old txt binding.
Signed-off-by: Rob Herring <robh@kernel.org>
---
Documentation/devicetree/bindings/usb/brcm,bcm3384-usb.txt | 11 -----------
1 file changed, 11 deletions(-)
diff --git a/Documentation/devicetree/bindings/usb/brcm,bcm3384-usb.txt b/Documentation/devicetree/bindings/usb/brcm,bcm3384-usb.txt
deleted file mode 100644
index 452c45c7bf29..000000000000
--- a/Documentation/devicetree/bindings/usb/brcm,bcm3384-usb.txt
+++ /dev/null
@@ -1,11 +0,0 @@
-* Broadcom USB controllers
-
-Required properties:
-- compatible: "brcm,bcm3384-ohci", "brcm,bcm3384-ehci"
-
- These currently use the generic-ohci and generic-ehci drivers. On some
- systems, special handling may be needed in the following cases:
-
- - Restoring state after systemwide power save modes
- - Sharing PHYs with the USBD (UDC) hardware
- - Figuring out which controllers are disabled on ASIC bondout variants
--
2.39.0
^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCH v3 2/5] dt-bindings: usb: Convert multiple "usb-ohci" bindings to DT schema
2023-01-24 3:05 ` Rob Herring
@ 2023-01-24 3:05 ` Rob Herring
-1 siblings, 0 replies; 20+ messages in thread
From: Rob Herring @ 2023-01-24 3:05 UTC (permalink / raw)
To: Greg Kroah-Hartman, Krzysztof Kozlowski, Michael Ellerman,
Nicholas Piggin, Christophe Leroy, Avi Fishman, Tomer Maimon,
Tali Perry, Patrick Venture, Nancy Yuen, Benjamin Fair,
Lee Jones
Cc: linux-usb, devicetree, linux-kernel, linuxppc-dev, openbmc
"usb-ohci" is another "generic" OHCI controller compatible string used by
several platforms. Add it to the generic-ohci.yaml schema and remove all
the old binding docs.
Marvell pxa-usb.txt has "usb-ohci" in the example, but actual users don't,
so drop it.
Signed-off-by: Rob Herring <robh@kernel.org>
---
v2:
- Fix transceiver property in if/then schema
- Move OMAP to separate patch
---
.../devicetree/bindings/powerpc/nintendo/wii.txt | 10 -------
.../devicetree/bindings/usb/generic-ohci.yaml | 28 +++++++++++++++--
Documentation/devicetree/bindings/usb/ohci-nxp.txt | 24 ---------------
Documentation/devicetree/bindings/usb/pxa-usb.txt | 2 +-
.../devicetree/bindings/usb/spear-usb.txt | 35 ----------------------
5 files changed, 26 insertions(+), 73 deletions(-)
diff --git a/Documentation/devicetree/bindings/powerpc/nintendo/wii.txt b/Documentation/devicetree/bindings/powerpc/nintendo/wii.txt
index c4d78f28d23c..3ff6ebbb4998 100644
--- a/Documentation/devicetree/bindings/powerpc/nintendo/wii.txt
+++ b/Documentation/devicetree/bindings/powerpc/nintendo/wii.txt
@@ -97,16 +97,6 @@ Nintendo Wii device tree
- reg : should contain the EXI registers location and length
- interrupts : should contain the EXI interrupt
-1.g) The Open Host Controller Interface (OHCI) nodes
-
- Represent the USB 1.x Open Host Controller Interfaces.
-
- Required properties:
-
- - compatible : should be "nintendo,hollywood-usb-ohci","usb-ohci"
- - reg : should contain the OHCI registers location and length
- - interrupts : should contain the OHCI interrupt
-
1.h) The Enhanced Host Controller Interface (EHCI) node
Represents the USB 2.0 Enhanced Host Controller Interface.
diff --git a/Documentation/devicetree/bindings/usb/generic-ohci.yaml b/Documentation/devicetree/bindings/usb/generic-ohci.yaml
index 4fcbd0add49d..8492d809ba40 100644
--- a/Documentation/devicetree/bindings/usb/generic-ohci.yaml
+++ b/Documentation/devicetree/bindings/usb/generic-ohci.yaml
@@ -6,9 +6,6 @@ $schema: http://devicetree.org/meta-schemas/core.yaml#
title: USB OHCI Controller
-allOf:
- - $ref: "usb-hcd.yaml"
-
maintainers:
- Greg Kroah-Hartman <gregkh@linuxfoundation.org>
@@ -50,6 +47,13 @@ properties:
- snps,hsdk-v1.0-ohci
- const: generic-ohci
- const: generic-ohci
+ - items:
+ - enum:
+ - cavium,octeon-6335-ohci
+ - nintendo,hollywood-usb-ohci
+ - nxp,ohci-nxp
+ - st,spear600-ohci
+ - const: usb-ohci
reg:
maxItems: 1
@@ -119,11 +123,29 @@ properties:
- host
- otg
+ transceiver:
+ $ref: /schemas/types.yaml#/definitions/phandle
+ description:
+ The associated ISP1301 device. Necessary for the UDC controller for
+ connecting to the USB physical layer.
+
required:
- compatible
- reg
- interrupts
+allOf:
+ - $ref: usb-hcd.yaml
+ - if:
+ not:
+ properties:
+ compatible:
+ contains:
+ const: nxp,ohci-nxp
+ then:
+ properties:
+ transceiver: false
+
additionalProperties: false
examples:
diff --git a/Documentation/devicetree/bindings/usb/ohci-nxp.txt b/Documentation/devicetree/bindings/usb/ohci-nxp.txt
deleted file mode 100644
index 71e28c1017ed..000000000000
--- a/Documentation/devicetree/bindings/usb/ohci-nxp.txt
+++ /dev/null
@@ -1,24 +0,0 @@
-* OHCI controller, NXP ohci-nxp variant
-
-Required properties:
-- compatible: must be "nxp,ohci-nxp"
-- reg: physical base address of the controller and length of memory mapped
- region.
-- interrupts: The OHCI interrupt
-- transceiver: phandle of the associated ISP1301 device - this is necessary for
- the UDC controller for connecting to the USB physical layer
-
-Example (LPC32xx):
-
- isp1301: usb-transceiver@2c {
- compatible = "nxp,isp1301";
- reg = <0x2c>;
- };
-
- ohci@31020000 {
- compatible = "nxp,ohci-nxp";
- reg = <0x31020000 0x300>;
- interrupt-parent = <&mic>;
- interrupts = <0x3b 0>;
- transceiver = <&isp1301>;
- };
diff --git a/Documentation/devicetree/bindings/usb/pxa-usb.txt b/Documentation/devicetree/bindings/usb/pxa-usb.txt
index 9c331799b87c..53fdae4fa6f6 100644
--- a/Documentation/devicetree/bindings/usb/pxa-usb.txt
+++ b/Documentation/devicetree/bindings/usb/pxa-usb.txt
@@ -22,7 +22,7 @@ Optional properties:
Example:
usb0: ohci@4c000000 {
- compatible = "marvell,pxa-ohci", "usb-ohci";
+ compatible = "marvell,pxa-ohci";
reg = <0x4c000000 0x100000>;
interrupts = <18>;
marvell,enable-port1;
diff --git a/Documentation/devicetree/bindings/usb/spear-usb.txt b/Documentation/devicetree/bindings/usb/spear-usb.txt
deleted file mode 100644
index 1dc91cc459c0..000000000000
--- a/Documentation/devicetree/bindings/usb/spear-usb.txt
+++ /dev/null
@@ -1,35 +0,0 @@
-ST SPEAr SoC USB controllers:
------------------------------
-
-EHCI:
------
-
-Required properties:
-- compatible: "st,spear600-ehci"
-- interrupts: Should contain the EHCI interrupt
-
-Example:
-
- ehci@e1800000 {
- compatible = "st,spear600-ehci", "usb-ehci";
- reg = <0xe1800000 0x1000>;
- interrupt-parent = <&vic1>;
- interrupts = <27>;
- };
-
-
-OHCI:
------
-
-Required properties:
-- compatible: "st,spear600-ohci"
-- interrupts: Should contain the OHCI interrupt
-
-Example:
-
- ohci@e1900000 {
- compatible = "st,spear600-ohci", "usb-ohci";
- reg = <0xe1800000 0x1000>;
- interrupt-parent = <&vic1>;
- interrupts = <26>;
- };
--
2.39.0
^ permalink raw reply related [flat|nested] 20+ messages in thread* [PATCH v3 2/5] dt-bindings: usb: Convert multiple "usb-ohci" bindings to DT schema
@ 2023-01-24 3:05 ` Rob Herring
0 siblings, 0 replies; 20+ messages in thread
From: Rob Herring @ 2023-01-24 3:05 UTC (permalink / raw)
To: Greg Kroah-Hartman, Krzysztof Kozlowski, Michael Ellerman,
Nicholas Piggin, Christophe Leroy, Avi Fishman, Tomer Maimon,
Tali Perry, Patrick Venture, Nancy Yuen, Benjamin Fair,
Lee Jones
Cc: devicetree, openbmc, linux-usb, linuxppc-dev, linux-kernel
"usb-ohci" is another "generic" OHCI controller compatible string used by
several platforms. Add it to the generic-ohci.yaml schema and remove all
the old binding docs.
Marvell pxa-usb.txt has "usb-ohci" in the example, but actual users don't,
so drop it.
Signed-off-by: Rob Herring <robh@kernel.org>
---
v2:
- Fix transceiver property in if/then schema
- Move OMAP to separate patch
---
.../devicetree/bindings/powerpc/nintendo/wii.txt | 10 -------
.../devicetree/bindings/usb/generic-ohci.yaml | 28 +++++++++++++++--
Documentation/devicetree/bindings/usb/ohci-nxp.txt | 24 ---------------
Documentation/devicetree/bindings/usb/pxa-usb.txt | 2 +-
.../devicetree/bindings/usb/spear-usb.txt | 35 ----------------------
5 files changed, 26 insertions(+), 73 deletions(-)
diff --git a/Documentation/devicetree/bindings/powerpc/nintendo/wii.txt b/Documentation/devicetree/bindings/powerpc/nintendo/wii.txt
index c4d78f28d23c..3ff6ebbb4998 100644
--- a/Documentation/devicetree/bindings/powerpc/nintendo/wii.txt
+++ b/Documentation/devicetree/bindings/powerpc/nintendo/wii.txt
@@ -97,16 +97,6 @@ Nintendo Wii device tree
- reg : should contain the EXI registers location and length
- interrupts : should contain the EXI interrupt
-1.g) The Open Host Controller Interface (OHCI) nodes
-
- Represent the USB 1.x Open Host Controller Interfaces.
-
- Required properties:
-
- - compatible : should be "nintendo,hollywood-usb-ohci","usb-ohci"
- - reg : should contain the OHCI registers location and length
- - interrupts : should contain the OHCI interrupt
-
1.h) The Enhanced Host Controller Interface (EHCI) node
Represents the USB 2.0 Enhanced Host Controller Interface.
diff --git a/Documentation/devicetree/bindings/usb/generic-ohci.yaml b/Documentation/devicetree/bindings/usb/generic-ohci.yaml
index 4fcbd0add49d..8492d809ba40 100644
--- a/Documentation/devicetree/bindings/usb/generic-ohci.yaml
+++ b/Documentation/devicetree/bindings/usb/generic-ohci.yaml
@@ -6,9 +6,6 @@ $schema: http://devicetree.org/meta-schemas/core.yaml#
title: USB OHCI Controller
-allOf:
- - $ref: "usb-hcd.yaml"
-
maintainers:
- Greg Kroah-Hartman <gregkh@linuxfoundation.org>
@@ -50,6 +47,13 @@ properties:
- snps,hsdk-v1.0-ohci
- const: generic-ohci
- const: generic-ohci
+ - items:
+ - enum:
+ - cavium,octeon-6335-ohci
+ - nintendo,hollywood-usb-ohci
+ - nxp,ohci-nxp
+ - st,spear600-ohci
+ - const: usb-ohci
reg:
maxItems: 1
@@ -119,11 +123,29 @@ properties:
- host
- otg
+ transceiver:
+ $ref: /schemas/types.yaml#/definitions/phandle
+ description:
+ The associated ISP1301 device. Necessary for the UDC controller for
+ connecting to the USB physical layer.
+
required:
- compatible
- reg
- interrupts
+allOf:
+ - $ref: usb-hcd.yaml
+ - if:
+ not:
+ properties:
+ compatible:
+ contains:
+ const: nxp,ohci-nxp
+ then:
+ properties:
+ transceiver: false
+
additionalProperties: false
examples:
diff --git a/Documentation/devicetree/bindings/usb/ohci-nxp.txt b/Documentation/devicetree/bindings/usb/ohci-nxp.txt
deleted file mode 100644
index 71e28c1017ed..000000000000
--- a/Documentation/devicetree/bindings/usb/ohci-nxp.txt
+++ /dev/null
@@ -1,24 +0,0 @@
-* OHCI controller, NXP ohci-nxp variant
-
-Required properties:
-- compatible: must be "nxp,ohci-nxp"
-- reg: physical base address of the controller and length of memory mapped
- region.
-- interrupts: The OHCI interrupt
-- transceiver: phandle of the associated ISP1301 device - this is necessary for
- the UDC controller for connecting to the USB physical layer
-
-Example (LPC32xx):
-
- isp1301: usb-transceiver@2c {
- compatible = "nxp,isp1301";
- reg = <0x2c>;
- };
-
- ohci@31020000 {
- compatible = "nxp,ohci-nxp";
- reg = <0x31020000 0x300>;
- interrupt-parent = <&mic>;
- interrupts = <0x3b 0>;
- transceiver = <&isp1301>;
- };
diff --git a/Documentation/devicetree/bindings/usb/pxa-usb.txt b/Documentation/devicetree/bindings/usb/pxa-usb.txt
index 9c331799b87c..53fdae4fa6f6 100644
--- a/Documentation/devicetree/bindings/usb/pxa-usb.txt
+++ b/Documentation/devicetree/bindings/usb/pxa-usb.txt
@@ -22,7 +22,7 @@ Optional properties:
Example:
usb0: ohci@4c000000 {
- compatible = "marvell,pxa-ohci", "usb-ohci";
+ compatible = "marvell,pxa-ohci";
reg = <0x4c000000 0x100000>;
interrupts = <18>;
marvell,enable-port1;
diff --git a/Documentation/devicetree/bindings/usb/spear-usb.txt b/Documentation/devicetree/bindings/usb/spear-usb.txt
deleted file mode 100644
index 1dc91cc459c0..000000000000
--- a/Documentation/devicetree/bindings/usb/spear-usb.txt
+++ /dev/null
@@ -1,35 +0,0 @@
-ST SPEAr SoC USB controllers:
------------------------------
-
-EHCI:
------
-
-Required properties:
-- compatible: "st,spear600-ehci"
-- interrupts: Should contain the EHCI interrupt
-
-Example:
-
- ehci@e1800000 {
- compatible = "st,spear600-ehci", "usb-ehci";
- reg = <0xe1800000 0x1000>;
- interrupt-parent = <&vic1>;
- interrupts = <27>;
- };
-
-
-OHCI:
------
-
-Required properties:
-- compatible: "st,spear600-ohci"
-- interrupts: Should contain the OHCI interrupt
-
-Example:
-
- ohci@e1900000 {
- compatible = "st,spear600-ohci", "usb-ohci";
- reg = <0xe1800000 0x1000>;
- interrupt-parent = <&vic1>;
- interrupts = <26>;
- };
--
2.39.0
^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCH v3 3/5] dt-bindings: usb: Convert OMAP OHCI/EHCI bindings to schema
2023-01-24 3:05 ` Rob Herring
@ 2023-01-24 3:05 ` Rob Herring
-1 siblings, 0 replies; 20+ messages in thread
From: Rob Herring @ 2023-01-24 3:05 UTC (permalink / raw)
To: Greg Kroah-Hartman, Krzysztof Kozlowski, Michael Ellerman,
Nicholas Piggin, Christophe Leroy, Avi Fishman, Tomer Maimon,
Tali Perry, Patrick Venture, Nancy Yuen, Benjamin Fair,
Lee Jones
Cc: linux-usb, devicetree, linux-kernel, linuxppc-dev, openbmc
The OMAP OHCI and EHCI USB host bindings follow the generic binding, so
add the compatibles and remove the old txt binding docs.
The examples in omap-usb-host.txt don't match actual users, so update
them dropping the fallback compatible.
Signed-off-by: Rob Herring <robh@kernel.org>
---
v3:
- Fix document references to generic-ehci.yaml and generic-ohci.yaml (0-day)
v2:
- New patch
---
.../devicetree/bindings/mfd/omap-usb-host.txt | 8 +++---
.../devicetree/bindings/usb/ehci-omap.txt | 31 ----------------------
.../devicetree/bindings/usb/generic-ehci.yaml | 1 +
.../devicetree/bindings/usb/generic-ohci.yaml | 4 ++-
.../devicetree/bindings/usb/ohci-omap3.txt | 15 -----------
5 files changed, 8 insertions(+), 51 deletions(-)
diff --git a/Documentation/devicetree/bindings/mfd/omap-usb-host.txt b/Documentation/devicetree/bindings/mfd/omap-usb-host.txt
index aa1eaa59581b..a0d8c30c2631 100644
--- a/Documentation/devicetree/bindings/mfd/omap-usb-host.txt
+++ b/Documentation/devicetree/bindings/mfd/omap-usb-host.txt
@@ -64,8 +64,8 @@ Required properties if child node exists:
Properties for children:
The OMAP HS USB Host subsystem contains EHCI and OHCI controllers.
-See Documentation/devicetree/bindings/usb/ehci-omap.txt and
-Documentation/devicetree/bindings/usb/ohci-omap3.txt.
+See Documentation/devicetree/bindings/usb/generic-ehci.yaml and
+Documentation/devicetree/bindings/usb/generic-ohci.yaml.
Example for OMAP4:
@@ -78,14 +78,14 @@ usbhshost: usbhshost@4a064000 {
ranges;
usbhsohci: ohci@4a064800 {
- compatible = "ti,ohci-omap3", "usb-ohci";
+ compatible = "ti,ohci-omap3";
reg = <0x4a064800 0x400>;
interrupt-parent = <&gic>;
interrupts = <0 76 0x4>;
};
usbhsehci: ehci@4a064c00 {
- compatible = "ti,ehci-omap", "usb-ehci";
+ compatible = "ti,ehci-omap";
reg = <0x4a064c00 0x400>;
interrupt-parent = <&gic>;
interrupts = <0 77 0x4>;
diff --git a/Documentation/devicetree/bindings/usb/ehci-omap.txt b/Documentation/devicetree/bindings/usb/ehci-omap.txt
deleted file mode 100644
index d77e11a975a2..000000000000
--- a/Documentation/devicetree/bindings/usb/ehci-omap.txt
+++ /dev/null
@@ -1,31 +0,0 @@
-OMAP HS USB EHCI controller
-
-This device is usually the child of the omap-usb-host
-Documentation/devicetree/bindings/mfd/omap-usb-host.txt
-
-Required properties:
-
-- compatible: should be "ti,ehci-omap"
-- reg: should contain one register range i.e. start and length
-- interrupts: description of the interrupt line
-
-Optional properties:
-
-- phys: list of phandles to PHY nodes.
- This property is required if at least one of the ports are in
- PHY mode i.e. OMAP_EHCI_PORT_MODE_PHY
-
-To specify the port mode, see
-Documentation/devicetree/bindings/mfd/omap-usb-host.txt
-
-Example for OMAP4:
-
-usbhsehci: ehci@4a064c00 {
- compatible = "ti,ehci-omap";
- reg = <0x4a064c00 0x400>;
- interrupts = <0 77 0x4>;
-};
-
-&usbhsehci {
- phys = <&hsusb1_phy 0 &hsusb3_phy>;
-};
diff --git a/Documentation/devicetree/bindings/usb/generic-ehci.yaml b/Documentation/devicetree/bindings/usb/generic-ehci.yaml
index 994818cb6044..2d382ae424da 100644
--- a/Documentation/devicetree/bindings/usb/generic-ehci.yaml
+++ b/Documentation/devicetree/bindings/usb/generic-ehci.yaml
@@ -74,6 +74,7 @@ properties:
- const: usb-ehci
- enum:
- generic-ehci
+ - ti,ehci-omap
- usb-ehci
reg:
diff --git a/Documentation/devicetree/bindings/usb/generic-ohci.yaml b/Documentation/devicetree/bindings/usb/generic-ohci.yaml
index 8492d809ba40..a9ba7257b884 100644
--- a/Documentation/devicetree/bindings/usb/generic-ohci.yaml
+++ b/Documentation/devicetree/bindings/usb/generic-ohci.yaml
@@ -46,7 +46,9 @@ properties:
- ingenic,jz4740-ohci
- snps,hsdk-v1.0-ohci
- const: generic-ohci
- - const: generic-ohci
+ - enum:
+ - generic-ohci
+ - ti,ohci-omap3
- items:
- enum:
- cavium,octeon-6335-ohci
diff --git a/Documentation/devicetree/bindings/usb/ohci-omap3.txt b/Documentation/devicetree/bindings/usb/ohci-omap3.txt
deleted file mode 100644
index ce8c47cff6d0..000000000000
--- a/Documentation/devicetree/bindings/usb/ohci-omap3.txt
+++ /dev/null
@@ -1,15 +0,0 @@
-OMAP HS USB OHCI controller (OMAP3 and later)
-
-Required properties:
-
-- compatible: should be "ti,ohci-omap3"
-- reg: should contain one register range i.e. start and length
-- interrupts: description of the interrupt line
-
-Example for OMAP4:
-
-usbhsohci: ohci@4a064800 {
- compatible = "ti,ohci-omap3";
- reg = <0x4a064800 0x400>;
- interrupts = <0 76 0x4>;
-};
--
2.39.0
^ permalink raw reply related [flat|nested] 20+ messages in thread* [PATCH v3 3/5] dt-bindings: usb: Convert OMAP OHCI/EHCI bindings to schema
@ 2023-01-24 3:05 ` Rob Herring
0 siblings, 0 replies; 20+ messages in thread
From: Rob Herring @ 2023-01-24 3:05 UTC (permalink / raw)
To: Greg Kroah-Hartman, Krzysztof Kozlowski, Michael Ellerman,
Nicholas Piggin, Christophe Leroy, Avi Fishman, Tomer Maimon,
Tali Perry, Patrick Venture, Nancy Yuen, Benjamin Fair,
Lee Jones
Cc: devicetree, openbmc, linux-usb, linuxppc-dev, linux-kernel
The OMAP OHCI and EHCI USB host bindings follow the generic binding, so
add the compatibles and remove the old txt binding docs.
The examples in omap-usb-host.txt don't match actual users, so update
them dropping the fallback compatible.
Signed-off-by: Rob Herring <robh@kernel.org>
---
v3:
- Fix document references to generic-ehci.yaml and generic-ohci.yaml (0-day)
v2:
- New patch
---
.../devicetree/bindings/mfd/omap-usb-host.txt | 8 +++---
.../devicetree/bindings/usb/ehci-omap.txt | 31 ----------------------
.../devicetree/bindings/usb/generic-ehci.yaml | 1 +
.../devicetree/bindings/usb/generic-ohci.yaml | 4 ++-
.../devicetree/bindings/usb/ohci-omap3.txt | 15 -----------
5 files changed, 8 insertions(+), 51 deletions(-)
diff --git a/Documentation/devicetree/bindings/mfd/omap-usb-host.txt b/Documentation/devicetree/bindings/mfd/omap-usb-host.txt
index aa1eaa59581b..a0d8c30c2631 100644
--- a/Documentation/devicetree/bindings/mfd/omap-usb-host.txt
+++ b/Documentation/devicetree/bindings/mfd/omap-usb-host.txt
@@ -64,8 +64,8 @@ Required properties if child node exists:
Properties for children:
The OMAP HS USB Host subsystem contains EHCI and OHCI controllers.
-See Documentation/devicetree/bindings/usb/ehci-omap.txt and
-Documentation/devicetree/bindings/usb/ohci-omap3.txt.
+See Documentation/devicetree/bindings/usb/generic-ehci.yaml and
+Documentation/devicetree/bindings/usb/generic-ohci.yaml.
Example for OMAP4:
@@ -78,14 +78,14 @@ usbhshost: usbhshost@4a064000 {
ranges;
usbhsohci: ohci@4a064800 {
- compatible = "ti,ohci-omap3", "usb-ohci";
+ compatible = "ti,ohci-omap3";
reg = <0x4a064800 0x400>;
interrupt-parent = <&gic>;
interrupts = <0 76 0x4>;
};
usbhsehci: ehci@4a064c00 {
- compatible = "ti,ehci-omap", "usb-ehci";
+ compatible = "ti,ehci-omap";
reg = <0x4a064c00 0x400>;
interrupt-parent = <&gic>;
interrupts = <0 77 0x4>;
diff --git a/Documentation/devicetree/bindings/usb/ehci-omap.txt b/Documentation/devicetree/bindings/usb/ehci-omap.txt
deleted file mode 100644
index d77e11a975a2..000000000000
--- a/Documentation/devicetree/bindings/usb/ehci-omap.txt
+++ /dev/null
@@ -1,31 +0,0 @@
-OMAP HS USB EHCI controller
-
-This device is usually the child of the omap-usb-host
-Documentation/devicetree/bindings/mfd/omap-usb-host.txt
-
-Required properties:
-
-- compatible: should be "ti,ehci-omap"
-- reg: should contain one register range i.e. start and length
-- interrupts: description of the interrupt line
-
-Optional properties:
-
-- phys: list of phandles to PHY nodes.
- This property is required if at least one of the ports are in
- PHY mode i.e. OMAP_EHCI_PORT_MODE_PHY
-
-To specify the port mode, see
-Documentation/devicetree/bindings/mfd/omap-usb-host.txt
-
-Example for OMAP4:
-
-usbhsehci: ehci@4a064c00 {
- compatible = "ti,ehci-omap";
- reg = <0x4a064c00 0x400>;
- interrupts = <0 77 0x4>;
-};
-
-&usbhsehci {
- phys = <&hsusb1_phy 0 &hsusb3_phy>;
-};
diff --git a/Documentation/devicetree/bindings/usb/generic-ehci.yaml b/Documentation/devicetree/bindings/usb/generic-ehci.yaml
index 994818cb6044..2d382ae424da 100644
--- a/Documentation/devicetree/bindings/usb/generic-ehci.yaml
+++ b/Documentation/devicetree/bindings/usb/generic-ehci.yaml
@@ -74,6 +74,7 @@ properties:
- const: usb-ehci
- enum:
- generic-ehci
+ - ti,ehci-omap
- usb-ehci
reg:
diff --git a/Documentation/devicetree/bindings/usb/generic-ohci.yaml b/Documentation/devicetree/bindings/usb/generic-ohci.yaml
index 8492d809ba40..a9ba7257b884 100644
--- a/Documentation/devicetree/bindings/usb/generic-ohci.yaml
+++ b/Documentation/devicetree/bindings/usb/generic-ohci.yaml
@@ -46,7 +46,9 @@ properties:
- ingenic,jz4740-ohci
- snps,hsdk-v1.0-ohci
- const: generic-ohci
- - const: generic-ohci
+ - enum:
+ - generic-ohci
+ - ti,ohci-omap3
- items:
- enum:
- cavium,octeon-6335-ohci
diff --git a/Documentation/devicetree/bindings/usb/ohci-omap3.txt b/Documentation/devicetree/bindings/usb/ohci-omap3.txt
deleted file mode 100644
index ce8c47cff6d0..000000000000
--- a/Documentation/devicetree/bindings/usb/ohci-omap3.txt
+++ /dev/null
@@ -1,15 +0,0 @@
-OMAP HS USB OHCI controller (OMAP3 and later)
-
-Required properties:
-
-- compatible: should be "ti,ohci-omap3"
-- reg: should contain one register range i.e. start and length
-- interrupts: description of the interrupt line
-
-Example for OMAP4:
-
-usbhsohci: ohci@4a064800 {
- compatible = "ti,ohci-omap3";
- reg = <0x4a064800 0x400>;
- interrupts = <0 76 0x4>;
-};
--
2.39.0
^ permalink raw reply related [flat|nested] 20+ messages in thread* Re: [PATCH v3 3/5] dt-bindings: usb: Convert OMAP OHCI/EHCI bindings to schema
2023-01-24 3:05 ` Rob Herring
@ 2023-01-24 10:31 ` Lee Jones
-1 siblings, 0 replies; 20+ messages in thread
From: Lee Jones @ 2023-01-24 10:31 UTC (permalink / raw)
To: Rob Herring
Cc: Greg Kroah-Hartman, Krzysztof Kozlowski, Michael Ellerman,
Nicholas Piggin, Christophe Leroy, Avi Fishman, Tomer Maimon,
Tali Perry, Patrick Venture, Nancy Yuen, Benjamin Fair,
linux-usb, devicetree, linux-kernel, linuxppc-dev, openbmc
On Mon, 23 Jan 2023, Rob Herring wrote:
> The OMAP OHCI and EHCI USB host bindings follow the generic binding, so
> add the compatibles and remove the old txt binding docs.
>
> The examples in omap-usb-host.txt don't match actual users, so update
> them dropping the fallback compatible.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> v3:
> - Fix document references to generic-ehci.yaml and generic-ohci.yaml (0-day)
> v2:
> - New patch
> ---
> .../devicetree/bindings/mfd/omap-usb-host.txt | 8 +++---
Acked-by: Lee Jones <lee@kernel.org>
> .../devicetree/bindings/usb/ehci-omap.txt | 31 ----------------------
> .../devicetree/bindings/usb/generic-ehci.yaml | 1 +
> .../devicetree/bindings/usb/generic-ohci.yaml | 4 ++-
> .../devicetree/bindings/usb/ohci-omap3.txt | 15 -----------
> 5 files changed, 8 insertions(+), 51 deletions(-)
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH v3 3/5] dt-bindings: usb: Convert OMAP OHCI/EHCI bindings to schema
@ 2023-01-24 10:31 ` Lee Jones
0 siblings, 0 replies; 20+ messages in thread
From: Lee Jones @ 2023-01-24 10:31 UTC (permalink / raw)
To: Rob Herring
Cc: devicetree, Tomer Maimon, Avi Fishman, Greg Kroah-Hartman,
openbmc, linux-usb, linux-kernel, Tali Perry, Nancy Yuen,
Patrick Venture, Nicholas Piggin, Krzysztof Kozlowski,
linuxppc-dev, Benjamin Fair
On Mon, 23 Jan 2023, Rob Herring wrote:
> The OMAP OHCI and EHCI USB host bindings follow the generic binding, so
> add the compatibles and remove the old txt binding docs.
>
> The examples in omap-usb-host.txt don't match actual users, so update
> them dropping the fallback compatible.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> v3:
> - Fix document references to generic-ehci.yaml and generic-ohci.yaml (0-day)
> v2:
> - New patch
> ---
> .../devicetree/bindings/mfd/omap-usb-host.txt | 8 +++---
Acked-by: Lee Jones <lee@kernel.org>
> .../devicetree/bindings/usb/ehci-omap.txt | 31 ----------------------
> .../devicetree/bindings/usb/generic-ehci.yaml | 1 +
> .../devicetree/bindings/usb/generic-ohci.yaml | 4 ++-
> .../devicetree/bindings/usb/ohci-omap3.txt | 15 -----------
> 5 files changed, 8 insertions(+), 51 deletions(-)
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 20+ messages in thread
* [PATCH v3 4/5] dt-bindings: usb: Convert Marvell Orion EHCI to DT schema
2023-01-24 3:05 ` Rob Herring
@ 2023-01-24 3:05 ` Rob Herring
-1 siblings, 0 replies; 20+ messages in thread
From: Rob Herring @ 2023-01-24 3:05 UTC (permalink / raw)
To: Greg Kroah-Hartman, Krzysztof Kozlowski, Michael Ellerman,
Nicholas Piggin, Christophe Leroy, Avi Fishman, Tomer Maimon,
Tali Perry, Patrick Venture, Nancy Yuen, Benjamin Fair,
Lee Jones
Cc: linux-usb, devicetree, linux-kernel, linuxppc-dev, openbmc
The Marvell Orion EHCI binding is just some compatible strings, so add it
to the generic-ehci.yaml schema.
Signed-off-by: Rob Herring <robh@kernel.org>
---
.../devicetree/bindings/usb/ehci-orion.txt | 22 ----------------------
.../devicetree/bindings/usb/generic-ehci.yaml | 2 ++
2 files changed, 2 insertions(+), 22 deletions(-)
diff --git a/Documentation/devicetree/bindings/usb/ehci-orion.txt b/Documentation/devicetree/bindings/usb/ehci-orion.txt
deleted file mode 100644
index 2855bae79fda..000000000000
--- a/Documentation/devicetree/bindings/usb/ehci-orion.txt
+++ /dev/null
@@ -1,22 +0,0 @@
-* EHCI controller, Orion Marvell variants
-
-Required properties:
-- compatible: must be one of the following
- "marvell,orion-ehci"
- "marvell,armada-3700-ehci"
-- reg: physical base address of the controller and length of memory mapped
- region.
-- interrupts: The EHCI interrupt
-
-Optional properties:
-- clocks: reference to the clock
-- phys: reference to the USB PHY
-- phy-names: name of the USB PHY, should be "usb"
-
-Example:
-
- ehci@50000 {
- compatible = "marvell,orion-ehci";
- reg = <0x50000 0x1000>;
- interrupts = <19>;
- };
diff --git a/Documentation/devicetree/bindings/usb/generic-ehci.yaml b/Documentation/devicetree/bindings/usb/generic-ehci.yaml
index 2d382ae424da..ebbb01b39a92 100644
--- a/Documentation/devicetree/bindings/usb/generic-ehci.yaml
+++ b/Documentation/devicetree/bindings/usb/generic-ehci.yaml
@@ -74,6 +74,8 @@ properties:
- const: usb-ehci
- enum:
- generic-ehci
+ - marvell,armada-3700-ehci
+ - marvell,orion-ehci
- ti,ehci-omap
- usb-ehci
--
2.39.0
^ permalink raw reply related [flat|nested] 20+ messages in thread* [PATCH v3 4/5] dt-bindings: usb: Convert Marvell Orion EHCI to DT schema
@ 2023-01-24 3:05 ` Rob Herring
0 siblings, 0 replies; 20+ messages in thread
From: Rob Herring @ 2023-01-24 3:05 UTC (permalink / raw)
To: Greg Kroah-Hartman, Krzysztof Kozlowski, Michael Ellerman,
Nicholas Piggin, Christophe Leroy, Avi Fishman, Tomer Maimon,
Tali Perry, Patrick Venture, Nancy Yuen, Benjamin Fair,
Lee Jones
Cc: devicetree, openbmc, linux-usb, linuxppc-dev, linux-kernel
The Marvell Orion EHCI binding is just some compatible strings, so add it
to the generic-ehci.yaml schema.
Signed-off-by: Rob Herring <robh@kernel.org>
---
.../devicetree/bindings/usb/ehci-orion.txt | 22 ----------------------
.../devicetree/bindings/usb/generic-ehci.yaml | 2 ++
2 files changed, 2 insertions(+), 22 deletions(-)
diff --git a/Documentation/devicetree/bindings/usb/ehci-orion.txt b/Documentation/devicetree/bindings/usb/ehci-orion.txt
deleted file mode 100644
index 2855bae79fda..000000000000
--- a/Documentation/devicetree/bindings/usb/ehci-orion.txt
+++ /dev/null
@@ -1,22 +0,0 @@
-* EHCI controller, Orion Marvell variants
-
-Required properties:
-- compatible: must be one of the following
- "marvell,orion-ehci"
- "marvell,armada-3700-ehci"
-- reg: physical base address of the controller and length of memory mapped
- region.
-- interrupts: The EHCI interrupt
-
-Optional properties:
-- clocks: reference to the clock
-- phys: reference to the USB PHY
-- phy-names: name of the USB PHY, should be "usb"
-
-Example:
-
- ehci@50000 {
- compatible = "marvell,orion-ehci";
- reg = <0x50000 0x1000>;
- interrupts = <19>;
- };
diff --git a/Documentation/devicetree/bindings/usb/generic-ehci.yaml b/Documentation/devicetree/bindings/usb/generic-ehci.yaml
index 2d382ae424da..ebbb01b39a92 100644
--- a/Documentation/devicetree/bindings/usb/generic-ehci.yaml
+++ b/Documentation/devicetree/bindings/usb/generic-ehci.yaml
@@ -74,6 +74,8 @@ properties:
- const: usb-ehci
- enum:
- generic-ehci
+ - marvell,armada-3700-ehci
+ - marvell,orion-ehci
- ti,ehci-omap
- usb-ehci
--
2.39.0
^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCH v3 5/5] dt-bindings: usb: Convert Nuvoton EHCI to DT schema
2023-01-24 3:05 ` Rob Herring
@ 2023-01-24 3:05 ` Rob Herring
-1 siblings, 0 replies; 20+ messages in thread
From: Rob Herring @ 2023-01-24 3:05 UTC (permalink / raw)
To: Greg Kroah-Hartman, Krzysztof Kozlowski, Michael Ellerman,
Nicholas Piggin, Christophe Leroy, Avi Fishman, Tomer Maimon,
Tali Perry, Patrick Venture, Nancy Yuen, Benjamin Fair,
Lee Jones
Cc: linux-usb, devicetree, linux-kernel, linuxppc-dev, openbmc
The Nuvoton EHCI binding is just some compatible strings, so add it to the
generic-ehci.yaml schema.
Signed-off-by: Rob Herring <robh@kernel.org>
---
.../devicetree/bindings/usb/generic-ehci.yaml | 2 ++
.../devicetree/bindings/usb/npcm7xx-usb.txt | 20 --------------------
2 files changed, 2 insertions(+), 20 deletions(-)
diff --git a/Documentation/devicetree/bindings/usb/generic-ehci.yaml b/Documentation/devicetree/bindings/usb/generic-ehci.yaml
index ebbb01b39a92..050cfd5acdaa 100644
--- a/Documentation/devicetree/bindings/usb/generic-ehci.yaml
+++ b/Documentation/devicetree/bindings/usb/generic-ehci.yaml
@@ -76,6 +76,8 @@ properties:
- generic-ehci
- marvell,armada-3700-ehci
- marvell,orion-ehci
+ - nuvoton,npcm750-ehci
+ - nuvoton,npcm845-ehci
- ti,ehci-omap
- usb-ehci
diff --git a/Documentation/devicetree/bindings/usb/npcm7xx-usb.txt b/Documentation/devicetree/bindings/usb/npcm7xx-usb.txt
deleted file mode 100644
index 352a0a1e2f76..000000000000
--- a/Documentation/devicetree/bindings/usb/npcm7xx-usb.txt
+++ /dev/null
@@ -1,20 +0,0 @@
-Nuvoton NPCM7XX SoC USB controllers:
------------------------------
-
-EHCI:
------
-
-Required properties:
-- compatible: should be one of
- "nuvoton,npcm750-ehci"
- "nuvoton,npcm845-ehci"
-- interrupts: Should contain the EHCI interrupt
-- reg: Physical address and length of the register set for the device
-
-Example:
-
- ehci1: usb@f0806000 {
- compatible = "nuvoton,npcm750-ehci";
- reg = <0xf0806000 0x1000>;
- interrupts = <0 61 4>;
- };
--
2.39.0
^ permalink raw reply related [flat|nested] 20+ messages in thread* [PATCH v3 5/5] dt-bindings: usb: Convert Nuvoton EHCI to DT schema
@ 2023-01-24 3:05 ` Rob Herring
0 siblings, 0 replies; 20+ messages in thread
From: Rob Herring @ 2023-01-24 3:05 UTC (permalink / raw)
To: Greg Kroah-Hartman, Krzysztof Kozlowski, Michael Ellerman,
Nicholas Piggin, Christophe Leroy, Avi Fishman, Tomer Maimon,
Tali Perry, Patrick Venture, Nancy Yuen, Benjamin Fair,
Lee Jones
Cc: devicetree, openbmc, linux-usb, linuxppc-dev, linux-kernel
The Nuvoton EHCI binding is just some compatible strings, so add it to the
generic-ehci.yaml schema.
Signed-off-by: Rob Herring <robh@kernel.org>
---
.../devicetree/bindings/usb/generic-ehci.yaml | 2 ++
.../devicetree/bindings/usb/npcm7xx-usb.txt | 20 --------------------
2 files changed, 2 insertions(+), 20 deletions(-)
diff --git a/Documentation/devicetree/bindings/usb/generic-ehci.yaml b/Documentation/devicetree/bindings/usb/generic-ehci.yaml
index ebbb01b39a92..050cfd5acdaa 100644
--- a/Documentation/devicetree/bindings/usb/generic-ehci.yaml
+++ b/Documentation/devicetree/bindings/usb/generic-ehci.yaml
@@ -76,6 +76,8 @@ properties:
- generic-ehci
- marvell,armada-3700-ehci
- marvell,orion-ehci
+ - nuvoton,npcm750-ehci
+ - nuvoton,npcm845-ehci
- ti,ehci-omap
- usb-ehci
diff --git a/Documentation/devicetree/bindings/usb/npcm7xx-usb.txt b/Documentation/devicetree/bindings/usb/npcm7xx-usb.txt
deleted file mode 100644
index 352a0a1e2f76..000000000000
--- a/Documentation/devicetree/bindings/usb/npcm7xx-usb.txt
+++ /dev/null
@@ -1,20 +0,0 @@
-Nuvoton NPCM7XX SoC USB controllers:
------------------------------
-
-EHCI:
------
-
-Required properties:
-- compatible: should be one of
- "nuvoton,npcm750-ehci"
- "nuvoton,npcm845-ehci"
-- interrupts: Should contain the EHCI interrupt
-- reg: Physical address and length of the register set for the device
-
-Example:
-
- ehci1: usb@f0806000 {
- compatible = "nuvoton,npcm750-ehci";
- reg = <0xf0806000 0x1000>;
- interrupts = <0 61 4>;
- };
--
2.39.0
^ permalink raw reply related [flat|nested] 20+ messages in thread
* Re: [PATCH v3 0/5] dt-bindings: usb: Convert some more simple OHCI/EHCI bindings
2023-01-24 3:05 ` Rob Herring
(?)
@ 2023-01-24 17:17 ` Greg Kroah-Hartman
-1 siblings, 0 replies; 20+ messages in thread
From: Greg Kroah-Hartman @ 2023-01-24 17:17 UTC (permalink / raw)
To: Rob Herring
Cc: Krzysztof Kozlowski, Michael Ellerman, Nicholas Piggin,
Christophe Leroy, Avi Fishman, Tomer Maimon, Tali Perry,
Patrick Venture, Nancy Yuen, Benjamin Fair, Lee Jones, linux-usb,
devicetree, linux-kernel, linuxppc-dev, openbmc
On Mon, Jan 23, 2023 at 09:05:15PM -0600, Rob Herring wrote:
> The 'ohci-usb' compatible is another 'generic' compatible for OHCI, but
> isn't documented with a schema. Let's add it to generic-ohci.yaml
> schema. While looking at this, I found a few other USB host bindings
> which are simple enough to use the 'generic' schemas.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
Am I supposed to take these in my USB tree?
I'm still confused if you all want me to take these types of things or
not...
thanks,
greg k-h
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH v3 0/5] dt-bindings: usb: Convert some more simple OHCI/EHCI bindings
@ 2023-01-24 17:17 ` Greg Kroah-Hartman
0 siblings, 0 replies; 20+ messages in thread
From: Greg Kroah-Hartman @ 2023-01-24 17:17 UTC (permalink / raw)
To: Rob Herring
Cc: devicetree, linux-usb, Tomer Maimon, Avi Fishman,
Michael Ellerman, openbmc, Lee Jones, linux-kernel,
Christophe Leroy, Tali Perry, Nicholas Piggin,
Krzysztof Kozlowski, Patrick Venture, linuxppc-dev,
Benjamin Fair
On Mon, Jan 23, 2023 at 09:05:15PM -0600, Rob Herring wrote:
> The 'ohci-usb' compatible is another 'generic' compatible for OHCI, but
> isn't documented with a schema. Let's add it to generic-ohci.yaml
> schema. While looking at this, I found a few other USB host bindings
> which are simple enough to use the 'generic' schemas.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
Am I supposed to take these in my USB tree?
I'm still confused if you all want me to take these types of things or
not...
thanks,
greg k-h
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH v3 0/5] dt-bindings: usb: Convert some more simple OHCI/EHCI bindings
@ 2023-01-24 17:17 ` Greg Kroah-Hartman
0 siblings, 0 replies; 20+ messages in thread
From: Greg Kroah-Hartman @ 2023-01-24 17:17 UTC (permalink / raw)
To: Rob Herring
Cc: devicetree, linux-usb, Tomer Maimon, Avi Fishman, openbmc,
Lee Jones, linux-kernel, Tali Perry, Nancy Yuen, Nicholas Piggin,
Krzysztof Kozlowski, Patrick Venture, linuxppc-dev,
Benjamin Fair
On Mon, Jan 23, 2023 at 09:05:15PM -0600, Rob Herring wrote:
> The 'ohci-usb' compatible is another 'generic' compatible for OHCI, but
> isn't documented with a schema. Let's add it to generic-ohci.yaml
> schema. While looking at this, I found a few other USB host bindings
> which are simple enough to use the 'generic' schemas.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
Am I supposed to take these in my USB tree?
I'm still confused if you all want me to take these types of things or
not...
thanks,
greg k-h
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH v3 0/5] dt-bindings: usb: Convert some more simple OHCI/EHCI bindings
2023-01-24 17:17 ` Greg Kroah-Hartman
(?)
@ 2023-01-24 18:42 ` Rob Herring
-1 siblings, 0 replies; 20+ messages in thread
From: Rob Herring @ 2023-01-24 18:42 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Krzysztof Kozlowski, Michael Ellerman, Nicholas Piggin,
Christophe Leroy, Avi Fishman, Tomer Maimon, Tali Perry,
Patrick Venture, Nancy Yuen, Benjamin Fair, Lee Jones, linux-usb,
devicetree, linux-kernel, linuxppc-dev, openbmc
On Tue, Jan 24, 2023 at 11:17 AM Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> On Mon, Jan 23, 2023 at 09:05:15PM -0600, Rob Herring wrote:
> > The 'ohci-usb' compatible is another 'generic' compatible for OHCI, but
> > isn't documented with a schema. Let's add it to generic-ohci.yaml
> > schema. While looking at this, I found a few other USB host bindings
> > which are simple enough to use the 'generic' schemas.
> >
> > Signed-off-by: Rob Herring <robh@kernel.org>
>
> Am I supposed to take these in my USB tree?
Yes, please.
> I'm still confused if you all want me to take these types of things or
> not...
Yes. I try to only pick up what has less responsive subsys
maintainers, treewide (binding) cleanups, or otherwise falls thru the
cracks.
Rob
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH v3 0/5] dt-bindings: usb: Convert some more simple OHCI/EHCI bindings
@ 2023-01-24 18:42 ` Rob Herring
0 siblings, 0 replies; 20+ messages in thread
From: Rob Herring @ 2023-01-24 18:42 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: devicetree, linux-usb, Tomer Maimon, Avi Fishman,
Michael Ellerman, openbmc, Lee Jones, linux-kernel,
Christophe Leroy, Tali Perry, Nicholas Piggin,
Krzysztof Kozlowski, Patrick Venture, linuxppc-dev,
Benjamin Fair
On Tue, Jan 24, 2023 at 11:17 AM Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> On Mon, Jan 23, 2023 at 09:05:15PM -0600, Rob Herring wrote:
> > The 'ohci-usb' compatible is another 'generic' compatible for OHCI, but
> > isn't documented with a schema. Let's add it to generic-ohci.yaml
> > schema. While looking at this, I found a few other USB host bindings
> > which are simple enough to use the 'generic' schemas.
> >
> > Signed-off-by: Rob Herring <robh@kernel.org>
>
> Am I supposed to take these in my USB tree?
Yes, please.
> I'm still confused if you all want me to take these types of things or
> not...
Yes. I try to only pick up what has less responsive subsys
maintainers, treewide (binding) cleanups, or otherwise falls thru the
cracks.
Rob
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH v3 0/5] dt-bindings: usb: Convert some more simple OHCI/EHCI bindings
@ 2023-01-24 18:42 ` Rob Herring
0 siblings, 0 replies; 20+ messages in thread
From: Rob Herring @ 2023-01-24 18:42 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: devicetree, linux-usb, Tomer Maimon, Avi Fishman, openbmc,
Lee Jones, linux-kernel, Tali Perry, Nancy Yuen, Nicholas Piggin,
Krzysztof Kozlowski, Patrick Venture, linuxppc-dev,
Benjamin Fair
On Tue, Jan 24, 2023 at 11:17 AM Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> On Mon, Jan 23, 2023 at 09:05:15PM -0600, Rob Herring wrote:
> > The 'ohci-usb' compatible is another 'generic' compatible for OHCI, but
> > isn't documented with a schema. Let's add it to generic-ohci.yaml
> > schema. While looking at this, I found a few other USB host bindings
> > which are simple enough to use the 'generic' schemas.
> >
> > Signed-off-by: Rob Herring <robh@kernel.org>
>
> Am I supposed to take these in my USB tree?
Yes, please.
> I'm still confused if you all want me to take these types of things or
> not...
Yes. I try to only pick up what has less responsive subsys
maintainers, treewide (binding) cleanups, or otherwise falls thru the
cracks.
Rob
^ permalink raw reply [flat|nested] 20+ messages in thread