* misc mdev tidyups
@ 2023-01-10 9:10 ` Christoph Hellwig
0 siblings, 0 replies; 28+ messages in thread
From: Christoph Hellwig @ 2023-01-10 9:10 UTC (permalink / raw)
To: Alex Williamson, Kirti Wankhede
Cc: Tony Krowiak, Halil Pasic, Jason Herne, Zhenyu Wang, Zhi Wang,
kvm, linux-s390, intel-gfx
Hi all,
this series tidies up the mdev Kconfig interaction and documentation a bit.
Diffstat:
Documentation/driver-api/vfio-mediated-device.rst | 108 ----------------------
Documentation/s390/vfio-ap.rst | 1
arch/s390/Kconfig | 6 -
arch/s390/configs/debug_defconfig | 1
arch/s390/configs/defconfig | 1
drivers/gpu/drm/i915/Kconfig | 2
drivers/vfio/mdev/Kconfig | 8 -
samples/Kconfig | 16 +--
samples/vfio-mdev/README.rst | 100 ++++++++++++++++++++
9 files changed, 115 insertions(+), 128 deletions(-)
^ permalink raw reply [flat|nested] 28+ messages in thread
* [Intel-gfx] misc mdev tidyups
@ 2023-01-10 9:10 ` Christoph Hellwig
0 siblings, 0 replies; 28+ messages in thread
From: Christoph Hellwig @ 2023-01-10 9:10 UTC (permalink / raw)
To: Alex Williamson, Kirti Wankhede
Cc: Tony Krowiak, Jason Herne, kvm, linux-s390, intel-gfx, Halil Pasic
Hi all,
this series tidies up the mdev Kconfig interaction and documentation a bit.
Diffstat:
Documentation/driver-api/vfio-mediated-device.rst | 108 ----------------------
Documentation/s390/vfio-ap.rst | 1
arch/s390/Kconfig | 6 -
arch/s390/configs/debug_defconfig | 1
arch/s390/configs/defconfig | 1
drivers/gpu/drm/i915/Kconfig | 2
drivers/vfio/mdev/Kconfig | 8 -
samples/Kconfig | 16 +--
samples/vfio-mdev/README.rst | 100 ++++++++++++++++++++
9 files changed, 115 insertions(+), 128 deletions(-)
^ permalink raw reply [flat|nested] 28+ messages in thread
* [PATCH 1/4] vfio-mdev: allow building the samples into the kernel
2023-01-10 9:10 ` [Intel-gfx] " Christoph Hellwig
@ 2023-01-10 9:10 ` Christoph Hellwig
-1 siblings, 0 replies; 28+ messages in thread
From: Christoph Hellwig @ 2023-01-10 9:10 UTC (permalink / raw)
To: Alex Williamson, Kirti Wankhede
Cc: Tony Krowiak, Halil Pasic, Jason Herne, Zhenyu Wang, Zhi Wang,
kvm, linux-s390, intel-gfx
There is nothing in the vfio-mdev sample drivers that requires building
them as modules, so remove that restriction.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
samples/Kconfig | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/samples/Kconfig b/samples/Kconfig
index 0d81c00289ee36..f1b8d4ff123036 100644
--- a/samples/Kconfig
+++ b/samples/Kconfig
@@ -184,23 +184,23 @@ config SAMPLE_UHID
Build UHID sample program.
config SAMPLE_VFIO_MDEV_MTTY
- tristate "Build VFIO mtty example mediated device sample code -- loadable modules only"
- depends on VFIO_MDEV && m
+ tristate "Build VFIO mtty example mediated device sample code"
+ depends on VFIO_MDEV
help
Build a virtual tty sample driver for use as a VFIO
mediated device
config SAMPLE_VFIO_MDEV_MDPY
- tristate "Build VFIO mdpy example mediated device sample code -- loadable modules only"
- depends on VFIO_MDEV && m
+ tristate "Build VFIO mdpy example mediated device sample code"
+ depends on VFIO_MDEV
help
Build a virtual display sample driver for use as a VFIO
mediated device. It is a simple framebuffer and supports
the region display interface (VFIO_GFX_PLANE_TYPE_REGION).
config SAMPLE_VFIO_MDEV_MDPY_FB
- tristate "Build VFIO mdpy example guest fbdev driver -- loadable module only"
- depends on FB && m
+ tristate "Build VFIO mdpy example guest fbdev driver"
+ depends on FB
select FB_CFB_FILLRECT
select FB_CFB_COPYAREA
select FB_CFB_IMAGEBLIT
@@ -208,8 +208,8 @@ config SAMPLE_VFIO_MDEV_MDPY_FB
Guest fbdev driver for the virtual display sample driver.
config SAMPLE_VFIO_MDEV_MBOCHS
- tristate "Build VFIO mdpy example mediated device sample code -- loadable modules only"
- depends on VFIO_MDEV && m
+ tristate "Build VFIO mdpy example mediated device sample code"
+ depends on VFIO_MDEV
select DMA_SHARED_BUFFER
help
Build a virtual display sample driver for use as a VFIO
--
2.35.1
^ permalink raw reply related [flat|nested] 28+ messages in thread
* [Intel-gfx] [PATCH 1/4] vfio-mdev: allow building the samples into the kernel
@ 2023-01-10 9:10 ` Christoph Hellwig
0 siblings, 0 replies; 28+ messages in thread
From: Christoph Hellwig @ 2023-01-10 9:10 UTC (permalink / raw)
To: Alex Williamson, Kirti Wankhede
Cc: Tony Krowiak, Jason Herne, kvm, linux-s390, intel-gfx, Halil Pasic
There is nothing in the vfio-mdev sample drivers that requires building
them as modules, so remove that restriction.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
samples/Kconfig | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/samples/Kconfig b/samples/Kconfig
index 0d81c00289ee36..f1b8d4ff123036 100644
--- a/samples/Kconfig
+++ b/samples/Kconfig
@@ -184,23 +184,23 @@ config SAMPLE_UHID
Build UHID sample program.
config SAMPLE_VFIO_MDEV_MTTY
- tristate "Build VFIO mtty example mediated device sample code -- loadable modules only"
- depends on VFIO_MDEV && m
+ tristate "Build VFIO mtty example mediated device sample code"
+ depends on VFIO_MDEV
help
Build a virtual tty sample driver for use as a VFIO
mediated device
config SAMPLE_VFIO_MDEV_MDPY
- tristate "Build VFIO mdpy example mediated device sample code -- loadable modules only"
- depends on VFIO_MDEV && m
+ tristate "Build VFIO mdpy example mediated device sample code"
+ depends on VFIO_MDEV
help
Build a virtual display sample driver for use as a VFIO
mediated device. It is a simple framebuffer and supports
the region display interface (VFIO_GFX_PLANE_TYPE_REGION).
config SAMPLE_VFIO_MDEV_MDPY_FB
- tristate "Build VFIO mdpy example guest fbdev driver -- loadable module only"
- depends on FB && m
+ tristate "Build VFIO mdpy example guest fbdev driver"
+ depends on FB
select FB_CFB_FILLRECT
select FB_CFB_COPYAREA
select FB_CFB_IMAGEBLIT
@@ -208,8 +208,8 @@ config SAMPLE_VFIO_MDEV_MDPY_FB
Guest fbdev driver for the virtual display sample driver.
config SAMPLE_VFIO_MDEV_MBOCHS
- tristate "Build VFIO mdpy example mediated device sample code -- loadable modules only"
- depends on VFIO_MDEV && m
+ tristate "Build VFIO mdpy example mediated device sample code"
+ depends on VFIO_MDEV
select DMA_SHARED_BUFFER
help
Build a virtual display sample driver for use as a VFIO
--
2.35.1
^ permalink raw reply related [flat|nested] 28+ messages in thread
* [PATCH 2/4] vfio-mdev: turn VFIO_MDEV into a selectable symbol
2023-01-10 9:10 ` [Intel-gfx] " Christoph Hellwig
@ 2023-01-10 9:10 ` Christoph Hellwig
-1 siblings, 0 replies; 28+ messages in thread
From: Christoph Hellwig @ 2023-01-10 9:10 UTC (permalink / raw)
To: Alex Williamson, Kirti Wankhede
Cc: Tony Krowiak, Halil Pasic, Jason Herne, Zhenyu Wang, Zhi Wang,
kvm, linux-s390, intel-gfx
VFIO_MDEV is just a library with helpers for the drivers. Stop making
it a user choice and just select it by the drivers that use the helpers.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
Documentation/s390/vfio-ap.rst | 1 -
arch/s390/Kconfig | 6 ++++--
arch/s390/configs/debug_defconfig | 1 -
arch/s390/configs/defconfig | 1 -
drivers/gpu/drm/i915/Kconfig | 2 +-
drivers/vfio/mdev/Kconfig | 8 +-------
samples/Kconfig | 6 +++---
7 files changed, 9 insertions(+), 16 deletions(-)
diff --git a/Documentation/s390/vfio-ap.rst b/Documentation/s390/vfio-ap.rst
index 00f4a04f6d4c6a..d46e98c7c1ec6c 100644
--- a/Documentation/s390/vfio-ap.rst
+++ b/Documentation/s390/vfio-ap.rst
@@ -553,7 +553,6 @@ These are the steps:
* ZCRYPT
* S390_AP_IOMMU
* VFIO
- * VFIO_MDEV
* KVM
If using make menuconfig select the following to build the vfio_ap module::
diff --git a/arch/s390/Kconfig b/arch/s390/Kconfig
index 318fce77601d35..60fddcdad495e6 100644
--- a/arch/s390/Kconfig
+++ b/arch/s390/Kconfig
@@ -705,7 +705,8 @@ config EADM_SCH
config VFIO_CCW
def_tristate n
prompt "Support for VFIO-CCW subchannels"
- depends on S390_CCW_IOMMU && VFIO_MDEV
+ depends on S390_CCW_IOMMU
+ select VFIO_MDEV
help
This driver allows usage of I/O subchannels via VFIO-CCW.
@@ -715,7 +716,8 @@ config VFIO_CCW
config VFIO_AP
def_tristate n
prompt "VFIO support for AP devices"
- depends on S390_AP_IOMMU && VFIO_MDEV && KVM
+ depends on S390_AP_IOMMU && KVM
+ select VFIO_MDEV
depends on ZCRYPT
help
This driver grants access to Adjunct Processor (AP) devices
diff --git a/arch/s390/configs/debug_defconfig b/arch/s390/configs/debug_defconfig
index 2a827002934bc6..e78fc3ba7d442a 100644
--- a/arch/s390/configs/debug_defconfig
+++ b/arch/s390/configs/debug_defconfig
@@ -596,7 +596,6 @@ CONFIG_SYNC_FILE=y
CONFIG_VFIO=m
CONFIG_VFIO_PCI=m
CONFIG_MLX5_VFIO_PCI=m
-CONFIG_VFIO_MDEV=m
CONFIG_VIRTIO_PCI=m
CONFIG_VIRTIO_BALLOON=m
CONFIG_VIRTIO_INPUT=y
diff --git a/arch/s390/configs/defconfig b/arch/s390/configs/defconfig
index fb780e80e4c8f7..f7eb2e527b6e65 100644
--- a/arch/s390/configs/defconfig
+++ b/arch/s390/configs/defconfig
@@ -585,7 +585,6 @@ CONFIG_SYNC_FILE=y
CONFIG_VFIO=m
CONFIG_VFIO_PCI=m
CONFIG_MLX5_VFIO_PCI=m
-CONFIG_VFIO_MDEV=m
CONFIG_VIRTIO_PCI=m
CONFIG_VIRTIO_BALLOON=m
CONFIG_VIRTIO_INPUT=y
diff --git a/drivers/gpu/drm/i915/Kconfig b/drivers/gpu/drm/i915/Kconfig
index 3efce05d7b57ca..d06da455253cdb 100644
--- a/drivers/gpu/drm/i915/Kconfig
+++ b/drivers/gpu/drm/i915/Kconfig
@@ -116,9 +116,9 @@ config DRM_I915_GVT_KVMGT
depends on X86
depends on 64BIT
depends on KVM
- depends on VFIO_MDEV
select DRM_I915_GVT
select KVM_EXTERNAL_WRITE_TRACKING
+ select VFIO_MDEV
help
Choose this option if you want to enable Intel GVT-g graphics
diff --git a/drivers/vfio/mdev/Kconfig b/drivers/vfio/mdev/Kconfig
index 646dbed44eb283..e5fb84e0796507 100644
--- a/drivers/vfio/mdev/Kconfig
+++ b/drivers/vfio/mdev/Kconfig
@@ -1,10 +1,4 @@
# SPDX-License-Identifier: GPL-2.0-only
config VFIO_MDEV
- tristate "Mediated device driver framework"
- default n
- help
- Provides a framework to virtualize devices.
- See Documentation/driver-api/vfio-mediated-device.rst for more details.
-
- If you don't know what do here, say N.
+ tristate
diff --git a/samples/Kconfig b/samples/Kconfig
index f1b8d4ff123036..56b191d128d88f 100644
--- a/samples/Kconfig
+++ b/samples/Kconfig
@@ -185,14 +185,14 @@ config SAMPLE_UHID
config SAMPLE_VFIO_MDEV_MTTY
tristate "Build VFIO mtty example mediated device sample code"
- depends on VFIO_MDEV
+ select VFIO_MDEV
help
Build a virtual tty sample driver for use as a VFIO
mediated device
config SAMPLE_VFIO_MDEV_MDPY
tristate "Build VFIO mdpy example mediated device sample code"
- depends on VFIO_MDEV
+ select VFIO_MDEV
help
Build a virtual display sample driver for use as a VFIO
mediated device. It is a simple framebuffer and supports
@@ -209,7 +209,7 @@ config SAMPLE_VFIO_MDEV_MDPY_FB
config SAMPLE_VFIO_MDEV_MBOCHS
tristate "Build VFIO mdpy example mediated device sample code"
- depends on VFIO_MDEV
+ select VFIO_MDEV
select DMA_SHARED_BUFFER
help
Build a virtual display sample driver for use as a VFIO
--
2.35.1
^ permalink raw reply related [flat|nested] 28+ messages in thread
* [Intel-gfx] [PATCH 2/4] vfio-mdev: turn VFIO_MDEV into a selectable symbol
@ 2023-01-10 9:10 ` Christoph Hellwig
0 siblings, 0 replies; 28+ messages in thread
From: Christoph Hellwig @ 2023-01-10 9:10 UTC (permalink / raw)
To: Alex Williamson, Kirti Wankhede
Cc: Tony Krowiak, Jason Herne, kvm, linux-s390, intel-gfx, Halil Pasic
VFIO_MDEV is just a library with helpers for the drivers. Stop making
it a user choice and just select it by the drivers that use the helpers.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
Documentation/s390/vfio-ap.rst | 1 -
arch/s390/Kconfig | 6 ++++--
arch/s390/configs/debug_defconfig | 1 -
arch/s390/configs/defconfig | 1 -
drivers/gpu/drm/i915/Kconfig | 2 +-
drivers/vfio/mdev/Kconfig | 8 +-------
samples/Kconfig | 6 +++---
7 files changed, 9 insertions(+), 16 deletions(-)
diff --git a/Documentation/s390/vfio-ap.rst b/Documentation/s390/vfio-ap.rst
index 00f4a04f6d4c6a..d46e98c7c1ec6c 100644
--- a/Documentation/s390/vfio-ap.rst
+++ b/Documentation/s390/vfio-ap.rst
@@ -553,7 +553,6 @@ These are the steps:
* ZCRYPT
* S390_AP_IOMMU
* VFIO
- * VFIO_MDEV
* KVM
If using make menuconfig select the following to build the vfio_ap module::
diff --git a/arch/s390/Kconfig b/arch/s390/Kconfig
index 318fce77601d35..60fddcdad495e6 100644
--- a/arch/s390/Kconfig
+++ b/arch/s390/Kconfig
@@ -705,7 +705,8 @@ config EADM_SCH
config VFIO_CCW
def_tristate n
prompt "Support for VFIO-CCW subchannels"
- depends on S390_CCW_IOMMU && VFIO_MDEV
+ depends on S390_CCW_IOMMU
+ select VFIO_MDEV
help
This driver allows usage of I/O subchannels via VFIO-CCW.
@@ -715,7 +716,8 @@ config VFIO_CCW
config VFIO_AP
def_tristate n
prompt "VFIO support for AP devices"
- depends on S390_AP_IOMMU && VFIO_MDEV && KVM
+ depends on S390_AP_IOMMU && KVM
+ select VFIO_MDEV
depends on ZCRYPT
help
This driver grants access to Adjunct Processor (AP) devices
diff --git a/arch/s390/configs/debug_defconfig b/arch/s390/configs/debug_defconfig
index 2a827002934bc6..e78fc3ba7d442a 100644
--- a/arch/s390/configs/debug_defconfig
+++ b/arch/s390/configs/debug_defconfig
@@ -596,7 +596,6 @@ CONFIG_SYNC_FILE=y
CONFIG_VFIO=m
CONFIG_VFIO_PCI=m
CONFIG_MLX5_VFIO_PCI=m
-CONFIG_VFIO_MDEV=m
CONFIG_VIRTIO_PCI=m
CONFIG_VIRTIO_BALLOON=m
CONFIG_VIRTIO_INPUT=y
diff --git a/arch/s390/configs/defconfig b/arch/s390/configs/defconfig
index fb780e80e4c8f7..f7eb2e527b6e65 100644
--- a/arch/s390/configs/defconfig
+++ b/arch/s390/configs/defconfig
@@ -585,7 +585,6 @@ CONFIG_SYNC_FILE=y
CONFIG_VFIO=m
CONFIG_VFIO_PCI=m
CONFIG_MLX5_VFIO_PCI=m
-CONFIG_VFIO_MDEV=m
CONFIG_VIRTIO_PCI=m
CONFIG_VIRTIO_BALLOON=m
CONFIG_VIRTIO_INPUT=y
diff --git a/drivers/gpu/drm/i915/Kconfig b/drivers/gpu/drm/i915/Kconfig
index 3efce05d7b57ca..d06da455253cdb 100644
--- a/drivers/gpu/drm/i915/Kconfig
+++ b/drivers/gpu/drm/i915/Kconfig
@@ -116,9 +116,9 @@ config DRM_I915_GVT_KVMGT
depends on X86
depends on 64BIT
depends on KVM
- depends on VFIO_MDEV
select DRM_I915_GVT
select KVM_EXTERNAL_WRITE_TRACKING
+ select VFIO_MDEV
help
Choose this option if you want to enable Intel GVT-g graphics
diff --git a/drivers/vfio/mdev/Kconfig b/drivers/vfio/mdev/Kconfig
index 646dbed44eb283..e5fb84e0796507 100644
--- a/drivers/vfio/mdev/Kconfig
+++ b/drivers/vfio/mdev/Kconfig
@@ -1,10 +1,4 @@
# SPDX-License-Identifier: GPL-2.0-only
config VFIO_MDEV
- tristate "Mediated device driver framework"
- default n
- help
- Provides a framework to virtualize devices.
- See Documentation/driver-api/vfio-mediated-device.rst for more details.
-
- If you don't know what do here, say N.
+ tristate
diff --git a/samples/Kconfig b/samples/Kconfig
index f1b8d4ff123036..56b191d128d88f 100644
--- a/samples/Kconfig
+++ b/samples/Kconfig
@@ -185,14 +185,14 @@ config SAMPLE_UHID
config SAMPLE_VFIO_MDEV_MTTY
tristate "Build VFIO mtty example mediated device sample code"
- depends on VFIO_MDEV
+ select VFIO_MDEV
help
Build a virtual tty sample driver for use as a VFIO
mediated device
config SAMPLE_VFIO_MDEV_MDPY
tristate "Build VFIO mdpy example mediated device sample code"
- depends on VFIO_MDEV
+ select VFIO_MDEV
help
Build a virtual display sample driver for use as a VFIO
mediated device. It is a simple framebuffer and supports
@@ -209,7 +209,7 @@ config SAMPLE_VFIO_MDEV_MDPY_FB
config SAMPLE_VFIO_MDEV_MBOCHS
tristate "Build VFIO mdpy example mediated device sample code"
- depends on VFIO_MDEV
+ select VFIO_MDEV
select DMA_SHARED_BUFFER
help
Build a virtual display sample driver for use as a VFIO
--
2.35.1
^ permalink raw reply related [flat|nested] 28+ messages in thread
* [PATCH 3/4] vfio-mdev: move the mtty usage documentation
2023-01-10 9:10 ` [Intel-gfx] " Christoph Hellwig
@ 2023-01-10 9:10 ` Christoph Hellwig
-1 siblings, 0 replies; 28+ messages in thread
From: Christoph Hellwig @ 2023-01-10 9:10 UTC (permalink / raw)
To: Alex Williamson, Kirti Wankhede
Cc: Tony Krowiak, Halil Pasic, Jason Herne, Zhenyu Wang, Zhi Wang,
kvm, linux-s390, intel-gfx
Move the documentation on how to use mtty to samples/vfio-mdev/README.rst
as it is in no way related to the vfio API. This matches how the bpf
and pktgen samples are documented.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
.../driver-api/vfio-mediated-device.rst | 100 ------------------
samples/vfio-mdev/README.rst | 100 ++++++++++++++++++
2 files changed, 100 insertions(+), 100 deletions(-)
create mode 100644 samples/vfio-mdev/README.rst
diff --git a/Documentation/driver-api/vfio-mediated-device.rst b/Documentation/driver-api/vfio-mediated-device.rst
index fdf7d69378ec4a..d4267243b4f525 100644
--- a/Documentation/driver-api/vfio-mediated-device.rst
+++ b/Documentation/driver-api/vfio-mediated-device.rst
@@ -270,106 +270,6 @@ these callbacks are supported in the TYPE1 IOMMU module. To enable them for
other IOMMU backend modules, such as PPC64 sPAPR module, they need to provide
these two callback functions.
-Using the Sample Code
-=====================
-
-mtty.c in samples/vfio-mdev/ directory is a sample driver program to
-demonstrate how to use the mediated device framework.
-
-The sample driver creates an mdev device that simulates a serial port over a PCI
-card.
-
-1. Build and load the mtty.ko module.
-
- This step creates a dummy device, /sys/devices/virtual/mtty/mtty/
-
- Files in this device directory in sysfs are similar to the following::
-
- # tree /sys/devices/virtual/mtty/mtty/
- /sys/devices/virtual/mtty/mtty/
- |-- mdev_supported_types
- | |-- mtty-1
- | | |-- available_instances
- | | |-- create
- | | |-- device_api
- | | |-- devices
- | | `-- name
- | `-- mtty-2
- | |-- available_instances
- | |-- create
- | |-- device_api
- | |-- devices
- | `-- name
- |-- mtty_dev
- | `-- sample_mtty_dev
- |-- power
- | |-- autosuspend_delay_ms
- | |-- control
- | |-- runtime_active_time
- | |-- runtime_status
- | `-- runtime_suspended_time
- |-- subsystem -> ../../../../class/mtty
- `-- uevent
-
-2. Create a mediated device by using the dummy device that you created in the
- previous step::
-
- # echo "83b8f4f2-509f-382f-3c1e-e6bfe0fa1001" > \
- /sys/devices/virtual/mtty/mtty/mdev_supported_types/mtty-2/create
-
-3. Add parameters to qemu-kvm::
-
- -device vfio-pci,\
- sysfsdev=/sys/bus/mdev/devices/83b8f4f2-509f-382f-3c1e-e6bfe0fa1001
-
-4. Boot the VM.
-
- In the Linux guest VM, with no hardware on the host, the device appears
- as follows::
-
- # lspci -s 00:05.0 -xxvv
- 00:05.0 Serial controller: Device 4348:3253 (rev 10) (prog-if 02 [16550])
- Subsystem: Device 4348:3253
- Physical Slot: 5
- Control: I/O+ Mem- BusMaster- SpecCycle- MemWINV- VGASnoop- ParErr-
- Stepping- SERR- FastB2B- DisINTx-
- Status: Cap- 66MHz- UDF- FastB2B- ParErr- DEVSEL=medium >TAbort-
- <TAbort- <MAbort- >SERR- <PERR- INTx-
- Interrupt: pin A routed to IRQ 10
- Region 0: I/O ports at c150 [size=8]
- Region 1: I/O ports at c158 [size=8]
- Kernel driver in use: serial
- 00: 48 43 53 32 01 00 00 02 10 02 00 07 00 00 00 00
- 10: 51 c1 00 00 59 c1 00 00 00 00 00 00 00 00 00 00
- 20: 00 00 00 00 00 00 00 00 00 00 00 00 48 43 53 32
- 30: 00 00 00 00 00 00 00 00 00 00 00 00 0a 01 00 00
-
- In the Linux guest VM, dmesg output for the device is as follows:
-
- serial 0000:00:05.0: PCI INT A -> Link[LNKA] -> GSI 10 (level, high) -> IRQ 10
- 0000:00:05.0: ttyS1 at I/O 0xc150 (irq = 10) is a 16550A
- 0000:00:05.0: ttyS2 at I/O 0xc158 (irq = 10) is a 16550A
-
-
-5. In the Linux guest VM, check the serial ports::
-
- # setserial -g /dev/ttyS*
- /dev/ttyS0, UART: 16550A, Port: 0x03f8, IRQ: 4
- /dev/ttyS1, UART: 16550A, Port: 0xc150, IRQ: 10
- /dev/ttyS2, UART: 16550A, Port: 0xc158, IRQ: 10
-
-6. Using minicom or any terminal emulation program, open port /dev/ttyS1 or
- /dev/ttyS2 with hardware flow control disabled.
-
-7. Type data on the minicom terminal or send data to the terminal emulation
- program and read the data.
-
- Data is loop backed from hosts mtty driver.
-
-8. Destroy the mediated device that you created::
-
- # echo 1 > /sys/bus/mdev/devices/83b8f4f2-509f-382f-3c1e-e6bfe0fa1001/remove
-
References
==========
diff --git a/samples/vfio-mdev/README.rst b/samples/vfio-mdev/README.rst
new file mode 100644
index 00000000000000..b52eb37739c039
--- /dev/null
+++ b/samples/vfio-mdev/README.rst
@@ -0,0 +1,100 @@
+Using the mtty vfio-mdev sample code
+====================================
+
+mtty is a sample vfio-mdev driver that demonstrates how to use the mediated
+device framework.
+
+The sample driver creates an mdev device that simulates a serial port over a PCI
+card.
+
+1. Build and load the mtty.ko module.
+
+ This step creates a dummy device, /sys/devices/virtual/mtty/mtty/
+
+ Files in this device directory in sysfs are similar to the following::
+
+ # tree /sys/devices/virtual/mtty/mtty/
+ /sys/devices/virtual/mtty/mtty/
+ |-- mdev_supported_types
+ | |-- mtty-1
+ | | |-- available_instances
+ | | |-- create
+ | | |-- device_api
+ | | |-- devices
+ | | `-- name
+ | `-- mtty-2
+ | |-- available_instances
+ | |-- create
+ | |-- device_api
+ | |-- devices
+ | `-- name
+ |-- mtty_dev
+ | `-- sample_mtty_dev
+ |-- power
+ | |-- autosuspend_delay_ms
+ | |-- control
+ | |-- runtime_active_time
+ | |-- runtime_status
+ | `-- runtime_suspended_time
+ |-- subsystem -> ../../../../class/mtty
+ `-- uevent
+
+2. Create a mediated device by using the dummy device that you created in the
+ previous step::
+
+ # echo "83b8f4f2-509f-382f-3c1e-e6bfe0fa1001" > \
+ /sys/devices/virtual/mtty/mtty/mdev_supported_types/mtty-2/create
+
+3. Add parameters to qemu-kvm::
+
+ -device vfio-pci,\
+ sysfsdev=/sys/bus/mdev/devices/83b8f4f2-509f-382f-3c1e-e6bfe0fa1001
+
+4. Boot the VM.
+
+ In the Linux guest VM, with no hardware on the host, the device appears
+ as follows::
+
+ # lspci -s 00:05.0 -xxvv
+ 00:05.0 Serial controller: Device 4348:3253 (rev 10) (prog-if 02 [16550])
+ Subsystem: Device 4348:3253
+ Physical Slot: 5
+ Control: I/O+ Mem- BusMaster- SpecCycle- MemWINV- VGASnoop- ParErr-
+ Stepping- SERR- FastB2B- DisINTx-
+ Status: Cap- 66MHz- UDF- FastB2B- ParErr- DEVSEL=medium >TAbort-
+ <TAbort- <MAbort- >SERR- <PERR- INTx-
+ Interrupt: pin A routed to IRQ 10
+ Region 0: I/O ports at c150 [size=8]
+ Region 1: I/O ports at c158 [size=8]
+ Kernel driver in use: serial
+ 00: 48 43 53 32 01 00 00 02 10 02 00 07 00 00 00 00
+ 10: 51 c1 00 00 59 c1 00 00 00 00 00 00 00 00 00 00
+ 20: 00 00 00 00 00 00 00 00 00 00 00 00 48 43 53 32
+ 30: 00 00 00 00 00 00 00 00 00 00 00 00 0a 01 00 00
+
+ In the Linux guest VM, dmesg output for the device is as follows:
+
+ serial 0000:00:05.0: PCI INT A -> Link[LNKA] -> GSI 10 (level, high) -> IRQ 10
+ 0000:00:05.0: ttyS1 at I/O 0xc150 (irq = 10) is a 16550A
+ 0000:00:05.0: ttyS2 at I/O 0xc158 (irq = 10) is a 16550A
+
+
+5. In the Linux guest VM, check the serial ports::
+
+ # setserial -g /dev/ttyS*
+ /dev/ttyS0, UART: 16550A, Port: 0x03f8, IRQ: 4
+ /dev/ttyS1, UART: 16550A, Port: 0xc150, IRQ: 10
+ /dev/ttyS2, UART: 16550A, Port: 0xc158, IRQ: 10
+
+6. Using minicom or any terminal emulation program, open port /dev/ttyS1 or
+ /dev/ttyS2 with hardware flow control disabled.
+
+7. Type data on the minicom terminal or send data to the terminal emulation
+ program and read the data.
+
+ Data is loop backed from hosts mtty driver.
+
+8. Destroy the mediated device that you created::
+
+ # echo 1 > /sys/bus/mdev/devices/83b8f4f2-509f-382f-3c1e-e6bfe0fa1001/remove
+
--
2.35.1
^ permalink raw reply related [flat|nested] 28+ messages in thread
* [Intel-gfx] [PATCH 3/4] vfio-mdev: move the mtty usage documentation
@ 2023-01-10 9:10 ` Christoph Hellwig
0 siblings, 0 replies; 28+ messages in thread
From: Christoph Hellwig @ 2023-01-10 9:10 UTC (permalink / raw)
To: Alex Williamson, Kirti Wankhede
Cc: Tony Krowiak, Jason Herne, kvm, linux-s390, intel-gfx, Halil Pasic
Move the documentation on how to use mtty to samples/vfio-mdev/README.rst
as it is in no way related to the vfio API. This matches how the bpf
and pktgen samples are documented.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
.../driver-api/vfio-mediated-device.rst | 100 ------------------
samples/vfio-mdev/README.rst | 100 ++++++++++++++++++
2 files changed, 100 insertions(+), 100 deletions(-)
create mode 100644 samples/vfio-mdev/README.rst
diff --git a/Documentation/driver-api/vfio-mediated-device.rst b/Documentation/driver-api/vfio-mediated-device.rst
index fdf7d69378ec4a..d4267243b4f525 100644
--- a/Documentation/driver-api/vfio-mediated-device.rst
+++ b/Documentation/driver-api/vfio-mediated-device.rst
@@ -270,106 +270,6 @@ these callbacks are supported in the TYPE1 IOMMU module. To enable them for
other IOMMU backend modules, such as PPC64 sPAPR module, they need to provide
these two callback functions.
-Using the Sample Code
-=====================
-
-mtty.c in samples/vfio-mdev/ directory is a sample driver program to
-demonstrate how to use the mediated device framework.
-
-The sample driver creates an mdev device that simulates a serial port over a PCI
-card.
-
-1. Build and load the mtty.ko module.
-
- This step creates a dummy device, /sys/devices/virtual/mtty/mtty/
-
- Files in this device directory in sysfs are similar to the following::
-
- # tree /sys/devices/virtual/mtty/mtty/
- /sys/devices/virtual/mtty/mtty/
- |-- mdev_supported_types
- | |-- mtty-1
- | | |-- available_instances
- | | |-- create
- | | |-- device_api
- | | |-- devices
- | | `-- name
- | `-- mtty-2
- | |-- available_instances
- | |-- create
- | |-- device_api
- | |-- devices
- | `-- name
- |-- mtty_dev
- | `-- sample_mtty_dev
- |-- power
- | |-- autosuspend_delay_ms
- | |-- control
- | |-- runtime_active_time
- | |-- runtime_status
- | `-- runtime_suspended_time
- |-- subsystem -> ../../../../class/mtty
- `-- uevent
-
-2. Create a mediated device by using the dummy device that you created in the
- previous step::
-
- # echo "83b8f4f2-509f-382f-3c1e-e6bfe0fa1001" > \
- /sys/devices/virtual/mtty/mtty/mdev_supported_types/mtty-2/create
-
-3. Add parameters to qemu-kvm::
-
- -device vfio-pci,\
- sysfsdev=/sys/bus/mdev/devices/83b8f4f2-509f-382f-3c1e-e6bfe0fa1001
-
-4. Boot the VM.
-
- In the Linux guest VM, with no hardware on the host, the device appears
- as follows::
-
- # lspci -s 00:05.0 -xxvv
- 00:05.0 Serial controller: Device 4348:3253 (rev 10) (prog-if 02 [16550])
- Subsystem: Device 4348:3253
- Physical Slot: 5
- Control: I/O+ Mem- BusMaster- SpecCycle- MemWINV- VGASnoop- ParErr-
- Stepping- SERR- FastB2B- DisINTx-
- Status: Cap- 66MHz- UDF- FastB2B- ParErr- DEVSEL=medium >TAbort-
- <TAbort- <MAbort- >SERR- <PERR- INTx-
- Interrupt: pin A routed to IRQ 10
- Region 0: I/O ports at c150 [size=8]
- Region 1: I/O ports at c158 [size=8]
- Kernel driver in use: serial
- 00: 48 43 53 32 01 00 00 02 10 02 00 07 00 00 00 00
- 10: 51 c1 00 00 59 c1 00 00 00 00 00 00 00 00 00 00
- 20: 00 00 00 00 00 00 00 00 00 00 00 00 48 43 53 32
- 30: 00 00 00 00 00 00 00 00 00 00 00 00 0a 01 00 00
-
- In the Linux guest VM, dmesg output for the device is as follows:
-
- serial 0000:00:05.0: PCI INT A -> Link[LNKA] -> GSI 10 (level, high) -> IRQ 10
- 0000:00:05.0: ttyS1 at I/O 0xc150 (irq = 10) is a 16550A
- 0000:00:05.0: ttyS2 at I/O 0xc158 (irq = 10) is a 16550A
-
-
-5. In the Linux guest VM, check the serial ports::
-
- # setserial -g /dev/ttyS*
- /dev/ttyS0, UART: 16550A, Port: 0x03f8, IRQ: 4
- /dev/ttyS1, UART: 16550A, Port: 0xc150, IRQ: 10
- /dev/ttyS2, UART: 16550A, Port: 0xc158, IRQ: 10
-
-6. Using minicom or any terminal emulation program, open port /dev/ttyS1 or
- /dev/ttyS2 with hardware flow control disabled.
-
-7. Type data on the minicom terminal or send data to the terminal emulation
- program and read the data.
-
- Data is loop backed from hosts mtty driver.
-
-8. Destroy the mediated device that you created::
-
- # echo 1 > /sys/bus/mdev/devices/83b8f4f2-509f-382f-3c1e-e6bfe0fa1001/remove
-
References
==========
diff --git a/samples/vfio-mdev/README.rst b/samples/vfio-mdev/README.rst
new file mode 100644
index 00000000000000..b52eb37739c039
--- /dev/null
+++ b/samples/vfio-mdev/README.rst
@@ -0,0 +1,100 @@
+Using the mtty vfio-mdev sample code
+====================================
+
+mtty is a sample vfio-mdev driver that demonstrates how to use the mediated
+device framework.
+
+The sample driver creates an mdev device that simulates a serial port over a PCI
+card.
+
+1. Build and load the mtty.ko module.
+
+ This step creates a dummy device, /sys/devices/virtual/mtty/mtty/
+
+ Files in this device directory in sysfs are similar to the following::
+
+ # tree /sys/devices/virtual/mtty/mtty/
+ /sys/devices/virtual/mtty/mtty/
+ |-- mdev_supported_types
+ | |-- mtty-1
+ | | |-- available_instances
+ | | |-- create
+ | | |-- device_api
+ | | |-- devices
+ | | `-- name
+ | `-- mtty-2
+ | |-- available_instances
+ | |-- create
+ | |-- device_api
+ | |-- devices
+ | `-- name
+ |-- mtty_dev
+ | `-- sample_mtty_dev
+ |-- power
+ | |-- autosuspend_delay_ms
+ | |-- control
+ | |-- runtime_active_time
+ | |-- runtime_status
+ | `-- runtime_suspended_time
+ |-- subsystem -> ../../../../class/mtty
+ `-- uevent
+
+2. Create a mediated device by using the dummy device that you created in the
+ previous step::
+
+ # echo "83b8f4f2-509f-382f-3c1e-e6bfe0fa1001" > \
+ /sys/devices/virtual/mtty/mtty/mdev_supported_types/mtty-2/create
+
+3. Add parameters to qemu-kvm::
+
+ -device vfio-pci,\
+ sysfsdev=/sys/bus/mdev/devices/83b8f4f2-509f-382f-3c1e-e6bfe0fa1001
+
+4. Boot the VM.
+
+ In the Linux guest VM, with no hardware on the host, the device appears
+ as follows::
+
+ # lspci -s 00:05.0 -xxvv
+ 00:05.0 Serial controller: Device 4348:3253 (rev 10) (prog-if 02 [16550])
+ Subsystem: Device 4348:3253
+ Physical Slot: 5
+ Control: I/O+ Mem- BusMaster- SpecCycle- MemWINV- VGASnoop- ParErr-
+ Stepping- SERR- FastB2B- DisINTx-
+ Status: Cap- 66MHz- UDF- FastB2B- ParErr- DEVSEL=medium >TAbort-
+ <TAbort- <MAbort- >SERR- <PERR- INTx-
+ Interrupt: pin A routed to IRQ 10
+ Region 0: I/O ports at c150 [size=8]
+ Region 1: I/O ports at c158 [size=8]
+ Kernel driver in use: serial
+ 00: 48 43 53 32 01 00 00 02 10 02 00 07 00 00 00 00
+ 10: 51 c1 00 00 59 c1 00 00 00 00 00 00 00 00 00 00
+ 20: 00 00 00 00 00 00 00 00 00 00 00 00 48 43 53 32
+ 30: 00 00 00 00 00 00 00 00 00 00 00 00 0a 01 00 00
+
+ In the Linux guest VM, dmesg output for the device is as follows:
+
+ serial 0000:00:05.0: PCI INT A -> Link[LNKA] -> GSI 10 (level, high) -> IRQ 10
+ 0000:00:05.0: ttyS1 at I/O 0xc150 (irq = 10) is a 16550A
+ 0000:00:05.0: ttyS2 at I/O 0xc158 (irq = 10) is a 16550A
+
+
+5. In the Linux guest VM, check the serial ports::
+
+ # setserial -g /dev/ttyS*
+ /dev/ttyS0, UART: 16550A, Port: 0x03f8, IRQ: 4
+ /dev/ttyS1, UART: 16550A, Port: 0xc150, IRQ: 10
+ /dev/ttyS2, UART: 16550A, Port: 0xc158, IRQ: 10
+
+6. Using minicom or any terminal emulation program, open port /dev/ttyS1 or
+ /dev/ttyS2 with hardware flow control disabled.
+
+7. Type data on the minicom terminal or send data to the terminal emulation
+ program and read the data.
+
+ Data is loop backed from hosts mtty driver.
+
+8. Destroy the mediated device that you created::
+
+ # echo 1 > /sys/bus/mdev/devices/83b8f4f2-509f-382f-3c1e-e6bfe0fa1001/remove
+
--
2.35.1
^ permalink raw reply related [flat|nested] 28+ messages in thread
* [PATCH 4/4] vfio-mdev: remove an non-existing driver from vfio-mediated-device
2023-01-10 9:10 ` [Intel-gfx] " Christoph Hellwig
@ 2023-01-10 9:10 ` Christoph Hellwig
-1 siblings, 0 replies; 28+ messages in thread
From: Christoph Hellwig @ 2023-01-10 9:10 UTC (permalink / raw)
To: Alex Williamson, Kirti Wankhede
Cc: Tony Krowiak, Halil Pasic, Jason Herne, Zhenyu Wang, Zhi Wang,
kvm, linux-s390, intel-gfx
The nvidia mdev driver does not actually exist anywhere in the tree.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
Documentation/driver-api/vfio-mediated-device.rst | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/Documentation/driver-api/vfio-mediated-device.rst b/Documentation/driver-api/vfio-mediated-device.rst
index d4267243b4f525..bbd548b66b4255 100644
--- a/Documentation/driver-api/vfio-mediated-device.rst
+++ b/Documentation/driver-api/vfio-mediated-device.rst
@@ -60,7 +60,7 @@ devices as examples, as these devices are the first devices to use this module::
| mdev.ko |
| +-----------+ | mdev_register_parent() +--------------+
| | | +<------------------------+ |
- | | | | | nvidia.ko |<-> physical
+ | | | | | ccw_device.ko|<-> physical
| | | +------------------------>+ | device
| | | | callbacks +--------------+
| | Physical | |
@@ -69,12 +69,6 @@ devices as examples, as these devices are the first devices to use this module::
| | | | | i915.ko |<-> physical
| | | +------------------------>+ | device
| | | | callbacks +--------------+
- | | | |
- | | | | mdev_register_parent() +--------------+
- | | | +<------------------------+ |
- | | | | | ccw_device.ko|<-> physical
- | | | +------------------------>+ | device
- | | | | callbacks +--------------+
| +-----------+ |
+---------------+
--
2.35.1
^ permalink raw reply related [flat|nested] 28+ messages in thread
* [Intel-gfx] [PATCH 4/4] vfio-mdev: remove an non-existing driver from vfio-mediated-device
@ 2023-01-10 9:10 ` Christoph Hellwig
0 siblings, 0 replies; 28+ messages in thread
From: Christoph Hellwig @ 2023-01-10 9:10 UTC (permalink / raw)
To: Alex Williamson, Kirti Wankhede
Cc: Tony Krowiak, Jason Herne, kvm, linux-s390, intel-gfx, Halil Pasic
The nvidia mdev driver does not actually exist anywhere in the tree.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
Documentation/driver-api/vfio-mediated-device.rst | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/Documentation/driver-api/vfio-mediated-device.rst b/Documentation/driver-api/vfio-mediated-device.rst
index d4267243b4f525..bbd548b66b4255 100644
--- a/Documentation/driver-api/vfio-mediated-device.rst
+++ b/Documentation/driver-api/vfio-mediated-device.rst
@@ -60,7 +60,7 @@ devices as examples, as these devices are the first devices to use this module::
| mdev.ko |
| +-----------+ | mdev_register_parent() +--------------+
| | | +<------------------------+ |
- | | | | | nvidia.ko |<-> physical
+ | | | | | ccw_device.ko|<-> physical
| | | +------------------------>+ | device
| | | | callbacks +--------------+
| | Physical | |
@@ -69,12 +69,6 @@ devices as examples, as these devices are the first devices to use this module::
| | | | | i915.ko |<-> physical
| | | +------------------------>+ | device
| | | | callbacks +--------------+
- | | | |
- | | | | mdev_register_parent() +--------------+
- | | | +<------------------------+ |
- | | | | | ccw_device.ko|<-> physical
- | | | +------------------------>+ | device
- | | | | callbacks +--------------+
| +-----------+ |
+---------------+
--
2.35.1
^ permalink raw reply related [flat|nested] 28+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/4] vfio-mdev: allow building the samples into the kernel
2023-01-10 9:10 ` [Intel-gfx] " Christoph Hellwig
` (4 preceding siblings ...)
(?)
@ 2023-01-10 9:48 ` Patchwork
-1 siblings, 0 replies; 28+ messages in thread
From: Patchwork @ 2023-01-10 9:48 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 3575 bytes --]
== Series Details ==
Series: series starting with [1/4] vfio-mdev: allow building the samples into the kernel
URL : https://patchwork.freedesktop.org/series/112602/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12562 -> Patchwork_112602v1
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112602v1/index.html
Participating hosts (39 -> 36)
------------------------------
Additional (1): fi-pnv-d510
Missing (4): fi-kbl-soraka fi-rkl-11600 fi-bsw-kefka fi-snb-2520m
Known issues
------------
Here are the changes found in Patchwork_112602v1 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live@gt_heartbeat:
- fi-glk-j4005: [PASS][1] -> [DMESG-FAIL][2] ([i915#5334])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12562/fi-glk-j4005/igt@i915_selftest@live@gt_heartbeat.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112602v1/fi-glk-j4005/igt@i915_selftest@live@gt_heartbeat.html
* igt@i915_selftest@live@workarounds:
- fi-rkl-guc: [PASS][3] -> [INCOMPLETE][4] ([i915#4983])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12562/fi-rkl-guc/igt@i915_selftest@live@workarounds.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112602v1/fi-rkl-guc/igt@i915_selftest@live@workarounds.html
* igt@kms_psr@primary_page_flip:
- fi-pnv-d510: NOTRUN -> [SKIP][5] ([fdo#109271]) +44 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112602v1/fi-pnv-d510/igt@kms_psr@primary_page_flip.html
#### Possible fixes ####
* igt@i915_selftest@live@requests:
- {bat-rpls-1}: [INCOMPLETE][6] ([i915#6257]) -> [PASS][7]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12562/bat-rpls-1/igt@i915_selftest@live@requests.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112602v1/bat-rpls-1/igt@i915_selftest@live@requests.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#6257]: https://gitlab.freedesktop.org/drm/intel/issues/6257
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#7625]: https://gitlab.freedesktop.org/drm/intel/issues/7625
[i915#7699]: https://gitlab.freedesktop.org/drm/intel/issues/7699
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
Build changes
-------------
* Linux: CI_DRM_12562 -> Patchwork_112602v1
CI-20190529: 20190529
CI_DRM_12562: 89adbd3908455888dca4c5c42d0340446e40c28e @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7114: 2fd839599a200c089a5c9dbf5048609faf9b8104 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_112602v1: 89adbd3908455888dca4c5c42d0340446e40c28e @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
aa8846676b50 vfio-mdev: remove an non-existing driver from vfio-mediated-device
0e4c11b9dcc9 vfio-mdev: move the mtty usage documentation
749b11fe92da vfio-mdev: turn VFIO_MDEV into a selectable symbol
64e0953903a7 vfio-mdev: allow building the samples into the kernel
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112602v1/index.html
[-- Attachment #2: Type: text/html, Size: 4023 bytes --]
^ permalink raw reply [flat|nested] 28+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/4] vfio-mdev: allow building the samples into the kernel
2023-01-10 9:10 ` [Intel-gfx] " Christoph Hellwig
` (5 preceding siblings ...)
(?)
@ 2023-01-10 12:05 ` Patchwork
-1 siblings, 0 replies; 28+ messages in thread
From: Patchwork @ 2023-01-10 12:05 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 21679 bytes --]
== Series Details ==
Series: series starting with [1/4] vfio-mdev: allow building the samples into the kernel
URL : https://patchwork.freedesktop.org/series/112602/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12562_full -> Patchwork_112602v1_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112602v1/index.html
Participating hosts (13 -> 10)
------------------------------
Missing (3): pig-skl-6260u pig-kbl-iris pig-glk-j5005
Known issues
------------
Here are the changes found in Patchwork_112602v1_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_capture@capture-invisible@smem0:
- shard-glk: NOTRUN -> [SKIP][1] ([fdo#109271] / [i915#6334])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112602v1/shard-glk2/igt@gem_exec_capture@capture-invisible@smem0.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [PASS][2] -> [FAIL][3] ([i915#2842]) +1 similar issue
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12562/shard-glk5/igt@gem_exec_fair@basic-pace-share@rcs0.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112602v1/shard-glk9/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gen9_exec_parse@allowed-single:
- shard-glk: [PASS][4] -> [DMESG-WARN][5] ([i915#5566] / [i915#716])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12562/shard-glk1/igt@gen9_exec_parse@allowed-single.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112602v1/shard-glk5/igt@gen9_exec_parse@allowed-single.html
* igt@kms_ccs@pipe-a-bad-aux-stride-y_tiled_gen12_rc_ccs_cc:
- shard-glk: NOTRUN -> [SKIP][6] ([fdo#109271] / [i915#3886])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112602v1/shard-glk2/igt@kms_ccs@pipe-a-bad-aux-stride-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_chamelium_edid@dp-edid-change-during-suspend:
- shard-glk: NOTRUN -> [SKIP][7] ([fdo#109271]) +15 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112602v1/shard-glk2/igt@kms_chamelium_edid@dp-edid-change-during-suspend.html
* igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size:
- shard-glk: [PASS][8] -> [FAIL][9] ([i915#2346])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12562/shard-glk9/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112602v1/shard-glk3/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size.html
* igt@kms_flip@2x-flip-vs-expired-vblank@ac-hdmi-a1-hdmi-a2:
- shard-glk: [PASS][10] -> [FAIL][11] ([i915#79])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12562/shard-glk6/igt@kms_flip@2x-flip-vs-expired-vblank@ac-hdmi-a1-hdmi-a2.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112602v1/shard-glk5/igt@kms_flip@2x-flip-vs-expired-vblank@ac-hdmi-a1-hdmi-a2.html
* igt@runner@aborted:
- shard-glk: NOTRUN -> [FAIL][12] ([i915#4312])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112602v1/shard-glk5/igt@runner@aborted.html
#### Possible fixes ####
* igt@drm_fdinfo@idle@rcs0:
- {shard-rkl}: [FAIL][13] ([i915#7742]) -> [PASS][14] +1 similar issue
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12562/shard-rkl-2/igt@drm_fdinfo@idle@rcs0.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112602v1/shard-rkl-4/igt@drm_fdinfo@idle@rcs0.html
* igt@fbdev@write:
- {shard-rkl}: [SKIP][15] ([i915#2582]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12562/shard-rkl-4/igt@fbdev@write.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112602v1/shard-rkl-6/igt@fbdev@write.html
* igt@gem_ctx_exec@basic-nohangcheck:
- {shard-rkl}: [FAIL][17] ([i915#6268]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12562/shard-rkl-2/igt@gem_ctx_exec@basic-nohangcheck.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112602v1/shard-rkl-3/igt@gem_ctx_exec@basic-nohangcheck.html
* igt@gem_ctx_persistence@hang:
- {shard-rkl}: [SKIP][19] ([i915#6252]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12562/shard-rkl-5/igt@gem_ctx_persistence@hang.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112602v1/shard-rkl-1/igt@gem_ctx_persistence@hang.html
* igt@gem_eio@in-flight-contexts-1us:
- {shard-rkl}: [TIMEOUT][21] ([i915#3063]) -> [PASS][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12562/shard-rkl-1/igt@gem_eio@in-flight-contexts-1us.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112602v1/shard-rkl-5/igt@gem_eio@in-flight-contexts-1us.html
* igt@gem_eio@kms:
- {shard-dg1}: [FAIL][23] ([i915#5784]) -> [PASS][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12562/shard-dg1-19/igt@gem_eio@kms.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112602v1/shard-dg1-13/igt@gem_eio@kms.html
* igt@gem_exec_fair@basic-deadline:
- shard-glk: [FAIL][25] ([i915#2846]) -> [PASS][26]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12562/shard-glk4/igt@gem_exec_fair@basic-deadline.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112602v1/shard-glk4/igt@gem_exec_fair@basic-deadline.html
* igt@gem_exec_fair@basic-none-rrul@rcs0:
- {shard-rkl}: [FAIL][27] ([i915#2842]) -> [PASS][28] +1 similar issue
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12562/shard-rkl-6/igt@gem_exec_fair@basic-none-rrul@rcs0.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112602v1/shard-rkl-5/igt@gem_exec_fair@basic-none-rrul@rcs0.html
* igt@gem_exec_reloc@basic-gtt-wc-noreloc:
- {shard-rkl}: [SKIP][29] ([i915#3281]) -> [PASS][30] +9 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12562/shard-rkl-1/igt@gem_exec_reloc@basic-gtt-wc-noreloc.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112602v1/shard-rkl-5/igt@gem_exec_reloc@basic-gtt-wc-noreloc.html
* igt@gem_pwrite_snooped:
- {shard-rkl}: [SKIP][31] ([i915#3282]) -> [PASS][32] +6 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12562/shard-rkl-1/igt@gem_pwrite_snooped.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112602v1/shard-rkl-5/igt@gem_pwrite_snooped.html
* igt@gen9_exec_parse@allowed-all:
- {shard-rkl}: [SKIP][33] ([i915#2527]) -> [PASS][34] +2 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12562/shard-rkl-1/igt@gen9_exec_parse@allowed-all.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112602v1/shard-rkl-5/igt@gen9_exec_parse@allowed-all.html
* igt@i915_pm_dc@dc9-dpms:
- {shard-rkl}: [SKIP][35] ([i915#3361]) -> [PASS][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12562/shard-rkl-5/igt@i915_pm_dc@dc9-dpms.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112602v1/shard-rkl-1/igt@i915_pm_dc@dc9-dpms.html
* igt@i915_pm_rc6_residency@rc6-idle@vcs0:
- {shard-dg1}: [FAIL][37] ([i915#3591]) -> [PASS][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12562/shard-dg1-17/igt@i915_pm_rc6_residency@rc6-idle@vcs0.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112602v1/shard-dg1-14/igt@i915_pm_rc6_residency@rc6-idle@vcs0.html
* igt@i915_pm_rpm@dpms-non-lpsp:
- {shard-dg1}: [SKIP][39] ([i915#1397]) -> [PASS][40] +1 similar issue
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12562/shard-dg1-14/igt@i915_pm_rpm@dpms-non-lpsp.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112602v1/shard-dg1-17/igt@i915_pm_rpm@dpms-non-lpsp.html
* igt@i915_suspend@forcewake:
- {shard-rkl}: [DMESG-WARN][41] ([i915#5122]) -> [PASS][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12562/shard-rkl-4/igt@i915_suspend@forcewake.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112602v1/shard-rkl-6/igt@i915_suspend@forcewake.html
* igt@kms_ccs@pipe-b-bad-aux-stride-y_tiled_gen12_rc_ccs:
- {shard-rkl}: [SKIP][43] ([i915#1845] / [i915#4098]) -> [PASS][44] +39 similar issues
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12562/shard-rkl-1/igt@kms_ccs@pipe-b-bad-aux-stride-y_tiled_gen12_rc_ccs.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112602v1/shard-rkl-6/igt@kms_ccs@pipe-b-bad-aux-stride-y_tiled_gen12_rc_ccs.html
* igt@kms_frontbuffer_tracking@psr-modesetfrombusy:
- {shard-rkl}: [SKIP][45] ([i915#1849] / [i915#4098]) -> [PASS][46] +14 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12562/shard-rkl-4/igt@kms_frontbuffer_tracking@psr-modesetfrombusy.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112602v1/shard-rkl-6/igt@kms_frontbuffer_tracking@psr-modesetfrombusy.html
* igt@kms_plane@pixel-format-source-clamping@pipe-b-planes:
- {shard-rkl}: [SKIP][47] ([i915#1849]) -> [PASS][48] +1 similar issue
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12562/shard-rkl-1/igt@kms_plane@pixel-format-source-clamping@pipe-b-planes.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112602v1/shard-rkl-6/igt@kms_plane@pixel-format-source-clamping@pipe-b-planes.html
* igt@kms_psr@primary_render:
- {shard-rkl}: [SKIP][49] ([i915#1072]) -> [PASS][50] +3 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12562/shard-rkl-1/igt@kms_psr@primary_render.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112602v1/shard-rkl-6/igt@kms_psr@primary_render.html
* igt@kms_universal_plane@cursor-fb-leak-pipe-b:
- {shard-rkl}: [SKIP][51] ([i915#1845] / [i915#4070] / [i915#4098]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12562/shard-rkl-1/igt@kms_universal_plane@cursor-fb-leak-pipe-b.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112602v1/shard-rkl-6/igt@kms_universal_plane@cursor-fb-leak-pipe-b.html
* igt@kms_universal_plane@universal-plane-pageflip-windowed-pipe-b:
- {shard-rkl}: [SKIP][53] ([i915#4070] / [i915#4098]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12562/shard-rkl-1/igt@kms_universal_plane@universal-plane-pageflip-windowed-pipe-b.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112602v1/shard-rkl-6/igt@kms_universal_plane@universal-plane-pageflip-windowed-pipe-b.html
* igt@perf@mi-rpc:
- {shard-rkl}: [SKIP][55] ([i915#2434]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12562/shard-rkl-1/igt@perf@mi-rpc.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112602v1/shard-rkl-5/igt@perf@mi-rpc.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109283]: https://bugs.freedesktop.org/show_bug.cgi?id=109283
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109303]: https://bugs.freedesktop.org/show_bug.cgi?id=109303
[fdo#109307]: https://bugs.freedesktop.org/show_bug.cgi?id=109307
[fdo#109308]: https://bugs.freedesktop.org/show_bug.cgi?id=109308
[fdo#109309]: https://bugs.freedesktop.org/show_bug.cgi?id=109309
[fdo#109312]: https://bugs.freedesktop.org/show_bug.cgi?id=109312
[fdo#109313]: https://bugs.freedesktop.org/show_bug.cgi?id=109313
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#110542]: https://bugs.freedesktop.org/show_bug.cgi?id=110542
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111644]: https://bugs.freedesktop.org/show_bug.cgi?id=111644
[fdo#111656]: https://bugs.freedesktop.org/show_bug.cgi?id=111656
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[fdo#112054]: https://bugs.freedesktop.org/show_bug.cgi?id=112054
[fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#1722]: https://gitlab.freedesktop.org/drm/intel/issues/1722
[i915#1769]: https://gitlab.freedesktop.org/drm/intel/issues/1769
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2434]: https://gitlab.freedesktop.org/drm/intel/issues/2434
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
[i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
[i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
[i915#284]: https://gitlab.freedesktop.org/drm/intel/issues/284
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846
[i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
[i915#3063]: https://gitlab.freedesktop.org/drm/intel/issues/3063
[i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116
[i915#315]: https://gitlab.freedesktop.org/drm/intel/issues/315
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299
[i915#3318]: https://gitlab.freedesktop.org/drm/intel/issues/3318
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3361]: https://gitlab.freedesktop.org/drm/intel/issues/3361
[i915#3469]: https://gitlab.freedesktop.org/drm/intel/issues/3469
[i915#3536]: https://gitlab.freedesktop.org/drm/intel/issues/3536
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3558]: https://gitlab.freedesktop.org/drm/intel/issues/3558
[i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
[i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742
[i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#3989]: https://gitlab.freedesktop.org/drm/intel/issues/3989
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4281]: https://gitlab.freedesktop.org/drm/intel/issues/4281
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4349]: https://gitlab.freedesktop.org/drm/intel/issues/4349
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4767]: https://gitlab.freedesktop.org/drm/intel/issues/4767
[i915#5122]: https://gitlab.freedesktop.org/drm/intel/issues/5122
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5288]: https://gitlab.freedesktop.org/drm/intel/issues/5288
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#5327]: https://gitlab.freedesktop.org/drm/intel/issues/5327
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5439]: https://gitlab.freedesktop.org/drm/intel/issues/5439
[i915#5461]: https://gitlab.freedesktop.org/drm/intel/issues/5461
[i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
[i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6227]: https://gitlab.freedesktop.org/drm/intel/issues/6227
[i915#6230]: https://gitlab.freedesktop.org/drm/intel/issues/6230
[i915#6245]: https://gitlab.freedesktop.org/drm/intel/issues/6245
[i915#6248]: https://gitlab.freedesktop.org/drm/intel/issues/6248
[i915#6252]: https://gitlab.freedesktop.org/drm/intel/issues/6252
[i915#6258]: https://gitlab.freedesktop.org/drm/intel/issues/6258
[i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
[i915#6301]: https://gitlab.freedesktop.org/drm/intel/issues/6301
[i915#6334]: https://gitlab.freedesktop.org/drm/intel/issues/6334
[i915#6335]: https://gitlab.freedesktop.org/drm/intel/issues/6335
[i915#6355]: https://gitlab.freedesktop.org/drm/intel/issues/6355
[i915#6412]: https://gitlab.freedesktop.org/drm/intel/issues/6412
[i915#6433]: https://gitlab.freedesktop.org/drm/intel/issues/6433
[i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497
[i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768
[i915#6944]: https://gitlab.freedesktop.org/drm/intel/issues/6944
[i915#6946]: https://gitlab.freedesktop.org/drm/intel/issues/6946
[i915#6953]: https://gitlab.freedesktop.org/drm/intel/issues/6953
[i915#7037]: https://gitlab.freedesktop.org/drm/intel/issues/7037
[i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116
[i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
[i915#7128]: https://gitlab.freedesktop.org/drm/intel/issues/7128
[i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
[i915#7294]: https://gitlab.freedesktop.org/drm/intel/issues/7294
[i915#7456]: https://gitlab.freedesktop.org/drm/intel/issues/7456
[i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
[i915#7651]: https://gitlab.freedesktop.org/drm/intel/issues/7651
[i915#7697]: https://gitlab.freedesktop.org/drm/intel/issues/7697
[i915#7701]: https://gitlab.freedesktop.org/drm/intel/issues/7701
[i915#7707]: https://gitlab.freedesktop.org/drm/intel/issues/7707
[i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
[i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
Build changes
-------------
* Linux: CI_DRM_12562 -> Patchwork_112602v1
* Piglit: piglit_4509 -> None
CI-20190529: 20190529
CI_DRM_12562: 89adbd3908455888dca4c5c42d0340446e40c28e @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7114: 2fd839599a200c089a5c9dbf5048609faf9b8104 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_112602v1: 89adbd3908455888dca4c5c42d0340446e40c28e @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112602v1/index.html
[-- Attachment #2: Type: text/html, Size: 15829 bytes --]
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [Intel-gfx] [PATCH 4/4] vfio-mdev: remove an non-existing driver from vfio-mediated-device
2023-01-10 9:10 ` [Intel-gfx] " Christoph Hellwig
@ 2023-01-10 14:49 ` Anthony Krowiak
-1 siblings, 0 replies; 28+ messages in thread
From: Anthony Krowiak @ 2023-01-10 14:49 UTC (permalink / raw)
To: Christoph Hellwig, Alex Williamson, Kirti Wankhede
Cc: Jason Herne, linux-s390, kvm, intel-gfx, Halil Pasic
LGTM
Reviewed-by: Tony Krowiak <akrowiak@linux.ibm.com>
On 1/10/23 4:10 AM, Christoph Hellwig wrote:
> The nvidia mdev driver does not actually exist anywhere in the tree.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> Documentation/driver-api/vfio-mediated-device.rst | 8 +-------
> 1 file changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/Documentation/driver-api/vfio-mediated-device.rst b/Documentation/driver-api/vfio-mediated-device.rst
> index d4267243b4f525..bbd548b66b4255 100644
> --- a/Documentation/driver-api/vfio-mediated-device.rst
> +++ b/Documentation/driver-api/vfio-mediated-device.rst
> @@ -60,7 +60,7 @@ devices as examples, as these devices are the first devices to use this module::
> | mdev.ko |
> | +-----------+ | mdev_register_parent() +--------------+
> | | | +<------------------------+ |
> - | | | | | nvidia.ko |<-> physical
> + | | | | | ccw_device.ko|<-> physical
> | | | +------------------------>+ | device
> | | | | callbacks +--------------+
> | | Physical | |
> @@ -69,12 +69,6 @@ devices as examples, as these devices are the first devices to use this module::
> | | | | | i915.ko |<-> physical
> | | | +------------------------>+ | device
> | | | | callbacks +--------------+
> - | | | |
> - | | | | mdev_register_parent() +--------------+
> - | | | +<------------------------+ |
> - | | | | | ccw_device.ko|<-> physical
> - | | | +------------------------>+ | device
> - | | | | callbacks +--------------+
> | +-----------+ |
> +---------------+
>
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 4/4] vfio-mdev: remove an non-existing driver from vfio-mediated-device
@ 2023-01-10 14:49 ` Anthony Krowiak
0 siblings, 0 replies; 28+ messages in thread
From: Anthony Krowiak @ 2023-01-10 14:49 UTC (permalink / raw)
To: Christoph Hellwig, Alex Williamson, Kirti Wankhede
Cc: Halil Pasic, Jason Herne, Zhenyu Wang, Zhi Wang, kvm, linux-s390,
intel-gfx
LGTM
Reviewed-by: Tony Krowiak <akrowiak@linux.ibm.com>
On 1/10/23 4:10 AM, Christoph Hellwig wrote:
> The nvidia mdev driver does not actually exist anywhere in the tree.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> Documentation/driver-api/vfio-mediated-device.rst | 8 +-------
> 1 file changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/Documentation/driver-api/vfio-mediated-device.rst b/Documentation/driver-api/vfio-mediated-device.rst
> index d4267243b4f525..bbd548b66b4255 100644
> --- a/Documentation/driver-api/vfio-mediated-device.rst
> +++ b/Documentation/driver-api/vfio-mediated-device.rst
> @@ -60,7 +60,7 @@ devices as examples, as these devices are the first devices to use this module::
> | mdev.ko |
> | +-----------+ | mdev_register_parent() +--------------+
> | | | +<------------------------+ |
> - | | | | | nvidia.ko |<-> physical
> + | | | | | ccw_device.ko|<-> physical
> | | | +------------------------>+ | device
> | | | | callbacks +--------------+
> | | Physical | |
> @@ -69,12 +69,6 @@ devices as examples, as these devices are the first devices to use this module::
> | | | | | i915.ko |<-> physical
> | | | +------------------------>+ | device
> | | | | callbacks +--------------+
> - | | | |
> - | | | | mdev_register_parent() +--------------+
> - | | | +<------------------------+ |
> - | | | | | ccw_device.ko|<-> physical
> - | | | +------------------------>+ | device
> - | | | | callbacks +--------------+
> | +-----------+ |
> +---------------+
>
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 2/4] vfio-mdev: turn VFIO_MDEV into a selectable symbol
2023-01-10 9:10 ` [Intel-gfx] " Christoph Hellwig
@ 2023-01-10 14:51 ` Anthony Krowiak
-1 siblings, 0 replies; 28+ messages in thread
From: Anthony Krowiak @ 2023-01-10 14:51 UTC (permalink / raw)
To: Christoph Hellwig, Alex Williamson, Kirti Wankhede
Cc: Halil Pasic, Jason Herne, Zhenyu Wang, Zhi Wang, kvm, linux-s390,
intel-gfx
Reviewed-by: Tony Krowiak <akrowiak@linux.ibm.com>
On 1/10/23 4:10 AM, Christoph Hellwig wrote:
> VFIO_MDEV is just a library with helpers for the drivers. Stop making
> it a user choice and just select it by the drivers that use the helpers.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> Documentation/s390/vfio-ap.rst | 1 -
> arch/s390/Kconfig | 6 ++++--
> arch/s390/configs/debug_defconfig | 1 -
> arch/s390/configs/defconfig | 1 -
> drivers/gpu/drm/i915/Kconfig | 2 +-
> drivers/vfio/mdev/Kconfig | 8 +-------
> samples/Kconfig | 6 +++---
> 7 files changed, 9 insertions(+), 16 deletions(-)
>
> diff --git a/Documentation/s390/vfio-ap.rst b/Documentation/s390/vfio-ap.rst
> index 00f4a04f6d4c6a..d46e98c7c1ec6c 100644
> --- a/Documentation/s390/vfio-ap.rst
> +++ b/Documentation/s390/vfio-ap.rst
> @@ -553,7 +553,6 @@ These are the steps:
> * ZCRYPT
> * S390_AP_IOMMU
> * VFIO
> - * VFIO_MDEV
> * KVM
>
> If using make menuconfig select the following to build the vfio_ap module::
> diff --git a/arch/s390/Kconfig b/arch/s390/Kconfig
> index 318fce77601d35..60fddcdad495e6 100644
> --- a/arch/s390/Kconfig
> +++ b/arch/s390/Kconfig
> @@ -705,7 +705,8 @@ config EADM_SCH
> config VFIO_CCW
> def_tristate n
> prompt "Support for VFIO-CCW subchannels"
> - depends on S390_CCW_IOMMU && VFIO_MDEV
> + depends on S390_CCW_IOMMU
> + select VFIO_MDEV
> help
> This driver allows usage of I/O subchannels via VFIO-CCW.
>
> @@ -715,7 +716,8 @@ config VFIO_CCW
> config VFIO_AP
> def_tristate n
> prompt "VFIO support for AP devices"
> - depends on S390_AP_IOMMU && VFIO_MDEV && KVM
> + depends on S390_AP_IOMMU && KVM
> + select VFIO_MDEV
> depends on ZCRYPT
> help
> This driver grants access to Adjunct Processor (AP) devices
> diff --git a/arch/s390/configs/debug_defconfig b/arch/s390/configs/debug_defconfig
> index 2a827002934bc6..e78fc3ba7d442a 100644
> --- a/arch/s390/configs/debug_defconfig
> +++ b/arch/s390/configs/debug_defconfig
> @@ -596,7 +596,6 @@ CONFIG_SYNC_FILE=y
> CONFIG_VFIO=m
> CONFIG_VFIO_PCI=m
> CONFIG_MLX5_VFIO_PCI=m
> -CONFIG_VFIO_MDEV=m
> CONFIG_VIRTIO_PCI=m
> CONFIG_VIRTIO_BALLOON=m
> CONFIG_VIRTIO_INPUT=y
> diff --git a/arch/s390/configs/defconfig b/arch/s390/configs/defconfig
> index fb780e80e4c8f7..f7eb2e527b6e65 100644
> --- a/arch/s390/configs/defconfig
> +++ b/arch/s390/configs/defconfig
> @@ -585,7 +585,6 @@ CONFIG_SYNC_FILE=y
> CONFIG_VFIO=m
> CONFIG_VFIO_PCI=m
> CONFIG_MLX5_VFIO_PCI=m
> -CONFIG_VFIO_MDEV=m
> CONFIG_VIRTIO_PCI=m
> CONFIG_VIRTIO_BALLOON=m
> CONFIG_VIRTIO_INPUT=y
> diff --git a/drivers/gpu/drm/i915/Kconfig b/drivers/gpu/drm/i915/Kconfig
> index 3efce05d7b57ca..d06da455253cdb 100644
> --- a/drivers/gpu/drm/i915/Kconfig
> +++ b/drivers/gpu/drm/i915/Kconfig
> @@ -116,9 +116,9 @@ config DRM_I915_GVT_KVMGT
> depends on X86
> depends on 64BIT
> depends on KVM
> - depends on VFIO_MDEV
> select DRM_I915_GVT
> select KVM_EXTERNAL_WRITE_TRACKING
> + select VFIO_MDEV
>
> help
> Choose this option if you want to enable Intel GVT-g graphics
> diff --git a/drivers/vfio/mdev/Kconfig b/drivers/vfio/mdev/Kconfig
> index 646dbed44eb283..e5fb84e0796507 100644
> --- a/drivers/vfio/mdev/Kconfig
> +++ b/drivers/vfio/mdev/Kconfig
> @@ -1,10 +1,4 @@
> # SPDX-License-Identifier: GPL-2.0-only
>
> config VFIO_MDEV
> - tristate "Mediated device driver framework"
> - default n
> - help
> - Provides a framework to virtualize devices.
> - See Documentation/driver-api/vfio-mediated-device.rst for more details.
> -
> - If you don't know what do here, say N.
> + tristate
> diff --git a/samples/Kconfig b/samples/Kconfig
> index f1b8d4ff123036..56b191d128d88f 100644
> --- a/samples/Kconfig
> +++ b/samples/Kconfig
> @@ -185,14 +185,14 @@ config SAMPLE_UHID
>
> config SAMPLE_VFIO_MDEV_MTTY
> tristate "Build VFIO mtty example mediated device sample code"
> - depends on VFIO_MDEV
> + select VFIO_MDEV
> help
> Build a virtual tty sample driver for use as a VFIO
> mediated device
>
> config SAMPLE_VFIO_MDEV_MDPY
> tristate "Build VFIO mdpy example mediated device sample code"
> - depends on VFIO_MDEV
> + select VFIO_MDEV
> help
> Build a virtual display sample driver for use as a VFIO
> mediated device. It is a simple framebuffer and supports
> @@ -209,7 +209,7 @@ config SAMPLE_VFIO_MDEV_MDPY_FB
>
> config SAMPLE_VFIO_MDEV_MBOCHS
> tristate "Build VFIO mdpy example mediated device sample code"
> - depends on VFIO_MDEV
> + select VFIO_MDEV
> select DMA_SHARED_BUFFER
> help
> Build a virtual display sample driver for use as a VFIO
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [Intel-gfx] [PATCH 2/4] vfio-mdev: turn VFIO_MDEV into a selectable symbol
@ 2023-01-10 14:51 ` Anthony Krowiak
0 siblings, 0 replies; 28+ messages in thread
From: Anthony Krowiak @ 2023-01-10 14:51 UTC (permalink / raw)
To: Christoph Hellwig, Alex Williamson, Kirti Wankhede
Cc: Jason Herne, linux-s390, kvm, intel-gfx, Halil Pasic
Reviewed-by: Tony Krowiak <akrowiak@linux.ibm.com>
On 1/10/23 4:10 AM, Christoph Hellwig wrote:
> VFIO_MDEV is just a library with helpers for the drivers. Stop making
> it a user choice and just select it by the drivers that use the helpers.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> Documentation/s390/vfio-ap.rst | 1 -
> arch/s390/Kconfig | 6 ++++--
> arch/s390/configs/debug_defconfig | 1 -
> arch/s390/configs/defconfig | 1 -
> drivers/gpu/drm/i915/Kconfig | 2 +-
> drivers/vfio/mdev/Kconfig | 8 +-------
> samples/Kconfig | 6 +++---
> 7 files changed, 9 insertions(+), 16 deletions(-)
>
> diff --git a/Documentation/s390/vfio-ap.rst b/Documentation/s390/vfio-ap.rst
> index 00f4a04f6d4c6a..d46e98c7c1ec6c 100644
> --- a/Documentation/s390/vfio-ap.rst
> +++ b/Documentation/s390/vfio-ap.rst
> @@ -553,7 +553,6 @@ These are the steps:
> * ZCRYPT
> * S390_AP_IOMMU
> * VFIO
> - * VFIO_MDEV
> * KVM
>
> If using make menuconfig select the following to build the vfio_ap module::
> diff --git a/arch/s390/Kconfig b/arch/s390/Kconfig
> index 318fce77601d35..60fddcdad495e6 100644
> --- a/arch/s390/Kconfig
> +++ b/arch/s390/Kconfig
> @@ -705,7 +705,8 @@ config EADM_SCH
> config VFIO_CCW
> def_tristate n
> prompt "Support for VFIO-CCW subchannels"
> - depends on S390_CCW_IOMMU && VFIO_MDEV
> + depends on S390_CCW_IOMMU
> + select VFIO_MDEV
> help
> This driver allows usage of I/O subchannels via VFIO-CCW.
>
> @@ -715,7 +716,8 @@ config VFIO_CCW
> config VFIO_AP
> def_tristate n
> prompt "VFIO support for AP devices"
> - depends on S390_AP_IOMMU && VFIO_MDEV && KVM
> + depends on S390_AP_IOMMU && KVM
> + select VFIO_MDEV
> depends on ZCRYPT
> help
> This driver grants access to Adjunct Processor (AP) devices
> diff --git a/arch/s390/configs/debug_defconfig b/arch/s390/configs/debug_defconfig
> index 2a827002934bc6..e78fc3ba7d442a 100644
> --- a/arch/s390/configs/debug_defconfig
> +++ b/arch/s390/configs/debug_defconfig
> @@ -596,7 +596,6 @@ CONFIG_SYNC_FILE=y
> CONFIG_VFIO=m
> CONFIG_VFIO_PCI=m
> CONFIG_MLX5_VFIO_PCI=m
> -CONFIG_VFIO_MDEV=m
> CONFIG_VIRTIO_PCI=m
> CONFIG_VIRTIO_BALLOON=m
> CONFIG_VIRTIO_INPUT=y
> diff --git a/arch/s390/configs/defconfig b/arch/s390/configs/defconfig
> index fb780e80e4c8f7..f7eb2e527b6e65 100644
> --- a/arch/s390/configs/defconfig
> +++ b/arch/s390/configs/defconfig
> @@ -585,7 +585,6 @@ CONFIG_SYNC_FILE=y
> CONFIG_VFIO=m
> CONFIG_VFIO_PCI=m
> CONFIG_MLX5_VFIO_PCI=m
> -CONFIG_VFIO_MDEV=m
> CONFIG_VIRTIO_PCI=m
> CONFIG_VIRTIO_BALLOON=m
> CONFIG_VIRTIO_INPUT=y
> diff --git a/drivers/gpu/drm/i915/Kconfig b/drivers/gpu/drm/i915/Kconfig
> index 3efce05d7b57ca..d06da455253cdb 100644
> --- a/drivers/gpu/drm/i915/Kconfig
> +++ b/drivers/gpu/drm/i915/Kconfig
> @@ -116,9 +116,9 @@ config DRM_I915_GVT_KVMGT
> depends on X86
> depends on 64BIT
> depends on KVM
> - depends on VFIO_MDEV
> select DRM_I915_GVT
> select KVM_EXTERNAL_WRITE_TRACKING
> + select VFIO_MDEV
>
> help
> Choose this option if you want to enable Intel GVT-g graphics
> diff --git a/drivers/vfio/mdev/Kconfig b/drivers/vfio/mdev/Kconfig
> index 646dbed44eb283..e5fb84e0796507 100644
> --- a/drivers/vfio/mdev/Kconfig
> +++ b/drivers/vfio/mdev/Kconfig
> @@ -1,10 +1,4 @@
> # SPDX-License-Identifier: GPL-2.0-only
>
> config VFIO_MDEV
> - tristate "Mediated device driver framework"
> - default n
> - help
> - Provides a framework to virtualize devices.
> - See Documentation/driver-api/vfio-mediated-device.rst for more details.
> -
> - If you don't know what do here, say N.
> + tristate
> diff --git a/samples/Kconfig b/samples/Kconfig
> index f1b8d4ff123036..56b191d128d88f 100644
> --- a/samples/Kconfig
> +++ b/samples/Kconfig
> @@ -185,14 +185,14 @@ config SAMPLE_UHID
>
> config SAMPLE_VFIO_MDEV_MTTY
> tristate "Build VFIO mtty example mediated device sample code"
> - depends on VFIO_MDEV
> + select VFIO_MDEV
> help
> Build a virtual tty sample driver for use as a VFIO
> mediated device
>
> config SAMPLE_VFIO_MDEV_MDPY
> tristate "Build VFIO mdpy example mediated device sample code"
> - depends on VFIO_MDEV
> + select VFIO_MDEV
> help
> Build a virtual display sample driver for use as a VFIO
> mediated device. It is a simple framebuffer and supports
> @@ -209,7 +209,7 @@ config SAMPLE_VFIO_MDEV_MDPY_FB
>
> config SAMPLE_VFIO_MDEV_MBOCHS
> tristate "Build VFIO mdpy example mediated device sample code"
> - depends on VFIO_MDEV
> + select VFIO_MDEV
> select DMA_SHARED_BUFFER
> help
> Build a virtual display sample driver for use as a VFIO
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [Intel-gfx] [PATCH 1/4] vfio-mdev: allow building the samples into the kernel
2023-01-10 9:10 ` [Intel-gfx] " Christoph Hellwig
@ 2023-01-10 14:54 ` Anthony Krowiak
-1 siblings, 0 replies; 28+ messages in thread
From: Anthony Krowiak @ 2023-01-10 14:54 UTC (permalink / raw)
To: Christoph Hellwig, Alex Williamson, Kirti Wankhede
Cc: Jason Herne, linux-s390, kvm, intel-gfx, Halil Pasic
On 1/10/23 4:10 AM, Christoph Hellwig wrote:
> There is nothing in the vfio-mdev sample drivers that requires building
> them as modules, so remove that restriction.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> samples/Kconfig | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/samples/Kconfig b/samples/Kconfig
> index 0d81c00289ee36..f1b8d4ff123036 100644
> --- a/samples/Kconfig
> +++ b/samples/Kconfig
> @@ -184,23 +184,23 @@ config SAMPLE_UHID
> Build UHID sample program.
>
> config SAMPLE_VFIO_MDEV_MTTY
> - tristate "Build VFIO mtty example mediated device sample code -- loadable modules only"
> - depends on VFIO_MDEV && m
> + tristate "Build VFIO mtty example mediated device sample code"
> + depends on VFIO_MDEV
Admittedly, I'm not very fluent with Kconfig, but in patch 2 you stated,
"VFIO_MDEV is just a library with helpers for the drivers. Stop making
it a user choice and just select it by the drivers that use the
helpers". Why are you not selecting it here?
> help
> Build a virtual tty sample driver for use as a VFIO
> mediated device
>
> config SAMPLE_VFIO_MDEV_MDPY
> - tristate "Build VFIO mdpy example mediated device sample code -- loadable modules only"
> - depends on VFIO_MDEV && m
> + tristate "Build VFIO mdpy example mediated device sample code"
> + depends on VFIO_MDEV
> help
> Build a virtual display sample driver for use as a VFIO
> mediated device. It is a simple framebuffer and supports
> the region display interface (VFIO_GFX_PLANE_TYPE_REGION).
>
> config SAMPLE_VFIO_MDEV_MDPY_FB
> - tristate "Build VFIO mdpy example guest fbdev driver -- loadable module only"
> - depends on FB && m
> + tristate "Build VFIO mdpy example guest fbdev driver"
> + depends on FB
> select FB_CFB_FILLRECT
> select FB_CFB_COPYAREA
> select FB_CFB_IMAGEBLIT
> @@ -208,8 +208,8 @@ config SAMPLE_VFIO_MDEV_MDPY_FB
> Guest fbdev driver for the virtual display sample driver.
>
> config SAMPLE_VFIO_MDEV_MBOCHS
> - tristate "Build VFIO mdpy example mediated device sample code -- loadable modules only"
> - depends on VFIO_MDEV && m
> + tristate "Build VFIO mdpy example mediated device sample code"
> + depends on VFIO_MDEV
> select DMA_SHARED_BUFFER
> help
> Build a virtual display sample driver for use as a VFIO
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 1/4] vfio-mdev: allow building the samples into the kernel
@ 2023-01-10 14:54 ` Anthony Krowiak
0 siblings, 0 replies; 28+ messages in thread
From: Anthony Krowiak @ 2023-01-10 14:54 UTC (permalink / raw)
To: Christoph Hellwig, Alex Williamson, Kirti Wankhede
Cc: Halil Pasic, Jason Herne, Zhenyu Wang, Zhi Wang, kvm, linux-s390,
intel-gfx
On 1/10/23 4:10 AM, Christoph Hellwig wrote:
> There is nothing in the vfio-mdev sample drivers that requires building
> them as modules, so remove that restriction.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> samples/Kconfig | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/samples/Kconfig b/samples/Kconfig
> index 0d81c00289ee36..f1b8d4ff123036 100644
> --- a/samples/Kconfig
> +++ b/samples/Kconfig
> @@ -184,23 +184,23 @@ config SAMPLE_UHID
> Build UHID sample program.
>
> config SAMPLE_VFIO_MDEV_MTTY
> - tristate "Build VFIO mtty example mediated device sample code -- loadable modules only"
> - depends on VFIO_MDEV && m
> + tristate "Build VFIO mtty example mediated device sample code"
> + depends on VFIO_MDEV
Admittedly, I'm not very fluent with Kconfig, but in patch 2 you stated,
"VFIO_MDEV is just a library with helpers for the drivers. Stop making
it a user choice and just select it by the drivers that use the
helpers". Why are you not selecting it here?
> help
> Build a virtual tty sample driver for use as a VFIO
> mediated device
>
> config SAMPLE_VFIO_MDEV_MDPY
> - tristate "Build VFIO mdpy example mediated device sample code -- loadable modules only"
> - depends on VFIO_MDEV && m
> + tristate "Build VFIO mdpy example mediated device sample code"
> + depends on VFIO_MDEV
> help
> Build a virtual display sample driver for use as a VFIO
> mediated device. It is a simple framebuffer and supports
> the region display interface (VFIO_GFX_PLANE_TYPE_REGION).
>
> config SAMPLE_VFIO_MDEV_MDPY_FB
> - tristate "Build VFIO mdpy example guest fbdev driver -- loadable module only"
> - depends on FB && m
> + tristate "Build VFIO mdpy example guest fbdev driver"
> + depends on FB
> select FB_CFB_FILLRECT
> select FB_CFB_COPYAREA
> select FB_CFB_IMAGEBLIT
> @@ -208,8 +208,8 @@ config SAMPLE_VFIO_MDEV_MDPY_FB
> Guest fbdev driver for the virtual display sample driver.
>
> config SAMPLE_VFIO_MDEV_MBOCHS
> - tristate "Build VFIO mdpy example mediated device sample code -- loadable modules only"
> - depends on VFIO_MDEV && m
> + tristate "Build VFIO mdpy example mediated device sample code"
> + depends on VFIO_MDEV
> select DMA_SHARED_BUFFER
> help
> Build a virtual display sample driver for use as a VFIO
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 1/4] vfio-mdev: allow building the samples into the kernel
2023-01-10 14:54 ` Anthony Krowiak
@ 2023-01-10 15:27 ` Christoph Hellwig
-1 siblings, 0 replies; 28+ messages in thread
From: Christoph Hellwig @ 2023-01-10 15:27 UTC (permalink / raw)
To: Anthony Krowiak
Cc: Christoph Hellwig, Alex Williamson, Kirti Wankhede, Halil Pasic,
Jason Herne, Zhenyu Wang, Zhi Wang, kvm, linux-s390, intel-gfx
On Tue, Jan 10, 2023 at 09:54:51AM -0500, Anthony Krowiak wrote:
>> + tristate "Build VFIO mtty example mediated device sample code"
>> + depends on VFIO_MDEV
>
>
> Admittedly, I'm not very fluent with Kconfig, but in patch 2 you stated,
> "VFIO_MDEV is just a library with helpers for the drivers. Stop making it a
> user choice and just select it by the drivers that use the helpers". Why
> are you not selecting it here?
Because this changes one thing at a time. Patch 2 then switches this
depends to a select.
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [Intel-gfx] [PATCH 1/4] vfio-mdev: allow building the samples into the kernel
@ 2023-01-10 15:27 ` Christoph Hellwig
0 siblings, 0 replies; 28+ messages in thread
From: Christoph Hellwig @ 2023-01-10 15:27 UTC (permalink / raw)
To: Anthony Krowiak
Cc: Jason Herne, linux-s390, kvm, intel-gfx, Kirti Wankhede,
Halil Pasic, Christoph Hellwig
On Tue, Jan 10, 2023 at 09:54:51AM -0500, Anthony Krowiak wrote:
>> + tristate "Build VFIO mtty example mediated device sample code"
>> + depends on VFIO_MDEV
>
>
> Admittedly, I'm not very fluent with Kconfig, but in patch 2 you stated,
> "VFIO_MDEV is just a library with helpers for the drivers. Stop making it a
> user choice and just select it by the drivers that use the helpers". Why
> are you not selecting it here?
Because this changes one thing at a time. Patch 2 then switches this
depends to a select.
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [Intel-gfx] [PATCH 1/4] vfio-mdev: allow building the samples into the kernel
2023-01-10 15:27 ` [Intel-gfx] " Christoph Hellwig
@ 2023-01-10 15:32 ` Anthony Krowiak
-1 siblings, 0 replies; 28+ messages in thread
From: Anthony Krowiak @ 2023-01-10 15:32 UTC (permalink / raw)
To: Christoph Hellwig
Cc: Jason Herne, linux-s390, kvm, intel-gfx, Kirti Wankhede, Halil Pasic
On 1/10/23 10:27 AM, Christoph Hellwig wrote:
> On Tue, Jan 10, 2023 at 09:54:51AM -0500, Anthony Krowiak wrote:
>>> + tristate "Build VFIO mtty example mediated device sample code"
>>> + depends on VFIO_MDEV
>>
>> Admittedly, I'm not very fluent with Kconfig, but in patch 2 you stated,
>> "VFIO_MDEV is just a library with helpers for the drivers. Stop making it a
>> user choice and just select it by the drivers that use the helpers". Why
>> are you not selecting it here?
> Because this changes one thing at a time. Patch 2 then switches this
> depends to a select.
My bad, I missed it.
Reviewed-by: Tony Krowiak <akrowiak@linux.ibm.com>
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 1/4] vfio-mdev: allow building the samples into the kernel
@ 2023-01-10 15:32 ` Anthony Krowiak
0 siblings, 0 replies; 28+ messages in thread
From: Anthony Krowiak @ 2023-01-10 15:32 UTC (permalink / raw)
To: Christoph Hellwig
Cc: Alex Williamson, Kirti Wankhede, Halil Pasic, Jason Herne,
Zhenyu Wang, Zhi Wang, kvm, linux-s390, intel-gfx
On 1/10/23 10:27 AM, Christoph Hellwig wrote:
> On Tue, Jan 10, 2023 at 09:54:51AM -0500, Anthony Krowiak wrote:
>>> + tristate "Build VFIO mtty example mediated device sample code"
>>> + depends on VFIO_MDEV
>>
>> Admittedly, I'm not very fluent with Kconfig, but in patch 2 you stated,
>> "VFIO_MDEV is just a library with helpers for the drivers. Stop making it a
>> user choice and just select it by the drivers that use the helpers". Why
>> are you not selecting it here?
> Because this changes one thing at a time. Patch 2 then switches this
> depends to a select.
My bad, I missed it.
Reviewed-by: Tony Krowiak <akrowiak@linux.ibm.com>
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 1/4] vfio-mdev: allow building the samples into the kernel
2023-01-10 9:10 ` [Intel-gfx] " Christoph Hellwig
(?)
(?)
@ 2023-01-10 16:11 ` Jason Gunthorpe
-1 siblings, 0 replies; 28+ messages in thread
From: Jason Gunthorpe @ 2023-01-10 16:11 UTC (permalink / raw)
To: Christoph Hellwig
Cc: Alex Williamson, Kirti Wankhede, Tony Krowiak, Halil Pasic,
Jason Herne, Zhenyu Wang, Zhi Wang, kvm, linux-s390, intel-gfx
On Tue, Jan 10, 2023 at 10:10:06AM +0100, Christoph Hellwig wrote:
> There is nothing in the vfio-mdev sample drivers that requires building
> them as modules, so remove that restriction.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> samples/Kconfig | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Jason
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 2/4] vfio-mdev: turn VFIO_MDEV into a selectable symbol
2023-01-10 9:10 ` [Intel-gfx] " Christoph Hellwig
(?)
(?)
@ 2023-01-10 16:12 ` Jason Gunthorpe
-1 siblings, 0 replies; 28+ messages in thread
From: Jason Gunthorpe @ 2023-01-10 16:12 UTC (permalink / raw)
To: Christoph Hellwig
Cc: Alex Williamson, Kirti Wankhede, Tony Krowiak, Halil Pasic,
Jason Herne, Zhenyu Wang, Zhi Wang, kvm, linux-s390, intel-gfx
On Tue, Jan 10, 2023 at 10:10:07AM +0100, Christoph Hellwig wrote:
> VFIO_MDEV is just a library with helpers for the drivers. Stop making
> it a user choice and just select it by the drivers that use the helpers.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> Documentation/s390/vfio-ap.rst | 1 -
> arch/s390/Kconfig | 6 ++++--
> arch/s390/configs/debug_defconfig | 1 -
> arch/s390/configs/defconfig | 1 -
> drivers/gpu/drm/i915/Kconfig | 2 +-
> drivers/vfio/mdev/Kconfig | 8 +-------
> samples/Kconfig | 6 +++---
> 7 files changed, 9 insertions(+), 16 deletions(-)
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Jason
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 3/4] vfio-mdev: move the mtty usage documentation
2023-01-10 9:10 ` [Intel-gfx] " Christoph Hellwig
(?)
@ 2023-01-10 16:12 ` Jason Gunthorpe
-1 siblings, 0 replies; 28+ messages in thread
From: Jason Gunthorpe @ 2023-01-10 16:12 UTC (permalink / raw)
To: Christoph Hellwig
Cc: Alex Williamson, Kirti Wankhede, Tony Krowiak, Halil Pasic,
Jason Herne, Zhenyu Wang, Zhi Wang, kvm, linux-s390, intel-gfx
On Tue, Jan 10, 2023 at 10:10:08AM +0100, Christoph Hellwig wrote:
> Move the documentation on how to use mtty to samples/vfio-mdev/README.rst
> as it is in no way related to the vfio API. This matches how the bpf
> and pktgen samples are documented.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> .../driver-api/vfio-mediated-device.rst | 100 ------------------
> samples/vfio-mdev/README.rst | 100 ++++++++++++++++++
> 2 files changed, 100 insertions(+), 100 deletions(-)
> create mode 100644 samples/vfio-mdev/README.rst
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Jason
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 4/4] vfio-mdev: remove an non-existing driver from vfio-mediated-device
2023-01-10 9:10 ` [Intel-gfx] " Christoph Hellwig
(?)
(?)
@ 2023-01-10 16:13 ` Jason Gunthorpe
-1 siblings, 0 replies; 28+ messages in thread
From: Jason Gunthorpe @ 2023-01-10 16:13 UTC (permalink / raw)
To: Christoph Hellwig
Cc: Alex Williamson, Kirti Wankhede, Tony Krowiak, Halil Pasic,
Jason Herne, Zhenyu Wang, Zhi Wang, kvm, linux-s390, intel-gfx
On Tue, Jan 10, 2023 at 10:10:09AM +0100, Christoph Hellwig wrote:
> The nvidia mdev driver does not actually exist anywhere in the tree.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> Documentation/driver-api/vfio-mediated-device.rst | 8 +-------
> 1 file changed, 1 insertion(+), 7 deletions(-)
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Jason
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [Intel-gfx] misc mdev tidyups
2023-01-10 9:10 ` [Intel-gfx] " Christoph Hellwig
@ 2023-01-23 19:37 ` Alex Williamson
-1 siblings, 0 replies; 28+ messages in thread
From: Alex Williamson @ 2023-01-23 19:37 UTC (permalink / raw)
To: Christoph Hellwig
Cc: Tony Krowiak, Jason Herne, kvm, linux-s390, intel-gfx,
Halil Pasic, Kirti Wankhede
On Tue, 10 Jan 2023 10:10:05 +0100
Christoph Hellwig <hch@lst.de> wrote:
> Hi all,
>
> this series tidies up the mdev Kconfig interaction and documentation a bit.
>
> Diffstat:
> Documentation/driver-api/vfio-mediated-device.rst | 108 ----------------------
> Documentation/s390/vfio-ap.rst | 1
> arch/s390/Kconfig | 6 -
> arch/s390/configs/debug_defconfig | 1
> arch/s390/configs/defconfig | 1
> drivers/gpu/drm/i915/Kconfig | 2
> drivers/vfio/mdev/Kconfig | 8 -
> samples/Kconfig | 16 +--
> samples/vfio-mdev/README.rst | 100 ++++++++++++++++++++
> 9 files changed, 115 insertions(+), 128 deletions(-)
>
Applied to vfio next branch for v6.3. Thanks,
Alex
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: misc mdev tidyups
@ 2023-01-23 19:37 ` Alex Williamson
0 siblings, 0 replies; 28+ messages in thread
From: Alex Williamson @ 2023-01-23 19:37 UTC (permalink / raw)
To: Christoph Hellwig
Cc: Kirti Wankhede, Tony Krowiak, Halil Pasic, Jason Herne,
Zhenyu Wang, Zhi Wang, kvm, linux-s390, intel-gfx
On Tue, 10 Jan 2023 10:10:05 +0100
Christoph Hellwig <hch@lst.de> wrote:
> Hi all,
>
> this series tidies up the mdev Kconfig interaction and documentation a bit.
>
> Diffstat:
> Documentation/driver-api/vfio-mediated-device.rst | 108 ----------------------
> Documentation/s390/vfio-ap.rst | 1
> arch/s390/Kconfig | 6 -
> arch/s390/configs/debug_defconfig | 1
> arch/s390/configs/defconfig | 1
> drivers/gpu/drm/i915/Kconfig | 2
> drivers/vfio/mdev/Kconfig | 8 -
> samples/Kconfig | 16 +--
> samples/vfio-mdev/README.rst | 100 ++++++++++++++++++++
> 9 files changed, 115 insertions(+), 128 deletions(-)
>
Applied to vfio next branch for v6.3. Thanks,
Alex
^ permalink raw reply [flat|nested] 28+ messages in thread
end of thread, other threads:[~2023-01-23 19:38 UTC | newest]
Thread overview: 28+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-10 9:10 misc mdev tidyups Christoph Hellwig
2023-01-10 9:10 ` [Intel-gfx] " Christoph Hellwig
2023-01-10 9:10 ` [PATCH 1/4] vfio-mdev: allow building the samples into the kernel Christoph Hellwig
2023-01-10 9:10 ` [Intel-gfx] " Christoph Hellwig
2023-01-10 14:54 ` Anthony Krowiak
2023-01-10 14:54 ` Anthony Krowiak
2023-01-10 15:27 ` Christoph Hellwig
2023-01-10 15:27 ` [Intel-gfx] " Christoph Hellwig
2023-01-10 15:32 ` Anthony Krowiak
2023-01-10 15:32 ` Anthony Krowiak
2023-01-10 16:11 ` Jason Gunthorpe
2023-01-10 9:10 ` [PATCH 2/4] vfio-mdev: turn VFIO_MDEV into a selectable symbol Christoph Hellwig
2023-01-10 9:10 ` [Intel-gfx] " Christoph Hellwig
2023-01-10 14:51 ` Anthony Krowiak
2023-01-10 14:51 ` [Intel-gfx] " Anthony Krowiak
2023-01-10 16:12 ` Jason Gunthorpe
2023-01-10 9:10 ` [PATCH 3/4] vfio-mdev: move the mtty usage documentation Christoph Hellwig
2023-01-10 9:10 ` [Intel-gfx] " Christoph Hellwig
2023-01-10 16:12 ` Jason Gunthorpe
2023-01-10 9:10 ` [PATCH 4/4] vfio-mdev: remove an non-existing driver from vfio-mediated-device Christoph Hellwig
2023-01-10 9:10 ` [Intel-gfx] " Christoph Hellwig
2023-01-10 14:49 ` Anthony Krowiak
2023-01-10 14:49 ` Anthony Krowiak
2023-01-10 16:13 ` Jason Gunthorpe
2023-01-10 9:48 ` [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/4] vfio-mdev: allow building the samples into the kernel Patchwork
2023-01-10 12:05 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2023-01-23 19:37 ` [Intel-gfx] misc mdev tidyups Alex Williamson
2023-01-23 19:37 ` Alex Williamson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.