[PATCH v1 1/2] gpio: zevio: Remove duplicate assignment of of_gpio_n_cells

[PATCH v1 1/2] gpio: zevio: Remove duplicate assignment of of_gpio_n_cells

[Andy Shevchenko]

The of_gpio_n_cells default is 2 when ->of_xlate() callback is
not defined. No need to assign it explicitly in the driver.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/gpio/gpio-zevio.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpio/gpio-zevio.c b/drivers/gpio/gpio-zevio.c
index ce9d1282165c..c9f4c26cae3d 100644
--- a/drivers/gpio/gpio-zevio.c
+++ b/drivers/gpio/gpio-zevio.c
@@ -162,7 +162,6 @@ static const struct gpio_chip zevio_gpio_chip = {
 	.base			= 0,
 	.owner			= THIS_MODULE,
 	.ngpio			= 32,
-	.of_gpio_n_cells	= 2,
 };
 
 /* Initialization */
-- 
2.39.0

[PATCH v1 2/2] gpio: zevio: Use proper headers and drop OF_GPIO dependency

[Andy Shevchenko]

The driver doesn't depend on the OF_GPIO to be compiled. Hence
the proper header to use is mod_devicetable.h. Replace of*.h with
the above mentioned and drop redundant dependency.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/gpio/Kconfig      | 2 +-
 drivers/gpio/gpio-zevio.c | 7 ++++---
 2 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index 3b2078a654ce..a2f64f880163 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -751,7 +751,7 @@ config GPIO_XTENSA
 
 config GPIO_ZEVIO
 	bool "LSI ZEVIO SoC memory mapped GPIOs"
-	depends on ARM && OF_GPIO
+	depends on ARM
 	help
 	  Say yes here to support the GPIO controller in LSI ZEVIO SoCs.
 
diff --git a/drivers/gpio/gpio-zevio.c b/drivers/gpio/gpio-zevio.c
index c9f4c26cae3d..61e47456c33a 100644
--- a/drivers/gpio/gpio-zevio.c
+++ b/drivers/gpio/gpio-zevio.c
@@ -5,13 +5,14 @@
  * Author: Fabian Vogt <fabian@ritter-vogt.de>
  */
 
-#include <linux/spinlock.h>
+#include <linux/bitops.h>
 #include <linux/errno.h>
 #include <linux/init.h>
-#include <linux/bitops.h>
 #include <linux/io.h>
-#include <linux/of_device.h>
+#include <linux/mod_devicetable.h>
 #include <linux/slab.h>
+#include <linux/spinlock.h>
+
 #include <linux/gpio/driver.h>
 
 /*
-- 
2.39.0

Re: [PATCH v1 1/2] gpio: zevio: Remove duplicate assignment of of_gpio_n_cells

[Bartosz Golaszewski]

On Thu, Jan 12, 2023 at 5:39 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> The of_gpio_n_cells default is 2 when ->of_xlate() callback is
> not defined. No need to assign it explicitly in the driver.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  drivers/gpio/gpio-zevio.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-zevio.c b/drivers/gpio/gpio-zevio.c
> index ce9d1282165c..c9f4c26cae3d 100644
> --- a/drivers/gpio/gpio-zevio.c
> +++ b/drivers/gpio/gpio-zevio.c
> @@ -162,7 +162,6 @@ static const struct gpio_chip zevio_gpio_chip = {
>         .base                   = 0,
>         .owner                  = THIS_MODULE,
>         .ngpio                  = 32,
> -       .of_gpio_n_cells        = 2,
>  };
>
>  /* Initialization */
> --
> 2.39.0
>

Applied, thanks!

Bart

Re: [PATCH v1 2/2] gpio: zevio: Use proper headers and drop OF_GPIO dependency

[Bartosz Golaszewski]

On Thu, Jan 12, 2023 at 5:39 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> The driver doesn't depend on the OF_GPIO to be compiled. Hence
> the proper header to use is mod_devicetable.h. Replace of*.h with
> the above mentioned and drop redundant dependency.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  drivers/gpio/Kconfig      | 2 +-
>  drivers/gpio/gpio-zevio.c | 7 ++++---
>  2 files changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> index 3b2078a654ce..a2f64f880163 100644
> --- a/drivers/gpio/Kconfig
> +++ b/drivers/gpio/Kconfig
> @@ -751,7 +751,7 @@ config GPIO_XTENSA
>
>  config GPIO_ZEVIO
>         bool "LSI ZEVIO SoC memory mapped GPIOs"
> -       depends on ARM && OF_GPIO
> +       depends on ARM
>         help
>           Say yes here to support the GPIO controller in LSI ZEVIO SoCs.
>
> diff --git a/drivers/gpio/gpio-zevio.c b/drivers/gpio/gpio-zevio.c
> index c9f4c26cae3d..61e47456c33a 100644
> --- a/drivers/gpio/gpio-zevio.c
> +++ b/drivers/gpio/gpio-zevio.c
> @@ -5,13 +5,14 @@
>   * Author: Fabian Vogt <fabian@ritter-vogt.de>
>   */
>
> -#include <linux/spinlock.h>
> +#include <linux/bitops.h>
>  #include <linux/errno.h>
>  #include <linux/init.h>
> -#include <linux/bitops.h>
>  #include <linux/io.h>
> -#include <linux/of_device.h>
> +#include <linux/mod_devicetable.h>
>  #include <linux/slab.h>
> +#include <linux/spinlock.h>
> +
>  #include <linux/gpio/driver.h>
>
>  /*
> --
> 2.39.0
>

Applied, thanks!

Bart