[PATCH BlueZ 0/1] *** hcidump: fix array boundary issue le_meta_ev_dump ***

[PATCH BlueZ 0/1] *** hcidump: fix array boundary issue le_meta_ev_dump ***

[Jing Qian]

*** BLURB HERE ***

Jing Qian (1):
  hcidump:fix array boundary issue le_meta_ev_dump()

 tools/parser/hci.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)


base-commit: 4e2ae14ea31178ebbbcb0bc81dfe74bd56b4885f
prerequisite-patch-id: 575020e7a5c285246441a91a4273d7eadaed45ac
prerequisite-patch-id: 6d2faa9ddc42fb2e346c0708d7624f9e7ed67c98
prerequisite-patch-id: 039c4d44eae6e358148da5a1d04a3ef9602f6a67
prerequisite-patch-id: ec5b1c0ec7a429dbbbf0367adb61b191ee231b59
prerequisite-patch-id: 6ea9dc8e56804c2755e9dc8cdc811690fb6c2c17
-- 
2.25.1

[PATCH BlueZ 1/1] hcidump:fix array boundary issue le_meta_ev_dump()

[Jing Qian]

le_meta_ev_dump() print array content without checking index boundary.
hcidump would crash if the event index is out-of-boundary
---
 tools/parser/hci.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/tools/parser/hci.c b/tools/parser/hci.c
index db7d32c011b9..30feafaed36c 100644
--- a/tools/parser/hci.c
+++ b/tools/parser/hci.c
@@ -3657,7 +3657,11 @@ static inline void le_meta_ev_dump(int level, struct frame *frm)
 	frm->len -= EVT_LE_META_EVENT_SIZE;
 
 	p_indent(level, frm);
-	printf("%s\n", ev_le_meta_str[subevent]);
+	if (subevent <= LE_EV_NUM) {
+		printf("%s\n", ev_le_meta_str[subevent]);
+	} else {
+		printf("Undefined--> %d\n", subevent);
+	}
 
 	switch (mevt->subevent) {
 	case EVT_LE_CONN_COMPLETE:
-- 
2.25.1

RE: *** hcidump: fix array boundary issue le_meta_ev_dump ***

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 945 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=711516

---Test result---

Test Summary:
CheckPatch                    PASS      0.57 seconds
GitLint                       PASS      0.28 seconds
BuildEll                      PASS      26.78 seconds
BluezMake                     PASS      760.11 seconds
MakeCheck                     PASS      11.57 seconds
MakeDistcheck                 PASS      148.88 seconds
CheckValgrind                 PASS      239.87 seconds
CheckSmatch                   PASS      320.10 seconds
bluezmakeextell               PASS      96.40 seconds
IncrementalBuild              PASS      610.04 seconds
ScanBuild                     PASS      954.08 seconds



---
Regards,
Linux Bluetooth

[PATCH BlueZ 0/1] *** hcidump: fix array boundary issue le_meta_ev_dump ***

[Jing Qian]

*** BLURB HERE ***

Jing Qian (1):
  hcidump:fix array boundary issue le_meta_ev_dump()

 tools/parser/hci.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)


base-commit: 4e2ae14ea31178ebbbcb0bc81dfe74bd56b4885f
-- 
2.25.1