From: Stephen Hemminger <stephen@networkplumber.org>
To: Jamal Hadi Salim <jhs@mojatatu.com>
Cc: Hangbin Liu <liuhangbin@gmail.com>,
netdev@vger.kernel.org, Cong Wang <xiyou.wangcong@gmail.com>,
Jiri Pirko <jiri@resnulli.us>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
David Ahern <dsahern@kernel.org>
Subject: Re: [PATCH iproute2-next 2/2] tc: add new attr TCA_EXT_WARN_MSG
Date: Sat, 14 Jan 2023 09:03:11 -0800 [thread overview]
Message-ID: <20230114090311.1adf0176@hermes.local> (raw)
In-Reply-To: <CAM0EoMmw+uQuXkVZprspDbqtoQLGHEM0An0ogzD5bFdOJEqWXg@mail.gmail.com>
On Sat, 14 Jan 2023 07:59:39 -0500
Jamal Hadi Salim <jhs@mojatatu.com> wrote:
> This is not really an error IMO (and therefore doesnt belong in
> stderr). If i send a request to add an
> entry and ask that it is installed both in the kernel as well as
> offloaded into h/w and half of that
> worked (example hardware rejected it for some reason) then the event
> generated (as observed by
> f.e. tc mon) will appear in TCA_EXT_WARN_MSG and the consumer of that
> event needs to see it
> if they are using the json format.
>
Ok, but use lower case for JSON tag following existing conventions.
Note: json support in monitor mode is incomplete for many of the
commands bridge, ip, tc, devlink. It doesn't always generate valid JSON
yet.
next prev parent reply other threads:[~2023-01-14 17:03 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-13 3:43 [PATCHv4 net-next] sched: add new attr TCA_EXT_WARN_MSG to report tc extact message Hangbin Liu
2023-01-13 3:46 ` [PATCH iproute2-next 1/2] Revert "tc/tc_monitor: print netlink extack message" Hangbin Liu
2023-01-13 3:46 ` [PATCH iproute2-next 2/2] tc: add new attr TCA_EXT_WARN_MSG Hangbin Liu
2023-01-13 4:00 ` Hangbin Liu
2023-01-13 4:30 ` Stephen Hemminger
2023-01-13 6:20 ` Hangbin Liu
2023-01-14 12:59 ` Jamal Hadi Salim
2023-01-14 17:03 ` Stephen Hemminger [this message]
2023-01-17 15:09 ` Jamal Hadi Salim
2023-01-31 9:53 ` Hangbin Liu
2023-01-14 2:15 ` David Ahern
2023-01-14 6:15 ` [PATCHv4 net-next] sched: add new attr TCA_EXT_WARN_MSG to report tc extact message Jakub Kicinski
2023-01-14 12:19 ` Jamal Hadi Salim
2023-01-17 7:19 ` [PATCHv2 iproute2-next 0/2] tc: add new attr TCA_EXT_WARN_MSG Hangbin Liu
2023-01-17 7:19 ` [PATCHv2 iproute2-next 1/2] Revert "tc/tc_monitor: print netlink extack message" Hangbin Liu
2023-01-17 7:19 ` [PATCHv2 iproute2-next 2/2] tc: add new attr TCA_EXT_WARN_MSG Hangbin Liu
2023-01-22 18:10 ` [PATCHv2 iproute2-next 0/2] " patchwork-bot+netdevbpf
2023-01-17 8:50 ` [PATCHv4 net-next] sched: add new attr TCA_EXT_WARN_MSG to report tc extact message patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230114090311.1adf0176@hermes.local \
--to=stephen@networkplumber.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.