Re: [PATCH iproute2-next 2/2] tc: add new attr TCA_EXT_WARN_MSG

From: Jamal Hadi Salim <jhs@mojatatu.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: Hangbin Liu <liuhangbin@gmail.com>,
	netdev@vger.kernel.org, Cong Wang <xiyou.wangcong@gmail.com>,
	Jiri Pirko <jiri@resnulli.us>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	David Ahern <dsahern@kernel.org>
Subject: Re: [PATCH iproute2-next 2/2] tc: add new attr TCA_EXT_WARN_MSG
Date: Sat, 14 Jan 2023 07:59:39 -0500	[thread overview]
Message-ID: <CAM0EoMmw+uQuXkVZprspDbqtoQLGHEM0An0ogzD5bFdOJEqWXg@mail.gmail.com> (raw)
In-Reply-To: <20230112203019.738d9744@hermes.local>

This is not really an error IMO (and therefore doesnt belong in
stderr). If i send a request to add an
entry and ask that it is installed both in the kernel as well as
offloaded into h/w and half of that
worked (example hardware rejected it for some reason) then the event
generated (as observed by
f.e. tc mon) will appear in TCA_EXT_WARN_MSG and the consumer of that
event needs to see it
if they are using the json format.

cheers,
jamal

On Thu, Jan 12, 2023 at 11:30 PM Stephen Hemminger
<stephen@networkplumber.org> wrote:
>
> On Fri, 13 Jan 2023 11:46:17 +0800
> Hangbin Liu <liuhangbin@gmail.com> wrote:
>
> >       if (tb[TCA_EXT_WARN_MSG]) {
> > +             print_string(PRINT_ANY, "Warn", "%s ", rta_getattr_str(tb[TCA_EXT_WARN_MSG]));
> > +             print_nl();
> > +     }
> > +
>
> Errors should go to stderr, and not to stdout. And no JSON support please.