From: Srivatsa Vaddagiri <quic_svaddagi@quicinc.com> To: Elliot Berman <quic_eberman@quicinc.com> Cc: Bjorn Andersson <quic_bjorande@quicinc.com>, Murali Nalajala <quic_mnalajal@quicinc.com>, Trilok Soni <quic_tsoni@quicinc.com>, "Carl van Schaik" <quic_cvanscha@quicinc.com>, Prakruthi Deepak Heragu <quic_pheragu@quicinc.com>, Arnd Bergmann <arnd@arndb.de>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Rob Herring <robh+dt@kernel.org>, "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>, Jonathan Corbet <corbet@lwn.net>, Bagas Sanjaya <bagasdotme@gmail.com>, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>, Jassi Brar <jassisinghbrar@gmail.com>, Sudeep Holla <sudeep.holla@arm.com>, Mark Rutland <mark.rutland@arm.com>, Lorenzo Pieralisi <lpieralisi@kernel.org>, "Dmitry Baryshkov" <dmitry.baryshkov@linaro.org>, <linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <linux-doc@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <linux-acpi@vger.kernel.org> Subject: Re: [PATCH v8 13/28] gunyah: rsc_mgr: Add RPC for sharing memory Date: Mon, 16 Jan 2023 14:15:57 +0530 [thread overview] Message-ID: <20230116084557.GB1737564@quicinc.com> (raw) In-Reply-To: <20221219225850.2397345-14-quic_eberman@quicinc.com> * Elliot Berman <quic_eberman@quicinc.com> [2022-12-19 14:58:34]: > +static int _gh_rm_mem_append(struct gh_rm_rpc *rm, u32 mem_handle, bool end_append, > + struct gh_rm_mem_entry *mem_entries, size_t n_mem_entries) > +{ > + size_t msg_size = 0; > + void *msg; > + struct gh_mem_append_req_header *req_header; > + struct gh_mem_share_req_mem_section *mem_section; > + void *resp; > + size_t resp_size; > + int ret; > + > + msg_size += sizeof(struct gh_mem_append_req_header); > + msg_size += offsetof(struct gh_mem_share_req_mem_section, entries[n_mem_entries]); > + > + msg = kzalloc(msg_size, GFP_KERNEL); > + if (!msg) > + return -ENOMEM; > + > + req_header = msg; > + mem_section = (void *)req_header + sizeof(struct gh_mem_append_req_header); > + > + req_header->mem_handle = mem_handle; cpu_to_le(mem_handle); > + if (end_append) > + req_header->flags |= GH_MEM_APPEND_REQ_FLAGS_END; > + > + mem_section->n_entries = n_mem_entries; > + memcpy(mem_section->entries, mem_entries, sizeof(*mem_entries) * n_mem_entries); > + > + ret = gh_rm_call(rm, GH_RM_RPC_MEM_APPEND, msg, msg_size, &resp, &resp_size); > + if (ret) kfree(msg); > + return ret; > + kfree(resp); kfree(msg); > + > + return ret; > +} > + > +static int gh_rm_mem_append(struct gh_rm_rpc *rm, u32 mem_handle, bool allow_append, Is there any scenario where allow_append will be 'true'? As of this patch atleast, its always 'false', so maybe just avoid this input argument? > +static int gh_rm_mem_lend_common(struct gh_rm_rpc *rm, u32 message_id, struct gh_rm_mem_parcel *p) > +{ [snip] > + acl_section->n_entries = p->n_acl_entries; cpu_to_le32(p->n_acl_entries); > + memcpy(acl_section->entries, p->acl_entries, sizeof(*(p->acl_entries)) * p->n_acl_entries); > + > + mem_section->n_entries = initial_n_mem_entries; cpu_to_le32(initial_n_mem_entries); > + memcpy(mem_section->entries, p->mem_entries, > + sizeof(*(p->mem_entries)) * initial_n_mem_entries); > + > + /* Set n_entries for memory attribute section to 0 */ > + *mem_attr_section = 0; > + > + ret = gh_rm_call(rm, message_id, msg, msg_size, &resp, &resp_size); > + if (ret) kfree(msg) > + return ret; > + > + if (resp_size != sizeof(__le32)) { > + ret = -EIO; > + goto out; > + } > + > + p->mem_handle = le32_to_cpu(*(__le32 *)resp); > + > + if (initial_n_mem_entries != p->n_mem_entries) { > + ret = gh_rm_mem_append(rm, p->mem_handle, false, > + &p->mem_entries[initial_n_mem_entries], > + p->n_mem_entries - initial_n_mem_entries); > + if (ret) > + gh_rm_mem_reclaim(rm, p); p->mem_handle = GH_MEM_HANDLE_INVAL in this case? > + } > + > +out: kfree(msg) ?
WARNING: multiple messages have this Message-ID (diff)
From: Srivatsa Vaddagiri <quic_svaddagi@quicinc.com> To: Elliot Berman <quic_eberman@quicinc.com> Cc: Bjorn Andersson <quic_bjorande@quicinc.com>, Murali Nalajala <quic_mnalajal@quicinc.com>, Trilok Soni <quic_tsoni@quicinc.com>, "Carl van Schaik" <quic_cvanscha@quicinc.com>, Prakruthi Deepak Heragu <quic_pheragu@quicinc.com>, Arnd Bergmann <arnd@arndb.de>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Rob Herring <robh+dt@kernel.org>, "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>, Jonathan Corbet <corbet@lwn.net>, Bagas Sanjaya <bagasdotme@gmail.com>, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>, Jassi Brar <jassisinghbrar@gmail.com>, Sudeep Holla <sudeep.holla@arm.com>, Mark Rutland <mark.rutland@arm.com>, Lorenzo Pieralisi <lpieralisi@kernel.org>, "Dmitry Baryshkov" <dmitry.baryshkov@linaro.org>, <linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <linux-doc@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <linux-acpi@vger.kernel.org> Subject: Re: [PATCH v8 13/28] gunyah: rsc_mgr: Add RPC for sharing memory Date: Mon, 16 Jan 2023 14:15:57 +0530 [thread overview] Message-ID: <20230116084557.GB1737564@quicinc.com> (raw) In-Reply-To: <20221219225850.2397345-14-quic_eberman@quicinc.com> * Elliot Berman <quic_eberman@quicinc.com> [2022-12-19 14:58:34]: > +static int _gh_rm_mem_append(struct gh_rm_rpc *rm, u32 mem_handle, bool end_append, > + struct gh_rm_mem_entry *mem_entries, size_t n_mem_entries) > +{ > + size_t msg_size = 0; > + void *msg; > + struct gh_mem_append_req_header *req_header; > + struct gh_mem_share_req_mem_section *mem_section; > + void *resp; > + size_t resp_size; > + int ret; > + > + msg_size += sizeof(struct gh_mem_append_req_header); > + msg_size += offsetof(struct gh_mem_share_req_mem_section, entries[n_mem_entries]); > + > + msg = kzalloc(msg_size, GFP_KERNEL); > + if (!msg) > + return -ENOMEM; > + > + req_header = msg; > + mem_section = (void *)req_header + sizeof(struct gh_mem_append_req_header); > + > + req_header->mem_handle = mem_handle; cpu_to_le(mem_handle); > + if (end_append) > + req_header->flags |= GH_MEM_APPEND_REQ_FLAGS_END; > + > + mem_section->n_entries = n_mem_entries; > + memcpy(mem_section->entries, mem_entries, sizeof(*mem_entries) * n_mem_entries); > + > + ret = gh_rm_call(rm, GH_RM_RPC_MEM_APPEND, msg, msg_size, &resp, &resp_size); > + if (ret) kfree(msg); > + return ret; > + kfree(resp); kfree(msg); > + > + return ret; > +} > + > +static int gh_rm_mem_append(struct gh_rm_rpc *rm, u32 mem_handle, bool allow_append, Is there any scenario where allow_append will be 'true'? As of this patch atleast, its always 'false', so maybe just avoid this input argument? > +static int gh_rm_mem_lend_common(struct gh_rm_rpc *rm, u32 message_id, struct gh_rm_mem_parcel *p) > +{ [snip] > + acl_section->n_entries = p->n_acl_entries; cpu_to_le32(p->n_acl_entries); > + memcpy(acl_section->entries, p->acl_entries, sizeof(*(p->acl_entries)) * p->n_acl_entries); > + > + mem_section->n_entries = initial_n_mem_entries; cpu_to_le32(initial_n_mem_entries); > + memcpy(mem_section->entries, p->mem_entries, > + sizeof(*(p->mem_entries)) * initial_n_mem_entries); > + > + /* Set n_entries for memory attribute section to 0 */ > + *mem_attr_section = 0; > + > + ret = gh_rm_call(rm, message_id, msg, msg_size, &resp, &resp_size); > + if (ret) kfree(msg) > + return ret; > + > + if (resp_size != sizeof(__le32)) { > + ret = -EIO; > + goto out; > + } > + > + p->mem_handle = le32_to_cpu(*(__le32 *)resp); > + > + if (initial_n_mem_entries != p->n_mem_entries) { > + ret = gh_rm_mem_append(rm, p->mem_handle, false, > + &p->mem_entries[initial_n_mem_entries], > + p->n_mem_entries - initial_n_mem_entries); > + if (ret) > + gh_rm_mem_reclaim(rm, p); p->mem_handle = GH_MEM_HANDLE_INVAL in this case? > + } > + > +out: kfree(msg) ? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-01-16 8:46 UTC|newest] Thread overview: 137+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-12-19 22:58 [PATCH v8 00/28] Drivers for gunyah hypervisor Elliot Berman 2022-12-19 22:58 ` Elliot Berman 2022-12-19 22:58 ` [PATCH v8 01/28] docs: gunyah: Introduce Gunyah Hypervisor Elliot Berman 2022-12-19 22:58 ` Elliot Berman 2023-01-09 21:34 ` Alex Elder 2023-01-09 21:34 ` Alex Elder 2023-01-10 17:54 ` Elliot Berman 2023-01-10 17:54 ` Elliot Berman 2022-12-19 22:58 ` [PATCH v8 02/28] dt-bindings: Add binding for gunyah hypervisor Elliot Berman 2022-12-19 22:58 ` Elliot Berman 2023-01-09 21:34 ` Alex Elder 2023-01-09 21:34 ` Alex Elder 2022-12-19 22:58 ` [PATCH v8 03/28] gunyah: Common types and error codes for Gunyah hypercalls Elliot Berman 2022-12-19 22:58 ` Elliot Berman 2023-01-09 21:34 ` Alex Elder 2023-01-09 21:34 ` Alex Elder 2023-01-10 17:55 ` Elliot Berman 2023-01-10 17:55 ` Elliot Berman 2022-12-19 22:58 ` [PATCH v8 04/28] arm64: smccc: Include alternative-macros.h Elliot Berman 2022-12-19 22:58 ` Elliot Berman 2023-01-09 21:34 ` Alex Elder 2023-01-09 21:34 ` Alex Elder 2023-01-10 22:55 ` Elliot Berman 2023-01-10 22:55 ` Elliot Berman 2022-12-19 22:58 ` [PATCH v8 05/28] virt: gunyah: Add hypercalls to identify Gunyah Elliot Berman 2022-12-19 22:58 ` Elliot Berman 2023-01-09 21:34 ` Alex Elder 2023-01-09 21:34 ` Alex Elder 2023-01-10 17:56 ` Elliot Berman 2023-01-10 17:56 ` Elliot Berman 2023-01-17 19:20 ` Alex Elder 2023-01-17 19:20 ` Alex Elder 2023-01-17 19:20 ` Alex Elder 2023-01-17 19:20 ` Alex Elder 2023-01-17 22:29 ` Elliot Berman 2023-01-17 22:29 ` Elliot Berman 2022-12-19 22:58 ` [PATCH v8 06/28] virt: gunyah: Identify hypervisor version Elliot Berman 2022-12-19 22:58 ` Elliot Berman 2023-01-09 21:34 ` Alex Elder 2023-01-09 21:34 ` Alex Elder 2023-01-10 17:56 ` Elliot Berman 2023-01-10 17:56 ` Elliot Berman 2023-01-17 19:21 ` Alex Elder 2023-01-17 19:21 ` Alex Elder 2023-01-17 22:29 ` Elliot Berman 2023-01-17 22:29 ` Elliot Berman 2022-12-19 22:58 ` [PATCH v8 07/28] mailbox: Allow direct registration to a channel Elliot Berman 2022-12-19 22:58 ` Elliot Berman 2023-01-09 21:34 ` Alex Elder 2023-01-09 21:34 ` Alex Elder 2023-01-10 17:57 ` Elliot Berman 2023-01-10 17:57 ` Elliot Berman 2023-01-17 19:21 ` Alex Elder 2023-01-17 19:21 ` Alex Elder 2022-12-19 22:58 ` [PATCH v8 08/28] virt: gunyah: msgq: Add hypercalls to send and receive messages Elliot Berman 2022-12-19 22:58 ` Elliot Berman 2022-12-19 22:58 ` [PATCH v8 09/28] mailbox: Add Gunyah message queue mailbox Elliot Berman 2022-12-19 22:58 ` Elliot Berman 2023-01-02 6:13 ` Srivatsa Vaddagiri 2023-01-02 6:13 ` Srivatsa Vaddagiri 2023-01-04 0:32 ` Elliot Berman 2023-01-04 0:32 ` Elliot Berman 2023-01-09 21:34 ` Alex Elder 2023-01-09 21:34 ` Alex Elder 2023-01-10 18:16 ` Elliot Berman 2023-01-10 18:16 ` Elliot Berman 2023-01-17 19:21 ` Alex Elder 2023-01-17 19:21 ` Alex Elder 2022-12-19 22:58 ` [PATCH v8 10/28] gunyah: rsc_mgr: Add resource manager RPC core Elliot Berman 2022-12-19 22:58 ` Elliot Berman 2023-01-17 22:33 ` Alex Elder 2023-01-17 22:33 ` Alex Elder 2023-01-20 23:18 ` Elliot Berman 2023-01-20 23:18 ` Elliot Berman 2022-12-19 22:58 ` [PATCH v8 11/28] gunyah: rsc_mgr: Add VM lifecycle RPC Elliot Berman 2022-12-19 22:58 ` Elliot Berman 2023-01-09 7:13 ` Srivatsa Vaddagiri 2023-01-09 7:13 ` Srivatsa Vaddagiri 2023-01-09 18:51 ` Elliot Berman 2023-01-09 18:51 ` Elliot Berman 2023-01-18 18:26 ` Alex Elder 2023-01-18 18:26 ` Alex Elder 2023-01-20 1:31 ` Elliot Berman 2023-01-20 1:31 ` Elliot Berman 2022-12-19 22:58 ` [PATCH v8 12/28] gunyah: vm_mgr: Introduce basic VM Manager Elliot Berman 2022-12-19 22:58 ` Elliot Berman 2023-01-09 9:05 ` Srivatsa Vaddagiri 2023-01-09 9:05 ` Srivatsa Vaddagiri 2023-01-09 19:38 ` Elliot Berman 2023-01-09 19:38 ` Elliot Berman 2022-12-19 22:58 ` [PATCH v8 13/28] gunyah: rsc_mgr: Add RPC for sharing memory Elliot Berman 2022-12-19 22:58 ` Elliot Berman 2023-01-16 8:45 ` Srivatsa Vaddagiri [this message] 2023-01-16 8:45 ` Srivatsa Vaddagiri 2022-12-19 22:58 ` [PATCH v8 14/28] gunyah: vm_mgr: Add/remove user memory regions Elliot Berman 2022-12-19 22:58 ` Elliot Berman 2023-01-20 5:34 ` Srivatsa Vaddagiri 2023-01-20 5:34 ` Srivatsa Vaddagiri 2022-12-19 22:58 ` [PATCH v8 15/28] gunyah: vm_mgr: Add ioctls to support basic non-proxy VM boot Elliot Berman 2022-12-19 22:58 ` Elliot Berman 2022-12-19 22:58 ` [PATCH v8 16/28] samples: Add sample userspace Gunyah VM Manager Elliot Berman 2022-12-19 22:58 ` Elliot Berman 2022-12-19 22:58 ` [PATCH v8 17/28] gunyah: rsc_mgr: Add platform ops on mem_lend/mem_reclaim Elliot Berman 2022-12-19 22:58 ` Elliot Berman 2022-12-19 22:58 ` [PATCH v8 18/28] firmware: qcom_scm: Use fixed width src vm bitmap Elliot Berman 2022-12-19 22:58 ` Elliot Berman 2022-12-19 22:58 ` Elliot Berman 2022-12-19 22:58 ` [PATCH v8 19/28] firmware: qcom_scm: Register Gunyah platform ops Elliot Berman 2022-12-19 22:58 ` Elliot Berman 2022-12-23 17:21 ` kernel test robot 2022-12-19 22:58 ` [PATCH v8 20/28] docs: gunyah: Document Gunyah VM Manager Elliot Berman 2022-12-19 22:58 ` Elliot Berman 2022-12-19 22:58 ` [PATCH v8 21/28] virt: gunyah: Translate gh_rm_hyp_resource into gunyah_resource Elliot Berman 2022-12-19 22:58 ` Elliot Berman 2022-12-19 22:58 ` [PATCH v8 22/28] gunyah: vm_mgr: Add framework to add VM Functions Elliot Berman 2022-12-19 22:58 ` Elliot Berman 2022-12-19 22:58 ` [PATCH v8 23/28] virt: gunyah: Add resource tickets Elliot Berman 2022-12-19 22:58 ` Elliot Berman 2022-12-19 22:58 ` [PATCH v8 24/28] virt: gunyah: Add IO handlers Elliot Berman 2022-12-19 22:58 ` Elliot Berman 2022-12-19 22:58 ` [PATCH v8 25/28] virt: gunyah: Add proxy-scheduled vCPUs Elliot Berman 2022-12-19 22:58 ` Elliot Berman 2022-12-19 22:58 ` [PATCH v8 26/28] virt: gunyah: Add hypercalls for sending doorbell Elliot Berman 2022-12-19 22:58 ` Elliot Berman 2022-12-19 22:58 ` [PATCH v8 27/28] virt: gunyah: Add irqfd interface Elliot Berman 2022-12-19 22:58 ` Elliot Berman 2022-12-21 17:00 ` kernel test robot 2022-12-19 22:58 ` [PATCH v8 28/28] virt: gunyah: Add ioeventfd Elliot Berman 2022-12-19 22:58 ` Elliot Berman 2023-01-09 21:34 ` [PATCH v8 00/28] Drivers for gunyah hypervisor Alex Elder 2023-01-09 21:34 ` Alex Elder 2023-01-10 17:54 ` Elliot Berman 2023-01-10 17:54 ` Elliot Berman 2023-01-10 21:47 ` Elliot Berman 2023-01-10 21:47 ` Elliot Berman 2023-01-17 19:20 ` Alex Elder 2023-01-17 19:20 ` Alex Elder
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230116084557.GB1737564@quicinc.com \ --to=quic_svaddagi@quicinc.com \ --cc=arnd@arndb.de \ --cc=bagasdotme@gmail.com \ --cc=catalin.marinas@arm.com \ --cc=corbet@lwn.net \ --cc=devicetree@vger.kernel.org \ --cc=dmitry.baryshkov@linaro.org \ --cc=gregkh@linuxfoundation.org \ --cc=jassisinghbrar@gmail.com \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=linux-acpi@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-doc@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=lpieralisi@kernel.org \ --cc=mark.rutland@arm.com \ --cc=quic_bjorande@quicinc.com \ --cc=quic_cvanscha@quicinc.com \ --cc=quic_eberman@quicinc.com \ --cc=quic_mnalajal@quicinc.com \ --cc=quic_pheragu@quicinc.com \ --cc=quic_tsoni@quicinc.com \ --cc=robh+dt@kernel.org \ --cc=sudeep.holla@arm.com \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.