* [PATCH] virt: sevguest: add CONFIG_CRYPTO dependency
@ 2023-01-17 17:13 Arnd Bergmann
2023-01-17 17:26 ` Tom Lendacky
2023-06-09 14:09 ` [tip: x86/cc] virt: sevguest: Add " tip-bot2 for Arnd Bergmann
0 siblings, 2 replies; 4+ messages in thread
From: Arnd Bergmann @ 2023-01-17 17:13 UTC (permalink / raw)
To: Tom Lendacky, Borislav Petkov; +Cc: Arnd Bergmann, Brijesh Singh, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
This driver fails to link when CRYPTO is disabled, or in a loadable module:
WARNING: unmet direct dependencies detected for CRYPTO_GCM
WARNING: unmet direct dependencies detected for CRYPTO_AEAD2
Depends on [m]: CRYPTO [=m]
Selected by [y]:
- SEV_GUEST [=y] && VIRT_DRIVERS [=y] && AMD_MEM_ENCRYPT [=y]
x86_64-linux-ld: crypto/aead.o: in function `crypto_register_aeads':
Fixes: d63670d23e60 ("virt: sevguest: Rename the sevguest dir and files to sev-guest")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/virt/coco/sev-guest/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/virt/coco/sev-guest/Kconfig b/drivers/virt/coco/sev-guest/Kconfig
index f9db0799ae67..da2d7ca531f0 100644
--- a/drivers/virt/coco/sev-guest/Kconfig
+++ b/drivers/virt/coco/sev-guest/Kconfig
@@ -2,6 +2,7 @@ config SEV_GUEST
tristate "AMD SEV Guest driver"
default m
depends on AMD_MEM_ENCRYPT
+ select CRYPTO
select CRYPTO_AEAD2
select CRYPTO_GCM
help
--
2.39.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] virt: sevguest: add CONFIG_CRYPTO dependency
2023-01-17 17:13 [PATCH] virt: sevguest: add CONFIG_CRYPTO dependency Arnd Bergmann
@ 2023-01-17 17:26 ` Tom Lendacky
2023-01-17 17:27 ` Tom Lendacky
2023-06-09 14:09 ` [tip: x86/cc] virt: sevguest: Add " tip-bot2 for Arnd Bergmann
1 sibling, 1 reply; 4+ messages in thread
From: Tom Lendacky @ 2023-01-17 17:26 UTC (permalink / raw)
To: Arnd Bergmann, Borislav Petkov; +Cc: Arnd Bergmann, Brijesh Singh, linux-kernel
On 1/17/23 11:13, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> This driver fails to link when CRYPTO is disabled, or in a loadable module:
>
> WARNING: unmet direct dependencies detected for CRYPTO_GCM
> WARNING: unmet direct dependencies detected for CRYPTO_AEAD2
> Depends on [m]: CRYPTO [=m]
> Selected by [y]:
> - SEV_GUEST [=y] && VIRT_DRIVERS [=y] && AMD_MEM_ENCRYPT [=y]
>
> x86_64-linux-ld: crypto/aead.o: in function `crypto_register_aeads':
>
> Fixes: d63670d23e60 ("virt: sevguest: Rename the sevguest dir and files to sev-guest")
This has been present from when the driver was first added, so I think the
correct Fixes: tag should be:
Fixes: fce96cf04430 ("virt: Add SEV-SNP guest driver")
Correct?
Thanks,
Tom
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/virt/coco/sev-guest/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/virt/coco/sev-guest/Kconfig b/drivers/virt/coco/sev-guest/Kconfig
> index f9db0799ae67..da2d7ca531f0 100644
> --- a/drivers/virt/coco/sev-guest/Kconfig
> +++ b/drivers/virt/coco/sev-guest/Kconfig
> @@ -2,6 +2,7 @@ config SEV_GUEST
> tristate "AMD SEV Guest driver"
> default m
> depends on AMD_MEM_ENCRYPT
> + select CRYPTO
> select CRYPTO_AEAD2
> select CRYPTO_GCM
> help
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] virt: sevguest: add CONFIG_CRYPTO dependency
2023-01-17 17:26 ` Tom Lendacky
@ 2023-01-17 17:27 ` Tom Lendacky
0 siblings, 0 replies; 4+ messages in thread
From: Tom Lendacky @ 2023-01-17 17:27 UTC (permalink / raw)
To: Arnd Bergmann, Borislav Petkov; +Cc: Arnd Bergmann, Brijesh Singh, linux-kernel
Updating email for Boris.
On 1/17/23 11:26, Tom Lendacky wrote:
> On 1/17/23 11:13, Arnd Bergmann wrote:
>> From: Arnd Bergmann <arnd@arndb.de>
>>
>> This driver fails to link when CRYPTO is disabled, or in a loadable module:
>>
>> WARNING: unmet direct dependencies detected for CRYPTO_GCM
>> WARNING: unmet direct dependencies detected for CRYPTO_AEAD2
>> Depends on [m]: CRYPTO [=m]
>> Selected by [y]:
>> - SEV_GUEST [=y] && VIRT_DRIVERS [=y] && AMD_MEM_ENCRYPT [=y]
>>
>> x86_64-linux-ld: crypto/aead.o: in function `crypto_register_aeads':
>>
>> Fixes: d63670d23e60 ("virt: sevguest: Rename the sevguest dir and files
>> to sev-guest")
>
> This has been present from when the driver was first added, so I think the
> correct Fixes: tag should be:
>
> Fixes: fce96cf04430 ("virt: Add SEV-SNP guest driver")
>
> Correct?
>
> Thanks,
> Tom
>
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>> ---
>> drivers/virt/coco/sev-guest/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/virt/coco/sev-guest/Kconfig
>> b/drivers/virt/coco/sev-guest/Kconfig
>> index f9db0799ae67..da2d7ca531f0 100644
>> --- a/drivers/virt/coco/sev-guest/Kconfig
>> +++ b/drivers/virt/coco/sev-guest/Kconfig
>> @@ -2,6 +2,7 @@ config SEV_GUEST
>> tristate "AMD SEV Guest driver"
>> default m
>> depends on AMD_MEM_ENCRYPT
>> + select CRYPTO
>> select CRYPTO_AEAD2
>> select CRYPTO_GCM
>> help
^ permalink raw reply [flat|nested] 4+ messages in thread
* [tip: x86/cc] virt: sevguest: Add CONFIG_CRYPTO dependency
2023-01-17 17:13 [PATCH] virt: sevguest: add CONFIG_CRYPTO dependency Arnd Bergmann
2023-01-17 17:26 ` Tom Lendacky
@ 2023-06-09 14:09 ` tip-bot2 for Arnd Bergmann
1 sibling, 0 replies; 4+ messages in thread
From: tip-bot2 for Arnd Bergmann @ 2023-06-09 14:09 UTC (permalink / raw)
To: linux-tip-commits; +Cc: Arnd Bergmann, Borislav Petkov (AMD), x86, linux-kernel
The following commit has been merged into the x86/cc branch of tip:
Commit-ID: 84b9b44b99780d35fe72ac63c4724f158771e898
Gitweb: https://git.kernel.org/tip/84b9b44b99780d35fe72ac63c4724f158771e898
Author: Arnd Bergmann <arnd@arndb.de>
AuthorDate: Tue, 17 Jan 2023 18:13:56 +01:00
Committer: Borislav Petkov (AMD) <bp@alien8.de>
CommitterDate: Fri, 09 Jun 2023 15:53:07 +02:00
virt: sevguest: Add CONFIG_CRYPTO dependency
This driver fails to link when CRYPTO is disabled, or in a loadable
module:
WARNING: unmet direct dependencies detected for CRYPTO_GCM
WARNING: unmet direct dependencies detected for CRYPTO_AEAD2
Depends on [m]: CRYPTO [=m]
Selected by [y]:
- SEV_GUEST [=y] && VIRT_DRIVERS [=y] && AMD_MEM_ENCRYPT [=y]
x86_64-linux-ld: crypto/aead.o: in function `crypto_register_aeads':
Fixes: fce96cf04430 ("virt: Add SEV-SNP guest driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de>
Link: https://lore.kernel.org/r/20230117171416.2715125-1-arnd@kernel.org
---
drivers/virt/coco/sev-guest/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/virt/coco/sev-guest/Kconfig b/drivers/virt/coco/sev-guest/Kconfig
index f9db079..da2d7ca 100644
--- a/drivers/virt/coco/sev-guest/Kconfig
+++ b/drivers/virt/coco/sev-guest/Kconfig
@@ -2,6 +2,7 @@ config SEV_GUEST
tristate "AMD SEV Guest driver"
default m
depends on AMD_MEM_ENCRYPT
+ select CRYPTO
select CRYPTO_AEAD2
select CRYPTO_GCM
help
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-06-09 14:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-17 17:13 [PATCH] virt: sevguest: add CONFIG_CRYPTO dependency Arnd Bergmann
2023-01-17 17:26 ` Tom Lendacky
2023-01-17 17:27 ` Tom Lendacky
2023-06-09 14:09 ` [tip: x86/cc] virt: sevguest: Add " tip-bot2 for Arnd Bergmann
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.