All of lore.kernel.org
 help / color / mirror / Atom feed
From: John.C.Harrison@Intel.com
To: Intel-GFX@Lists.FreeDesktop.Org
Cc: John Harrison <John.C.Harrison@Intel.com>,
	DRI-Devel@Lists.FreeDesktop.Org
Subject: [PATCH v2 0/5] Allow error capture without a request / on reset failure
Date: Tue, 17 Jan 2023 13:36:25 -0800	[thread overview]
Message-ID: <20230117213630.2897570-1-John.C.Harrison@Intel.com> (raw)

From: John Harrison <John.C.Harrison@Intel.com>

It is technically possible to get a hung context without a valid
request. In such a situation, try to provide as much information in
the error capture as possible rather than just aborting and capturing
nothing.

Similarly, in the case of an engine reset failure the GuC is not able
to report the guilty context. So try a manual search instead of
reporting nothing.

v2: Tidy up code flow in error capture. Reword some comments/messages.
(review feedback from Tvrtko)
Also fix up request locking issues from earlier changes noticed during
code review of this change.

Signed-off-by: John Harrison <John.C.Harrison@Intel.com>


John Harrison (5):
  drm/i915: Fix request locking during error capture & debugfs dump
  drm/i915: Allow error capture without a request
  drm/i915: Allow error capture of a pending request
  drm/i915/guc: Look for a guilty context when an engine reset fails
  drm/i915/guc: Add a debug print on GuC triggered reset

 drivers/gpu/drm/i915/gt/intel_context.c       |  1 +
 drivers/gpu/drm/i915/gt/intel_engine_cs.c     |  7 +-
 .../gpu/drm/i915/gt/uc/intel_guc_submission.c | 32 ++++++++-
 drivers/gpu/drm/i915/i915_gpu_error.c         | 71 ++++++++++++-------
 4 files changed, 82 insertions(+), 29 deletions(-)

-- 
2.39.0


WARNING: multiple messages have this Message-ID (diff)
From: John.C.Harrison@Intel.com
To: Intel-GFX@Lists.FreeDesktop.Org
Cc: DRI-Devel@Lists.FreeDesktop.Org
Subject: [Intel-gfx] [PATCH v2 0/5] Allow error capture without a request / on reset failure
Date: Tue, 17 Jan 2023 13:36:25 -0800	[thread overview]
Message-ID: <20230117213630.2897570-1-John.C.Harrison@Intel.com> (raw)

From: John Harrison <John.C.Harrison@Intel.com>

It is technically possible to get a hung context without a valid
request. In such a situation, try to provide as much information in
the error capture as possible rather than just aborting and capturing
nothing.

Similarly, in the case of an engine reset failure the GuC is not able
to report the guilty context. So try a manual search instead of
reporting nothing.

v2: Tidy up code flow in error capture. Reword some comments/messages.
(review feedback from Tvrtko)
Also fix up request locking issues from earlier changes noticed during
code review of this change.

Signed-off-by: John Harrison <John.C.Harrison@Intel.com>


John Harrison (5):
  drm/i915: Fix request locking during error capture & debugfs dump
  drm/i915: Allow error capture without a request
  drm/i915: Allow error capture of a pending request
  drm/i915/guc: Look for a guilty context when an engine reset fails
  drm/i915/guc: Add a debug print on GuC triggered reset

 drivers/gpu/drm/i915/gt/intel_context.c       |  1 +
 drivers/gpu/drm/i915/gt/intel_engine_cs.c     |  7 +-
 .../gpu/drm/i915/gt/uc/intel_guc_submission.c | 32 ++++++++-
 drivers/gpu/drm/i915/i915_gpu_error.c         | 71 ++++++++++++-------
 4 files changed, 82 insertions(+), 29 deletions(-)

-- 
2.39.0


             reply	other threads:[~2023-01-17 21:37 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-17 21:36 John.C.Harrison [this message]
2023-01-17 21:36 ` [Intel-gfx] [PATCH v2 0/5] Allow error capture without a request / on reset failure John.C.Harrison
2023-01-17 21:36 ` [PATCH v2 1/5] drm/i915: Fix request locking during error capture & debugfs dump John.C.Harrison
2023-01-17 21:36   ` [Intel-gfx] " John.C.Harrison
2023-01-18  8:29   ` Andy Shevchenko
2023-01-18  8:29     ` [Intel-gfx] " Andy Shevchenko
2023-01-18 17:34     ` John Harrison
2023-01-18 17:34       ` [Intel-gfx] " John Harrison
2023-01-18 17:54       ` Andy Shevchenko
2023-01-18 17:54         ` [Intel-gfx] " Andy Shevchenko
2023-01-18 18:18         ` John Harrison
2023-01-18 18:18           ` [Intel-gfx] " John Harrison
2023-01-18 16:22   ` Tvrtko Ursulin
2023-01-18 16:22     ` [Intel-gfx] " Tvrtko Ursulin
2023-01-18 17:55     ` John Harrison
2023-01-18 17:55       ` [Intel-gfx] " John Harrison
2023-01-17 21:36 ` [PATCH v2 2/5] drm/i915: Allow error capture without a request John.C.Harrison
2023-01-17 21:36   ` [Intel-gfx] " John.C.Harrison
2023-01-18 16:34   ` Tvrtko Ursulin
2023-01-17 21:36 ` [PATCH v2 3/5] drm/i915: Allow error capture of a pending request John.C.Harrison
2023-01-17 21:36   ` [Intel-gfx] " John.C.Harrison
2023-01-18 16:35   ` Tvrtko Ursulin
2023-01-17 21:36 ` [PATCH v2 4/5] drm/i915/guc: Look for a guilty context when an engine reset fails John.C.Harrison
2023-01-17 21:36   ` [Intel-gfx] " John.C.Harrison
2023-01-18 16:37   ` Tvrtko Ursulin
2023-01-17 21:36 ` [PATCH v2 5/5] drm/i915/guc: Add a debug print on GuC triggered reset John.C.Harrison
2023-01-17 21:36   ` [Intel-gfx] " John.C.Harrison
2023-01-17 22:55 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Allow error capture without a request / on reset failure (rev3) Patchwork
2023-01-17 22:55 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2023-01-17 23:05 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230117213630.2897570-1-John.C.Harrison@Intel.com \
    --to=john.c.harrison@intel.com \
    --cc=DRI-Devel@Lists.FreeDesktop.Org \
    --cc=Intel-GFX@Lists.FreeDesktop.Org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.