* [PATCH 0/3] Correct inaccuracies in Exynos5420 and Exynos5800 device trees
@ 2023-01-19 18:59 ` Markuss Broks
0 siblings, 0 replies; 10+ messages in thread
From: Markuss Broks @ 2023-01-19 18:59 UTC (permalink / raw)
To: linux-kernel
Cc: Markuss Broks, Rob Herring, Krzysztof Kozlowski, Alim Akhtar,
devicetree, linux-arm-kernel, linux-samsung-soc
Use the proper compatibles for the DSI host controller and MIPI
video phy, as the current ones are not compatible with the hardware.
While this fixes the kernel panic while trying to use DSI, I was still
unsuccessful to consistently produce image that isn't noise on S6E3FA2
panel of Samsung Galaxy S5. It seems to only work sometimes.
Markuss Broks (3):
arm: dts: exynos5420: Add a label to the DSI controller node
arm: dts: exynos5420: Use Exynos5420 compatible for the MIPI video phy
arm: dts: exynos5800: Use Exynos5422 compatible for the DSI controller
arch/arm/boot/dts/exynos5420.dtsi | 4 ++--
arch/arm/boot/dts/exynos5800.dtsi | 4 ++++
2 files changed, 6 insertions(+), 2 deletions(-)
--
2.39.0
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 0/3] Correct inaccuracies in Exynos5420 and Exynos5800 device trees
@ 2023-01-19 18:59 ` Markuss Broks
0 siblings, 0 replies; 10+ messages in thread
From: Markuss Broks @ 2023-01-19 18:59 UTC (permalink / raw)
To: linux-kernel
Cc: Markuss Broks, Rob Herring, Krzysztof Kozlowski, Alim Akhtar,
devicetree, linux-arm-kernel, linux-samsung-soc
Use the proper compatibles for the DSI host controller and MIPI
video phy, as the current ones are not compatible with the hardware.
While this fixes the kernel panic while trying to use DSI, I was still
unsuccessful to consistently produce image that isn't noise on S6E3FA2
panel of Samsung Galaxy S5. It seems to only work sometimes.
Markuss Broks (3):
arm: dts: exynos5420: Add a label to the DSI controller node
arm: dts: exynos5420: Use Exynos5420 compatible for the MIPI video phy
arm: dts: exynos5800: Use Exynos5422 compatible for the DSI controller
arch/arm/boot/dts/exynos5420.dtsi | 4 ++--
arch/arm/boot/dts/exynos5800.dtsi | 4 ++++
2 files changed, 6 insertions(+), 2 deletions(-)
--
2.39.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 1/3] arm: dts: exynos5420: Add a label to the DSI controller node
2023-01-19 18:59 ` Markuss Broks
@ 2023-01-19 18:59 ` Markuss Broks
-1 siblings, 0 replies; 10+ messages in thread
From: Markuss Broks @ 2023-01-19 18:59 UTC (permalink / raw)
To: linux-kernel
Cc: Markuss Broks, Rob Herring, Krzysztof Kozlowski, Alim Akhtar,
devicetree, linux-arm-kernel, linux-samsung-soc
Add a label to the DSI controller node so board device-trees
could add subnodes.
Signed-off-by: Markuss Broks <markuss.broks@gmail.com>
---
arch/arm/boot/dts/exynos5420.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
index 9f2523a873d9..099bbdf76d83 100644
--- a/arch/arm/boot/dts/exynos5420.dtsi
+++ b/arch/arm/boot/dts/exynos5420.dtsi
@@ -597,7 +597,7 @@ mipi_phy: mipi-video-phy {
#phy-cells = <1>;
};
- dsi@14500000 {
+ dsi: dsi@14500000 {
compatible = "samsung,exynos5410-mipi-dsi";
reg = <0x14500000 0x10000>;
interrupts = <GIC_SPI 82 IRQ_TYPE_LEVEL_HIGH>;
--
2.39.0
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 1/3] arm: dts: exynos5420: Add a label to the DSI controller node
@ 2023-01-19 18:59 ` Markuss Broks
0 siblings, 0 replies; 10+ messages in thread
From: Markuss Broks @ 2023-01-19 18:59 UTC (permalink / raw)
To: linux-kernel
Cc: Markuss Broks, Rob Herring, Krzysztof Kozlowski, Alim Akhtar,
devicetree, linux-arm-kernel, linux-samsung-soc
Add a label to the DSI controller node so board device-trees
could add subnodes.
Signed-off-by: Markuss Broks <markuss.broks@gmail.com>
---
arch/arm/boot/dts/exynos5420.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
index 9f2523a873d9..099bbdf76d83 100644
--- a/arch/arm/boot/dts/exynos5420.dtsi
+++ b/arch/arm/boot/dts/exynos5420.dtsi
@@ -597,7 +597,7 @@ mipi_phy: mipi-video-phy {
#phy-cells = <1>;
};
- dsi@14500000 {
+ dsi: dsi@14500000 {
compatible = "samsung,exynos5410-mipi-dsi";
reg = <0x14500000 0x10000>;
interrupts = <GIC_SPI 82 IRQ_TYPE_LEVEL_HIGH>;
--
2.39.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 2/3] arm: dts: exynos5420: Use Exynos5420 compatible for the MIPI video phy
2023-01-19 18:59 ` Markuss Broks
@ 2023-01-19 18:59 ` Markuss Broks
-1 siblings, 0 replies; 10+ messages in thread
From: Markuss Broks @ 2023-01-19 18:59 UTC (permalink / raw)
To: linux-kernel
Cc: Markuss Broks, Rob Herring, Krzysztof Kozlowski, Alim Akhtar,
devicetree, linux-arm-kernel, linux-samsung-soc
For some reason, the driver adding support for Exynos5420 MIPI phy
back in 2016 wasn't used on Exynos5420, which caused a kernel panic.
Add the proper compatible for it.
Signed-off-by: Markuss Broks <markuss.broks@gmail.com>
---
arch/arm/boot/dts/exynos5420.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
index 099bbdf76d83..b612468515eb 100644
--- a/arch/arm/boot/dts/exynos5420.dtsi
+++ b/arch/arm/boot/dts/exynos5420.dtsi
@@ -592,7 +592,7 @@ dp_phy: dp-video-phy {
};
mipi_phy: mipi-video-phy {
- compatible = "samsung,s5pv210-mipi-video-phy";
+ compatible = "samsung,exynos5420-mipi-video-phy";
syscon = <&pmu_system_controller>;
#phy-cells = <1>;
};
--
2.39.0
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 2/3] arm: dts: exynos5420: Use Exynos5420 compatible for the MIPI video phy
@ 2023-01-19 18:59 ` Markuss Broks
0 siblings, 0 replies; 10+ messages in thread
From: Markuss Broks @ 2023-01-19 18:59 UTC (permalink / raw)
To: linux-kernel
Cc: Markuss Broks, Rob Herring, Krzysztof Kozlowski, Alim Akhtar,
devicetree, linux-arm-kernel, linux-samsung-soc
For some reason, the driver adding support for Exynos5420 MIPI phy
back in 2016 wasn't used on Exynos5420, which caused a kernel panic.
Add the proper compatible for it.
Signed-off-by: Markuss Broks <markuss.broks@gmail.com>
---
arch/arm/boot/dts/exynos5420.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
index 099bbdf76d83..b612468515eb 100644
--- a/arch/arm/boot/dts/exynos5420.dtsi
+++ b/arch/arm/boot/dts/exynos5420.dtsi
@@ -592,7 +592,7 @@ dp_phy: dp-video-phy {
};
mipi_phy: mipi-video-phy {
- compatible = "samsung,s5pv210-mipi-video-phy";
+ compatible = "samsung,exynos5420-mipi-video-phy";
syscon = <&pmu_system_controller>;
#phy-cells = <1>;
};
--
2.39.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 3/3] arm: dts: exynos5800: Use Exynos5422 compatible for the DSI controller
2023-01-19 18:59 ` Markuss Broks
@ 2023-01-19 18:59 ` Markuss Broks
-1 siblings, 0 replies; 10+ messages in thread
From: Markuss Broks @ 2023-01-19 18:59 UTC (permalink / raw)
To: linux-kernel
Cc: Markuss Broks, Rob Herring, Krzysztof Kozlowski, Alim Akhtar,
devicetree, linux-arm-kernel, linux-samsung-soc
The driver adding support for Exynos5422/Exynos5800 DSI controller was
merged in 2016, yet it wasn't actually used. Add a proper compatible
for it.
Signed-off-by: Markuss Broks <markuss.broks@gmail.com>
---
arch/arm/boot/dts/exynos5800.dtsi | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm/boot/dts/exynos5800.dtsi b/arch/arm/boot/dts/exynos5800.dtsi
index 526729dad53f..8328ddb3b02f 100644
--- a/arch/arm/boot/dts/exynos5800.dtsi
+++ b/arch/arm/boot/dts/exynos5800.dtsi
@@ -148,6 +148,10 @@ opp-200000000 {
};
};
+&dsi {
+ compatible = "samsung,exynos5422-mipi-dsi";
+};
+
&mfc {
compatible = "samsung,mfc-v8";
};
--
2.39.0
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 3/3] arm: dts: exynos5800: Use Exynos5422 compatible for the DSI controller
@ 2023-01-19 18:59 ` Markuss Broks
0 siblings, 0 replies; 10+ messages in thread
From: Markuss Broks @ 2023-01-19 18:59 UTC (permalink / raw)
To: linux-kernel
Cc: Markuss Broks, Rob Herring, Krzysztof Kozlowski, Alim Akhtar,
devicetree, linux-arm-kernel, linux-samsung-soc
The driver adding support for Exynos5422/Exynos5800 DSI controller was
merged in 2016, yet it wasn't actually used. Add a proper compatible
for it.
Signed-off-by: Markuss Broks <markuss.broks@gmail.com>
---
arch/arm/boot/dts/exynos5800.dtsi | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm/boot/dts/exynos5800.dtsi b/arch/arm/boot/dts/exynos5800.dtsi
index 526729dad53f..8328ddb3b02f 100644
--- a/arch/arm/boot/dts/exynos5800.dtsi
+++ b/arch/arm/boot/dts/exynos5800.dtsi
@@ -148,6 +148,10 @@ opp-200000000 {
};
};
+&dsi {
+ compatible = "samsung,exynos5422-mipi-dsi";
+};
+
&mfc {
compatible = "samsung,mfc-v8";
};
--
2.39.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH 1/3] arm: dts: exynos5420: Add a label to the DSI controller node
2023-01-19 18:59 ` Markuss Broks
@ 2023-01-20 7:36 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 10+ messages in thread
From: Krzysztof Kozlowski @ 2023-01-20 7:36 UTC (permalink / raw)
To: Markuss Broks, linux-kernel
Cc: Rob Herring, Krzysztof Kozlowski, Alim Akhtar, devicetree,
linux-arm-kernel, linux-samsung-soc
On 19/01/2023 19:59, Markuss Broks wrote:
> Add a label to the DSI controller node so board device-trees
> could add subnodes.
>
> Signed-off-by: Markuss Broks <markuss.broks@gmail.com>
The patch on its own does not make any sense. We do not add labels just
because maybe they will or will not be used. Need to be squashed with
the user of this label.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/3] arm: dts: exynos5420: Add a label to the DSI controller node
@ 2023-01-20 7:36 ` Krzysztof Kozlowski
0 siblings, 0 replies; 10+ messages in thread
From: Krzysztof Kozlowski @ 2023-01-20 7:36 UTC (permalink / raw)
To: Markuss Broks, linux-kernel
Cc: Rob Herring, Krzysztof Kozlowski, Alim Akhtar, devicetree,
linux-arm-kernel, linux-samsung-soc
On 19/01/2023 19:59, Markuss Broks wrote:
> Add a label to the DSI controller node so board device-trees
> could add subnodes.
>
> Signed-off-by: Markuss Broks <markuss.broks@gmail.com>
The patch on its own does not make any sense. We do not add labels just
because maybe they will or will not be used. Need to be squashed with
the user of this label.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2023-01-20 7:37 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-19 18:59 [PATCH 0/3] Correct inaccuracies in Exynos5420 and Exynos5800 device trees Markuss Broks
2023-01-19 18:59 ` Markuss Broks
2023-01-19 18:59 ` [PATCH 1/3] arm: dts: exynos5420: Add a label to the DSI controller node Markuss Broks
2023-01-19 18:59 ` Markuss Broks
2023-01-20 7:36 ` Krzysztof Kozlowski
2023-01-20 7:36 ` Krzysztof Kozlowski
2023-01-19 18:59 ` [PATCH 2/3] arm: dts: exynos5420: Use Exynos5420 compatible for the MIPI video phy Markuss Broks
2023-01-19 18:59 ` Markuss Broks
2023-01-19 18:59 ` [PATCH 3/3] arm: dts: exynos5800: Use Exynos5422 compatible for the DSI controller Markuss Broks
2023-01-19 18:59 ` Markuss Broks
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.