* [PATCH] selftests: iommu: Fix test_cmd_destroy_access() call in user_copy
@ 2023-01-20 7:42 Nicolin Chen
2023-01-20 8:04 ` Tian, Kevin
2023-01-23 18:28 ` Jason Gunthorpe
0 siblings, 2 replies; 3+ messages in thread
From: Nicolin Chen @ 2023-01-20 7:42 UTC (permalink / raw)
To: jgg; +Cc: kevin.tian, shuah, yi.l.liu, iommu, linux-kselftest, linux-kernel
The test_cmd_destroy_access() should end with a semicolon, so add one.
There is a test_ioctl_destroy(ioas_id) following already, so drop one.
Fixes: 57f0988706fe ("iommufd: Add a selftest")
Signed-off-by: Nicolin Chen <nicolinc@nvidia.com>
---
tools/testing/selftests/iommu/iommufd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/iommu/iommufd.c b/tools/testing/selftests/iommu/iommufd.c
index 8aa8a346cf22..fa08209268c4 100644
--- a/tools/testing/selftests/iommu/iommufd.c
+++ b/tools/testing/selftests/iommu/iommufd.c
@@ -1259,7 +1259,7 @@ TEST_F(iommufd_mock_domain, user_copy)
test_cmd_destroy_access_pages(
access_cmd.id, access_cmd.access_pages.out_access_pages_id);
- test_cmd_destroy_access(access_cmd.id) test_ioctl_destroy(ioas_id);
+ test_cmd_destroy_access(access_cmd.id);
test_ioctl_destroy(ioas_id);
}
--
2.39.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH] selftests: iommu: Fix test_cmd_destroy_access() call in user_copy
2023-01-20 7:42 [PATCH] selftests: iommu: Fix test_cmd_destroy_access() call in user_copy Nicolin Chen
@ 2023-01-20 8:04 ` Tian, Kevin
2023-01-23 18:28 ` Jason Gunthorpe
1 sibling, 0 replies; 3+ messages in thread
From: Tian, Kevin @ 2023-01-20 8:04 UTC (permalink / raw)
To: Nicolin Chen, jgg; +Cc: shuah, Liu, Yi L, iommu, linux-kselftest, linux-kernel
> From: Nicolin Chen <nicolinc@nvidia.com>
> Sent: Friday, January 20, 2023 3:42 PM
>
> The test_cmd_destroy_access() should end with a semicolon, so add one.
> There is a test_ioctl_destroy(ioas_id) following already, so drop one.
>
> Fixes: 57f0988706fe ("iommufd: Add a selftest")
> Signed-off-by: Nicolin Chen <nicolinc@nvidia.com>
Reviewed-by: Kevin Tian <kevin.tian@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] selftests: iommu: Fix test_cmd_destroy_access() call in user_copy
2023-01-20 7:42 [PATCH] selftests: iommu: Fix test_cmd_destroy_access() call in user_copy Nicolin Chen
2023-01-20 8:04 ` Tian, Kevin
@ 2023-01-23 18:28 ` Jason Gunthorpe
1 sibling, 0 replies; 3+ messages in thread
From: Jason Gunthorpe @ 2023-01-23 18:28 UTC (permalink / raw)
To: Nicolin Chen
Cc: kevin.tian, shuah, yi.l.liu, iommu, linux-kselftest, linux-kernel
On Thu, Jan 19, 2023 at 11:42:04PM -0800, Nicolin Chen wrote:
> The test_cmd_destroy_access() should end with a semicolon, so add one.
> There is a test_ioctl_destroy(ioas_id) following already, so drop one.
>
> Fixes: 57f0988706fe ("iommufd: Add a selftest")
> Signed-off-by: Nicolin Chen <nicolinc@nvidia.com>
> ---
> tools/testing/selftests/iommu/iommufd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied thanks
Jason
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-01-23 18:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-20 7:42 [PATCH] selftests: iommu: Fix test_cmd_destroy_access() call in user_copy Nicolin Chen
2023-01-20 8:04 ` Tian, Kevin
2023-01-23 18:28 ` Jason Gunthorpe
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.