[Intel-gfx] [PATCH v2 7/8] drm/i915: Convert MBUS_ABOX_CTL() to _PICK_EVEN_2RANGES()

All of lore.kernel.org
 help / color / mirror / Atom feed

From: Lucas De Marchi <lucas.demarchi@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: Lucas De Marchi <lucas.demarchi@intel.com>,
	dri-devel@lists.freedesktop.org
Subject: [Intel-gfx] [PATCH v2 7/8] drm/i915: Convert MBUS_ABOX_CTL() to _PICK_EVEN_2RANGES()
Date: Fri, 20 Jan 2023 11:34:56 -0800	[thread overview]
Message-ID: <20230120193457.3295977-8-lucas.demarchi@intel.com> (raw)
In-Reply-To: <20230120193457.3295977-1-lucas.demarchi@intel.com>

MBUS_ABOX_CTL() can use _PICK_EVEN_2RANGES instead of _PICK, which
reduces the size and is safer.

Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
---
 drivers/gpu/drm/i915/i915_reg.h | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
index fe6385443c4a..3d6ad4424265 100644
--- a/drivers/gpu/drm/i915/i915_reg.h
+++ b/drivers/gpu/drm/i915/i915_reg.h
@@ -1040,9 +1040,11 @@
 #define _MBUS_ABOX0_CTL			0x45038
 #define _MBUS_ABOX1_CTL			0x45048
 #define _MBUS_ABOX2_CTL			0x4504C
-#define MBUS_ABOX_CTL(x)		_MMIO(_PICK(x, _MBUS_ABOX0_CTL, \
-						    _MBUS_ABOX1_CTL, \
-						    _MBUS_ABOX2_CTL))
+#define MBUS_ABOX_CTL(x)							\
+	_MMIO(_PICK_EVEN_2RANGES(x, 2,						\
+				 _MBUS_ABOX0_CTL, _MBUS_ABOX1_CTL,		\
+				 _MBUS_ABOX2_CTL, _MBUS_ABOX2_CTL))
+
 #define MBUS_ABOX_BW_CREDIT_MASK	(3 << 20)
 #define MBUS_ABOX_BW_CREDIT(x)		((x) << 20)
 #define MBUS_ABOX_B_CREDIT_MASK		(0xF << 16)
-- 
2.39.0

WARNING: multiple messages have this Message-ID (diff)

From: Lucas De Marchi <lucas.demarchi@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: Lucas De Marchi <lucas.demarchi@intel.com>,
	dri-devel@lists.freedesktop.org
Subject: [PATCH v2 7/8] drm/i915: Convert MBUS_ABOX_CTL() to _PICK_EVEN_2RANGES()
Date: Fri, 20 Jan 2023 11:34:56 -0800	[thread overview]
Message-ID: <20230120193457.3295977-8-lucas.demarchi@intel.com> (raw)
In-Reply-To: <20230120193457.3295977-1-lucas.demarchi@intel.com>

MBUS_ABOX_CTL() can use _PICK_EVEN_2RANGES instead of _PICK, which
reduces the size and is safer.

Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
---
 drivers/gpu/drm/i915/i915_reg.h | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
index fe6385443c4a..3d6ad4424265 100644
--- a/drivers/gpu/drm/i915/i915_reg.h
+++ b/drivers/gpu/drm/i915/i915_reg.h
@@ -1040,9 +1040,11 @@
 #define _MBUS_ABOX0_CTL			0x45038
 #define _MBUS_ABOX1_CTL			0x45048
 #define _MBUS_ABOX2_CTL			0x4504C
-#define MBUS_ABOX_CTL(x)		_MMIO(_PICK(x, _MBUS_ABOX0_CTL, \
-						    _MBUS_ABOX1_CTL, \
-						    _MBUS_ABOX2_CTL))
+#define MBUS_ABOX_CTL(x)							\
+	_MMIO(_PICK_EVEN_2RANGES(x, 2,						\
+				 _MBUS_ABOX0_CTL, _MBUS_ABOX1_CTL,		\
+				 _MBUS_ABOX2_CTL, _MBUS_ABOX2_CTL))
+
 #define MBUS_ABOX_BW_CREDIT_MASK	(3 << 20)
 #define MBUS_ABOX_BW_CREDIT(x)		((x) << 20)
 #define MBUS_ABOX_B_CREDIT_MASK		(0xF << 16)
-- 
2.39.0

next prev parent reply	other threads:[~2023-01-20 19:35 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-20 19:34 [PATCH v2 0/8] Add _PICK_EVEN_2RANGES Lucas De Marchi
2023-01-20 19:34 ` [Intel-gfx] " Lucas De Marchi
2023-01-20 19:34 ` [PATCH v2 1/8] drm/i915: Add _PICK_EVEN_2RANGES() Lucas De Marchi
2023-01-20 19:34   ` [Intel-gfx] " Lucas De Marchi
2023-01-21  6:14   ` Srivatsa, Anusha
2023-01-21  6:14     ` Srivatsa, Anusha
2023-01-22  1:28     ` Lucas De Marchi
2023-01-23 11:00       ` Jani Nikula
2023-01-23 16:15         ` Srivatsa, Anusha
2023-01-23 16:15           ` Srivatsa, Anusha
2023-01-23 16:53           ` Lucas De Marchi
2023-01-23 10:38   ` Jani Nikula
2023-01-23 10:38     ` [Intel-gfx] " Jani Nikula
2023-01-24  7:45     ` Lucas De Marchi
2023-01-24  7:45       ` [Intel-gfx] " Lucas De Marchi
2023-01-25 18:24       ` [PATCH v2.2] " Lucas De Marchi
2023-01-25 18:24         ` [Intel-gfx] " Lucas De Marchi
2023-01-23 17:15   ` [PATCH v2.1] " Lucas De Marchi
2023-01-23 17:15     ` [Intel-gfx] " Lucas De Marchi
2023-01-23 17:49     ` Srivatsa, Anusha
2023-01-23 17:49       ` [Intel-gfx] " Srivatsa, Anusha
2023-01-20 19:34 ` [PATCH v2 2/8] drm/i915: Fix coding style on DPLL*_ENABLE defines Lucas De Marchi
2023-01-20 19:34   ` [Intel-gfx] " Lucas De Marchi
2023-01-20 20:14   ` Srivatsa, Anusha
2023-01-20 20:14     ` Srivatsa, Anusha
2023-01-20 19:34 ` [PATCH v2 3/8] drm/i915: Convert pll macros to _PICK_EVEN_2RANGES Lucas De Marchi
2023-01-20 19:34   ` [Intel-gfx] " Lucas De Marchi
2023-01-23 19:12   ` Srivatsa, Anusha
2023-01-23 19:12     ` Srivatsa, Anusha
2023-01-20 19:34 ` [PATCH v2 4/8] drm/i915: Replace _MMIO_PHY3() with _PICK_EVEN_2RANGES() Lucas De Marchi
2023-01-20 19:34   ` [Intel-gfx] " Lucas De Marchi
2023-01-21  5:58   ` Srivatsa, Anusha
2023-01-21  5:58     ` Srivatsa, Anusha
2023-01-20 19:34 ` [PATCH v2 5/8] drm/i915: Convert PIPE3/PORT3 to _PICK_EVEN_2RANGES() Lucas De Marchi
2023-01-20 19:34   ` [Intel-gfx] " Lucas De Marchi
2023-01-21  6:00   ` Srivatsa, Anusha
2023-01-21  6:00     ` Srivatsa, Anusha
2023-01-20 19:34 ` [PATCH v2 6/8] drm/i915: Convert _FIA() " Lucas De Marchi
2023-01-20 19:34   ` [Intel-gfx] " Lucas De Marchi
2023-01-21  6:01   ` Srivatsa, Anusha
2023-01-21  6:01     ` Srivatsa, Anusha
2023-01-20 19:34 ` Lucas De Marchi [this message]
2023-01-20 19:34   ` [PATCH v2 7/8] drm/i915: Convert MBUS_ABOX_CTL() " Lucas De Marchi
2023-01-21  6:04   ` [Intel-gfx] " Srivatsa, Anusha
2023-01-21  6:04     ` Srivatsa, Anusha
2023-01-20 19:34 ` [PATCH v2 8/8] drm/i915: Convert PALETTE() " Lucas De Marchi
2023-01-20 19:34   ` [Intel-gfx] " Lucas De Marchi
2023-01-21  6:06   ` Srivatsa, Anusha
2023-01-21  6:06     ` Srivatsa, Anusha
2023-01-20 21:04 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Add _PICK_EVEN_2RANGES Patchwork
2023-01-20 21:17 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-01-21 20:55 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2023-01-23 10:39 ` [PATCH v2 0/8] " Jani Nikula
2023-01-23 10:39   ` [Intel-gfx] " Jani Nikula
2023-01-23 19:27 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Add _PICK_EVEN_2RANGES (rev2) Patchwork
2023-01-23 19:44 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-01-24  4:48 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2023-01-26  1:33 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for Add _PICK_EVEN_2RANGES (rev3) Patchwork
2023-01-26  1:52 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-01-26 12:13 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork

find likely ancestor, descendant, or conflicting patches for this message:
dfblob:fe6385443c4 dfblob:fe6385443c4 dfblob:3d6ad442426
dfblob:3d6ad442426
	(help)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230120193457.3295977-8-lucas.demarchi@intel.com \
    --to=lucas.demarchi@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.