From: Christoph Hellwig <hch@lst.de> To: Andrew Morton <akpm@linux-foundation.org>, Matthew Wilcox <willy@infradead.org>, Hugh Dickins <hughd@google.com> Cc: linux-afs@lists.infradead.org, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, cluster-devel@redhat.com, linux-mm@kvack.org, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-nilfs@vger.kernel.org Subject: [PATCH 1/7] mm: don't look at xarray value entries in split_huge_pages_in_file Date: Sat, 21 Jan 2023 07:57:49 +0100 [thread overview] Message-ID: <20230121065755.1140136-2-hch@lst.de> (raw) In-Reply-To: <20230121065755.1140136-1-hch@lst.de> split_huge_pages_in_file never wants to do anything with the special value enties. Switch to using filemap_get_folio to not even see them. Signed-off-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org> --- mm/huge_memory.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/mm/huge_memory.c b/mm/huge_memory.c index 1d6977dc6b31ba..a2830019aaa017 100644 --- a/mm/huge_memory.c +++ b/mm/huge_memory.c @@ -3100,11 +3100,10 @@ static int split_huge_pages_in_file(const char *file_path, pgoff_t off_start, mapping = candidate->f_mapping; for (index = off_start; index < off_end; index += nr_pages) { - struct folio *folio = __filemap_get_folio(mapping, index, - FGP_ENTRY, 0); + struct folio *folio = filemap_get_folio(mapping, index); nr_pages = 1; - if (xa_is_value(folio) || !folio) + if (!folio) continue; if (!folio_test_large(folio)) -- 2.39.0
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de> To: cluster-devel.redhat.com Subject: [Cluster-devel] [PATCH 1/7] mm: don't look at xarray value entries in split_huge_pages_in_file Date: Sat, 21 Jan 2023 07:57:49 +0100 [thread overview] Message-ID: <20230121065755.1140136-2-hch@lst.de> (raw) In-Reply-To: <20230121065755.1140136-1-hch@lst.de> split_huge_pages_in_file never wants to do anything with the special value enties. Switch to using filemap_get_folio to not even see them. Signed-off-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org> --- mm/huge_memory.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/mm/huge_memory.c b/mm/huge_memory.c index 1d6977dc6b31ba..a2830019aaa017 100644 --- a/mm/huge_memory.c +++ b/mm/huge_memory.c @@ -3100,11 +3100,10 @@ static int split_huge_pages_in_file(const char *file_path, pgoff_t off_start, mapping = candidate->f_mapping; for (index = off_start; index < off_end; index += nr_pages) { - struct folio *folio = __filemap_get_folio(mapping, index, - FGP_ENTRY, 0); + struct folio *folio = filemap_get_folio(mapping, index); nr_pages = 1; - if (xa_is_value(folio) || !folio) + if (!folio) continue; if (!folio_test_large(folio)) -- 2.39.0
next prev parent reply other threads:[~2023-01-21 6:58 UTC|newest] Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-01-21 6:57 return an ERR_PTR from __filemap_get_folio v2 Christoph Hellwig 2023-01-21 6:57 ` Christoph Hellwig 2023-01-21 6:57 ` [Cluster-devel] " Christoph Hellwig 2023-01-21 6:57 ` Christoph Hellwig [this message] 2023-01-21 6:57 ` [Cluster-devel] [PATCH 1/7] mm: don't look at xarray value entries in split_huge_pages_in_file Christoph Hellwig 2023-01-21 6:57 ` [PATCH 2/7] mm: make mapping_get_entry available outside of filemap.c Christoph Hellwig 2023-01-21 6:57 ` [Cluster-devel] " Christoph Hellwig 2023-01-21 6:57 ` [PATCH 3/7] mm: use filemap_get_entry in filemap_get_incore_folio Christoph Hellwig 2023-01-21 6:57 ` Christoph Hellwig 2023-01-21 6:57 ` [Cluster-devel] " Christoph Hellwig 2023-01-21 6:57 ` [PATCH 4/7] shmem: remove shmem_get_partial_folio Christoph Hellwig 2023-01-21 6:57 ` [Cluster-devel] " Christoph Hellwig 2023-01-21 6:57 ` [PATCH 5/7] shmem: open code the page cache lookup in shmem_get_folio_gfp Christoph Hellwig 2023-01-21 6:57 ` Christoph Hellwig 2023-01-21 6:57 ` [Cluster-devel] " Christoph Hellwig 2023-01-21 6:57 ` [PATCH 6/7] mm: remove FGP_ENTRY Christoph Hellwig 2023-01-21 6:57 ` [Cluster-devel] " Christoph Hellwig 2023-01-21 6:57 ` [PATCH 7/7] mm: return an ERR_PTR from __filemap_get_folio Christoph Hellwig 2023-01-21 6:57 ` [Cluster-devel] " Christoph Hellwig 2023-01-21 11:52 ` kernel test robot 2023-01-21 11:52 ` kernel test robot 2023-01-21 11:52 ` [Cluster-devel] " kernel test robot 2023-01-21 14:28 ` Christoph Hellwig 2023-01-21 14:28 ` [Cluster-devel] " Christoph Hellwig 2023-01-23 15:44 ` David Sterba 2023-01-23 15:44 ` [Cluster-devel] " David Sterba 2023-01-26 17:24 ` Ryusuke Konishi 2023-01-26 17:24 ` Ryusuke Konishi 2023-01-26 17:24 ` [Cluster-devel] " Ryusuke Konishi 2023-03-10 4:31 ` Naoya Horiguchi 2023-03-10 4:31 ` [Cluster-devel] " Naoya Horiguchi 2023-03-10 7:00 ` Christoph Hellwig 2023-03-10 7:00 ` Christoph Hellwig 2023-03-10 7:00 ` [Cluster-devel] " Christoph Hellwig 2023-03-10 8:02 ` Naoya Horiguchi 2023-03-10 8:02 ` [Cluster-devel] " Naoya Horiguchi 2023-01-22 1:06 ` return an ERR_PTR from __filemap_get_folio v2 Andrew Morton 2023-01-22 1:06 ` Andrew Morton 2023-01-22 1:06 ` [Cluster-devel] " Andrew Morton 2023-01-22 7:20 ` Christoph Hellwig 2023-01-22 7:20 ` Christoph Hellwig 2023-01-22 7:20 ` [Cluster-devel] " Christoph Hellwig 2023-01-23 18:59 ` Andrew Morton 2023-01-23 18:59 ` Andrew Morton 2023-01-23 18:59 ` [Cluster-devel] " Andrew Morton 2023-01-23 19:18 ` Christoph Hellwig 2023-01-23 19:18 ` Christoph Hellwig 2023-01-23 19:18 ` [Cluster-devel] " Christoph Hellwig 2023-03-28 23:04 ` Andrew Morton 2023-03-28 23:04 ` [Cluster-devel] " Andrew Morton 2023-03-29 23:56 ` Christoph Hellwig 2023-03-29 23:56 ` Christoph Hellwig 2023-03-29 23:56 ` [Cluster-devel] " Christoph Hellwig 2023-03-07 14:34 return an ERR_PTR from __filemap_get_folio v3 Christoph Hellwig 2023-03-07 14:34 ` [PATCH 1/7] mm: don't look at xarray value entries in split_huge_pages_in_file Christoph Hellwig 2023-03-07 14:34 ` Christoph Hellwig
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230121065755.1140136-2-hch@lst.de \ --to=hch@lst.de \ --cc=akpm@linux-foundation.org \ --cc=cluster-devel@redhat.com \ --cc=hughd@google.com \ --cc=linux-afs@lists.infradead.org \ --cc=linux-btrfs@vger.kernel.org \ --cc=linux-ext4@vger.kernel.org \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=linux-nilfs@vger.kernel.org \ --cc=linux-xfs@vger.kernel.org \ --cc=willy@infradead.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.