* [PATCH v3 1/4] arm64: dts: qcom: use generic node name for Bluetooth
@ 2023-01-24 8:49 Krzysztof Kozlowski
2023-01-24 8:49 ` [PATCH v3 2/4] arm64: dts: qcom: sm8350: drop incorrect cells from serial Krzysztof Kozlowski
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2023-01-24 8:49 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Dmitry Baryshkov, Vinod Koul,
Neil Armstrong, linux-arm-msm, devicetree, linux-kernel
Cc: Krzysztof Kozlowski
Node names should be generic (as Devicetree spec mandates), so use
"bluetooth" for BT node.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
Changes since v2:
1. Add tag
Changes since v1:
1. Fix also msm8996-xiaomi-common
---
arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi | 2 +-
arch/arm64/boot/dts/qcom/sc7180-idp.dts | 2 +-
arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi b/arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi
index 5b47b8de69da..2acfed28e3cb 100644
--- a/arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi
@@ -229,7 +229,7 @@ &blsp1_uart2 {
status = "okay";
label = "QCA_UART";
- bluetooth: qca6174a {
+ bluetooth: bluetooth {
compatible = "qcom,qca6174-bt";
enable-gpios = <&pm8994_gpios 19 GPIO_ACTIVE_HIGH>;
diff --git a/arch/arm64/boot/dts/qcom/sc7180-idp.dts b/arch/arm64/boot/dts/qcom/sc7180-idp.dts
index c7a22c7976b7..6437551c61d4 100644
--- a/arch/arm64/boot/dts/qcom/sc7180-idp.dts
+++ b/arch/arm64/boot/dts/qcom/sc7180-idp.dts
@@ -424,7 +424,7 @@ &uart3 {
pinctrl-names = "default", "sleep";
pinctrl-1 = <&qup_uart3_sleep>;
- bluetooth: wcn3990-bt {
+ bluetooth: bluetooth {
compatible = "qcom,wcn3990-bt";
vddio-supply = <&vreg_l10a_1p8>;
vddxo-supply = <&vreg_l1c_1p8>;
diff --git a/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi b/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi
index 4ed6f9fb1a3c..9e26b07512bc 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi
@@ -862,7 +862,7 @@ &uart6 {
pinctrl-0 = <&qup_uart6_4pin>;
- bluetooth: wcn3990-bt {
+ bluetooth: bluetooth {
compatible = "qcom,wcn3990-bt";
vddio-supply = <&src_pp1800_s4a>;
vddxo-supply = <&pp1800_l7a_wcn3990>;
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH v3 2/4] arm64: dts: qcom: sm8350: drop incorrect cells from serial
2023-01-24 8:49 [PATCH v3 1/4] arm64: dts: qcom: use generic node name for Bluetooth Krzysztof Kozlowski
@ 2023-01-24 8:49 ` Krzysztof Kozlowski
2023-01-24 8:49 ` [PATCH v3 3/4] arm64: dts: qcom: sm8450: " Krzysztof Kozlowski
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2023-01-24 8:49 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Dmitry Baryshkov, Vinod Koul,
Neil Armstrong, linux-arm-msm, devicetree, linux-kernel
Cc: Krzysztof Kozlowski
The serial/UART device node does not have children with unit addresses,
so address/size cells are not correct.
Fixes: cf03cd7e12bd ("arm64: dts: qcom: sm8350: Set up WRAP0 QUPs")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
Changes since v2:
1. Add tag
2. Correct typo in commit msg
Changes since v1:
1. None
---
arch/arm64/boot/dts/qcom/sm8350.dtsi | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sm8350.dtsi b/arch/arm64/boot/dts/qcom/sm8350.dtsi
index fafd92edc855..f9a05bdcc364 100644
--- a/arch/arm64/boot/dts/qcom/sm8350.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8350.dtsi
@@ -1048,8 +1048,6 @@ uart2: serial@98c000 {
interrupts = <GIC_SPI 604 IRQ_TYPE_LEVEL_HIGH>;
power-domains = <&rpmhpd SM8350_CX>;
operating-points-v2 = <&qup_opp_table_100mhz>;
- #address-cells = <1>;
- #size-cells = <0>;
status = "disabled";
};
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH v3 3/4] arm64: dts: qcom: sm8450: drop incorrect cells from serial
2023-01-24 8:49 [PATCH v3 1/4] arm64: dts: qcom: use generic node name for Bluetooth Krzysztof Kozlowski
2023-01-24 8:49 ` [PATCH v3 2/4] arm64: dts: qcom: sm8350: drop incorrect cells from serial Krzysztof Kozlowski
@ 2023-01-24 8:49 ` Krzysztof Kozlowski
2023-01-24 8:49 ` [PATCH v3 4/4] arm64: dts: qcom: sm8550: " Krzysztof Kozlowski
2023-02-09 4:23 ` (subset) [PATCH v3 1/4] arm64: dts: qcom: use generic node name for Bluetooth Bjorn Andersson
3 siblings, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2023-01-24 8:49 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Dmitry Baryshkov, Vinod Koul,
Neil Armstrong, linux-arm-msm, devicetree, linux-kernel
Cc: Krzysztof Kozlowski
The serial/UART device node does not have children with unit addresses,
so address/size cells are not correct.
Fixes: f5837418479a ("arm64: dts: qcom: sm8450: add uart20 node")
Fixes: 5188049c9b36 ("arm64: dts: qcom: Add base SM8450 DTSI")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
Changes since v2:
1. Add tag
2. Correct typo in commit msg
Changes since v1:
1. None
---
arch/arm64/boot/dts/qcom/sm8450.dtsi | 4 ----
1 file changed, 4 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi
index 5ba65780166e..873bc9c412f2 100644
--- a/arch/arm64/boot/dts/qcom/sm8450.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi
@@ -1007,8 +1007,6 @@ uart20: serial@894000 {
pinctrl-names = "default";
pinctrl-0 = <&qup_uart20_default>;
interrupts = <GIC_SPI 587 IRQ_TYPE_LEVEL_HIGH>;
- #address-cells = <1>;
- #size-cells = <0>;
status = "disabled";
};
@@ -1401,8 +1399,6 @@ uart7: serial@99c000 {
pinctrl-names = "default";
pinctrl-0 = <&qup_uart7_tx>, <&qup_uart7_rx>;
interrupts = <GIC_SPI 608 IRQ_TYPE_LEVEL_HIGH>;
- #address-cells = <1>;
- #size-cells = <0>;
status = "disabled";
};
};
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH v3 4/4] arm64: dts: qcom: sm8550: drop incorrect cells from serial
2023-01-24 8:49 [PATCH v3 1/4] arm64: dts: qcom: use generic node name for Bluetooth Krzysztof Kozlowski
2023-01-24 8:49 ` [PATCH v3 2/4] arm64: dts: qcom: sm8350: drop incorrect cells from serial Krzysztof Kozlowski
2023-01-24 8:49 ` [PATCH v3 3/4] arm64: dts: qcom: sm8450: " Krzysztof Kozlowski
@ 2023-01-24 8:49 ` Krzysztof Kozlowski
2023-02-09 4:23 ` (subset) [PATCH v3 1/4] arm64: dts: qcom: use generic node name for Bluetooth Bjorn Andersson
3 siblings, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2023-01-24 8:49 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Dmitry Baryshkov, Vinod Koul,
Neil Armstrong, linux-arm-msm, devicetree, linux-kernel
Cc: Krzysztof Kozlowski
The serial/UART device node does not have children with unit addresses,
so address/size cells are not correct.
Fixes: 377972ac743f ("arm64: dts: qcom: sm8550: add I2C Master Hub nodes")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
Changes since v2:
1. Add tag
2. Correct typo in commit msg
Changes since v1:
1. New patch
---
arch/arm64/boot/dts/qcom/sm8550.dtsi | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sm8550.dtsi b/arch/arm64/boot/dts/qcom/sm8550.dtsi
index 59756ec11564..c183eb5cb406 100644
--- a/arch/arm64/boot/dts/qcom/sm8550.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8550.dtsi
@@ -1487,8 +1487,6 @@ uart7: serial@a9c000 {
interconnect-names = "qup-core", "qup-config";
interconnects = <&clk_virt MASTER_QUP_CORE_1 0 &clk_virt SLAVE_QUP_CORE_1 0>,
<&gem_noc MASTER_APPSS_PROC 0 &config_noc SLAVE_QUP_1 0>;
- #address-cells = <1>;
- #size-cells = <0>;
status = "disabled";
};
};
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: (subset) [PATCH v3 1/4] arm64: dts: qcom: use generic node name for Bluetooth
2023-01-24 8:49 [PATCH v3 1/4] arm64: dts: qcom: use generic node name for Bluetooth Krzysztof Kozlowski
` (2 preceding siblings ...)
2023-01-24 8:49 ` [PATCH v3 4/4] arm64: dts: qcom: sm8550: " Krzysztof Kozlowski
@ 2023-02-09 4:23 ` Bjorn Andersson
3 siblings, 0 replies; 5+ messages in thread
From: Bjorn Andersson @ 2023-02-09 4:23 UTC (permalink / raw)
To: Andy Gross, Dmitry Baryshkov, Rob Herring, Krzysztof Kozlowski,
Konrad Dybcio, devicetree, Vinod Koul, linux-kernel,
Krzysztof Kozlowski, Neil Armstrong, linux-arm-msm
On Tue, 24 Jan 2023 09:49:48 +0100, Krzysztof Kozlowski wrote:
> Node names should be generic (as Devicetree spec mandates), so use
> "bluetooth" for BT node.
>
>
Applied, thanks!
[1/4] arm64: dts: qcom: use generic node name for Bluetooth
commit: f7aaaf3030d8c9873b2bb3abbe506fa4da8936cf
[2/4] arm64: dts: qcom: sm8350: drop incorrect cells from serial
commit: 6027331e6eae9eb957d1b73a7e3255f4151d6163
[3/4] arm64: dts: qcom: sm8450: drop incorrect cells from serial
commit: 60d2da2c916956535cf37b7bf1ae8fefbf432e55
[4/4] arm64: dts: qcom: sm8550: drop incorrect cells from serial
commit: fa3ba1c6a0be9f1924daa312271245cafd3f4305
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-02-09 4:26 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-24 8:49 [PATCH v3 1/4] arm64: dts: qcom: use generic node name for Bluetooth Krzysztof Kozlowski
2023-01-24 8:49 ` [PATCH v3 2/4] arm64: dts: qcom: sm8350: drop incorrect cells from serial Krzysztof Kozlowski
2023-01-24 8:49 ` [PATCH v3 3/4] arm64: dts: qcom: sm8450: " Krzysztof Kozlowski
2023-01-24 8:49 ` [PATCH v3 4/4] arm64: dts: qcom: sm8550: " Krzysztof Kozlowski
2023-02-09 4:23 ` (subset) [PATCH v3 1/4] arm64: dts: qcom: use generic node name for Bluetooth Bjorn Andersson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.