All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v4] leds: simatic-ipc-leds-gpio: make sure we have the GPIO providing driver
@ 2022-10-07 15:33 Henning Schild
  2022-12-22 10:19 ` Henning Schild
                   ` (2 more replies)
  0 siblings, 3 replies; 24+ messages in thread
From: Henning Schild @ 2022-10-07 15:33 UTC (permalink / raw)
  To: Andy Shevchenko, Pavel Machek, Lee Jones, linux-leds, linux-kernel
  Cc: Henning Schild, Andy Shevchenko

If we register a "leds-gpio" platform device for GPIO pins that do not
exist we get a -EPROBE_DEFER and the probe will be tried again later.
If there is no driver to provide that pin we will poll forever and also
create a lot of log messages.

So check if that GPIO driver is configured, if so it will come up
eventually. If not, we exit our probe function early and do not even
bother registering the "leds-gpio". This method was chosen over "Kconfig
depends" since this way we can add support for more devices and GPIO
backends more easily without "depends":ing on all GPIO backends.

Fixes: a6c80bec3c93 ("leds: simatic-ipc-leds-gpio: Add GPIO version of Siemens driver")
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Henning Schild <henning.schild@siemens.com>
---
 drivers/leds/simple/simatic-ipc-leds-gpio.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/leds/simple/simatic-ipc-leds-gpio.c b/drivers/leds/simple/simatic-ipc-leds-gpio.c
index b9eeb8702df0..fb8d427837db 100644
--- a/drivers/leds/simple/simatic-ipc-leds-gpio.c
+++ b/drivers/leds/simple/simatic-ipc-leds-gpio.c
@@ -77,6 +77,8 @@ static int simatic_ipc_leds_gpio_probe(struct platform_device *pdev)
 
 	switch (plat->devmode) {
 	case SIMATIC_IPC_DEVICE_127E:
+		if (!IS_ENABLED(CONFIG_PINCTRL_BROXTON))
+			return -ENODEV;
 		simatic_ipc_led_gpio_table = &simatic_ipc_led_gpio_table_127e;
 		break;
 	case SIMATIC_IPC_DEVICE_227G:
-- 
2.35.1


^ permalink raw reply related	[flat|nested] 24+ messages in thread

end of thread, other threads:[~2023-02-03 16:58 UTC | newest]

Thread overview: 24+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-07 15:33 [PATCH v4] leds: simatic-ipc-leds-gpio: make sure we have the GPIO providing driver Henning Schild
2022-12-22 10:19 ` Henning Schild
2022-12-23 11:58 ` Lee Jones
2023-01-02 15:22   ` Henning Schild
2023-01-03 20:20     ` Henning Schild
2023-01-04 14:24       ` Lee Jones
2023-01-04 14:39         ` Henning Schild
2023-01-04 15:51           ` Andy Shevchenko
2023-01-04 19:30             ` Henning Schild
2023-01-05  9:35               ` Andy Shevchenko
2023-01-05 11:23                 ` Henning Schild
2023-01-19 21:02 ` Lee Jones
2023-01-23 20:48   ` Henning Schild
2023-01-24  9:46     ` Andy Shevchenko
2023-01-24 10:29       ` Lee Jones
2023-01-24 13:52         ` Henning Schild
2023-01-24 14:50           ` Henning Schild
2023-01-24 13:35       ` Henning Schild
2023-01-24 13:46         ` Andy Shevchenko
2023-01-25 17:36           ` Henning Schild
2023-01-25 17:47             ` Andy Shevchenko
2023-02-02 19:57   ` Henning Schild
2023-02-03  7:59     ` Lee Jones
2023-02-03 16:58       ` Henning Schild

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.