From: kernel test robot <lkp@intel.com> To: Leon Romanovsky <leon@kernel.org>, "David S . Miller" <davem@davemloft.net>, Jakub Kicinski <kuba@kernel.org>, Steffen Klassert <steffen.klassert@secunet.com> Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, Leon Romanovsky <leonro@nvidia.com>, Andy Gospodarek <andy@greyhouse.net>, Ayush Sawal <ayush.sawal@chelsio.com>, Eric Dumazet <edumazet@google.com>, Herbert Xu <herbert@gondor.apana.org.au>, intel-wired-lan@lists.osuosl.org, Jay Vosburgh <j.vosburgh@gmail.com>, Jesse Brandeburg <jesse.brandeburg@intel.com>, Jonathan Corbet <corbet@lwn.net>, linux-doc@vger.kernel.org, netdev@vger.kernel.org, oss-drivers@corigine.com, Paolo Abeni <pabeni@redhat.com>, Raju Rangoju <rajur@chelsio.com>, Saeed Mahameed <saeedm@nvidia.com>, Simon Horman <simon.horman@corigine.com>, Tony Nguyen <anthony.l.nguyen@intel.com>, Veaceslav Falico <vfalico@gmail.com> Subject: Re: [PATCH net-next 10/10] cxgb4: fill IPsec state validation failure reason Date: Tue, 24 Jan 2023 17:42:01 +0800 [thread overview] Message-ID: <202301241750.Qpv1Vuj6-lkp@intel.com> (raw) In-Reply-To: <9b45993fb96b6faa2b65f3dd78e677a54eeeec31.1674481435.git.leon@kernel.org> Hi Leon, I love your patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/intel-lab-lkp/linux/commits/Leon-Romanovsky/xfrm-extend-add-policy-callback-to-set-failure-reason/20230123-220422 patch link: https://lore.kernel.org/r/9b45993fb96b6faa2b65f3dd78e677a54eeeec31.1674481435.git.leon%40kernel.org patch subject: [PATCH net-next 10/10] cxgb4: fill IPsec state validation failure reason config: i386-allmodconfig (https://download.01.org/0day-ci/archive/20230124/202301241750.Qpv1Vuj6-lkp@intel.com/config) compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/7eb8edee0c687243325ffd27b20c0f5d429b76f0 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Leon-Romanovsky/xfrm-extend-add-policy-callback-to-set-failure-reason/20230123-220422 git checkout 7eb8edee0c687243325ffd27b20c0f5d429b76f0 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/net/ethernet/chelsio/inline_crypto/ch_ipsec/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <lkp@intel.com> All errors (new ones prefixed by >>): >> drivers/net/ethernet/chelsio/inline_crypto/ch_ipsec/chcr_ipsec.c:263:63: error: too few arguments provided to function-like macro invocation NL_SET_ERR_MSG_MOD("Cannot offload xfrm states without aead"); ^ include/linux/netlink.h:127:9: note: macro 'NL_SET_ERR_MSG_MOD' defined here #define NL_SET_ERR_MSG_MOD(extack, msg) \ ^ >> drivers/net/ethernet/chelsio/inline_crypto/ch_ipsec/chcr_ipsec.c:263:3: error: use of undeclared identifier 'NL_SET_ERR_MSG_MOD' NL_SET_ERR_MSG_MOD("Cannot offload xfrm states without aead"); ^ 2 errors generated. vim +263 drivers/net/ethernet/chelsio/inline_crypto/ch_ipsec/chcr_ipsec.c 224 225 /* 226 * ch_ipsec_xfrm_add_state 227 * returns 0 on success, negative error if failed to send message to FPGA 228 * positive error if FPGA returned a bad response 229 */ 230 static int ch_ipsec_xfrm_add_state(struct xfrm_state *x, 231 struct netlink_ext_ack *extack) 232 { 233 struct ipsec_sa_entry *sa_entry; 234 int res = 0; 235 236 if (x->props.aalgo != SADB_AALG_NONE) { 237 NL_SET_ERR_MSG_MOD(extack, "Cannot offload authenticated xfrm states"); 238 return -EINVAL; 239 } 240 if (x->props.calgo != SADB_X_CALG_NONE) { 241 NL_SET_ERR_MSG_MOD(extack, "Cannot offload compressed xfrm states"); 242 return -EINVAL; 243 } 244 if (x->props.family != AF_INET && 245 x->props.family != AF_INET6) { 246 NL_SET_ERR_MSG_MOD(extack, "Only IPv4/6 xfrm state offloaded"); 247 return -EINVAL; 248 } 249 if (x->props.mode != XFRM_MODE_TRANSPORT && 250 x->props.mode != XFRM_MODE_TUNNEL) { 251 NL_SET_ERR_MSG_MOD(extack, "Only transport and tunnel xfrm offload"); 252 return -EINVAL; 253 } 254 if (x->id.proto != IPPROTO_ESP) { 255 NL_SET_ERR_MSG_MOD(extack, "Only ESP xfrm state offloaded"); 256 return -EINVAL; 257 } 258 if (x->encap) { 259 NL_SET_ERR_MSG_MOD(extack, "Encapsulated xfrm state not offloaded"); 260 return -EINVAL; 261 } 262 if (!x->aead) { > 263 NL_SET_ERR_MSG_MOD("Cannot offload xfrm states without aead"); 264 return -EINVAL; 265 } 266 if (x->aead->alg_icv_len != 128 && 267 x->aead->alg_icv_len != 96) { 268 NL_SET_ERR_MSG_MOD(extack, "Cannot offload xfrm states with AEAD ICV length other than 96b & 128b"); 269 return -EINVAL; 270 } 271 if ((x->aead->alg_key_len != 128 + 32) && 272 (x->aead->alg_key_len != 256 + 32)) { 273 NL_SET_ERR_MSG_MOD(extack, "cannot offload xfrm states with AEAD key length other than 128/256 bit"); 274 return -EINVAL; 275 } 276 if (x->tfcpad) { 277 NL_SET_ERR_MSG_MOD(extack, "Cannot offload xfrm states with tfc padding"); 278 return -EINVAL; 279 } 280 if (!x->geniv) { 281 NL_SET_ERR_MSG_MOD(extack, "Cannot offload xfrm states without geniv"); 282 return -EINVAL; 283 } 284 if (strcmp(x->geniv, "seqiv")) { 285 NL_SET_ERR_MSG_MOD(extack, "Cannot offload xfrm states with geniv other than seqiv"); 286 return -EINVAL; 287 } 288 if (x->xso.type != XFRM_DEV_OFFLOAD_CRYPTO) { 289 NL_SET_ERR_MSG_MOD(extack, "Unsupported xfrm offload"); 290 return -EINVAL; 291 } 292 293 sa_entry = kzalloc(sizeof(*sa_entry), GFP_KERNEL); 294 if (!sa_entry) { 295 res = -ENOMEM; 296 goto out; 297 } 298 299 sa_entry->hmac_ctrl = ch_ipsec_setauthsize(x, sa_entry); 300 if (x->props.flags & XFRM_STATE_ESN) 301 sa_entry->esn = 1; 302 ch_ipsec_setkey(x, sa_entry); 303 x->xso.offload_handle = (unsigned long)sa_entry; 304 try_module_get(THIS_MODULE); 305 out: 306 return res; 307 } 308 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com> To: Leon Romanovsky <leon@kernel.org>, "David S . Miller" <davem@davemloft.net>, Jakub Kicinski <kuba@kernel.org>, Steffen Klassert <steffen.klassert@secunet.com> Cc: Raju Rangoju <rajur@chelsio.com>, Herbert Xu <herbert@gondor.apana.org.au>, oe-kbuild-all@lists.linux.dev, Jonathan Corbet <corbet@lwn.net>, Jay Vosburgh <j.vosburgh@gmail.com>, oss-drivers@corigine.com, llvm@lists.linux.dev, linux-doc@vger.kernel.org, Jesse Brandeburg <jesse.brandeburg@intel.com>, Eric Dumazet <edumazet@google.com>, netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org, Ayush Sawal <ayush.sawal@chelsio.com>, Simon Horman <simon.horman@corigine.com>, Tony Nguyen <anthony.l.nguyen@intel.com>, Veaceslav Falico <vfalico@gmail.com>, Paolo Abeni <pabeni@redhat.com>, Leon Romanovsky <leonro@nvidia.com>, Saeed Mahameed <saeedm@nvidia.com>, Andy Gospodarek <andy@greyhouse.net> Subject: Re: [Intel-wired-lan] [PATCH net-next 10/10] cxgb4: fill IPsec state validation failure reason Date: Tue, 24 Jan 2023 17:42:01 +0800 [thread overview] Message-ID: <202301241750.Qpv1Vuj6-lkp@intel.com> (raw) In-Reply-To: <9b45993fb96b6faa2b65f3dd78e677a54eeeec31.1674481435.git.leon@kernel.org> Hi Leon, I love your patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/intel-lab-lkp/linux/commits/Leon-Romanovsky/xfrm-extend-add-policy-callback-to-set-failure-reason/20230123-220422 patch link: https://lore.kernel.org/r/9b45993fb96b6faa2b65f3dd78e677a54eeeec31.1674481435.git.leon%40kernel.org patch subject: [PATCH net-next 10/10] cxgb4: fill IPsec state validation failure reason config: i386-allmodconfig (https://download.01.org/0day-ci/archive/20230124/202301241750.Qpv1Vuj6-lkp@intel.com/config) compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/7eb8edee0c687243325ffd27b20c0f5d429b76f0 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Leon-Romanovsky/xfrm-extend-add-policy-callback-to-set-failure-reason/20230123-220422 git checkout 7eb8edee0c687243325ffd27b20c0f5d429b76f0 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/net/ethernet/chelsio/inline_crypto/ch_ipsec/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <lkp@intel.com> All errors (new ones prefixed by >>): >> drivers/net/ethernet/chelsio/inline_crypto/ch_ipsec/chcr_ipsec.c:263:63: error: too few arguments provided to function-like macro invocation NL_SET_ERR_MSG_MOD("Cannot offload xfrm states without aead"); ^ include/linux/netlink.h:127:9: note: macro 'NL_SET_ERR_MSG_MOD' defined here #define NL_SET_ERR_MSG_MOD(extack, msg) \ ^ >> drivers/net/ethernet/chelsio/inline_crypto/ch_ipsec/chcr_ipsec.c:263:3: error: use of undeclared identifier 'NL_SET_ERR_MSG_MOD' NL_SET_ERR_MSG_MOD("Cannot offload xfrm states without aead"); ^ 2 errors generated. vim +263 drivers/net/ethernet/chelsio/inline_crypto/ch_ipsec/chcr_ipsec.c 224 225 /* 226 * ch_ipsec_xfrm_add_state 227 * returns 0 on success, negative error if failed to send message to FPGA 228 * positive error if FPGA returned a bad response 229 */ 230 static int ch_ipsec_xfrm_add_state(struct xfrm_state *x, 231 struct netlink_ext_ack *extack) 232 { 233 struct ipsec_sa_entry *sa_entry; 234 int res = 0; 235 236 if (x->props.aalgo != SADB_AALG_NONE) { 237 NL_SET_ERR_MSG_MOD(extack, "Cannot offload authenticated xfrm states"); 238 return -EINVAL; 239 } 240 if (x->props.calgo != SADB_X_CALG_NONE) { 241 NL_SET_ERR_MSG_MOD(extack, "Cannot offload compressed xfrm states"); 242 return -EINVAL; 243 } 244 if (x->props.family != AF_INET && 245 x->props.family != AF_INET6) { 246 NL_SET_ERR_MSG_MOD(extack, "Only IPv4/6 xfrm state offloaded"); 247 return -EINVAL; 248 } 249 if (x->props.mode != XFRM_MODE_TRANSPORT && 250 x->props.mode != XFRM_MODE_TUNNEL) { 251 NL_SET_ERR_MSG_MOD(extack, "Only transport and tunnel xfrm offload"); 252 return -EINVAL; 253 } 254 if (x->id.proto != IPPROTO_ESP) { 255 NL_SET_ERR_MSG_MOD(extack, "Only ESP xfrm state offloaded"); 256 return -EINVAL; 257 } 258 if (x->encap) { 259 NL_SET_ERR_MSG_MOD(extack, "Encapsulated xfrm state not offloaded"); 260 return -EINVAL; 261 } 262 if (!x->aead) { > 263 NL_SET_ERR_MSG_MOD("Cannot offload xfrm states without aead"); 264 return -EINVAL; 265 } 266 if (x->aead->alg_icv_len != 128 && 267 x->aead->alg_icv_len != 96) { 268 NL_SET_ERR_MSG_MOD(extack, "Cannot offload xfrm states with AEAD ICV length other than 96b & 128b"); 269 return -EINVAL; 270 } 271 if ((x->aead->alg_key_len != 128 + 32) && 272 (x->aead->alg_key_len != 256 + 32)) { 273 NL_SET_ERR_MSG_MOD(extack, "cannot offload xfrm states with AEAD key length other than 128/256 bit"); 274 return -EINVAL; 275 } 276 if (x->tfcpad) { 277 NL_SET_ERR_MSG_MOD(extack, "Cannot offload xfrm states with tfc padding"); 278 return -EINVAL; 279 } 280 if (!x->geniv) { 281 NL_SET_ERR_MSG_MOD(extack, "Cannot offload xfrm states without geniv"); 282 return -EINVAL; 283 } 284 if (strcmp(x->geniv, "seqiv")) { 285 NL_SET_ERR_MSG_MOD(extack, "Cannot offload xfrm states with geniv other than seqiv"); 286 return -EINVAL; 287 } 288 if (x->xso.type != XFRM_DEV_OFFLOAD_CRYPTO) { 289 NL_SET_ERR_MSG_MOD(extack, "Unsupported xfrm offload"); 290 return -EINVAL; 291 } 292 293 sa_entry = kzalloc(sizeof(*sa_entry), GFP_KERNEL); 294 if (!sa_entry) { 295 res = -ENOMEM; 296 goto out; 297 } 298 299 sa_entry->hmac_ctrl = ch_ipsec_setauthsize(x, sa_entry); 300 if (x->props.flags & XFRM_STATE_ESN) 301 sa_entry->esn = 1; 302 ch_ipsec_setkey(x, sa_entry); 303 x->xso.offload_handle = (unsigned long)sa_entry; 304 try_module_get(THIS_MODULE); 305 out: 306 return res; 307 } 308 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
next prev parent reply other threads:[~2023-01-24 9:42 UTC|newest] Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-01-23 14:00 [PATCH net-next 00/10] Convert drivers to return XFRM configuration errors through extack Leon Romanovsky 2023-01-23 14:00 ` [Intel-wired-lan] " Leon Romanovsky 2023-01-23 14:00 ` [PATCH net-next 01/10] xfrm: extend add policy callback to set failure reason Leon Romanovsky 2023-01-23 14:00 ` [Intel-wired-lan] " Leon Romanovsky 2023-01-23 14:00 ` [Intel-wired-lan] [PATCH net-next 02/10] net/mlx5e: Fill IPsec policy validation " Leon Romanovsky 2023-01-23 14:00 ` Leon Romanovsky 2023-01-23 14:00 ` [Intel-wired-lan] [PATCH net-next 03/10] xfrm: extend add state callback to set " Leon Romanovsky 2023-01-23 14:00 ` Leon Romanovsky 2023-01-23 14:00 ` [PATCH net-next 04/10] net/mlx5e: Fill IPsec state validation " Leon Romanovsky 2023-01-23 14:00 ` [Intel-wired-lan] " Leon Romanovsky 2023-01-23 17:12 ` Leon Romanovsky 2023-01-23 17:12 ` Leon Romanovsky 2023-01-24 7:59 ` [Intel-wired-lan] " kernel test robot 2023-01-24 7:59 ` kernel test robot 2023-01-23 14:00 ` [PATCH net-next 05/10] netdevsim: " Leon Romanovsky 2023-01-23 14:00 ` [Intel-wired-lan] " Leon Romanovsky 2023-01-23 14:00 ` [Intel-wired-lan] [PATCH net-next 06/10] nfp: fill " Leon Romanovsky 2023-01-23 14:00 ` Leon Romanovsky 2023-01-23 15:09 ` Simon Horman 2023-01-23 15:09 ` [Intel-wired-lan] " Simon Horman 2023-01-23 16:34 ` Leon Romanovsky 2023-01-23 16:34 ` [Intel-wired-lan] " Leon Romanovsky 2023-01-23 14:00 ` [PATCH net-next 07/10] ixgbevf: " Leon Romanovsky 2023-01-23 14:00 ` [Intel-wired-lan] " Leon Romanovsky 2023-01-23 14:00 ` [Intel-wired-lan] [PATCH net-next 08/10] ixgbe: " Leon Romanovsky 2023-01-23 14:00 ` Leon Romanovsky 2023-01-23 14:00 ` [Intel-wired-lan] [PATCH net-next 09/10] bonding: " Leon Romanovsky 2023-01-23 14:00 ` Leon Romanovsky 2023-01-23 23:01 ` [Intel-wired-lan] " Jay Vosburgh 2023-01-23 23:01 ` Jay Vosburgh 2023-01-24 6:22 ` Leon Romanovsky 2023-01-24 6:22 ` Leon Romanovsky 2023-01-23 14:00 ` [PATCH net-next 10/10] cxgb4: " Leon Romanovsky 2023-01-23 14:00 ` [Intel-wired-lan] " Leon Romanovsky 2023-01-24 9:42 ` kernel test robot [this message] 2023-01-24 9:42 ` kernel test robot
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=202301241750.Qpv1Vuj6-lkp@intel.com \ --to=lkp@intel.com \ --cc=andy@greyhouse.net \ --cc=anthony.l.nguyen@intel.com \ --cc=ayush.sawal@chelsio.com \ --cc=corbet@lwn.net \ --cc=davem@davemloft.net \ --cc=edumazet@google.com \ --cc=herbert@gondor.apana.org.au \ --cc=intel-wired-lan@lists.osuosl.org \ --cc=j.vosburgh@gmail.com \ --cc=jesse.brandeburg@intel.com \ --cc=kuba@kernel.org \ --cc=leon@kernel.org \ --cc=leonro@nvidia.com \ --cc=linux-doc@vger.kernel.org \ --cc=llvm@lists.linux.dev \ --cc=netdev@vger.kernel.org \ --cc=oe-kbuild-all@lists.linux.dev \ --cc=oss-drivers@corigine.com \ --cc=pabeni@redhat.com \ --cc=rajur@chelsio.com \ --cc=saeedm@nvidia.com \ --cc=simon.horman@corigine.com \ --cc=steffen.klassert@secunet.com \ --cc=vfalico@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.