* [PATCH v2] drm/msm/dpu: Add DSC hardware blocks to register snapshot
@ 2023-01-25 10:14 ` Marijn Suijten
0 siblings, 0 replies; 6+ messages in thread
From: Marijn Suijten @ 2023-01-25 10:14 UTC (permalink / raw)
To: phone-devel
Cc: ~postmarketos/upstreaming, AngeloGioacchino Del Regno,
Konrad Dybcio, Martin Botka, Jami Kettunen, Neil Armstrong,
Kuogee Hsieh, Marijn Suijten, Rob Clark, Abhinav Kumar,
Dmitry Baryshkov, Sean Paul, David Airlie, Daniel Vetter,
Stephen Boyd, Bjorn Andersson, Vinod Polimera, Liu Shixin,
linux-arm-msm, dri-devel, freedreno, linux-kernel
Add missing DSC hardware block register ranges to the snapshot utility
to include them in dmesg (on MSM_DISP_SNAPSHOT_DUMP_IN_CONSOLE) and the
kms debugfs file.
Signed-off-by: Marijn Suijten <marijn.suijten@somainline.org>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
---
Changes since v1:
- Rebase on next-20230125 to solve conflicts with 43e3293fc614
("drm/msm/dpu: add support for MDP_TOP blackhole").
v1: https://lore.kernel.org/linux-arm-msm/20230125091315.133283-1-marijn.suijten@somainline.org/T/#u
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
index d612419118a2..a683bd9b5a04 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
@@ -937,6 +937,11 @@ static void dpu_kms_mdp_snapshot(struct msm_disp_state *disp_state, struct msm_k
dpu_kms->mmio + cat->mdp[0].base, "top");
}
+ /* dump DSC sub-blocks HW regs info */
+ for (i = 0; i < cat->dsc_count; i++)
+ msm_disp_snapshot_add_block(disp_state, cat->dsc[i].len,
+ dpu_kms->mmio + cat->dsc[i].base, "dsc_%d", i);
+
pm_runtime_put_sync(&dpu_kms->pdev->dev);
}
--
2.39.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v2] drm/msm/dpu: Add DSC hardware blocks to register snapshot
@ 2023-01-25 10:14 ` Marijn Suijten
0 siblings, 0 replies; 6+ messages in thread
From: Marijn Suijten @ 2023-01-25 10:14 UTC (permalink / raw)
To: phone-devel
Cc: dri-devel, Liu Shixin, AngeloGioacchino Del Regno,
Marijn Suijten, Vinod Polimera, Kuogee Hsieh, linux-arm-msm,
Abhinav Kumar, Stephen Boyd, Martin Botka,
~postmarketos/upstreaming, Sean Paul, Neil Armstrong,
Jami Kettunen, Bjorn Andersson, linux-kernel, Konrad Dybcio,
Dmitry Baryshkov, freedreno
Add missing DSC hardware block register ranges to the snapshot utility
to include them in dmesg (on MSM_DISP_SNAPSHOT_DUMP_IN_CONSOLE) and the
kms debugfs file.
Signed-off-by: Marijn Suijten <marijn.suijten@somainline.org>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
---
Changes since v1:
- Rebase on next-20230125 to solve conflicts with 43e3293fc614
("drm/msm/dpu: add support for MDP_TOP blackhole").
v1: https://lore.kernel.org/linux-arm-msm/20230125091315.133283-1-marijn.suijten@somainline.org/T/#u
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
index d612419118a2..a683bd9b5a04 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
@@ -937,6 +937,11 @@ static void dpu_kms_mdp_snapshot(struct msm_disp_state *disp_state, struct msm_k
dpu_kms->mmio + cat->mdp[0].base, "top");
}
+ /* dump DSC sub-blocks HW regs info */
+ for (i = 0; i < cat->dsc_count; i++)
+ msm_disp_snapshot_add_block(disp_state, cat->dsc[i].len,
+ dpu_kms->mmio + cat->dsc[i].base, "dsc_%d", i);
+
pm_runtime_put_sync(&dpu_kms->pdev->dev);
}
--
2.39.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2] drm/msm/dpu: Add DSC hardware blocks to register snapshot
2023-01-25 10:14 ` Marijn Suijten
@ 2023-01-25 19:05 ` Abhinav Kumar
-1 siblings, 0 replies; 6+ messages in thread
From: Abhinav Kumar @ 2023-01-25 19:05 UTC (permalink / raw)
To: Marijn Suijten, phone-devel
Cc: ~postmarketos/upstreaming, AngeloGioacchino Del Regno,
Konrad Dybcio, Martin Botka, Jami Kettunen, Neil Armstrong,
Kuogee Hsieh, Rob Clark, Dmitry Baryshkov, Sean Paul,
David Airlie, Daniel Vetter, Stephen Boyd, Bjorn Andersson,
Vinod Polimera, Liu Shixin, linux-arm-msm, dri-devel, freedreno,
linux-kernel
On 1/25/2023 2:14 AM, Marijn Suijten wrote:
> Add missing DSC hardware block register ranges to the snapshot utility
> to include them in dmesg (on MSM_DISP_SNAPSHOT_DUMP_IN_CONSOLE) and the
> kms debugfs file.
>
> Signed-off-by: Marijn Suijten <marijn.suijten@somainline.org>
> Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Huge ack from me,
Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
> ---
> Changes since v1:
> - Rebase on next-20230125 to solve conflicts with 43e3293fc614
> ("drm/msm/dpu: add support for MDP_TOP blackhole").
>
> v1: https://lore.kernel.org/linux-arm-msm/20230125091315.133283-1-marijn.suijten@somainline.org/T/#u
>
> drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
> index d612419118a2..a683bd9b5a04 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
> @@ -937,6 +937,11 @@ static void dpu_kms_mdp_snapshot(struct msm_disp_state *disp_state, struct msm_k
> dpu_kms->mmio + cat->mdp[0].base, "top");
> }
>
> + /* dump DSC sub-blocks HW regs info */
> + for (i = 0; i < cat->dsc_count; i++)
> + msm_disp_snapshot_add_block(disp_state, cat->dsc[i].len,
> + dpu_kms->mmio + cat->dsc[i].base, "dsc_%d", i);
> +
> pm_runtime_put_sync(&dpu_kms->pdev->dev);
> }
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] drm/msm/dpu: Add DSC hardware blocks to register snapshot
@ 2023-01-25 19:05 ` Abhinav Kumar
0 siblings, 0 replies; 6+ messages in thread
From: Abhinav Kumar @ 2023-01-25 19:05 UTC (permalink / raw)
To: Marijn Suijten, phone-devel
Cc: Neil Armstrong, Liu Shixin, Jami Kettunen, Bjorn Andersson,
freedreno, linux-kernel, dri-devel, Kuogee Hsieh, Konrad Dybcio,
Martin Botka, ~postmarketos/upstreaming,
AngeloGioacchino Del Regno, Dmitry Baryshkov, Stephen Boyd,
Sean Paul, Vinod Polimera, linux-arm-msm
On 1/25/2023 2:14 AM, Marijn Suijten wrote:
> Add missing DSC hardware block register ranges to the snapshot utility
> to include them in dmesg (on MSM_DISP_SNAPSHOT_DUMP_IN_CONSOLE) and the
> kms debugfs file.
>
> Signed-off-by: Marijn Suijten <marijn.suijten@somainline.org>
> Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Huge ack from me,
Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
> ---
> Changes since v1:
> - Rebase on next-20230125 to solve conflicts with 43e3293fc614
> ("drm/msm/dpu: add support for MDP_TOP blackhole").
>
> v1: https://lore.kernel.org/linux-arm-msm/20230125091315.133283-1-marijn.suijten@somainline.org/T/#u
>
> drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
> index d612419118a2..a683bd9b5a04 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
> @@ -937,6 +937,11 @@ static void dpu_kms_mdp_snapshot(struct msm_disp_state *disp_state, struct msm_k
> dpu_kms->mmio + cat->mdp[0].base, "top");
> }
>
> + /* dump DSC sub-blocks HW regs info */
> + for (i = 0; i < cat->dsc_count; i++)
> + msm_disp_snapshot_add_block(disp_state, cat->dsc[i].len,
> + dpu_kms->mmio + cat->dsc[i].base, "dsc_%d", i);
> +
> pm_runtime_put_sync(&dpu_kms->pdev->dev);
> }
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] drm/msm/dpu: Add DSC hardware blocks to register snapshot
2023-01-25 10:14 ` Marijn Suijten
@ 2023-01-26 19:01 ` Dmitry Baryshkov
-1 siblings, 0 replies; 6+ messages in thread
From: Dmitry Baryshkov @ 2023-01-26 19:01 UTC (permalink / raw)
To: phone-devel, Marijn Suijten
Cc: ~postmarketos/upstreaming, AngeloGioacchino Del Regno,
Konrad Dybcio, Martin Botka, Jami Kettunen, Neil Armstrong,
Kuogee Hsieh, Rob Clark, Abhinav Kumar, Sean Paul, David Airlie,
Daniel Vetter, Stephen Boyd, Bjorn Andersson, Vinod Polimera,
Liu Shixin, linux-arm-msm, dri-devel, freedreno, linux-kernel
On Wed, 25 Jan 2023 11:14:11 +0100, Marijn Suijten wrote:
> Add missing DSC hardware block register ranges to the snapshot utility
> to include them in dmesg (on MSM_DISP_SNAPSHOT_DUMP_IN_CONSOLE) and the
> kms debugfs file.
>
>
Applied, thanks!
[1/1] drm/msm/dpu: Add DSC hardware blocks to register snapshot
https://gitlab.freedesktop.org/lumag/msm/-/commit/a7efe60e36b9
Best regards,
--
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] drm/msm/dpu: Add DSC hardware blocks to register snapshot
@ 2023-01-26 19:01 ` Dmitry Baryshkov
0 siblings, 0 replies; 6+ messages in thread
From: Dmitry Baryshkov @ 2023-01-26 19:01 UTC (permalink / raw)
To: phone-devel, Marijn Suijten
Cc: Neil Armstrong, Liu Shixin, linux-kernel, Jami Kettunen,
Bjorn Andersson, freedreno, Abhinav Kumar, dri-devel,
Kuogee Hsieh, Konrad Dybcio, Martin Botka,
~postmarketos/upstreaming, AngeloGioacchino Del Regno,
Stephen Boyd, Sean Paul, Vinod Polimera, linux-arm-msm
On Wed, 25 Jan 2023 11:14:11 +0100, Marijn Suijten wrote:
> Add missing DSC hardware block register ranges to the snapshot utility
> to include them in dmesg (on MSM_DISP_SNAPSHOT_DUMP_IN_CONSOLE) and the
> kms debugfs file.
>
>
Applied, thanks!
[1/1] drm/msm/dpu: Add DSC hardware blocks to register snapshot
https://gitlab.freedesktop.org/lumag/msm/-/commit/a7efe60e36b9
Best regards,
--
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-01-26 19:02 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-25 10:14 [PATCH v2] drm/msm/dpu: Add DSC hardware blocks to register snapshot Marijn Suijten
2023-01-25 10:14 ` Marijn Suijten
2023-01-25 19:05 ` Abhinav Kumar
2023-01-25 19:05 ` Abhinav Kumar
2023-01-26 19:01 ` Dmitry Baryshkov
2023-01-26 19:01 ` Dmitry Baryshkov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.