All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2 0/1] CMD commands improvements
@ 2023-01-26 19:35 Svyatoslav Ryhel
  2023-01-26 19:35 ` [PATCH v2 1/1] cmd: ums: abort mounting by pressing any key Svyatoslav Ryhel
  0 siblings, 1 reply; 2+ messages in thread
From: Svyatoslav Ryhel @ 2023-01-26 19:35 UTC (permalink / raw)
  To: Lukasz Majewski, Simon Glass, Ilias Apalodimas,
	Heinrich Schuchardt, Masahisa Kojima, Ashok Reddy Soma,
	John Keeping, Marek Vasut, Svyatoslav Ryhel, Jonas Schwöbel,
	Maxim Schwalm, Hector Palacios
  Cc: u-boot

- add ability for 'ums' command to interrupt run of usb
mass storage with any key. This is especially useful on
devices with limited input capabilities like tablets and
smatphones which have only gpio keys in direct access.
Current implementation uses Kconfig entry.

Changelog from V1
- 'continue' command commit was dropped as there already
exists 'pause' command with same function.
- UMS_ABORT_KEYED renamed to CMD_UMS_ABORT_KEYED

Svyatoslav Ryhel (1):
  cmd: ums: abort mounting by pressing any key

 cmd/Kconfig            | 6 ++++++
 cmd/usb_mass_storage.c | 9 +++++++++
 2 files changed, 15 insertions(+)

-- 
2.25.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* [PATCH v2 1/1] cmd: ums: abort mounting by pressing any key
  2023-01-26 19:35 [PATCH v2 0/1] CMD commands improvements Svyatoslav Ryhel
@ 2023-01-26 19:35 ` Svyatoslav Ryhel
  0 siblings, 0 replies; 2+ messages in thread
From: Svyatoslav Ryhel @ 2023-01-26 19:35 UTC (permalink / raw)
  To: Lukasz Majewski, Simon Glass, Ilias Apalodimas,
	Heinrich Schuchardt, Masahisa Kojima, Ashok Reddy Soma,
	John Keeping, Marek Vasut, Svyatoslav Ryhel, Jonas Schwöbel,
	Maxim Schwalm, Hector Palacios
  Cc: u-boot

This patch introduses config which allows interrupt run of usb
mass storage with any key. This is especially useful on devices
with limited input capabilities like tablets and smatphones which
have only gpio keys in direct access.

Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
---
 cmd/Kconfig            | 6 ++++++
 cmd/usb_mass_storage.c | 9 +++++++++
 2 files changed, 15 insertions(+)

diff --git a/cmd/Kconfig b/cmd/Kconfig
index 4fe2c75de2..47d882e62f 100644
--- a/cmd/Kconfig
+++ b/cmd/Kconfig
@@ -1536,6 +1536,12 @@ config CMD_USB_MASS_STORAGE
 	  export a block device: U-Boot, the USB device, acts as a simple
 	  external hard drive plugged on the host USB port.
 
+config CMD_UMS_ABORT_KEYED
+	bool "UMS abort with any key"
+	depends on CMD_USB_MASS_STORAGE
+	help
+	  Allow interruption of usb mass storage run with any key pressed.
+
 config CMD_PVBLOCK
 	bool "Xen para-virtualized block device"
 	depends on XEN
diff --git a/cmd/usb_mass_storage.c b/cmd/usb_mass_storage.c
index b7daaa6e8e..8a758b5884 100644
--- a/cmd/usb_mass_storage.c
+++ b/cmd/usb_mass_storage.c
@@ -231,6 +231,15 @@ static int do_usb_mass_storage(struct cmd_tbl *cmdtp, int flag,
 			goto cleanup_register;
 		}
 
+		if (IS_ENABLED(CONFIG_CMD_UMS_ABORT_KEYED)) {
+			/* Abort by pressing any key */
+			if (getchar()) {
+				printf("\rOperation aborted.\n");
+				rc = CMD_RET_SUCCESS;
+				goto cleanup_register;
+			}
+		}
+
 		schedule();
 	}
 
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-01-26 19:37 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-26 19:35 [PATCH v2 0/1] CMD commands improvements Svyatoslav Ryhel
2023-01-26 19:35 ` [PATCH v2 1/1] cmd: ums: abort mounting by pressing any key Svyatoslav Ryhel

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.