[PATCH 1/1] cmd: move CONFIG_SYS_MEMTEST_START/END to cmd/Kconfig

[PATCH 1/1] cmd: move CONFIG_SYS_MEMTEST_START/END to cmd/Kconfig

[Heinrich Schuchardt]

These symbols are not specific to Keymile boards.

Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
---
 board/keymile/km83xx/Kconfig | 6 ------
 cmd/Kconfig                  | 8 ++++++++
 2 files changed, 8 insertions(+), 6 deletions(-)

diff --git a/board/keymile/km83xx/Kconfig b/board/keymile/km83xx/Kconfig
index f87a2e6416..014dde37cf 100644
--- a/board/keymile/km83xx/Kconfig
+++ b/board/keymile/km83xx/Kconfig
@@ -14,12 +14,6 @@ config KM_ENABLE_FULL_DM_DTS_SUPPORT
 	select PHYLIB
 endmenu
 
-config SYS_MEMTEST_START
-	default 0x00100000
-
-config SYS_MEMTEST_END
-	default 0x00f00000
-
 if TARGET_KMETER1
 
 config SYS_BOARD
diff --git a/cmd/Kconfig b/cmd/Kconfig
index 4fe2c75de2..bffb19924d 100644
--- a/cmd/Kconfig
+++ b/cmd/Kconfig
@@ -837,6 +837,14 @@ config CMD_MEMTEST
 
 if CMD_MEMTEST
 
+config SYS_MEMTEST_START
+	default 0x00100000 if SYS_BOARD="km83xx"
+	default TEXT_BASE
+
+config SYS_MEMTEST_END
+	default 0x00f00000 if SYS_BOARD="km83xx"
+	default TEXT_BASE
+
 config SYS_ALT_MEMTEST
 	bool "Alternative test"
 	help
-- 
2.38.1

Re: [PATCH 1/1] cmd: move CONFIG_SYS_MEMTEST_START/END to cmd/Kconfig

[Heiko Schocher]

Hello Heinrich,

On 27.01.23 01:42, Heinrich Schuchardt wrote:
> These symbols are not specific to Keymile boards.
> 
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> ---
>  board/keymile/km83xx/Kconfig | 6 ------
>  cmd/Kconfig                  | 8 ++++++++
>  2 files changed, 8 insertions(+), 6 deletions(-)
> 
> diff --git a/board/keymile/km83xx/Kconfig b/board/keymile/km83xx/Kconfig
> index f87a2e6416..014dde37cf 100644
> --- a/board/keymile/km83xx/Kconfig
> +++ b/board/keymile/km83xx/Kconfig
> @@ -14,12 +14,6 @@ config KM_ENABLE_FULL_DM_DTS_SUPPORT
>  	select PHYLIB
>  endmenu
>  
> -config SYS_MEMTEST_START
> -	default 0x00100000
> -
> -config SYS_MEMTEST_END
> -	default 0x00f00000
> -
>  if TARGET_KMETER1
>  
>  config SYS_BOARD
> diff --git a/cmd/Kconfig b/cmd/Kconfig
> index 4fe2c75de2..bffb19924d 100644
> --- a/cmd/Kconfig
> +++ b/cmd/Kconfig
> @@ -837,6 +837,14 @@ config CMD_MEMTEST
>  
>  if CMD_MEMTEST
>  
> +config SYS_MEMTEST_START
> +	default 0x00100000 if SYS_BOARD="km83xx"
> +	default TEXT_BASE
> +
> +config SYS_MEMTEST_END
> +	default 0x00f00000 if SYS_BOARD="km83xx"
> +	default TEXT_BASE
> +
>  config SYS_ALT_MEMTEST
>  	bool "Alternative test"
>  	help

Hmm... for me with current HEAD:
*   b6904cc98a - (HEAD -> master, origin/master, origin/HEAD) Merge
https://source.denx.de/u-boot/custodians/u-boot-spi

This symbols are already in cmd/Kconfig file:

 857 config SYS_MEMTEST_START
 858         hex "default start address for mtest"
 859         default 0x0
 860         help
 861           This is the default start address for mtest for simple read/write
 862           test. If no arguments are given to mtest, default address is used
 863           as start address.
 864
 865 config SYS_MEMTEST_END
 866         hex "default end address for mtest"
 867         default 0x1000
 868         help
 869           This is the default end address for mtest for simple read/write
 870           test. If no arguments are given to mtest, default address is used
 871           as end address.

Please review, if with your patch they are not twice in cmd(Kconfig file,
thanks!

bye,
Heiko
-- 
DENX Software Engineering GmbH,      Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: hs@denx.de