All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] arm64: tegra: dts: add vccmq on p3310 TX2 SoM
@ 2023-01-27  9:39 Ben Dooks
  2023-04-05 13:09 ` Thierry Reding
  0 siblings, 1 reply; 2+ messages in thread
From: Ben Dooks @ 2023-01-27  9:39 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Arnd Bergmann, linux-tegra, devicetree
  Cc: Thierry Reding, Jonathan Hunter, Ben Dooks

The TX2 SoM's SDIO WiFI card is connected via mmc@3440000 however it does
not look like the upstream kernel is even bothering to power this (and
the regulator framework shuts down this power rail post kernel init).

The issue seems to be a missing link for vccq from the MAX77620 PMIC's LDO5
which is labeled vddio_sdmmc3 (and not used anywhere else) to the mmc@3440000
node to ensure there is at leasr bus power.

Note this does not fix the WiFi issue on upstream kernels, there is still
something else missing that gets the BCM WiFi device to detect properly.

Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
Note, probably a candidate for stable.
---
 arch/arm64/boot/dts/nvidia/tegra186-p3310.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/nvidia/tegra186-p3310.dtsi b/arch/arm64/boot/dts/nvidia/tegra186-p3310.dtsi
index aff857df25cf..3fd34d3d912a 100644
--- a/arch/arm64/boot/dts/nvidia/tegra186-p3310.dtsi
+++ b/arch/arm64/boot/dts/nvidia/tegra186-p3310.dtsi
@@ -145,6 +145,7 @@ mmc@3400000 {
 	/* SDMMC3 (SDIO) */
 	mmc@3440000 {
 		status = "okay";
+		vqmmc-supply = <&vddio_sdmmc3>;
 	};
 
 	/* SDMMC4 (eMMC) */
-- 
2.39.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] arm64: tegra: dts: add vccmq on p3310 TX2 SoM
  2023-01-27  9:39 [PATCH] arm64: tegra: dts: add vccmq on p3310 TX2 SoM Ben Dooks
@ 2023-04-05 13:09 ` Thierry Reding
  0 siblings, 0 replies; 2+ messages in thread
From: Thierry Reding @ 2023-04-05 13:09 UTC (permalink / raw)
  To: Rob Herring, devicetree, Ben Dooks, Krzysztof Kozlowski,
	Arnd Bergmann, linux-tegra
  Cc: Thierry Reding, Jonathan Hunter

From: Thierry Reding <treding@nvidia.com>

On Fri, 27 Jan 2023 09:39:10 +0000, Ben Dooks wrote:
> The TX2 SoM's SDIO WiFI card is connected via mmc@3440000 however it does
> not look like the upstream kernel is even bothering to power this (and
> the regulator framework shuts down this power rail post kernel init).
> 
> The issue seems to be a missing link for vccq from the MAX77620 PMIC's LDO5
> which is labeled vddio_sdmmc3 (and not used anywhere else) to the mmc@3440000
> node to ensure there is at leasr bus power.
> 
> [...]

Applied, thanks!

[1/1] arm64: tegra: dts: add vccmq on p3310 TX2 SoM
      (no commit info)

Best regards,
-- 
Thierry Reding <treding@nvidia.com>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-04-05 13:10 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-27  9:39 [PATCH] arm64: tegra: dts: add vccmq on p3310 TX2 SoM Ben Dooks
2023-04-05 13:09 ` Thierry Reding

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.