[PATCH] arm64: dts: qcom: Fix regulators node names

[PATCH] arm64: dts: qcom: Fix regulators node names

[Abel Vesa]

Bindings check fails as the schema expects the regulator node names to
have the suffix -regulators, so use the name and the id of the pmic to
compile the node name instead.

Fixes: 71342fb91eae ("arm64: dts: qcom: Add base SM8550 MTP dts")
Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
---
 arch/arm64/boot/dts/qcom/sm8550-mtp.dts | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sm8550-mtp.dts b/arch/arm64/boot/dts/qcom/sm8550-mtp.dts
index 725d3bc3ee72..ec17226e11b8 100644
--- a/arch/arm64/boot/dts/qcom/sm8550-mtp.dts
+++ b/arch/arm64/boot/dts/qcom/sm8550-mtp.dts
@@ -39,7 +39,7 @@ vph_pwr: vph-pwr-regulator {
 };
 
 &apps_rsc {
-	regulators-0 {
+	pm8550-b-rpmh-regulators {
 		compatible = "qcom,pm8550-rpmh-regulators";
 		qcom,pmic-id = "b";
 
@@ -168,7 +168,7 @@ vreg_l17b_2p5: ldo17 {
 		};
 	};
 
-	regulators-1 {
+	pm8550vs-c-rpmh-regulators {
 		compatible = "qcom,pm8550vs-rpmh-regulators";
 		qcom,pmic-id = "c";
 
@@ -182,7 +182,7 @@ vreg_l3c_0p91: ldo3 {
 		};
 	};
 
-	regulators-2 {
+	pm8550vs-d-rpmh-regulators {
 		compatible = "qcom,pm8550vs-rpmh-regulators";
 		qcom,pmic-id = "d";
 
@@ -196,7 +196,7 @@ vreg_l1d_0p88: ldo1 {
 		};
 	};
 
-	regulators-3 {
+	pm8550vs-e-rpmh-regulators {
 		compatible = "qcom,pm8550vs-rpmh-regulators";
 		qcom,pmic-id = "e";
 
@@ -242,7 +242,7 @@ vreg_l3e_1p2: ldo3 {
 		};
 	};
 
-	regulators-4 {
+	pm8550vs-f-rpmh-regulators {
 		compatible = "qcom,pm8550ve-rpmh-regulators";
 		qcom,pmic-id = "f";
 
@@ -280,7 +280,7 @@ vreg_l3f_0p91: ldo3 {
 		};
 	};
 
-	regulators-5 {
+	pm8550vs-g-rpmh-regulators {
 		compatible = "qcom,pm8550vs-rpmh-regulators";
 		qcom,pmic-id = "g";
 
-- 
2.34.1

Re: [PATCH] arm64: dts: qcom: Fix regulators node names

[Krzysztof Kozlowski]

On 27/01/2023 14:01, Abel Vesa wrote:
> Bindings check fails as the schema expects the regulator node names to
> have the suffix -regulators, so use the name and the id of the pmic to
> compile the node name instead.
> 
> Fixes: 71342fb91eae ("arm64: dts: qcom: Add base SM8550 MTP dts")
> Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
> ---

No, the original code is what we requested.

You are making it now incorrect (although bindings need to catch up).

See:
https://lore.kernel.org/linux-arm-msm/9e805614-8d21-4f8b-1b31-790686c95aa5@linaro.org/T/#t

Best regards,
Krzysztof

Re: [PATCH] arm64: dts: qcom: Fix regulators node names

[Abel Vesa]

On 23-01-27 16:33:31, Krzysztof Kozlowski wrote:
> On 27/01/2023 14:01, Abel Vesa wrote:
> > Bindings check fails as the schema expects the regulator node names to
> > have the suffix -regulators, so use the name and the id of the pmic to
> > compile the node name instead.
> > 
> > Fixes: 71342fb91eae ("arm64: dts: qcom: Add base SM8550 MTP dts")
> > Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
> > ---
> 
> No, the original code is what we requested.
> 
> You are making it now incorrect (although bindings need to catch up).
> 
> See:
> https://lore.kernel.org/linux-arm-msm/9e805614-8d21-4f8b-1b31-790686c95aa5@linaro.org/T/#t

OK, fair point. Ignore this patch then.

> 
> Best regards,
> Krzysztof
>