* [PATCH] greybus: remove unused header variable in gb_operation_message_alloc()
@ 2023-01-28 15:57 Tom Rix
2023-01-28 17:47 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Tom Rix @ 2023-01-28 15:57 UTC (permalink / raw)
To: johan, elder, gregkh; +Cc: greybus-dev, linux-kernel, Tom Rix
cppcheck reports
drivers/greybus/operation.c:365:31: style: Variable 'header' is not assigned a value. [unassignedVariable]
struct gb_operation_msg_hdr *header;
^
header is only used to calculate the size of the messge. This can be done without a variable
but rather with calling sizeof() with the struct type.
Fixes: dc779229b538 ("greybus: introduce gb_operation_message_init()")
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/greybus/operation.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/greybus/operation.c b/drivers/greybus/operation.c
index 8459e9bc0749..9d322fc6531b 100644
--- a/drivers/greybus/operation.c
+++ b/drivers/greybus/operation.c
@@ -362,8 +362,7 @@ gb_operation_message_alloc(struct gb_host_device *hd, u8 type,
size_t payload_size, gfp_t gfp_flags)
{
struct gb_message *message;
- struct gb_operation_msg_hdr *header;
- size_t message_size = payload_size + sizeof(*header);
+ size_t message_size = payload_size + sizeof(struct gb_operation_msg_hdr);
if (message_size > hd->buffer_size_max) {
dev_warn(&hd->dev, "requested message size too big (%zu > %zu)\n",
--
2.26.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] greybus: remove unused header variable in gb_operation_message_alloc()
2023-01-28 15:57 [PATCH] greybus: remove unused header variable in gb_operation_message_alloc() Tom Rix
@ 2023-01-28 17:47 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2023-01-28 17:47 UTC (permalink / raw)
To: Tom Rix; +Cc: johan, elder, greybus-dev, linux-kernel
On Sat, Jan 28, 2023 at 07:57:06AM -0800, Tom Rix wrote:
> cppcheck reports
> drivers/greybus/operation.c:365:31: style: Variable 'header' is not assigned a value. [unassignedVariable]
> struct gb_operation_msg_hdr *header;
> ^
That's not a real problem.
> header is only used to calculate the size of the messge. This can be done without a variable
> but rather with calling sizeof() with the struct type.
>
> Fixes: dc779229b538 ("greybus: introduce gb_operation_message_init()")
This is not a bug that is being fixed.
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
> drivers/greybus/operation.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/greybus/operation.c b/drivers/greybus/operation.c
> index 8459e9bc0749..9d322fc6531b 100644
> --- a/drivers/greybus/operation.c
> +++ b/drivers/greybus/operation.c
> @@ -362,8 +362,7 @@ gb_operation_message_alloc(struct gb_host_device *hd, u8 type,
> size_t payload_size, gfp_t gfp_flags)
> {
> struct gb_message *message;
> - struct gb_operation_msg_hdr *header;
> - size_t message_size = payload_size + sizeof(*header);
> + size_t message_size = payload_size + sizeof(struct gb_operation_msg_hdr);
The compiler does not use any extra room for header, so this should be
fine, it's not a real issue.
cppcheck almost never finds anything real, be careful...
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-01-28 17:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-28 15:57 [PATCH] greybus: remove unused header variable in gb_operation_message_alloc() Tom Rix
2023-01-28 17:47 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.