All of lore.kernel.org
 help / color / mirror / Atom feed
* [RESEND PATCH v2] arm: dts: imx8mn-u-boot: fix DDR3 only support
@ 2023-01-28 16:04 Dario Binacchi
  2023-01-28 17:51 ` Fabio Estevam
  2023-01-30 22:09 ` sbabic
  0 siblings, 2 replies; 3+ messages in thread
From: Dario Binacchi @ 2023-01-28 16:04 UTC (permalink / raw)
  To: u-boot
  Cc: Dario Binacchi, Michael Trimarchi, Adam Ford, Fabio Estevam,
	NXP i.MX U-Boot Team, Stefano Babic, Tom Rini, linux-amarula

In case the CONFIG_IMX8M_LPDDR4 and CONFIG_IMX8M_DDR4 options are both
disabled (i. e. BSH boards), binmain fails because DDR4 bin files are
missing.

Fixes: 93c4c0e4dd1e75 ("arm: dts: imx8mn-u-boot: Create common imx8mn-u-boot.dtsi")
Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
Reviewed-by: Michael Trimarchi <michael@amarulasolutions.com>

---

Changes in v2:
- Fix typos in the commit message (DD3 --> DDR3, DD4 --> DDR4)

 arch/arm/dts/imx8mn-u-boot.dtsi | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/arch/arm/dts/imx8mn-u-boot.dtsi b/arch/arm/dts/imx8mn-u-boot.dtsi
index 95f45ad2522d..ec53390afb30 100644
--- a/arch/arm/dts/imx8mn-u-boot.dtsi
+++ b/arch/arm/dts/imx8mn-u-boot.dtsi
@@ -105,10 +105,11 @@
 			align-end = <4>;
 		};
 
+#if defined(CONFIG_IMX8M_LPDDR4) || defined(CONFIG_IMX8M_DDR4)
 		ddr-2d-imem-fw {
 #ifdef CONFIG_IMX8M_LPDDR4
 			filename = "lpddr4_pmu_train_2d_imem.bin";
-#elif CONFIG_IMX8M_DDR4
+#else
 			filename = "ddr4_imem_2d.bin";
 #endif
 			type = "blob-ext";
@@ -118,12 +119,13 @@
 		ddr-2d-dmem-fw {
 #ifdef CONFIG_IMX8M_LPDDR4
 			filename = "lpddr4_pmu_train_2d_dmem.bin";
-#elif CONFIG_IMX8M_DDR4
+#else
 			filename = "ddr4_dmem_2d.bin";
 #endif
 			type = "blob-ext";
 			align-end = <4>;
 		};
+#endif
 	};
 
 	spl {
-- 
2.32.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [RESEND PATCH v2] arm: dts: imx8mn-u-boot: fix DDR3 only support
  2023-01-28 16:04 [RESEND PATCH v2] arm: dts: imx8mn-u-boot: fix DDR3 only support Dario Binacchi
@ 2023-01-28 17:51 ` Fabio Estevam
  2023-01-30 22:09 ` sbabic
  1 sibling, 0 replies; 3+ messages in thread
From: Fabio Estevam @ 2023-01-28 17:51 UTC (permalink / raw)
  To: Dario Binacchi
  Cc: u-boot, Michael Trimarchi, Adam Ford, NXP i.MX U-Boot Team,
	Stefano Babic, Tom Rini, linux-amarula

On Sat, Jan 28, 2023 at 1:04 PM Dario Binacchi
<dario.binacchi@amarulasolutions.com> wrote:
>
> In case the CONFIG_IMX8M_LPDDR4 and CONFIG_IMX8M_DDR4 options are both
> disabled (i. e. BSH boards), binmain fails because DDR4 bin files are
> missing.
>
> Fixes: 93c4c0e4dd1e75 ("arm: dts: imx8mn-u-boot: Create common imx8mn-u-boot.dtsi")
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> Reviewed-by: Michael Trimarchi <michael@amarulasolutions.com>

Reviewed-by: Fabio Estevam <festevam@denx.de>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [RESEND PATCH v2] arm: dts: imx8mn-u-boot: fix DDR3 only support
  2023-01-28 16:04 [RESEND PATCH v2] arm: dts: imx8mn-u-boot: fix DDR3 only support Dario Binacchi
  2023-01-28 17:51 ` Fabio Estevam
@ 2023-01-30 22:09 ` sbabic
  1 sibling, 0 replies; 3+ messages in thread
From: sbabic @ 2023-01-30 22:09 UTC (permalink / raw)
  To: Dario Binacchi, u-boot

> In case the CONFIG_IMX8M_LPDDR4 and CONFIG_IMX8M_DDR4 options are both
> disabled (i. e. BSH boards), binmain fails because DDR4 bin files are
> missing.
> Fixes: 93c4c0e4dd1e75 ("arm: dts: imx8mn-u-boot: Create common imx8mn-u-boot.dtsi")
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> Reviewed-by: Michael Trimarchi <michael@amarulasolutions.com>
> Reviewed-by: Fabio Estevam <festevam@denx.de>
Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de
=====================================================================

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-01-30 22:11 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-28 16:04 [RESEND PATCH v2] arm: dts: imx8mn-u-boot: fix DDR3 only support Dario Binacchi
2023-01-28 17:51 ` Fabio Estevam
2023-01-30 22:09 ` sbabic

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.