All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/1] usb: chipidea: ci_hdrc_imx: use dev_err_probe
@ 2023-01-30  9:41 ` Alexander Stein
  0 siblings, 0 replies; 4+ messages in thread
From: Alexander Stein @ 2023-01-30  9:41 UTC (permalink / raw)
  To: Peter Chen, Greg Kroah-Hartman, Shawn Guo, Sascha Hauer, Fabio Estevam
  Cc: Alexander Stein, Pengutronix Kernel Team, linux-usb, linux-arm-kernel

Add error message if finding USB PHY fails or is deferred.

Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
 drivers/usb/chipidea/ci_hdrc_imx.c | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/drivers/usb/chipidea/ci_hdrc_imx.c b/drivers/usb/chipidea/ci_hdrc_imx.c
index 0dc482542d85..2eeccf4ec9d6 100644
--- a/drivers/usb/chipidea/ci_hdrc_imx.c
+++ b/drivers/usb/chipidea/ci_hdrc_imx.c
@@ -413,15 +413,19 @@ static int ci_hdrc_imx_probe(struct platform_device *pdev)
 	data->phy = devm_usb_get_phy_by_phandle(dev, "fsl,usbphy", 0);
 	if (IS_ERR(data->phy)) {
 		ret = PTR_ERR(data->phy);
-		if (ret != -ENODEV)
+		if (ret != -ENODEV) {
+			dev_err_probe(dev, ret, "Failed to parse fsl,usbphy\n");
 			goto err_clk;
+		}
 		data->phy = devm_usb_get_phy_by_phandle(dev, "phys", 0);
 		if (IS_ERR(data->phy)) {
 			ret = PTR_ERR(data->phy);
-			if (ret == -ENODEV)
+			if (ret == -ENODEV) {
 				data->phy = NULL;
-			else
+			} else {
+				dev_err_probe(dev, ret, "Failed to parse phys\n");
 				goto err_clk;
+			}
 		}
 	}
 
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [PATCH 1/1] usb: chipidea: ci_hdrc_imx: use dev_err_probe
@ 2023-01-30  9:41 ` Alexander Stein
  0 siblings, 0 replies; 4+ messages in thread
From: Alexander Stein @ 2023-01-30  9:41 UTC (permalink / raw)
  To: Peter Chen, Greg Kroah-Hartman, Shawn Guo, Sascha Hauer, Fabio Estevam
  Cc: Alexander Stein, Pengutronix Kernel Team, linux-usb, linux-arm-kernel

Add error message if finding USB PHY fails or is deferred.

Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
 drivers/usb/chipidea/ci_hdrc_imx.c | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/drivers/usb/chipidea/ci_hdrc_imx.c b/drivers/usb/chipidea/ci_hdrc_imx.c
index 0dc482542d85..2eeccf4ec9d6 100644
--- a/drivers/usb/chipidea/ci_hdrc_imx.c
+++ b/drivers/usb/chipidea/ci_hdrc_imx.c
@@ -413,15 +413,19 @@ static int ci_hdrc_imx_probe(struct platform_device *pdev)
 	data->phy = devm_usb_get_phy_by_phandle(dev, "fsl,usbphy", 0);
 	if (IS_ERR(data->phy)) {
 		ret = PTR_ERR(data->phy);
-		if (ret != -ENODEV)
+		if (ret != -ENODEV) {
+			dev_err_probe(dev, ret, "Failed to parse fsl,usbphy\n");
 			goto err_clk;
+		}
 		data->phy = devm_usb_get_phy_by_phandle(dev, "phys", 0);
 		if (IS_ERR(data->phy)) {
 			ret = PTR_ERR(data->phy);
-			if (ret == -ENODEV)
+			if (ret == -ENODEV) {
 				data->phy = NULL;
-			else
+			} else {
+				dev_err_probe(dev, ret, "Failed to parse phys\n");
 				goto err_clk;
+			}
 		}
 	}
 
-- 
2.34.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] usb: chipidea: ci_hdrc_imx: use dev_err_probe
  2023-01-30  9:41 ` Alexander Stein
@ 2023-02-10  8:51   ` Peter Chen
  -1 siblings, 0 replies; 4+ messages in thread
From: Peter Chen @ 2023-02-10  8:51 UTC (permalink / raw)
  To: Alexander Stein
  Cc: Greg Kroah-Hartman, Shawn Guo, Sascha Hauer, Fabio Estevam,
	Pengutronix Kernel Team, linux-usb, linux-arm-kernel

On 23-01-30 10:41:51, Alexander Stein wrote:
> Add error message if finding USB PHY fails or is deferred.
> 
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>

Acked-by: Peter Chen <peter.chen@kernel.org>

Peter
> ---
>  drivers/usb/chipidea/ci_hdrc_imx.c | 10 +++++++---
>  1 file changed, 7 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/usb/chipidea/ci_hdrc_imx.c b/drivers/usb/chipidea/ci_hdrc_imx.c
> index 0dc482542d85..2eeccf4ec9d6 100644
> --- a/drivers/usb/chipidea/ci_hdrc_imx.c
> +++ b/drivers/usb/chipidea/ci_hdrc_imx.c
> @@ -413,15 +413,19 @@ static int ci_hdrc_imx_probe(struct platform_device *pdev)
>  	data->phy = devm_usb_get_phy_by_phandle(dev, "fsl,usbphy", 0);
>  	if (IS_ERR(data->phy)) {
>  		ret = PTR_ERR(data->phy);
> -		if (ret != -ENODEV)
> +		if (ret != -ENODEV) {
> +			dev_err_probe(dev, ret, "Failed to parse fsl,usbphy\n");
>  			goto err_clk;
> +		}
>  		data->phy = devm_usb_get_phy_by_phandle(dev, "phys", 0);
>  		if (IS_ERR(data->phy)) {
>  			ret = PTR_ERR(data->phy);
> -			if (ret == -ENODEV)
> +			if (ret == -ENODEV) {
>  				data->phy = NULL;
> -			else
> +			} else {
> +				dev_err_probe(dev, ret, "Failed to parse phys\n");
>  				goto err_clk;
> +			}
>  		}
>  	}
>  
> -- 
> 2.34.1
> 

-- 

Thanks,
Peter Chen

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] usb: chipidea: ci_hdrc_imx: use dev_err_probe
@ 2023-02-10  8:51   ` Peter Chen
  0 siblings, 0 replies; 4+ messages in thread
From: Peter Chen @ 2023-02-10  8:51 UTC (permalink / raw)
  To: Alexander Stein
  Cc: Greg Kroah-Hartman, Shawn Guo, Sascha Hauer, Fabio Estevam,
	Pengutronix Kernel Team, linux-usb, linux-arm-kernel

On 23-01-30 10:41:51, Alexander Stein wrote:
> Add error message if finding USB PHY fails or is deferred.
> 
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>

Acked-by: Peter Chen <peter.chen@kernel.org>

Peter
> ---
>  drivers/usb/chipidea/ci_hdrc_imx.c | 10 +++++++---
>  1 file changed, 7 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/usb/chipidea/ci_hdrc_imx.c b/drivers/usb/chipidea/ci_hdrc_imx.c
> index 0dc482542d85..2eeccf4ec9d6 100644
> --- a/drivers/usb/chipidea/ci_hdrc_imx.c
> +++ b/drivers/usb/chipidea/ci_hdrc_imx.c
> @@ -413,15 +413,19 @@ static int ci_hdrc_imx_probe(struct platform_device *pdev)
>  	data->phy = devm_usb_get_phy_by_phandle(dev, "fsl,usbphy", 0);
>  	if (IS_ERR(data->phy)) {
>  		ret = PTR_ERR(data->phy);
> -		if (ret != -ENODEV)
> +		if (ret != -ENODEV) {
> +			dev_err_probe(dev, ret, "Failed to parse fsl,usbphy\n");
>  			goto err_clk;
> +		}
>  		data->phy = devm_usb_get_phy_by_phandle(dev, "phys", 0);
>  		if (IS_ERR(data->phy)) {
>  			ret = PTR_ERR(data->phy);
> -			if (ret == -ENODEV)
> +			if (ret == -ENODEV) {
>  				data->phy = NULL;
> -			else
> +			} else {
> +				dev_err_probe(dev, ret, "Failed to parse phys\n");
>  				goto err_clk;
> +			}
>  		}
>  	}
>  
> -- 
> 2.34.1
> 

-- 

Thanks,
Peter Chen

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-02-10  8:52 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-30  9:41 [PATCH 1/1] usb: chipidea: ci_hdrc_imx: use dev_err_probe Alexander Stein
2023-01-30  9:41 ` Alexander Stein
2023-02-10  8:51 ` Peter Chen
2023-02-10  8:51   ` Peter Chen

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.