* [PATCH v8 0/3] pmic on imx8mm
@ 2023-01-30 2:56 ` Johannes Schneider
0 siblings, 0 replies; 10+ messages in thread
From: Johannes Schneider @ 2023-01-30 2:56 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Shawn Guo, Sascha Hauer,
Fabio Estevam, Li Yang, Shengjiu Wang, Richard Zhu
Cc: Pengutronix Kernel Team, NXP Linux Team, devicetree,
linux-arm-kernel, Johannes Schneider
current(?) imx8mm EVKs come with a different PMIC: used to be
"rohm,bd71847", which is now replaced by "nxp,pca9450a" on the LPDDR4
variant at least the register settings etc where "backported" from
current u-boot sources for the EVK
Note: not sure if the changes should go in the ddr4-evk.dts or elsewhere;
what about backwards compatibility? = users/holders of the EVKs with the bd71847 IC?
changes with V10:
- keep rhom-pic node untouched, for the "old" evks, and
delete+replace the node in the newer evks = EVKB
- migrate voltage levels set for the rhom to the nxp pmic
changes with V9:
drop 'rev b' references
changes with V8:
rewording of commit messages, to reference "EVKB" instead of "rev-b"
changes with V7:
add missing "acked-by" tag
(finally) add missing makefile entry for imx8mm-evbk.dtb
changes with V6:
move A53 cpu-supply nodes back into imx8mm-evk.dtsi
rewording of commit messages
fix syntax error during compile
changes with V5:
split of bindings into separate commit
rewording of commit messages
changes with V4:
deduplicate rohm-pmic into one dtsi
changes with V3:
split changes into multiple commits
removed unused header
changes with V2:
reshuffle common nodes into the imx8mm-evk.dtsi, and only keeping the pmic related parts separate
Johannes Schneider (1):
arm64: dts: imx8mm: set PCA9450a as PMIC
.../boot/dts/freescale/imx8mm-ddr4-evk.dts | 124 ++++++++++++++++++
1 file changed, 124 insertions(+)
--
2.25.1
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v8 0/3] pmic on imx8mm
@ 2023-01-30 2:56 ` Johannes Schneider
0 siblings, 0 replies; 10+ messages in thread
From: Johannes Schneider @ 2023-01-30 2:56 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Shawn Guo, Sascha Hauer,
Fabio Estevam, Li Yang, Shengjiu Wang, Richard Zhu
Cc: Pengutronix Kernel Team, NXP Linux Team, devicetree,
linux-arm-kernel, Johannes Schneider
current(?) imx8mm EVKs come with a different PMIC: used to be
"rohm,bd71847", which is now replaced by "nxp,pca9450a" on the LPDDR4
variant at least the register settings etc where "backported" from
current u-boot sources for the EVK
Note: not sure if the changes should go in the ddr4-evk.dts or elsewhere;
what about backwards compatibility? = users/holders of the EVKs with the bd71847 IC?
changes with V10:
- keep rhom-pic node untouched, for the "old" evks, and
delete+replace the node in the newer evks = EVKB
- migrate voltage levels set for the rhom to the nxp pmic
changes with V9:
drop 'rev b' references
changes with V8:
rewording of commit messages, to reference "EVKB" instead of "rev-b"
changes with V7:
add missing "acked-by" tag
(finally) add missing makefile entry for imx8mm-evbk.dtb
changes with V6:
move A53 cpu-supply nodes back into imx8mm-evk.dtsi
rewording of commit messages
fix syntax error during compile
changes with V5:
split of bindings into separate commit
rewording of commit messages
changes with V4:
deduplicate rohm-pmic into one dtsi
changes with V3:
split changes into multiple commits
removed unused header
changes with V2:
reshuffle common nodes into the imx8mm-evk.dtsi, and only keeping the pmic related parts separate
Johannes Schneider (1):
arm64: dts: imx8mm: set PCA9450a as PMIC
.../boot/dts/freescale/imx8mm-ddr4-evk.dts | 124 ++++++++++++++++++
1 file changed, 124 insertions(+)
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v10 1/2] arm64: dts: imx8mm-evkb: add support for i.MX8MM-EVKB
2023-01-30 2:56 ` Johannes Schneider
@ 2023-01-30 2:56 ` Johannes Schneider
-1 siblings, 0 replies; 10+ messages in thread
From: Johannes Schneider @ 2023-01-30 2:56 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Shawn Guo, Sascha Hauer,
Fabio Estevam, Li Yang, Shengjiu Wang, Richard Zhu
Cc: Pengutronix Kernel Team, NXP Linux Team, devicetree,
linux-arm-kernel, Johannes Schneider
Add devicetree for the EVKB, which comes with LPDDR4 and a different
PMIC.
Signed-off-by: Johannes Schneider <johannes.schneider@leica-geosystems.com>
---
arch/arm64/boot/dts/freescale/Makefile | 1 +
arch/arm64/boot/dts/freescale/imx8mm-evkb.dts | 128 ++++++++++++++++++
2 files changed, 129 insertions(+)
create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-evkb.dts
diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile
index 3ea9edc87909..3bccc4d10928 100644
--- a/arch/arm64/boot/dts/freescale/Makefile
+++ b/arch/arm64/boot/dts/freescale/Makefile
@@ -55,6 +55,7 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mm-data-modul-edm-sbc.dtb
dtb-$(CONFIG_ARCH_MXC) += imx8mm-ddr4-evk.dtb
dtb-$(CONFIG_ARCH_MXC) += imx8mm-emcon-avari.dtb
dtb-$(CONFIG_ARCH_MXC) += imx8mm-evk.dtb
+dtb-$(CONFIG_ARCH_MXC) += imx8mm-evkb.dtb
dtb-$(CONFIG_ARCH_MXC) += imx8mm-icore-mx8mm-ctouch2.dtb
dtb-$(CONFIG_ARCH_MXC) += imx8mm-icore-mx8mm-edimm2.2.dtb
dtb-$(CONFIG_ARCH_MXC) += imx8mm-kontron-bl.dtb
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evkb.dts b/arch/arm64/boot/dts/freescale/imx8mm-evkb.dts
new file mode 100644
index 000000000000..9ada2512d9a0
--- /dev/null
+++ b/arch/arm64/boot/dts/freescale/imx8mm-evkb.dts
@@ -0,0 +1,128 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Copyright 2019-2020 NXP
+ */
+
+/dts-v1/;
+
+#include "imx8mm-evk.dtsi"
+
+/ {
+ model = "FSL i.MX8MM EVKB"; // with LPDDR4 and PCA9450 PMIC
+ compatible = "fsl,imx8mm-evkb", "fsl,imx8mm";
+};
+
+&i2c1 {
+ /*
+ replace "rohm,bd71847" pmic found on previous evks
+ with "nxp,pca9450a"
+ */
+ /delete-node/ pmic@4b
+
+ pmic: pmic@25 {
+ compatible = "nxp,pca9450a";
+ reg = <0x25>;
+ pinctrl-0 = <&pinctrl_pmic>;
+ pinctrl-names = "default";
+ interrupt-parent = <&gpio1>;
+ interrupts = <3 IRQ_TYPE_LEVEL_LOW>;
+
+ regulators {
+ buck1_reg: BUCK1 {
+ regulator-name = "BUCK1";
+ regulator-min-microvolt = <700000>;
+ regulator-max-microvolt = <1300000>;
+ regulator-boot-on;
+ regulator-always-on;
+ regulator-ramp-delay = <1250>;
+ };
+
+ buck2_reg: BUCK2 {
+ regulator-name = "BUCK2";
+ regulator-min-microvolt = <700000>;
+ regulator-max-microvolt = <1300000>;
+ regulator-boot-on;
+ regulator-always-on;
+ regulator-ramp-delay = <1250>;
+ rohm,dvs-run-voltage = <1000000>;
+ rohm,dvs-idle-voltage = <900000>;
+ };
+
+ buck3_reg: BUCK3 {
+ regulator-name = "BUCK3";
+ // BUCK5 in datasheet
+ regulator-min-microvolt = <700000>;
+ regulator-max-microvolt = <1350000>;
+ regulator-boot-on;
+ regulator-always-on;
+ };
+
+ buck4_reg: BUCK4 {
+ regulator-name = "BUCK4";
+ // BUCK6 in datasheet
+ regulator-min-microvolt = <3000000>;
+ regulator-max-microvolt = <3300000>;
+ regulator-boot-on;
+ regulator-always-on;
+ };
+
+ buck5_reg: BUCK5 {
+ regulator-name = "BUCK5";
+ // BUCK7 in datasheet
+ regulator-min-microvolt = <1605000>;
+ regulator-max-microvolt = <1995000>;
+ regulator-boot-on;
+ regulator-always-on;
+ };
+
+ buck6_reg: BUCK6 {
+ regulator-name = "BUCK6";
+ // BUCK8 in datasheet
+ regulator-min-microvolt = <800000>;
+ regulator-max-microvolt = <1400000>;
+ regulator-boot-on;
+ regulator-always-on;
+ };
+
+ ldo1_reg: LDO1 {
+ regulator-name = "LDO1";
+ regulator-min-microvolt = <1600000>;
+ regulator-max-microvolt = <3300000>;
+ regulator-boot-on;
+ regulator-always-on;
+ };
+
+ ldo2_reg: LDO2 {
+ regulator-name = "LDO2";
+ regulator-min-microvolt = <800000>;
+ regulator-max-microvolt = <900000>;
+ regulator-boot-on;
+ regulator-always-on;
+ };
+
+ ldo3_reg: LDO3 {
+ regulator-name = "LDO3";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <3300000>;
+ regulator-boot-on;
+ regulator-always-on;
+ };
+
+ ldo4_reg: LDO4 {
+ regulator-name = "LDO4";
+ regulator-min-microvolt = <900000>;
+ regulator-max-microvolt = <1800000>;
+ regulator-boot-on;
+ regulator-always-on;
+ };
+
+ ldo5_reg: LDO5 {
+ regulator-name = "LDO5";
+ regulator-min-microvolt = <900000>;
+ regulator-max-microvolt = <1800000>;
+ regulator-boot-on;
+ regulator-always-on;
+ };
+ };
+ };
+};
--
2.25.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH v10 1/2] arm64: dts: imx8mm-evkb: add support for i.MX8MM-EVKB
@ 2023-01-30 2:56 ` Johannes Schneider
0 siblings, 0 replies; 10+ messages in thread
From: Johannes Schneider @ 2023-01-30 2:56 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Shawn Guo, Sascha Hauer,
Fabio Estevam, Li Yang, Shengjiu Wang, Richard Zhu
Cc: Pengutronix Kernel Team, NXP Linux Team, devicetree,
linux-arm-kernel, Johannes Schneider
Add devicetree for the EVKB, which comes with LPDDR4 and a different
PMIC.
Signed-off-by: Johannes Schneider <johannes.schneider@leica-geosystems.com>
---
arch/arm64/boot/dts/freescale/Makefile | 1 +
arch/arm64/boot/dts/freescale/imx8mm-evkb.dts | 128 ++++++++++++++++++
2 files changed, 129 insertions(+)
create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-evkb.dts
diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile
index 3ea9edc87909..3bccc4d10928 100644
--- a/arch/arm64/boot/dts/freescale/Makefile
+++ b/arch/arm64/boot/dts/freescale/Makefile
@@ -55,6 +55,7 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mm-data-modul-edm-sbc.dtb
dtb-$(CONFIG_ARCH_MXC) += imx8mm-ddr4-evk.dtb
dtb-$(CONFIG_ARCH_MXC) += imx8mm-emcon-avari.dtb
dtb-$(CONFIG_ARCH_MXC) += imx8mm-evk.dtb
+dtb-$(CONFIG_ARCH_MXC) += imx8mm-evkb.dtb
dtb-$(CONFIG_ARCH_MXC) += imx8mm-icore-mx8mm-ctouch2.dtb
dtb-$(CONFIG_ARCH_MXC) += imx8mm-icore-mx8mm-edimm2.2.dtb
dtb-$(CONFIG_ARCH_MXC) += imx8mm-kontron-bl.dtb
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evkb.dts b/arch/arm64/boot/dts/freescale/imx8mm-evkb.dts
new file mode 100644
index 000000000000..9ada2512d9a0
--- /dev/null
+++ b/arch/arm64/boot/dts/freescale/imx8mm-evkb.dts
@@ -0,0 +1,128 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Copyright 2019-2020 NXP
+ */
+
+/dts-v1/;
+
+#include "imx8mm-evk.dtsi"
+
+/ {
+ model = "FSL i.MX8MM EVKB"; // with LPDDR4 and PCA9450 PMIC
+ compatible = "fsl,imx8mm-evkb", "fsl,imx8mm";
+};
+
+&i2c1 {
+ /*
+ replace "rohm,bd71847" pmic found on previous evks
+ with "nxp,pca9450a"
+ */
+ /delete-node/ pmic@4b
+
+ pmic: pmic@25 {
+ compatible = "nxp,pca9450a";
+ reg = <0x25>;
+ pinctrl-0 = <&pinctrl_pmic>;
+ pinctrl-names = "default";
+ interrupt-parent = <&gpio1>;
+ interrupts = <3 IRQ_TYPE_LEVEL_LOW>;
+
+ regulators {
+ buck1_reg: BUCK1 {
+ regulator-name = "BUCK1";
+ regulator-min-microvolt = <700000>;
+ regulator-max-microvolt = <1300000>;
+ regulator-boot-on;
+ regulator-always-on;
+ regulator-ramp-delay = <1250>;
+ };
+
+ buck2_reg: BUCK2 {
+ regulator-name = "BUCK2";
+ regulator-min-microvolt = <700000>;
+ regulator-max-microvolt = <1300000>;
+ regulator-boot-on;
+ regulator-always-on;
+ regulator-ramp-delay = <1250>;
+ rohm,dvs-run-voltage = <1000000>;
+ rohm,dvs-idle-voltage = <900000>;
+ };
+
+ buck3_reg: BUCK3 {
+ regulator-name = "BUCK3";
+ // BUCK5 in datasheet
+ regulator-min-microvolt = <700000>;
+ regulator-max-microvolt = <1350000>;
+ regulator-boot-on;
+ regulator-always-on;
+ };
+
+ buck4_reg: BUCK4 {
+ regulator-name = "BUCK4";
+ // BUCK6 in datasheet
+ regulator-min-microvolt = <3000000>;
+ regulator-max-microvolt = <3300000>;
+ regulator-boot-on;
+ regulator-always-on;
+ };
+
+ buck5_reg: BUCK5 {
+ regulator-name = "BUCK5";
+ // BUCK7 in datasheet
+ regulator-min-microvolt = <1605000>;
+ regulator-max-microvolt = <1995000>;
+ regulator-boot-on;
+ regulator-always-on;
+ };
+
+ buck6_reg: BUCK6 {
+ regulator-name = "BUCK6";
+ // BUCK8 in datasheet
+ regulator-min-microvolt = <800000>;
+ regulator-max-microvolt = <1400000>;
+ regulator-boot-on;
+ regulator-always-on;
+ };
+
+ ldo1_reg: LDO1 {
+ regulator-name = "LDO1";
+ regulator-min-microvolt = <1600000>;
+ regulator-max-microvolt = <3300000>;
+ regulator-boot-on;
+ regulator-always-on;
+ };
+
+ ldo2_reg: LDO2 {
+ regulator-name = "LDO2";
+ regulator-min-microvolt = <800000>;
+ regulator-max-microvolt = <900000>;
+ regulator-boot-on;
+ regulator-always-on;
+ };
+
+ ldo3_reg: LDO3 {
+ regulator-name = "LDO3";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <3300000>;
+ regulator-boot-on;
+ regulator-always-on;
+ };
+
+ ldo4_reg: LDO4 {
+ regulator-name = "LDO4";
+ regulator-min-microvolt = <900000>;
+ regulator-max-microvolt = <1800000>;
+ regulator-boot-on;
+ regulator-always-on;
+ };
+
+ ldo5_reg: LDO5 {
+ regulator-name = "LDO5";
+ regulator-min-microvolt = <900000>;
+ regulator-max-microvolt = <1800000>;
+ regulator-boot-on;
+ regulator-always-on;
+ };
+ };
+ };
+};
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH v10 2/2] dt-bindings: arm: fsl: Add i.MX8MM-EVKB
2023-01-30 2:56 ` Johannes Schneider
@ 2023-01-30 2:56 ` Johannes Schneider
-1 siblings, 0 replies; 10+ messages in thread
From: Johannes Schneider @ 2023-01-30 2:56 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Shawn Guo, Sascha Hauer,
Fabio Estevam, Li Yang, Shengjiu Wang, Richard Zhu
Cc: Pengutronix Kernel Team, NXP Linux Team, devicetree,
linux-arm-kernel, Johannes Schneider, Krzysztof Kozlowski
Add DT compatible strings for recent EVKs, that come with a different PMIC.
The most recent revision of the 'original' EVK CPU module is C2 and the most
recent revision of EVKB CPU2 module is A4.
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Johannes Schneider <johannes.schneider@leica-geosystems.com>
---
Documentation/devicetree/bindings/arm/fsl.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
index fbfc4f99c01e..bae1040afc14 100644
--- a/Documentation/devicetree/bindings/arm/fsl.yaml
+++ b/Documentation/devicetree/bindings/arm/fsl.yaml
@@ -818,6 +818,7 @@ properties:
- emtrion,emcon-mx8mm-avari # emCON-MX8MM SoM on Avari Base
- fsl,imx8mm-ddr4-evk # i.MX8MM DDR4 EVK Board
- fsl,imx8mm-evk # i.MX8MM EVK Board
+ - fsl,imx8mm-evkb # i.MX8MM EVKB Board
- gateworks,imx8mm-gw7904
- gw,imx8mm-gw71xx-0x # i.MX8MM Gateworks Development Kit
- gw,imx8mm-gw72xx-0x # i.MX8MM Gateworks Development Kit
--
2.25.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH v10 2/2] dt-bindings: arm: fsl: Add i.MX8MM-EVKB
@ 2023-01-30 2:56 ` Johannes Schneider
0 siblings, 0 replies; 10+ messages in thread
From: Johannes Schneider @ 2023-01-30 2:56 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Shawn Guo, Sascha Hauer,
Fabio Estevam, Li Yang, Shengjiu Wang, Richard Zhu
Cc: Pengutronix Kernel Team, NXP Linux Team, devicetree,
linux-arm-kernel, Johannes Schneider, Krzysztof Kozlowski
Add DT compatible strings for recent EVKs, that come with a different PMIC.
The most recent revision of the 'original' EVK CPU module is C2 and the most
recent revision of EVKB CPU2 module is A4.
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Johannes Schneider <johannes.schneider@leica-geosystems.com>
---
Documentation/devicetree/bindings/arm/fsl.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
index fbfc4f99c01e..bae1040afc14 100644
--- a/Documentation/devicetree/bindings/arm/fsl.yaml
+++ b/Documentation/devicetree/bindings/arm/fsl.yaml
@@ -818,6 +818,7 @@ properties:
- emtrion,emcon-mx8mm-avari # emCON-MX8MM SoM on Avari Base
- fsl,imx8mm-ddr4-evk # i.MX8MM DDR4 EVK Board
- fsl,imx8mm-evk # i.MX8MM EVK Board
+ - fsl,imx8mm-evkb # i.MX8MM EVKB Board
- gateworks,imx8mm-gw7904
- gw,imx8mm-gw71xx-0x # i.MX8MM Gateworks Development Kit
- gw,imx8mm-gw72xx-0x # i.MX8MM Gateworks Development Kit
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH v10 2/2] dt-bindings: arm: fsl: Add i.MX8MM-EVKB
2023-01-30 2:56 ` Johannes Schneider
@ 2023-01-30 11:35 ` Marco Felsch
-1 siblings, 0 replies; 10+ messages in thread
From: Marco Felsch @ 2023-01-30 11:35 UTC (permalink / raw)
To: Johannes Schneider
Cc: Rob Herring, Krzysztof Kozlowski, Shawn Guo, Sascha Hauer,
Fabio Estevam, Li Yang, Shengjiu Wang, Richard Zhu, devicetree,
Krzysztof Kozlowski, NXP Linux Team, Pengutronix Kernel Team,
linux-arm-kernel
On 23-01-30, Johannes Schneider wrote:
> Add DT compatible strings for recent EVKs, that come with a different PMIC.
>
> The most recent revision of the 'original' EVK CPU module is C2 and the most
> recent revision of EVKB CPU2 module is A4.
>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Signed-off-by: Johannes Schneider <johannes.schneider@leica-geosystems.com>
Reviewed-by: Marco Felsch <m.felsch@pengutronix.de>
> ---
> Documentation/devicetree/bindings/arm/fsl.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> index fbfc4f99c01e..bae1040afc14 100644
> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> @@ -818,6 +818,7 @@ properties:
> - emtrion,emcon-mx8mm-avari # emCON-MX8MM SoM on Avari Base
> - fsl,imx8mm-ddr4-evk # i.MX8MM DDR4 EVK Board
> - fsl,imx8mm-evk # i.MX8MM EVK Board
> + - fsl,imx8mm-evkb # i.MX8MM EVKB Board
> - gateworks,imx8mm-gw7904
> - gw,imx8mm-gw71xx-0x # i.MX8MM Gateworks Development Kit
> - gw,imx8mm-gw72xx-0x # i.MX8MM Gateworks Development Kit
> --
> 2.25.1
>
>
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v10 2/2] dt-bindings: arm: fsl: Add i.MX8MM-EVKB
@ 2023-01-30 11:35 ` Marco Felsch
0 siblings, 0 replies; 10+ messages in thread
From: Marco Felsch @ 2023-01-30 11:35 UTC (permalink / raw)
To: Johannes Schneider
Cc: Rob Herring, Krzysztof Kozlowski, Shawn Guo, Sascha Hauer,
Fabio Estevam, Li Yang, Shengjiu Wang, Richard Zhu, devicetree,
Krzysztof Kozlowski, NXP Linux Team, Pengutronix Kernel Team,
linux-arm-kernel
On 23-01-30, Johannes Schneider wrote:
> Add DT compatible strings for recent EVKs, that come with a different PMIC.
>
> The most recent revision of the 'original' EVK CPU module is C2 and the most
> recent revision of EVKB CPU2 module is A4.
>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Signed-off-by: Johannes Schneider <johannes.schneider@leica-geosystems.com>
Reviewed-by: Marco Felsch <m.felsch@pengutronix.de>
> ---
> Documentation/devicetree/bindings/arm/fsl.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> index fbfc4f99c01e..bae1040afc14 100644
> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> @@ -818,6 +818,7 @@ properties:
> - emtrion,emcon-mx8mm-avari # emCON-MX8MM SoM on Avari Base
> - fsl,imx8mm-ddr4-evk # i.MX8MM DDR4 EVK Board
> - fsl,imx8mm-evk # i.MX8MM EVK Board
> + - fsl,imx8mm-evkb # i.MX8MM EVKB Board
> - gateworks,imx8mm-gw7904
> - gw,imx8mm-gw71xx-0x # i.MX8MM Gateworks Development Kit
> - gw,imx8mm-gw72xx-0x # i.MX8MM Gateworks Development Kit
> --
> 2.25.1
>
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v10 1/2] arm64: dts: imx8mm-evkb: add support for i.MX8MM-EVKB
2023-01-30 2:56 ` Johannes Schneider
@ 2023-01-30 11:59 ` Marco Felsch
-1 siblings, 0 replies; 10+ messages in thread
From: Marco Felsch @ 2023-01-30 11:59 UTC (permalink / raw)
To: Johannes Schneider
Cc: Rob Herring, Krzysztof Kozlowski, Shawn Guo, Sascha Hauer,
Fabio Estevam, Li Yang, Shengjiu Wang, Richard Zhu,
linux-arm-kernel, devicetree, NXP Linux Team,
Pengutronix Kernel Team
Hi Johannes,
thanks for the patch.
On 23-01-30, Johannes Schneider wrote:
> Add devicetree for the EVKB, which comes with LPDDR4 and a different
> PMIC.
>
> Signed-off-by: Johannes Schneider <johannes.schneider@leica-geosystems.com>
> ---
> arch/arm64/boot/dts/freescale/Makefile | 1 +
> arch/arm64/boot/dts/freescale/imx8mm-evkb.dts | 128 ++++++++++++++++++
> 2 files changed, 129 insertions(+)
> create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-evkb.dts
>
> diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile
> index 3ea9edc87909..3bccc4d10928 100644
> --- a/arch/arm64/boot/dts/freescale/Makefile
> +++ b/arch/arm64/boot/dts/freescale/Makefile
> @@ -55,6 +55,7 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mm-data-modul-edm-sbc.dtb
> dtb-$(CONFIG_ARCH_MXC) += imx8mm-ddr4-evk.dtb
> dtb-$(CONFIG_ARCH_MXC) += imx8mm-emcon-avari.dtb
> dtb-$(CONFIG_ARCH_MXC) += imx8mm-evk.dtb
> +dtb-$(CONFIG_ARCH_MXC) += imx8mm-evkb.dtb
> dtb-$(CONFIG_ARCH_MXC) += imx8mm-icore-mx8mm-ctouch2.dtb
> dtb-$(CONFIG_ARCH_MXC) += imx8mm-icore-mx8mm-edimm2.2.dtb
> dtb-$(CONFIG_ARCH_MXC) += imx8mm-kontron-bl.dtb
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evkb.dts b/arch/arm64/boot/dts/freescale/imx8mm-evkb.dts
> new file mode 100644
> index 000000000000..9ada2512d9a0
> --- /dev/null
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-evkb.dts
> @@ -0,0 +1,128 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +/*
> + * Copyright 2019-2020 NXP
Is the copyright correct?
> + */
> +
> +/dts-v1/;
> +
> +#include "imx8mm-evk.dtsi"
> +
> +/ {
> + model = "FSL i.MX8MM EVKB"; // with LPDDR4 and PCA9450 PMIC
> + compatible = "fsl,imx8mm-evkb", "fsl,imx8mm";
> +};
> +
> +&i2c1 {
> + /*
> + replace "rohm,bd71847" pmic found on previous evks
> + with "nxp,pca9450a"
> + */
This is not how we do comments in dts(i) files. Either use:
// Comment
or
/*
* Multi line
* Comment
*/
> + /delete-node/ pmic@4b
> +
> + pmic: pmic@25 {
> + compatible = "nxp,pca9450a";
> + reg = <0x25>;
> + pinctrl-0 = <&pinctrl_pmic>;
> + pinctrl-names = "default";
> + interrupt-parent = <&gpio1>;
> + interrupts = <3 IRQ_TYPE_LEVEL_LOW>;
> +
> + regulators {
The min/max voltages should be adapted.
> + buck1_reg: BUCK1 {
Please add a comment like "VDD_SOC with PCIe" above the node.
> + regulator-name = "BUCK1";
> + regulator-min-microvolt = <700000>;
> + regulator-max-microvolt = <1300000>;
min/max should be set to 850000.
> + regulator-boot-on;
> + regulator-always-on;
> + regulator-ramp-delay = <1250>;
> + };
> +
> + buck2_reg: BUCK2 {
> + regulator-name = "BUCK2";
> + regulator-min-microvolt = <700000>;
min should be: 850000
> + regulator-max-microvolt = <1300000>;
max should be: 1000000
> + regulator-boot-on;
> + regulator-always-on;
> + regulator-ramp-delay = <1250>;
> + rohm,dvs-run-voltage = <1000000>;
You just copied the rohm nodes instead the property should be:
nxp,dvs-run-voltage. However, the dvs-run-voltage is not required so
drop it completely.
> + rohm,dvs-idle-voltage = <900000>;
This should be:
nxp,dvs-standby-voltage = <850000>;
> + };
> +
> + buck3_reg: BUCK3 {
> + regulator-name = "BUCK3";
> + // BUCK5 in datasheet
Unrelated comment.
> + regulator-min-microvolt = <700000>;
min: 850000
> + regulator-max-microvolt = <1350000>;
max: 1000000
> + regulator-boot-on;
> + regulator-always-on;
> + };
> +
> + buck4_reg: BUCK4 {
> + regulator-name = "BUCK4";
> + // BUCK6 in datasheet
Unrelated comment.
> + regulator-min-microvolt = <3000000>;
min: 3300000
> + regulator-max-microvolt = <3300000>;
> + regulator-boot-on;
> + regulator-always-on;
> + };
> +
> + buck5_reg: BUCK5 {
> + regulator-name = "BUCK5";
> + // BUCK7 in datasheet
Unrelated comment.
> + regulator-min-microvolt = <1605000>;
min: 1800000
> + regulator-max-microvolt = <1995000>;
max: 1800000
> + regulator-boot-on;
> + regulator-always-on;
> + };
> +
> + buck6_reg: BUCK6 {
Please add follwoing comment above the node name:
"NVCC_DRAM for LPDDR4".
> + regulator-name = "BUCK6";
> + // BUCK8 in datasheet
Unrelated comment.
> + regulator-min-microvolt = <800000>;
> + regulator-max-microvolt = <1400000>;
min/max: 1100000
> + regulator-boot-on;
> + regulator-always-on;
> + };
> +
> + ldo1_reg: LDO1 {
> + regulator-name = "LDO1";
> + regulator-min-microvolt = <1600000>;
> + regulator-max-microvolt = <3300000>;
min/max: 1800000.
> + regulator-boot-on;
> + regulator-always-on;
> + };
> +
> + ldo2_reg: LDO2 {
> + regulator-name = "LDO2";
> + regulator-min-microvolt = <800000>;
> + regulator-max-microvolt = <900000>;
max: 800000
> + regulator-boot-on;
> + regulator-always-on;
> + };
> +
> + ldo3_reg: LDO3 {
> + regulator-name = "LDO3";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <3300000>;
min/max: 1800000
> + regulator-boot-on;
> + regulator-always-on;
> + };
> +
> + ldo4_reg: LDO4 {
> + regulator-name = "LDO4";
> + regulator-min-microvolt = <900000>;
> + regulator-max-microvolt = <1800000>;
min/max: 900000
> + regulator-boot-on;
> + regulator-always-on;
> + };
> +
> + ldo5_reg: LDO5 {
> + regulator-name = "LDO5";
> + regulator-min-microvolt = <900000>;
min: 1800000
> + regulator-max-microvolt = <1800000>;
max: 3300000
With the voltages fixed and the comments adapted this approach looks
good.
Regards,
Marco
> + regulator-boot-on;
> + regulator-always-on;
> + };
> + };
> + };
> +};
> --
> 2.25.1
>
>
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v10 1/2] arm64: dts: imx8mm-evkb: add support for i.MX8MM-EVKB
@ 2023-01-30 11:59 ` Marco Felsch
0 siblings, 0 replies; 10+ messages in thread
From: Marco Felsch @ 2023-01-30 11:59 UTC (permalink / raw)
To: Johannes Schneider
Cc: Rob Herring, Krzysztof Kozlowski, Shawn Guo, Sascha Hauer,
Fabio Estevam, Li Yang, Shengjiu Wang, Richard Zhu,
linux-arm-kernel, devicetree, NXP Linux Team,
Pengutronix Kernel Team
Hi Johannes,
thanks for the patch.
On 23-01-30, Johannes Schneider wrote:
> Add devicetree for the EVKB, which comes with LPDDR4 and a different
> PMIC.
>
> Signed-off-by: Johannes Schneider <johannes.schneider@leica-geosystems.com>
> ---
> arch/arm64/boot/dts/freescale/Makefile | 1 +
> arch/arm64/boot/dts/freescale/imx8mm-evkb.dts | 128 ++++++++++++++++++
> 2 files changed, 129 insertions(+)
> create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-evkb.dts
>
> diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile
> index 3ea9edc87909..3bccc4d10928 100644
> --- a/arch/arm64/boot/dts/freescale/Makefile
> +++ b/arch/arm64/boot/dts/freescale/Makefile
> @@ -55,6 +55,7 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mm-data-modul-edm-sbc.dtb
> dtb-$(CONFIG_ARCH_MXC) += imx8mm-ddr4-evk.dtb
> dtb-$(CONFIG_ARCH_MXC) += imx8mm-emcon-avari.dtb
> dtb-$(CONFIG_ARCH_MXC) += imx8mm-evk.dtb
> +dtb-$(CONFIG_ARCH_MXC) += imx8mm-evkb.dtb
> dtb-$(CONFIG_ARCH_MXC) += imx8mm-icore-mx8mm-ctouch2.dtb
> dtb-$(CONFIG_ARCH_MXC) += imx8mm-icore-mx8mm-edimm2.2.dtb
> dtb-$(CONFIG_ARCH_MXC) += imx8mm-kontron-bl.dtb
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evkb.dts b/arch/arm64/boot/dts/freescale/imx8mm-evkb.dts
> new file mode 100644
> index 000000000000..9ada2512d9a0
> --- /dev/null
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-evkb.dts
> @@ -0,0 +1,128 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +/*
> + * Copyright 2019-2020 NXP
Is the copyright correct?
> + */
> +
> +/dts-v1/;
> +
> +#include "imx8mm-evk.dtsi"
> +
> +/ {
> + model = "FSL i.MX8MM EVKB"; // with LPDDR4 and PCA9450 PMIC
> + compatible = "fsl,imx8mm-evkb", "fsl,imx8mm";
> +};
> +
> +&i2c1 {
> + /*
> + replace "rohm,bd71847" pmic found on previous evks
> + with "nxp,pca9450a"
> + */
This is not how we do comments in dts(i) files. Either use:
// Comment
or
/*
* Multi line
* Comment
*/
> + /delete-node/ pmic@4b
> +
> + pmic: pmic@25 {
> + compatible = "nxp,pca9450a";
> + reg = <0x25>;
> + pinctrl-0 = <&pinctrl_pmic>;
> + pinctrl-names = "default";
> + interrupt-parent = <&gpio1>;
> + interrupts = <3 IRQ_TYPE_LEVEL_LOW>;
> +
> + regulators {
The min/max voltages should be adapted.
> + buck1_reg: BUCK1 {
Please add a comment like "VDD_SOC with PCIe" above the node.
> + regulator-name = "BUCK1";
> + regulator-min-microvolt = <700000>;
> + regulator-max-microvolt = <1300000>;
min/max should be set to 850000.
> + regulator-boot-on;
> + regulator-always-on;
> + regulator-ramp-delay = <1250>;
> + };
> +
> + buck2_reg: BUCK2 {
> + regulator-name = "BUCK2";
> + regulator-min-microvolt = <700000>;
min should be: 850000
> + regulator-max-microvolt = <1300000>;
max should be: 1000000
> + regulator-boot-on;
> + regulator-always-on;
> + regulator-ramp-delay = <1250>;
> + rohm,dvs-run-voltage = <1000000>;
You just copied the rohm nodes instead the property should be:
nxp,dvs-run-voltage. However, the dvs-run-voltage is not required so
drop it completely.
> + rohm,dvs-idle-voltage = <900000>;
This should be:
nxp,dvs-standby-voltage = <850000>;
> + };
> +
> + buck3_reg: BUCK3 {
> + regulator-name = "BUCK3";
> + // BUCK5 in datasheet
Unrelated comment.
> + regulator-min-microvolt = <700000>;
min: 850000
> + regulator-max-microvolt = <1350000>;
max: 1000000
> + regulator-boot-on;
> + regulator-always-on;
> + };
> +
> + buck4_reg: BUCK4 {
> + regulator-name = "BUCK4";
> + // BUCK6 in datasheet
Unrelated comment.
> + regulator-min-microvolt = <3000000>;
min: 3300000
> + regulator-max-microvolt = <3300000>;
> + regulator-boot-on;
> + regulator-always-on;
> + };
> +
> + buck5_reg: BUCK5 {
> + regulator-name = "BUCK5";
> + // BUCK7 in datasheet
Unrelated comment.
> + regulator-min-microvolt = <1605000>;
min: 1800000
> + regulator-max-microvolt = <1995000>;
max: 1800000
> + regulator-boot-on;
> + regulator-always-on;
> + };
> +
> + buck6_reg: BUCK6 {
Please add follwoing comment above the node name:
"NVCC_DRAM for LPDDR4".
> + regulator-name = "BUCK6";
> + // BUCK8 in datasheet
Unrelated comment.
> + regulator-min-microvolt = <800000>;
> + regulator-max-microvolt = <1400000>;
min/max: 1100000
> + regulator-boot-on;
> + regulator-always-on;
> + };
> +
> + ldo1_reg: LDO1 {
> + regulator-name = "LDO1";
> + regulator-min-microvolt = <1600000>;
> + regulator-max-microvolt = <3300000>;
min/max: 1800000.
> + regulator-boot-on;
> + regulator-always-on;
> + };
> +
> + ldo2_reg: LDO2 {
> + regulator-name = "LDO2";
> + regulator-min-microvolt = <800000>;
> + regulator-max-microvolt = <900000>;
max: 800000
> + regulator-boot-on;
> + regulator-always-on;
> + };
> +
> + ldo3_reg: LDO3 {
> + regulator-name = "LDO3";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <3300000>;
min/max: 1800000
> + regulator-boot-on;
> + regulator-always-on;
> + };
> +
> + ldo4_reg: LDO4 {
> + regulator-name = "LDO4";
> + regulator-min-microvolt = <900000>;
> + regulator-max-microvolt = <1800000>;
min/max: 900000
> + regulator-boot-on;
> + regulator-always-on;
> + };
> +
> + ldo5_reg: LDO5 {
> + regulator-name = "LDO5";
> + regulator-min-microvolt = <900000>;
min: 1800000
> + regulator-max-microvolt = <1800000>;
max: 3300000
With the voltages fixed and the comments adapted this approach looks
good.
Regards,
Marco
> + regulator-boot-on;
> + regulator-always-on;
> + };
> + };
> + };
> +};
> --
> 2.25.1
>
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2023-01-30 18:46 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-30 2:56 [PATCH v8 0/3] pmic on imx8mm Johannes Schneider
2023-01-30 2:56 ` Johannes Schneider
2023-01-30 2:56 ` [PATCH v10 1/2] arm64: dts: imx8mm-evkb: add support for i.MX8MM-EVKB Johannes Schneider
2023-01-30 2:56 ` Johannes Schneider
2023-01-30 11:59 ` Marco Felsch
2023-01-30 11:59 ` Marco Felsch
2023-01-30 2:56 ` [PATCH v10 2/2] dt-bindings: arm: fsl: Add i.MX8MM-EVKB Johannes Schneider
2023-01-30 2:56 ` Johannes Schneider
2023-01-30 11:35 ` Marco Felsch
2023-01-30 11:35 ` Marco Felsch
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.