All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ASoC: sma1303: Convert to i2c's .probe_new()
@ 2023-01-31  8:21 Uwe Kleine-König
  2023-01-31 14:32 ` Mark Brown
  0 siblings, 1 reply; 2+ messages in thread
From: Uwe Kleine-König @ 2023-01-31  8:21 UTC (permalink / raw)
  To: Liam Girdwood, Mark Brown
  Cc: Wolfram Sang, alsa-devel, kernel, Colin Ian King

The probe function doesn't make use of the i2c_device_id * parameter so it
can be trivially converted.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
Hello,

there is an ongoing effort to convert all drivers to .probe_new to
eventually drop .probe with the i2c_device_id parameter. This driver
currently sits in next so wasn't on my radar before.

My plan is to tackle that after the next merge window. So I ask you to
either apply this patch during the next merge window or accept that it
will go in via the i2c tree together with the patch that drops .probe().

Best regards
Uwe

 sound/soc/codecs/sma1303.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/sound/soc/codecs/sma1303.c b/sound/soc/codecs/sma1303.c
index 3d8e3900f5c3..fbedba574ff4 100644
--- a/sound/soc/codecs/sma1303.c
+++ b/sound/soc/codecs/sma1303.c
@@ -1597,8 +1597,7 @@ static struct attribute_group sma1303_attr_group = {
 	.attrs = sma1303_attr,
 };
 
-static int sma1303_i2c_probe(struct i2c_client *client,
-				const struct i2c_device_id *id)
+static int sma1303_i2c_probe(struct i2c_client *client)
 {
 	struct sma1303_priv *sma1303;
 	struct device_node *np = client->dev.of_node;
@@ -1791,7 +1790,7 @@ static struct i2c_driver sma1303_i2c_driver = {
 		.name = "sma1303",
 		.of_match_table = sma1303_of_match,
 	},
-	.probe = sma1303_i2c_probe,
+	.probe_new = sma1303_i2c_probe,
 	.remove = sma1303_i2c_remove,
 	.id_table = sma1303_i2c_id,
 };

base-commit: 5b28c049ff53cf49e3a97d80cebd2e9c2779ea96
-- 
2.39.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ASoC: sma1303: Convert to i2c's .probe_new()
  2023-01-31  8:21 [PATCH] ASoC: sma1303: Convert to i2c's .probe_new() Uwe Kleine-König
@ 2023-01-31 14:32 ` Mark Brown
  0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2023-01-31 14:32 UTC (permalink / raw)
  To: Liam Girdwood, Uwe Kleine-König
  Cc: Wolfram Sang, alsa-devel, Colin Ian King, kernel

On Tue, 31 Jan 2023 09:21:07 +0100, Uwe Kleine-König wrote:
> The probe function doesn't make use of the i2c_device_id * parameter so it
> can be trivially converted.
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: sma1303: Convert to i2c's .probe_new()
      commit: 30cf002579969120ce926dffa3630afbb2ae899f

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-01-31 14:34 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-31  8:21 [PATCH] ASoC: sma1303: Convert to i2c's .probe_new() Uwe Kleine-König
2023-01-31 14:32 ` Mark Brown

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.