All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mario Limonciello <mario.limonciello@amd.com>
To: Jaroslav Kysela <jkysela@redhat.com>,
	Mukunda Vijendar <Vijendar.Mukunda@amd.com>,
	Saba Kareem Syed <Syed.SabaKareem@amd.com>
Cc: Pananchikkal Renjith <Renjith.Pananchikkal@amd.com>,
	Mark Pearson <mpearson@lenovo.com>,
	Mario Limonciello <mario.limonciello@amd.com>,
	<alsa-devel@alsa-project.org>, <linux-kernel@vger.kernel.org>
Subject: [PATCH v3 0/6] Fix default DMIC gain on AMD PDM drivers
Date: Tue, 31 Jan 2023 12:46:46 -0600	[thread overview]
Message-ID: <20230131184653.10216-1-mario.limonciello@amd.com> (raw)

It's been reported that a number of laptops have a low volume
level from the digital microphone compared to Windows.

AMD offers a register that can adjust the gain for PDM which is not
configured at maximum gain by default.

To fix this change the default for all 3 drivers to raise the gain
but also offer a module parameter. The module parameter can be used
for debugging if the gain is too high on a given laptop.

This is intentionally split into multiple patches for default and
parameter so that if the default really does behave better universally
we can bring it back to stable too later.

v2->v3:
 * Use clamp and clear properly

Mario Limonciello (6):
  ASoC: amd: yc: Adjust the gain for PDM DMIC
  ASoC: amd: yc: Add a module parameter to influence pdm_gain
  ASoC: amd: renoir: Adjust the gain for PDM DMIC
  ASoC: amd: renoir: Add a module parameter to influence pdm_gain
  ASoC: amd: ps: Adjust the gain for PDM DMIC
  ASoC: amd: ps: Add a module parameter to influence pdm_gain

 sound/soc/amd/ps/acp63.h             | 2 +-
 sound/soc/amd/ps/ps-pdm-dma.c        | 8 +++++++-
 sound/soc/amd/renoir/acp3x-pdm-dma.c | 8 +++++++-
 sound/soc/amd/renoir/rn_acp3x.h      | 2 +-
 sound/soc/amd/yc/acp6x-pdm-dma.c     | 8 +++++++-
 sound/soc/amd/yc/acp6x.h             | 2 +-
 6 files changed, 24 insertions(+), 6 deletions(-)

-- 
2.34.1


WARNING: multiple messages have this Message-ID (diff)
From: Mario Limonciello <mario.limonciello@amd.com>
To: Jaroslav Kysela <jkysela@redhat.com>,
	Mukunda Vijendar <Vijendar.Mukunda@amd.com>,
	Saba Kareem Syed <Syed.SabaKareem@amd.com>
Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
	Mark Pearson <mpearson@lenovo.com>,
	Pananchikkal Renjith <Renjith.Pananchikkal@amd.com>,
	Mario Limonciello <mario.limonciello@amd.com>
Subject: [PATCH v3 0/6] Fix default DMIC gain on AMD PDM drivers
Date: Tue, 31 Jan 2023 12:46:46 -0600	[thread overview]
Message-ID: <20230131184653.10216-1-mario.limonciello@amd.com> (raw)

It's been reported that a number of laptops have a low volume
level from the digital microphone compared to Windows.

AMD offers a register that can adjust the gain for PDM which is not
configured at maximum gain by default.

To fix this change the default for all 3 drivers to raise the gain
but also offer a module parameter. The module parameter can be used
for debugging if the gain is too high on a given laptop.

This is intentionally split into multiple patches for default and
parameter so that if the default really does behave better universally
we can bring it back to stable too later.

v2->v3:
 * Use clamp and clear properly

Mario Limonciello (6):
  ASoC: amd: yc: Adjust the gain for PDM DMIC
  ASoC: amd: yc: Add a module parameter to influence pdm_gain
  ASoC: amd: renoir: Adjust the gain for PDM DMIC
  ASoC: amd: renoir: Add a module parameter to influence pdm_gain
  ASoC: amd: ps: Adjust the gain for PDM DMIC
  ASoC: amd: ps: Add a module parameter to influence pdm_gain

 sound/soc/amd/ps/acp63.h             | 2 +-
 sound/soc/amd/ps/ps-pdm-dma.c        | 8 +++++++-
 sound/soc/amd/renoir/acp3x-pdm-dma.c | 8 +++++++-
 sound/soc/amd/renoir/rn_acp3x.h      | 2 +-
 sound/soc/amd/yc/acp6x-pdm-dma.c     | 8 +++++++-
 sound/soc/amd/yc/acp6x.h             | 2 +-
 6 files changed, 24 insertions(+), 6 deletions(-)

-- 
2.34.1


             reply	other threads:[~2023-01-31 18:47 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-31 18:46 Mario Limonciello [this message]
2023-01-31 18:46 ` [PATCH v3 0/6] Fix default DMIC gain on AMD PDM drivers Mario Limonciello
2023-01-31 18:46 ` [PATCH v3 1/6] ASoC: amd: yc: Adjust the gain for PDM DMIC Mario Limonciello
2023-01-31 18:46   ` Mario Limonciello
2023-02-02 11:42   ` Mark Brown
2023-02-02 11:42     ` Mark Brown
2023-02-02 13:38     ` Mario Limonciello
2023-02-02 13:38       ` Mario Limonciello
2023-02-02 13:42       ` Mark Brown
2023-02-02 13:42         ` Mark Brown
2023-01-31 18:46 ` [PATCH v3 2/6] ASoC: amd: yc: Add a module parameter to influence pdm_gain Mario Limonciello
2023-01-31 18:46   ` Mario Limonciello
2023-01-31 18:46 ` [PATCH v3 3/6] ASoC: amd: renoir: Adjust the gain for PDM DMIC Mario Limonciello
2023-01-31 18:46   ` Mario Limonciello
2023-01-31 18:46 ` [PATCH v3 4/6] ASoC: amd: renoir: Add a module parameter to influence pdm_gain Mario Limonciello
2023-01-31 18:46   ` Mario Limonciello
2023-01-31 18:46 ` [PATCH v3 5/6] ASoC: amd: ps: Adjust the gain for PDM DMIC Mario Limonciello
2023-01-31 18:46   ` Mario Limonciello
2023-01-31 18:46 ` [PATCH v3 6/6] ASoC: amd: ps: Add a module parameter to influence pdm_gain Mario Limonciello
2023-01-31 18:46   ` Mario Limonciello
2023-01-31 18:51 ` [PATCH v3 0/6] Fix default DMIC gain on AMD PDM drivers Jaroslav Kysela
2023-01-31 18:51   ` Jaroslav Kysela
2023-02-02 15:37 ` Mark Brown
2023-02-02 15:37   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230131184653.10216-1-mario.limonciello@amd.com \
    --to=mario.limonciello@amd.com \
    --cc=Renjith.Pananchikkal@amd.com \
    --cc=Syed.SabaKareem@amd.com \
    --cc=Vijendar.Mukunda@amd.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=jkysela@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mpearson@lenovo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.