From: Jakub Kicinski <kuba@kernel.org>
To: Mengyuan Lou <mengyuanlou@net-swift.com>
Cc: netdev@vger.kernel.org, jiawenwu@trustnetic.com
Subject: Re: [PATCH net-next v2 01/10] net: libwx: Add irq flow functions
Date: Wed, 1 Feb 2023 21:45:05 -0800 [thread overview]
Message-ID: <20230201214505.24b1fb4a@kernel.org> (raw)
In-Reply-To: <20230131100541.73757-2-mengyuanlou@net-swift.com>
On Tue, 31 Jan 2023 18:05:32 +0800 Mengyuan Lou wrote:
> + /* initialize work limits */
> + q_vector->tx.work_limit = wx->tx_work_limit;
> + q_vector->rx.work_limit = wx->rx_work_limit;
How is the work limit used?
> + wx->isb_mem = dma_alloc_coherent(&pdev->dev,
> + sizeof(u32) * 4,
> + &wx->isb_dma,
> + GFP_KERNEL);
> + if (!wx->isb_mem) {
> + wx_err(wx, "Alloc isb_mem failed\n");
> + return -ENOMEM;
> + }
> + memset(wx->isb_mem, 0, sizeof(u32) * 4);
unnecessary, dma_alloc_coherent() clears the memory.
next prev parent reply other threads:[~2023-02-02 5:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-31 10:05 [PATCH net-next v2 00/10] Wangxun interrupt and RxTx support Mengyuan Lou
2023-01-31 10:05 ` [PATCH net-next v2 01/10] net: libwx: Add irq flow functions Mengyuan Lou
2023-02-02 5:39 ` Jakub Kicinski
2023-02-02 5:45 ` Jakub Kicinski [this message]
2023-01-31 10:05 ` [PATCH net-next v2 02/10] net: ngbe: Add irqs request flow Mengyuan Lou
2023-01-31 10:05 ` [PATCH net-next v2 03/10] net: txgbe: Add interrupt support Mengyuan Lou
2023-01-31 10:05 ` [PATCH net-next v2 04/10] net: libwx: Configure Rx and Tx unit on hardware Mengyuan Lou
2023-01-31 10:05 ` [PATCH net-next v2 05/10] net: libwx: Allocate Rx and Tx resources Mengyuan Lou
2023-02-02 5:51 ` Jakub Kicinski
2023-02-02 14:32 ` mengyuanlou
2023-01-31 10:05 ` [PATCH net-next v2 06/10] net: txgbe: Setup Rx and Tx ring Mengyuan Lou
2023-01-31 10:05 ` [PATCH net-next v2 07/10] net: libwx: Support to receive packets in NAPI Mengyuan Lou
2023-01-31 10:05 ` [PATCH net-next v2 08/10] net: libwx: Add tx path to process packets Mengyuan Lou
2023-01-31 10:05 ` [PATCH net-next v2 09/10] net: txgbe: Support Rx and Tx process path Mengyuan Lou
2023-01-31 10:05 ` [PATCH net-next v2 10/10] net: ngbe: " Mengyuan Lou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230201214505.24b1fb4a@kernel.org \
--to=kuba@kernel.org \
--cc=jiawenwu@trustnetic.com \
--cc=mengyuanlou@net-swift.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.